Skip to contentSkip to conversation

Enable bootmenu, and button-kbd driver for menu entry navigation.

PATCH In review Dzmitry Sankouski 3 participants 7 messages Apr 1, 2023 – May 3, 2023 Arm (32-bit)

lore
Share & tools
lore
#0 lore raw

cover Enable bootmenu, and button-kbd driver for menu entry navigation.

Bootmenu needed to multiboot Android with other OSes. 16x32 font used for starqltechn's high ppi display.

Dzmitry Sankouski (3):
starqltechn: use 16x32 font
starqltechn: use button keyboard driver
starqltechn: enable bootmenu

 arch/arm/dts/starqltechn.dts  | 18 ++++++++++++++++++
 configs/starqltechn_defconfig |  6 ++++++
 include/configs/sdm845.h      |  2 +-
 3 files changed, 25 insertions(+), 1 deletion(-)
Signature · 1 line
2.30.2
#1 lore raw

PATCH 1/3 starqltechn: use 16x32 font

This font is more readable on high ppi display

---

 configs/starqltechn_defconfig | 2 ++
 1 file changed, 2 insertions(+)
configs/starqltechn_defconfig +2 -0
index 3d96e0ae09..599d926058 100644
@@ -29,6 +29,8 @@ CONFIG_PMIC_QCOM=y
 CONFIG_MSM_GENI_SERIAL=y
 CONFIG_SPMI_MSM=y
 CONFIG_VIDEO=y
+# CONFIG_VIDEO_FONT_8X16 is not set
+CONFIG_VIDEO_FONT_16X32=y
 CONFIG_SYS_WHITE_ON_BLACK=y
 CONFIG_VIDEO_SIMPLE=y
 CONFIG_VIDEO_DT_SIMPLEFB=y
Signature · 1 line
2.30.2
#4 lore raw

PATCH 2/3 starqltechn: use button keyboard driver

In reply to Dzmitry Sankouski

Button keyboard driver used to navigate bootmenu entries.

Add gpio buttons, button keyboard driver.
Add gpio keys dts bindings.

---

 arch/arm/dts/starqltechn.dts  | 18 ++++++++++++++++++
 configs/starqltechn_defconfig |  3 +++
 include/configs/sdm845.h      |  2 +-
 3 files changed, 22 insertions(+), 1 deletion(-)
arch/arm/dts/starqltechn.dts +18 -0
index 34a4f59cbd..6c90447362 100644
@@ -9,6 +9,8 @@
 /dts-v1/;
 
 #include "sdm845.dtsi"
+#include <dt-bindings/gpio/gpio.h>
+#include <dt-bindings/input/input.h>
 
 / {
 	model = "Samsung S9 (SM-G9600)";
@@ -43,6 +45,22 @@
 		format = "a8r8g8b8";
 	};
 
+	gpio-keys {
+		compatible = "gpio-keys";
+
+		key-pwr {
+			label = "Power";
+			linux,code = <KEY_ENTER>;
+			gpios = <&pm8998_pon 0 GPIO_ACTIVE_LOW>;
+		};
+
+		key-vol-down {
+			label = "Volume Down";
+			linux,code = <KEY_DOWN>;
+			gpios = <&pm8998_pon 1 GPIO_ACTIVE_LOW>;
+		};
+	};
+
 	soc: soc {
 		serial@a84000 {
 			status = "okay";
configs/starqltechn_defconfig +3 -0
index 599d926058..92e7254c73 100644
@@ -20,9 +20,12 @@ CONFIG_SYS_PBSIZE=532
 CONFIG_CMD_GPIO=y
 CONFIG_CMD_BMP=y
 # CONFIG_NET is not set
+CONFIG_BUTTON=y
 CONFIG_CLK=y
 CONFIG_MSM_GPIO=y
 CONFIG_QCOM_PMIC_GPIO=y
+CONFIG_DM_KEYBOARD=y
+CONFIG_BUTTON_KEYBOARD=y
 CONFIG_PINCTRL=y
 CONFIG_DM_PMIC=y
 CONFIG_PMIC_QCOM=y
include/configs/sdm845.h +1 -1
index 2211751b54..673268dca9 100644
@@ -16,7 +16,7 @@
 #define CFG_EXTRA_ENV_SETTINGS \
 	"bootm_size=0x4000000\0"	\
 	"bootm_low=0x80000000\0"	\
-	"stdin=serial\0"	\
+	"stdin=serial,button-kbd\0"	\
 	"stdout=serial,vidconsole\0"	\
 	"stderr=serial,vidconsole\0"	\
 	"preboot=source $prevbl_initrd_start_addr:prebootscript\0" \
Signature · 1 line
2.30.2
Reviewed-by on v1 2/3
#5 lore raw

Re: [PATCH 2/3] starqltechn: use button keyboard driver

Quoted 6 lines · Dzmitry Sankouski

Button keyboard driver used to navigate bootmenu entries.

Add gpio buttons, button keyboard driver.
Add gpio keys dts bindings.

Quoted 8 lines

---

 arch/arm/dts/starqltechn.dts  | 18 ++++++++++++++++++
 configs/starqltechn_defconfig |  3 +++
 include/configs/sdm845.h      |  2 +-
 3 files changed, 22 insertions(+), 1 deletion(-)
#6 lore raw

PATCH 3/3 starqltechn: enable bootmenu

In reply to Dzmitry Sankouski

Needed for multiboot with vendor's Android.

---

 configs/starqltechn_defconfig | 1 +
 1 file changed, 1 insertion(+)
configs/starqltechn_defconfig +1 -0
index 92e7254c73..5b85ce5fe9 100644
@@ -17,6 +17,7 @@ CONFIG_HUSH_PARSER=y
 CONFIG_SYS_MAXARGS=64
 CONFIG_SYS_CBSIZE=512
 CONFIG_SYS_PBSIZE=532
+CONFIG_CMD_BOOTMENU=y
 CONFIG_CMD_GPIO=y
 CONFIG_CMD_BMP=y
 # CONFIG_NET is not set
Signature · 1 line
2.30.2