Skip to contentSkip to conversation

libsemanage: fix memory leak in semanage_user_roles

PATCH Superseded Christian Göttsche 2 participants 5 messages Apr 1, 2023 – May 3, 2023 SELinux security module

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 libsemanage: fix memory leak in semanage_user_roles

The output parameter role_arr of semanage_user_get_roles() is an array of non-owned role names. Since the array is never used again, as its contents have been copied into the return value roles, free it.

Example leak report from useradd(8):

    Direct leak of 8 byte(s) in 1 object(s) allocated from:
    #0 0x5597624284a8 in __interceptor_calloc (./shadow/src/useradd+0xee4a8)
    #1 0x7f53aefcbbf9 in sepol_user_get_roles src/user_record.c:270:21
---
 libsemanage/src/seusers_local.c | 1 +
 1 file changed, 1 insertion(+)
libsemanage/src/seusers_local.c +1 -0
index 6508ec05..795a33d6 100644
@@ -47,6 +47,7 @@ static char *semanage_user_roles(semanage_handle_t * handle, const char *sename)
 						}
 					}
 				}
+				free(roles_arr);
 			}
 			semanage_user_free(user);
 		}
Signature · 1 line
2.40.0
#1 lore raw
Quoted 10 lines · Christian Göttsche

The output parameter role_arr of semanage_user_get_roles() is an array of non-owned role names. Since the array is never used again, as its contents have been copied into the return value roles, free it.

Example leak report from useradd(8):

    Direct leak of 8 byte(s) in 1 object(s) allocated from:
    #0 0x5597624284a8 in __interceptor_calloc (./shadow/src/useradd+0xee4a8)
    #1 0x7f53aefcbbf9 in sepol_user_get_roles src/user_record.c:270:21

I was going to ack this, but I just noticed that it doesn't have a signed-off line.
Jim

Quoted 19 lines
---
 libsemanage/src/seusers_local.c | 1 +
 1 file changed, 1 insertion(+)
libsemanage/src/seusers_local.c +1 -1
index 6508ec05..795a33d6 100644
@@ -47,6 +47,7 @@ static char *semanage_user_roles(semanage_handle_t * handle, const char *sename)
                                                }
                                        }
                                }
+                               free(roles_arr);
                        }
                        semanage_user_free(user);
                }
--

2.40.0

#2 lore raw

PATCH RESEND 1/1 libsemanage: fix memory leak in semanage_user_roles

In reply to Christian Göttsche

The output parameter role_arr of semanage_user_get_roles() is an array of non-owned role names. Since the array is never used again, as its contents have been copied into the return value roles, free it.

Example leak report from useradd(8):

    Direct leak of 8 byte(s) in 1 object(s) allocated from:
    #0 0x5597624284a8 in __interceptor_calloc (./shadow/src/useradd+0xee4a8)
    #1 0x7f53aefcbbf9 in sepol_user_get_roles src/user_record.c:270:21

---
same as v1, only signed-of

---
 libsemanage/src/seusers_local.c | 1 +
 1 file changed, 1 insertion(+)
libsemanage/src/seusers_local.c +1 -0
index 6508ec05..795a33d6 100644
@@ -47,6 +47,7 @@ static char *semanage_user_roles(semanage_handle_t * handle, const char *sename)
 						}
 					}
 				}
+				free(roles_arr);
 			}
 			semanage_user_free(user);
 		}
Signature · 1 line
2.40.0
Acked-by on v1 1/1
#3 lore raw
Quoted 5 lines · Christian Göttsche

The output parameter role_arr of semanage_user_get_roles() is an array of non-owned role names. Since the array is never used again, as its contents have been copied into the return value roles, free it.

Quoted 7 lines

Example leak report from useradd(8):

    Direct leak of 8 byte(s) in 1 object(s) allocated from:
    #0 0x5597624284a8 in __interceptor_calloc (./shadow/src/useradd+0xee4a8)
    #1 0x7f53aefcbbf9 in sepol_user_get_roles src/user_record.c:270:21
Quoted 21 lines

---
same as v1, only signed-of

---
 libsemanage/src/seusers_local.c | 1 +
 1 file changed, 1 insertion(+)
libsemanage/src/seusers_local.c +1 -1
index 6508ec05..795a33d6 100644
@@ -47,6 +47,7 @@ static char *semanage_user_roles(semanage_handle_t * handle, const char *sename)
                                                }
                                        }
                                }
+                               free(roles_arr);
                        }
                        semanage_user_free(user);
                }
--

2.40.0

#4 lore raw
Quoted 10 lines · James Carter
Quoted 7 lines · Christian Göttsche

The output parameter role_arr of semanage_user_get_roles() is an array of non-owned role names. Since the array is never used again, as its contents have been copied into the return value roles, free it.

Example leak report from useradd(8):

Quoted 8 lines
Quoted 5 lines
    Direct leak of 8 byte(s) in 1 object(s) allocated from:
    #0 0x5597624284a8 in __interceptor_calloc (./shadow/src/useradd+0xee4a8)
    #1 0x7f53aefcbbf9 in sepol_user_get_roles src/user_record.c:270:21

Merged.
Thanks,
Jim

Quoted 21 lines
Quoted 21 lines

---
same as v1, only signed-of

---
 libsemanage/src/seusers_local.c | 1 +
 1 file changed, 1 insertion(+)
libsemanage/src/seusers_local.c +1 -1
index 6508ec05..795a33d6 100644
@@ -47,6 +47,7 @@ static char *semanage_user_roles(semanage_handle_t * handle, const char *sename)
                                                }
                                        }
                                }
+                               free(roles_arr);
                        }
                        semanage_user_free(user);
                }
--

2.40.0