Skip to contentSkip to conversation

staging: octeon: remove typedef declaration for cvmx_fau_op_size

PATCH In review Dalvin-Ehinoma Noah Aiguobas 2 participants 2 messages Apr 1, 2023 – Apr 3, 2023 Staging

lore
Share & tools
lore

Dalvin-Ehinoma Noah Aiguobas

author
#0 lore raw

PATCH 1/1 staging: octeon: remove typedef declaration for cvmx_fau_op_size

Fix checkpatch.pl warning: do not add new typedefs in drivers/staging/octeon/octeon-stubs.h:216

Signed-off-by Dalvin-Ehinoma Noah Aiguobas <[email protected]>
---
 drivers/staging/octeon/octeon-stubs.h | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/staging/octeon/octeon-stubs.h +3 -3
index 3e7b92cd2e35..cf560c321c92 100644
@@ -213,12 +213,12 @@ enum cvmx_fau_op_size {
 	CVMX_FAU_OP_SIZE_64 = 3
 };
 
-typedef enum {
+enum cvmx_spi_mode_t {
 	CVMX_SPI_MODE_UNKNOWN = 0,
 	CVMX_SPI_MODE_TX_HALFPLEX = 1,
 	CVMX_SPI_MODE_RX_HALFPLEX = 2,
 	CVMX_SPI_MODE_DUPLEX = 3
-} cvmx_spi_mode_t;
+};
 
 typedef enum {
 	CVMX_HELPER_INTERFACE_MODE_DISABLED,

@@ -1362,7 +1362,7 @@ static inline struct cvmx_wqe *cvmx_pow_work_request_sync(cvmx_pow_wait_t wait)
 }
 
 static inline int cvmx_spi_restart_interface(int interface,
-					cvmx_spi_mode_t mode, int timeout)
+					enum cvmx_spi_mode_t mode, int timeout)
 {
 	return 0;
 }
Signature · 1 line
2.25.1
#1 lore raw
Quoted 13 lines · Dalvin-Ehinoma Noah Aiguobas

Fix checkpatch.pl warning: do not add new typedefs in drivers/staging/octeon/octeon-stubs.h:216

Signed-off-by Dalvin-Ehinoma Noah Aiguobas <[email protected]>
---
 drivers/staging/octeon/octeon-stubs.h | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/staging/octeon/octeon-stubs.h +0 -0
index 3e7b92cd2e35..cf560c321c92 100644

drivers/staging/octeon/octeon-stubs.h enum cvmx_fau_op_size { · line 216

Quoted 5 lines
drivers/staging/octeon/octeon-stubs.h +1 -1
@@ -213,12 +213,12 @@ enum cvmx_fau_op_size {
 	CVMX_FAU_OP_SIZE_64 = 3
 };
 
-typedef enum {
+enum cvmx_spi_mode_t {

The _t means typedef and it isn't a typedef now. Change the name to "cvmx_spi_mode".

drivers/staging/octeon/octeon-stubs.h enum cvmx_fau_op_size { · line 221

Quoted 6 lines
drivers/staging/octeon/octeon-stubs.h +1 -1
 	CVMX_SPI_MODE_UNKNOWN = 0,
 	CVMX_SPI_MODE_TX_HALFPLEX = 1,
 	CVMX_SPI_MODE_RX_HALFPLEX = 2,
 	CVMX_SPI_MODE_DUPLEX = 3
-} cvmx_spi_mode_t;
+};

regards,
dan carpenter