Skip to contentSkip to conversation

driver core: class : fix slab-use-after-free Read in class_register()

PATCH New Greg Kroah-Hartman 1 participant 1 message Apr 1, 2023 Driver core

lore
Share & tools
lore

Greg Kroah-Hartman

author maintainer
#0 lore raw

PATCH 1/1 driver core: class : fix slab-use-after-free Read in class_register()

Syzbot found that we had forgotten to unregister the lock_class_key when using it in commit dcfbb67e48a2 ("driver core: class: use lock_class_key already present in struct subsys_private") so fix that up and correctly release it when done.

Cc "Rafael J. Wysocki" <[email protected]>
Reported-and-tested-by <[email protected]>
Fixes dcfbb67e48a2 ("driver core: class: use lock_class_key already present in struct subsys_private")
---
 drivers/base/class.c | 1 +
 1 file changed, 1 insertion(+)
drivers/base/class.c +1 -0
index 2991936c80db..ac1808d1a2e8 100644
@@ -103,6 +103,7 @@ static void class_release(struct kobject *kobj)
 		pr_debug("class '%s' does not have a release() function, "
 			 "be careful\n", class->name);
 
+	lockdep_unregister_key(&cp->lock_key);
 	kfree(cp);
 }
 
Signature · 1 line
2.40.0