Skip to contentSkip to conversation

Silence Emacs warning on loading cocci.el

PATCH In review Matti Niemenmaa 2 participants 2 messages Apr 2, 2023

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Silence Emacs warning on loading cocci.el

Unescaped quote character literals (?") have produced an "unescaped character literals" warning on load ever since Emacs 26 (Emacs commit c2bbdc3316487 and bug#20852). As far as I can tell the escaped syntax has been supported since at least the early 90s, so there are no backwards compat issues with this change.

---
 editors/emacs/cocci.el | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
emacs/cocci.el +1 -1
index 072e4a9d..12e384f3 100644
@@ -394,7 +394,7 @@ Turning on cocci-mode runs the hook `cocci-mode-hook'."
 ; put cursor before a parse error coccinelle message and it will
 ; open the corresponding file and go to corresponding line.
 (fset 'cocci-goto-next-error
-   [?\C-s ?F ?i ?l ?e right right ?\C-  ?\C-s ?" left ?\M-w ?\C-x ?\C-f S-insert return ?\C-\M-l C-right right C-S-right C-insert ?\C-\M-l ?\M-g S-insert return])
+   [?\C-s ?F ?i ?l ?e right right ?\C-  ?\C-s ?\" left ?\M-w ?\C-x ?\C-f S-insert return ?\C-\M-l C-right right C-S-right C-insert ?\C-\M-l ?\M-g S-insert return])
 ;"
 
 ;; Provide
Signature · 1 line
2.40.0
#1 lore raw
Quoted 5 lines · Matti Niemenmaa

Unescaped quote character literals (?") have produced an "unescaped character literals" warning on load ever since Emacs 26 (Emacs commit c2bbdc3316487 and bug#20852). As far as I can tell the escaped syntax has been supported since at least the early 90s, so there are no backwards compat issues with this change.

Thanks! Applied.

julia

Quoted 23 lines
---
 editors/emacs/cocci.el | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
emacs/cocci.el +1 -2
index 072e4a9d..12e384f3 100644
@@ -394,7 +394,7 @@ Turning on cocci-mode runs the hook `cocci-mode-hook'."
 ; put cursor before a parse error coccinelle message and it will
 ; open the corresponding file and go to corresponding line.
 (fset 'cocci-goto-next-error
-   [?\C-s ?F ?i ?l ?e right right ?\C-  ?\C-s ?" left ?\M-w ?\C-x ?\C-f S-insert return ?\C-\M-l C-right right C-S-right C-insert ?\C-\M-l ?\M-g S-insert return])
+   [?\C-s ?F ?i ?l ?e right right ?\C-  ?\C-s ?\" left ?\M-w ?\C-x ?\C-f S-insert return ?\C-\M-l C-right right C-S-right C-insert ?\C-\M-l ?\M-g S-insert return])
 ;"
 
 ;; Provide
--

2.40.0