Skip to contentSkip to conversation

update xdp_statistics in docs

PATCH In review nick black 3 participants 4 messages Apr 4, 2023

Subsystems (2)
lore
Share & tools
lore

nick black

author
#0 lore raw

PATCH 1/1 update xdp_statistics in docs

Add the three fields from xdp_statistics that were missing in the AF_XDP documentation.

---
 Documentation/networking/af_xdp.rst | 3 +++
 1 file changed, 3 insertions(+)
networking/af_xdp.rst +3 -0
index 247c6c4127e9..a968de7e902c 100644
@@ -445,6 +445,9 @@ purposes. The supported statistics are shown below:
        __u64 rx_dropped; /* Dropped for reasons other than invalid desc */
        __u64 rx_invalid_descs; /* Dropped due to invalid descriptor */
        __u64 tx_invalid_descs; /* Dropped due to invalid descriptor */
+       __u64 rx_ring_full; /* Dropped due to rx ring being full */
+       __u64 rx_fill_ring_empty_descs; /* Failed to retrieve item from fill ring */
+       __u64 tx_ring_empty_descs; /* Failed to retrieve item from tx ring */
    };
 
 XDP_OPTIONS getsockopt
Signature · 1 line
2.40.0
Acked-by on v1 1/1
#1 lore raw
Quoted 3 lines · nick black

Add the three fields from xdp_statistics that were missing in the AF_XDP documentation.

Thanks Nick.

Quoted 21 lines
---
 Documentation/networking/af_xdp.rst | 3 +++
 1 file changed, 3 insertions(+)
networking/af_xdp.rst +3 -1
index 247c6c4127e9..a968de7e902c 100644
@@ -445,6 +445,9 @@ purposes. The supported statistics are shown below:
        __u64 rx_dropped; /* Dropped for reasons other than invalid desc */
        __u64 rx_invalid_descs; /* Dropped due to invalid descriptor */
        __u64 tx_invalid_descs; /* Dropped due to invalid descriptor */
+       __u64 rx_ring_full; /* Dropped due to rx ring being full */
+       __u64 rx_fill_ring_empty_descs; /* Failed to retrieve item from fill ring */
+       __u64 tx_ring_empty_descs; /* Failed to retrieve item from tx ring */
    };
 
 XDP_OPTIONS getsockopt
--

2.40.0

maintainer
#2 lore raw
In reply to nick black
Quoted 4 lines · nick black

Add the three fields from xdp_statistics that were missing in the AF_XDP documentation.

I think this kind of changes are best suited for net-next, please set the target tree accordingly in next submissions.

networking/af_xdp.rst

Quoted 8 lines
---
 Documentation/networking/af_xdp.rst | 3 +++
 1 file changed, 3 insertions(+)
networking/af_xdp.rst +0 -0
index 247c6c4127e9..a968de7e902c 100644

There is something strange in your setup, the above should be:

--- a/Documentation/networking/af_xdp.rst
+++ b/Documentation/networking/af_xdp.rst

The format you used confuses my scripts. I handled this one manually, but please update your setup to stick to the standard layout.

Cheers,

Paolo

maintainer
#3 lore raw
Quoted 23 lines · Paolo Abeni
Quoted 4 lines · nick black

Add the three fields from xdp_statistics that were missing in the AF_XDP documentation.

I think this kind of changes are best suited for net-next, please set the target tree accordingly in next submissions.

networking/af_xdp.rst

Quoted 8 lines
---
 Documentation/networking/af_xdp.rst | 3 +++
 1 file changed, 3 insertions(+)
networking/af_xdp.rst +0 -0
index 247c6c4127e9..a968de7e902c 100644

There is something strange in your setup, the above should be:

Documentation/networking/af_xdp.rst +0 -0
Quoted 2 lines

The format you used confuses my scripts. I handled this one manually, but please update your setup to stick to the standard layout.

I almost forgot: you should include into the subject a tag identifying the relevant subsystem/networking area. In this case, a proper subject could be:

net: doc: update xdp_statistics in docs

Given all the above I think is better if you re-submit addressing my comments. You can retain Magnus's ack.

Thanks!

Paolo