memory: Skip tests for instructions that are absent
Paolo Bonzini
maintainerPATCH v2 1/1 memory: Skip tests for instructions that are absent
Checking that instructions are absent is broken when running with CPU models other than the bare metal processor's, because neither VMX nor SVM have intercept controls for the instructions.
This can even happen with "-cpu max" when running under nested virtualization, which is the current situation in the Fedora KVM job on Cirrus-CI:
FAIL: clflushopt (ABSENT)
FAIL: clwb (ABSENT)
In other words it looks like the features have been marked as disabled in the L0 host, while the hardware supports them.
--- x86/memory.c | 83 +++++++++++++++++++++++++++++++--------------------- 1 file changed, 49 insertions(+), 34 deletions(-)
x86/memory.c +49 -34
@@ -25,53 +25,68 @@ static void handle_ud(struct ex_regs *regs)int main (int ac,char **av) { -int expected; -handle_exception (UD_VECTOR , handle_ud);/* 3-byte instructions: */ isize =3 ; - expected = !this_cpu_has (X86_FEATURE_CLFLUSH );/* CLFLUSH */ - ud =0 ; - asmvolatile ("clflush (%0)" : :"b" (&target)); -report (ud == expected,"clflush (%s)" , expected ?"ABSENT" :"present" ); +if (this_cpu_has (X86_FEATURE_CLFLUSH )) {/* CLFLUSH */ + ud =0 ; + asmvolatile ("clflush (%0)" : :"b" (&target)); +report (!ud,"clflush" ); + }else { +report_skip ("clflush" ); + } - expected = !this_cpu_has (X86_FEATURE_XMM );/* SSE */ - ud =0 ; - asmvolatile ("sfence" ); -report (ud == expected,"sfence (%s)" , expected ?"ABSENT" :"present" ); +if (this_cpu_has (X86_FEATURE_XMM )) {/* SSE */ + ud =0 ; + asmvolatile ("sfence" ); +report (!ud,"sfence" ); + }else { +report_skip ("sfence" ); + } - expected = !this_cpu_has (X86_FEATURE_XMM2 );/* SSE2 */ - ud =0 ; - asmvolatile ("lfence" ); -report (ud == expected,"lfence (%s)" , expected ?"ABSENT" :"present" ); - - ud =0 ; - asmvolatile ("mfence" ); -report (ud == expected,"mfence (%s)" , expected ?"ABSENT" :"present" ); +if (this_cpu_has (X86_FEATURE_XMM2 )) {/* SSE2 */ + ud =0 ; + asmvolatile ("lfence" ); +report (!ud,"lfence" ); + ud =0 ; + asmvolatile ("mfence" ); +report (!ud,"mfence" ); + }else { +report_skip ("lfence" ); +report_skip ("mfence" ); + }/* 4-byte instructions: */ isize =4 ; - expected = !this_cpu_has (X86_FEATURE_CLFLUSHOPT );/* CLFLUSHOPT */ - ud =0 ; -/* clflushopt (%rbx): */ - asmvolatile (".byte 0x66, 0x0f, 0xae, 0x3b" : :"b" (&target)); -report (ud == expected,"clflushopt (%s)" , - expected ?"ABSENT" :"present" ); +if (this_cpu_has (X86_FEATURE_CLFLUSHOPT )) {/* CLFLUSHOPT */ + ud =0 ; +/* clflushopt (%rbx): */ + asmvolatile (".byte 0x66, 0x0f, 0xae, 0x3b" : :"b" (&target)); +report (!ud,"clflushopt" ); + }else { +report_skip ("clflushopt" ); + } - expected = !this_cpu_has (X86_FEATURE_CLWB );/* CLWB */ - ud =0 ; -/* clwb (%rbx): */ - asmvolatile (".byte 0x66, 0x0f, 0xae, 0x33" : :"b" (&target)); -report (ud == expected,"clwb (%s)" , expected ?"ABSENT" :"present" ); +if (this_cpu_has (X86_FEATURE_CLWB )) {/* CLWB */ + ud =0 ; +/* clwb (%rbx): */ + asmvolatile (".byte 0x66, 0x0f, 0xae, 0x33" : :"b" (&target)); +report (!ud,"clwb" ); + }else { +report_skip ("clwb" ); + } - expected = !this_cpu_has (X86_FEATURE_PCOMMIT );/* PCOMMIT */ - ud =0 ; -/* pcommit: */ - asmvolatile (".byte 0x66, 0x0f, 0xae, 0xf8" ); -report (ud == expected,"pcommit (%s)" , expected ?"ABSENT" :"present" ); +if (this_cpu_has (X86_FEATURE_PCOMMIT )) {/* PCOMMIT */ + ud =0 ; +/* pcommit: */ + asmvolatile (".byte 0x66, 0x0f, 0xae, 0xf8" ); +report (!ud,"pcommit" ); + }else { +report_skip ("pcommit" ); + }return report_summary (); }
Signature · 1 line
2.39.2
Sean Christopherson
reviewerQuoted 26 lines · Paolo Bonzini
Checking that instructions are absent is broken when running with CPU models other than the bare metal processor's, because neither VMX nor SVM have intercept controls for the instructions.
This can even happen with "-cpu max" when running under nested virtualization, which is the current situation in the Fedora KVM job on Cirrus-CI:
FAIL: clflushopt (ABSENT)
FAIL: clwb (ABSENT)In other words it looks like the features have been marked as disabled in the L0 host, while the hardware supports them.
Reported-by Thomas Huth <[email protected]>Reviewed-by Thomas Huth <[email protected]>Signed-off-by Paolo Bonzini <[email protected]>--- x86/memory.c | 83 +++++++++++++++++++++++++++++++--------------------- 1 file changed, 49 insertions(+), 34 deletions(-)x86/memory.c +0
-0
x86/memory.c static void handle_ud(struct ex_regs *regs) · line 31
Quoted 9 lines
x86/memory.c +0
-2@@ -25,53 +25,68 @@ static void handle_ud(struct ex_regs *regs)int main (int ac,char **av) { -int expected; -handle_exception (UD_VECTOR , handle_ud);/* 3-byte instructions: */ isize =3 ;
We can clean this up even further by utilizing TRY_ASM(). Though I think this is a good excuse to add things like asm_safe(), asm_safe_report(), and asm_safe_report_ex(), to cut down on the boilerplate even more. I'll send patches on top.