Skip to contentSkip to conversation

arm64: dts: imx8mm: Add display pipeline components

PATCH In review Marek Vasut 3 participants 6 messages Apr 4, 2023 – Apr 5, 2023

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 arm64: dts: imx8mm: Add display pipeline components

Add LCDIF scanout engine and DSIM bridge nodes for i.MX8M Mini. This makes the DSI display pipeline available on this SoC.

---
Cc: Abel Vesa <[email protected]>
Cc: Dong Aisheng <[email protected]>
Cc: Fabio Estevam <[email protected]>
Cc: Guido Günther <[email protected]>
Cc: Krzysztof Kozlowski <[email protected]>
Cc: Lucas Stach <[email protected]>
Cc: NXP Linux Team <[email protected]>
Cc: Pengutronix Kernel Team <[email protected]>
Cc: Richard Cochran <[email protected]>
Cc: Rob Herring <[email protected]>
Cc: Sascha Hauer <[email protected]>
Cc: Shawn Guo <[email protected]>
Cc: [email protected]
Cc: [email protected]

---
 arch/arm64/boot/dts/freescale/imx8mm.dtsi | 57 +++++++++++++++++++++++
 1 file changed, 57 insertions(+)
arch/arm64/boot/dts/freescale/imx8mm.dtsi +57 -0
index e311da7e87bdc..06495c225c94b 100644
@@ -1119,6 +1119,63 @@ aips4: bus@32c00000 {
 			#size-cells = <1>;
 			ranges = <0x32c00000 0x32c00000 0x400000>;
 
+			lcdif: lcdif@32e00000 {
+				compatible = "fsl,imx8mm-lcdif", "fsl,imx6sx-lcdif";
+				reg = <0x32e00000 0x10000>;
+				clocks = <&clk IMX8MM_CLK_LCDIF_PIXEL>,
+					 <&clk IMX8MM_CLK_DISP_APB_ROOT>,
+					 <&clk IMX8MM_CLK_DISP_AXI_ROOT>;
+				clock-names = "pix", "axi", "disp_axi";
+				assigned-clocks = <&clk IMX8MM_CLK_LCDIF_PIXEL>,
+						  <&clk IMX8MM_CLK_DISP_AXI>,
+						  <&clk IMX8MM_CLK_DISP_APB>;
+				assigned-clock-parents = <&clk IMX8MM_VIDEO_PLL1_OUT>,
+							 <&clk IMX8MM_SYS_PLL2_1000M>,
+							 <&clk IMX8MM_SYS_PLL1_800M>;
+				assigned-clock-rates = <594000000>, <500000000>, <200000000>;
+				interrupts = <GIC_SPI 5 IRQ_TYPE_LEVEL_HIGH>;
+				power-domains = <&disp_blk_ctrl IMX8MM_DISPBLK_PD_LCDIF>;
+				status = "disabled";
+
+				port {
+					lcdif_to_dsim: endpoint {
+						remote-endpoint = <&dsim_from_lcdif>;
+					};
+				};
+			};
+
+			mipi_dsi: dsi@32e10000 {
+				#address-cells = <1>;
+				#size-cells = <0>;
+				compatible = "fsl,imx8mm-mipi-dsim";
+				reg = <0x32e10000 0x400>;
+				clocks = <&clk IMX8MM_CLK_DSI_CORE>,
+					 <&clk IMX8MM_CLK_DSI_PHY_REF>;
+				clock-names = "bus_clk", "sclk_mipi";
+				assigned-clocks = <&clk IMX8MM_CLK_DSI_CORE>,
+						  <&clk IMX8MM_CLK_DSI_PHY_REF>;
+				assigned-clock-parents = <&clk IMX8MM_SYS_PLL1_266M>,
+							 <&clk IMX8MM_CLK_24M>;
+				assigned-clock-rates = <266000000>, <24000000>;
+				samsung,pll-clock-frequency = <24000000>;
+				interrupts = <GIC_SPI 18 IRQ_TYPE_LEVEL_HIGH>;
+				power-domains = <&disp_blk_ctrl IMX8MM_DISPBLK_PD_MIPI_DSI>;
+				status = "disabled";
+
+				ports {
+					#address-cells = <1>;
+					#size-cells = <0>;
+
+					port@0 {
+						reg = <0>;
+
+						dsim_from_lcdif: endpoint {
+							remote-endpoint = <&lcdif_to_dsim>;
+						};
+					};
+				};
+			};
+
 			csi: csi@32e20000 {
 				compatible = "fsl,imx8mm-csi", "fsl,imx7-csi";
 				reg = <0x32e20000 0x1000>;
Signature · 1 line
2.39.2
#2 lore raw
In reply to Marek Vasut

Hi Marek,

Am Dienstag, 4. April 2023, 02:01:51 CEST schrieb Marek Vasut:

Quoted 29 lines

Add LCDIF scanout engine and DSIM bridge nodes for i.MX8M Mini. This makes the DSI display pipeline available on this SoC.

---
Cc: Abel Vesa <[email protected]>
Cc: Dong Aisheng <[email protected]>
Cc: Fabio Estevam <[email protected]>
Cc: Guido Günther <[email protected]>
Cc: Krzysztof Kozlowski <[email protected]>
Cc: Lucas Stach <[email protected]>
Cc: NXP Linux Team <[email protected]>
Cc: Pengutronix Kernel Team <[email protected]>
Cc: Richard Cochran <[email protected]>
Cc: Rob Herring <[email protected]>
Cc: Sascha Hauer <[email protected]>
Cc: Shawn Guo <[email protected]>
Cc: [email protected]
Cc: [email protected]

---
 arch/arm64/boot/dts/freescale/imx8mm.dtsi | 57 +++++++++++++++++++++++
 1 file changed, 57 insertions(+)
(quoted diff) +0 -0

b/arch/arm64/boot/dts/freescale/imx8mm.dtsi index
e311da7e87bdc..06495c225c94b 100644

arch/arm64/boot/dts/freescale/imx8mm.dtsi aips4: bus@32c00000 { · line 1123

Quoted 5 lines
arch/arm64/boot/dts/freescale/imx8mm.dtsi +2 -0
@@ -1119,6 +1119,63 @@ aips4: bus@32c00000 {
 			#size-cells = <1>;
 			ranges = <0x32c00000 0x32c00000 0x400000>;
 
+			lcdif: lcdif@32e00000 {
+				compatible = "fsl,imx8mm-lcdif", 

"fsl,imx6sx-lcdif";

arch/arm64/boot/dts/freescale/imx8mm.dtsi aips4: bus@32c00000 { · line 1125

Quoted 2 lines
arch/arm64/boot/dts/freescale/imx8mm.dtsi +2 -0
+				reg = <0x32e00000 0x10000>;
+				clocks = <&clk 

IMX8MM_CLK_LCDIF_PIXEL>,

arch/arm64/boot/dts/freescale/imx8mm.dtsi aips4: bus@32c00000 { · line 1126

Quoted 1 line
arch/arm64/boot/dts/freescale/imx8mm.dtsi +1 -0
+					 <&clk 

IMX8MM_CLK_DISP_APB_ROOT>,

arch/arm64/boot/dts/freescale/imx8mm.dtsi aips4: bus@32c00000 { · line 1127

Quoted 1 line
arch/arm64/boot/dts/freescale/imx8mm.dtsi +1 -0
+					 <&clk 

IMX8MM_CLK_DISP_AXI_ROOT>;

arch/arm64/boot/dts/freescale/imx8mm.dtsi aips4: bus@32c00000 { · line 1128

Quoted 1 line
arch/arm64/boot/dts/freescale/imx8mm.dtsi +1 -0
+				clock-names = "pix", "axi", 

"disp_axi";

arch/arm64/boot/dts/freescale/imx8mm.dtsi aips4: bus@32c00000 { · line 1129

Quoted 1 line
arch/arm64/boot/dts/freescale/imx8mm.dtsi +1 -0
+				assigned-clocks = <&clk 

IMX8MM_CLK_LCDIF_PIXEL>,

arch/arm64/boot/dts/freescale/imx8mm.dtsi aips4: bus@32c00000 { · line 1130

Quoted 1 line
arch/arm64/boot/dts/freescale/imx8mm.dtsi +1 -0
+						  <&clk 

IMX8MM_CLK_DISP_AXI>,

arch/arm64/boot/dts/freescale/imx8mm.dtsi aips4: bus@32c00000 { · line 1131

Quoted 1 line
arch/arm64/boot/dts/freescale/imx8mm.dtsi +1 -0
+						  <&clk 

IMX8MM_CLK_DISP_APB>;

arch/arm64/boot/dts/freescale/imx8mm.dtsi aips4: bus@32c00000 { · line 1132

Quoted 1 line
arch/arm64/boot/dts/freescale/imx8mm.dtsi +1 -0
+				assigned-clock-parents = <&clk 

IMX8MM_VIDEO_PLL1_OUT>,

arch/arm64/boot/dts/freescale/imx8mm.dtsi aips4: bus@32c00000 { · line 1133

Quoted 1 line
arch/arm64/boot/dts/freescale/imx8mm.dtsi +1 -0
+							 <&clk 

IMX8MM_SYS_PLL2_1000M>,

arch/arm64/boot/dts/freescale/imx8mm.dtsi aips4: bus@32c00000 { · line 1134

Quoted 1 line
arch/arm64/boot/dts/freescale/imx8mm.dtsi +1 -0
+							 <&clk 

IMX8MM_SYS_PLL1_800M>;

arch/arm64/boot/dts/freescale/imx8mm.dtsi aips4: bus@32c00000 { · line 1135

Quoted 1 line
arch/arm64/boot/dts/freescale/imx8mm.dtsi +1 -0
+				assigned-clock-rates = <594000000>, 

<500000000>, <200000000>;

arch/arm64/boot/dts/freescale/imx8mm.dtsi aips4: bus@32c00000 { · line 1136

Quoted 1 line
arch/arm64/boot/dts/freescale/imx8mm.dtsi +1 -0
+				interrupts = <GIC_SPI 5 

IRQ_TYPE_LEVEL_HIGH>;

arch/arm64/boot/dts/freescale/imx8mm.dtsi aips4: bus@32c00000 { · line 1137

Quoted 1 line
arch/arm64/boot/dts/freescale/imx8mm.dtsi +1 -0
+				power-domains = <&disp_blk_ctrl 

IMX8MM_DISPBLK_PD_LCDIF>;

arch/arm64/boot/dts/freescale/imx8mm.dtsi aips4: bus@32c00000 {

Quoted 5 lines
arch/arm64/boot/dts/freescale/imx8mm.dtsi +5 -0
+				status = "disabled";
+
+				port {
+					lcdif_to_dsim: endpoint {
+						remote-endpoint = 

<&dsim_from_lcdif>;

arch/arm64/boot/dts/freescale/imx8mm.dtsi aips4: bus@32c00000 {

Quoted 11 lines
arch/arm64/boot/dts/freescale/imx8mm.dtsi +11 -0
+					};
+				};
+			};
+
+			mipi_dsi: dsi@32e10000 {
+				#address-cells = <1>;
+				#size-cells = <0>;
+				compatible = "fsl,imx8mm-mipi-dsim";
+				reg = <0x32e10000 0x400>;
+				clocks = <&clk IMX8MM_CLK_DSI_CORE>,
+					 <&clk 

IMX8MM_CLK_DSI_PHY_REF>;

arch/arm64/boot/dts/freescale/imx8mm.dtsi aips4: bus@32c00000 { · line 1155

Quoted 2 lines
arch/arm64/boot/dts/freescale/imx8mm.dtsi +2 -0
+				clock-names = "bus_clk", "sclk_mipi";
+				assigned-clocks = <&clk 

IMX8MM_CLK_DSI_CORE>,

arch/arm64/boot/dts/freescale/imx8mm.dtsi aips4: bus@32c00000 { · line 1156

Quoted 1 line
arch/arm64/boot/dts/freescale/imx8mm.dtsi +1 -0
+						  <&clk 

IMX8MM_CLK_DSI_PHY_REF>;

arch/arm64/boot/dts/freescale/imx8mm.dtsi aips4: bus@32c00000 { · line 1157

Quoted 1 line
arch/arm64/boot/dts/freescale/imx8mm.dtsi +1 -0
+				assigned-clock-parents = <&clk 

IMX8MM_SYS_PLL1_266M>,

arch/arm64/boot/dts/freescale/imx8mm.dtsi aips4: bus@32c00000 { · line 1158

Quoted 1 line
arch/arm64/boot/dts/freescale/imx8mm.dtsi +1 -0
+							 <&clk 

IMX8MM_CLK_24M>;

arch/arm64/boot/dts/freescale/imx8mm.dtsi aips4: bus@32c00000 { · line 1159

Quoted 1 line
arch/arm64/boot/dts/freescale/imx8mm.dtsi +1 -0
+				assigned-clock-rates = <266000000>, 

<24000000>;

arch/arm64/boot/dts/freescale/imx8mm.dtsi aips4: bus@32c00000 { · line 1160

Quoted 1 line
arch/arm64/boot/dts/freescale/imx8mm.dtsi +1 -0
+				samsung,pll-clock-frequency = 

<24000000>;

What about samsung,burst-clock-frequency and samsung,esc-clock-frequency? Is there is sane default? Do they need to be provided in the board file?

Best regards,
Alexander

arch/arm64/boot/dts/freescale/imx8mm.dtsi aips4: bus@32c00000 { · line 1161

Quoted 1 line
arch/arm64/boot/dts/freescale/imx8mm.dtsi +1 -0
+				interrupts = <GIC_SPI 18 

IRQ_TYPE_LEVEL_HIGH>;

arch/arm64/boot/dts/freescale/imx8mm.dtsi aips4: bus@32c00000 { · line 1162

Quoted 1 line
arch/arm64/boot/dts/freescale/imx8mm.dtsi +1 -0
+				power-domains = <&disp_blk_ctrl 

IMX8MM_DISPBLK_PD_MIPI_DSI>;

arch/arm64/boot/dts/freescale/imx8mm.dtsi aips4: bus@32c00000 {

Quoted 10 lines
arch/arm64/boot/dts/freescale/imx8mm.dtsi +10 -0
+				status = "disabled";
+
+				ports {
+					#address-cells = <1>;
+					#size-cells = <0>;
+
+					port@0 {
+						reg = <0>;
+
+						dsim_from_lcdif: 

endpoint {

arch/arm64/boot/dts/freescale/imx8mm.dtsi aips4: bus@32c00000 { · line 1173

Quoted 1 line
arch/arm64/boot/dts/freescale/imx8mm.dtsi +1 -0
+							remote-

endpoint = <&lcdif_to_dsim>;

arch/arm64/boot/dts/freescale/imx8mm.dtsi aips4: bus@32c00000 {

Quoted 7 lines
arch/arm64/boot/dts/freescale/imx8mm.dtsi +5 -0
+						};
+					};
+				};
+			};
+
 			csi: csi@32e20000 {
 				compatible = "fsl,imx8mm-csi", 

"fsl,imx7-csi";

Quoted 1 line
arch/arm64/boot/dts/freescale/imx8mm.dtsi +0 -0
 				reg = <0x32e20000 0x1000>;
Signature · 4 lines
TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany
Amtsgericht München, HRB 105018
Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider
http://www.tq-group.com/
#3 lore raw
Quoted 1 line · Alexander Stein

Hi Marek,

Hi,

Quoted 90 lines

Am Dienstag, 4. April 2023, 02:01:51 CEST schrieb Marek Vasut:

Quoted 29 lines

Add LCDIF scanout engine and DSIM bridge nodes for i.MX8M Mini. This makes the DSI display pipeline available on this SoC.

---
Cc: Abel Vesa <[email protected]>
Cc: Dong Aisheng <[email protected]>
Cc: Fabio Estevam <[email protected]>
Cc: Guido Günther <[email protected]>
Cc: Krzysztof Kozlowski <[email protected]>
Cc: Lucas Stach <[email protected]>
Cc: NXP Linux Team <[email protected]>
Cc: Pengutronix Kernel Team <[email protected]>
Cc: Richard Cochran <[email protected]>
Cc: Rob Herring <[email protected]>
Cc: Sascha Hauer <[email protected]>
Cc: Shawn Guo <[email protected]>
Cc: [email protected]
Cc: [email protected]

---
  arch/arm64/boot/dts/freescale/imx8mm.dtsi | 57 +++++++++++++++++++++++
  1 file changed, 57 insertions(+)
(quoted diff) +0 -0

b/arch/arm64/boot/dts/freescale/imx8mm.dtsi index
e311da7e87bdc..06495c225c94b 100644

arch/arm64/boot/dts/freescale/imx8mm.dtsi aips4: bus@32c00000 { · line 1123

Quoted 5 lines
arch/arm64/boot/dts/freescale/imx8mm.dtsi +2 -0
@@ -1119,6 +1119,63 @@ aips4: bus@32c00000 {
  			#size-cells = <1>;
  			ranges = <0x32c00000 0x32c00000 0x400000>;
 
+			lcdif: lcdif@32e00000 {
+				compatible = "fsl,imx8mm-lcdif",

"fsl,imx6sx-lcdif";

arch/arm64/boot/dts/freescale/imx8mm.dtsi aips4: bus@32c00000 { · line 1125

Quoted 2 lines
arch/arm64/boot/dts/freescale/imx8mm.dtsi +2 -0
+				reg = <0x32e00000 0x10000>;
+				clocks = <&clk

IMX8MM_CLK_LCDIF_PIXEL>,

arch/arm64/boot/dts/freescale/imx8mm.dtsi aips4: bus@32c00000 { · line 1126

Quoted 1 line
arch/arm64/boot/dts/freescale/imx8mm.dtsi +1 -0
+					 <&clk

IMX8MM_CLK_DISP_APB_ROOT>,

arch/arm64/boot/dts/freescale/imx8mm.dtsi aips4: bus@32c00000 { · line 1127

Quoted 1 line
arch/arm64/boot/dts/freescale/imx8mm.dtsi +1 -0
+					 <&clk

IMX8MM_CLK_DISP_AXI_ROOT>;

arch/arm64/boot/dts/freescale/imx8mm.dtsi aips4: bus@32c00000 { · line 1128

Quoted 1 line
arch/arm64/boot/dts/freescale/imx8mm.dtsi +1 -0
+				clock-names = "pix", "axi",

"disp_axi";

arch/arm64/boot/dts/freescale/imx8mm.dtsi aips4: bus@32c00000 { · line 1129

Quoted 1 line
arch/arm64/boot/dts/freescale/imx8mm.dtsi +1 -0
+				assigned-clocks = <&clk

IMX8MM_CLK_LCDIF_PIXEL>,

arch/arm64/boot/dts/freescale/imx8mm.dtsi aips4: bus@32c00000 { · line 1130

Quoted 1 line
arch/arm64/boot/dts/freescale/imx8mm.dtsi +1 -0
+						  <&clk

IMX8MM_CLK_DISP_AXI>,

arch/arm64/boot/dts/freescale/imx8mm.dtsi aips4: bus@32c00000 { · line 1131

Quoted 1 line
arch/arm64/boot/dts/freescale/imx8mm.dtsi +1 -0
+						  <&clk

IMX8MM_CLK_DISP_APB>;

arch/arm64/boot/dts/freescale/imx8mm.dtsi aips4: bus@32c00000 { · line 1132

Quoted 1 line
arch/arm64/boot/dts/freescale/imx8mm.dtsi +1 -0
+				assigned-clock-parents = <&clk

IMX8MM_VIDEO_PLL1_OUT>,

arch/arm64/boot/dts/freescale/imx8mm.dtsi aips4: bus@32c00000 { · line 1133

Quoted 1 line
arch/arm64/boot/dts/freescale/imx8mm.dtsi +1 -0
+							 <&clk

IMX8MM_SYS_PLL2_1000M>,

arch/arm64/boot/dts/freescale/imx8mm.dtsi aips4: bus@32c00000 { · line 1134

Quoted 1 line
arch/arm64/boot/dts/freescale/imx8mm.dtsi +1 -0
+							 <&clk

IMX8MM_SYS_PLL1_800M>;

arch/arm64/boot/dts/freescale/imx8mm.dtsi aips4: bus@32c00000 { · line 1135

Quoted 1 line
arch/arm64/boot/dts/freescale/imx8mm.dtsi +1 -0
+				assigned-clock-rates = <594000000>,

<500000000>, <200000000>;

arch/arm64/boot/dts/freescale/imx8mm.dtsi aips4: bus@32c00000 { · line 1136

Quoted 1 line
arch/arm64/boot/dts/freescale/imx8mm.dtsi +1 -0
+				interrupts = <GIC_SPI 5

IRQ_TYPE_LEVEL_HIGH>;

arch/arm64/boot/dts/freescale/imx8mm.dtsi aips4: bus@32c00000 { · line 1137

Quoted 1 line
arch/arm64/boot/dts/freescale/imx8mm.dtsi +1 -0
+				power-domains = <&disp_blk_ctrl

IMX8MM_DISPBLK_PD_LCDIF>;

arch/arm64/boot/dts/freescale/imx8mm.dtsi aips4: bus@32c00000 {

Quoted 5 lines
arch/arm64/boot/dts/freescale/imx8mm.dtsi +5 -0
+				status = "disabled";
+
+				port {
+					lcdif_to_dsim: endpoint {
+						remote-endpoint =

<&dsim_from_lcdif>;

arch/arm64/boot/dts/freescale/imx8mm.dtsi aips4: bus@32c00000 {

Quoted 11 lines
arch/arm64/boot/dts/freescale/imx8mm.dtsi +11 -0
+					};
+				};
+			};
+
+			mipi_dsi: dsi@32e10000 {
+				#address-cells = <1>;
+				#size-cells = <0>;
+				compatible = "fsl,imx8mm-mipi-dsim";
+				reg = <0x32e10000 0x400>;
+				clocks = <&clk IMX8MM_CLK_DSI_CORE>,
+					 <&clk

IMX8MM_CLK_DSI_PHY_REF>;

arch/arm64/boot/dts/freescale/imx8mm.dtsi aips4: bus@32c00000 { · line 1155

Quoted 2 lines
arch/arm64/boot/dts/freescale/imx8mm.dtsi +2 -0
+				clock-names = "bus_clk", "sclk_mipi";
+				assigned-clocks = <&clk

IMX8MM_CLK_DSI_CORE>,

arch/arm64/boot/dts/freescale/imx8mm.dtsi aips4: bus@32c00000 { · line 1156

Quoted 1 line
arch/arm64/boot/dts/freescale/imx8mm.dtsi +1 -0
+						  <&clk

IMX8MM_CLK_DSI_PHY_REF>;

arch/arm64/boot/dts/freescale/imx8mm.dtsi aips4: bus@32c00000 { · line 1157

Quoted 1 line
arch/arm64/boot/dts/freescale/imx8mm.dtsi +1 -0
+				assigned-clock-parents = <&clk

IMX8MM_SYS_PLL1_266M>,

arch/arm64/boot/dts/freescale/imx8mm.dtsi aips4: bus@32c00000 { · line 1158

Quoted 1 line
arch/arm64/boot/dts/freescale/imx8mm.dtsi +1 -0
+							 <&clk

IMX8MM_CLK_24M>;

Quoted 7 lines

arch/arm64/boot/dts/freescale/imx8mm.dtsi aips4: bus@32c00000 { · line 1159

Quoted 1 line
arch/arm64/boot/dts/freescale/imx8mm.dtsi +1 -0
+				assigned-clock-rates = <266000000>,

<24000000>;

arch/arm64/boot/dts/freescale/imx8mm.dtsi aips4: bus@32c00000 { · line 1160

Quoted 1 line
arch/arm64/boot/dts/freescale/imx8mm.dtsi +1 -0
+				samsung,pll-clock-frequency =

<24000000>;

What about samsung,burst-clock-frequency and samsung,esc-clock-frequency? Is there is sane default? Do they need to be provided in the board file?

Those two (burst and esc) are display or nearest-bridge specific and go into board files.

Reviewed-by
#4 lore raw

Hi,

Am Mittwoch, 5. April 2023, 14:32:35 CEST schrieb Marek Vasut:

Quoted 106 lines · Alexander Stein
Quoted 1 line

Hi Marek,

Hi,

Quoted 101 lines

Am Dienstag, 4. April 2023, 02:01:51 CEST schrieb Marek Vasut:

Quoted 30 lines

Add LCDIF scanout engine and DSIM bridge nodes for i.MX8M Mini. This makes the DSI display pipeline available on this SoC.

---
Cc: Abel Vesa <[email protected]>
Cc: Dong Aisheng <[email protected]>
Cc: Fabio Estevam <[email protected]>
Cc: Guido Günther <[email protected]>
Cc: Krzysztof Kozlowski <[email protected]>
Cc: Lucas Stach <[email protected]>
Cc: NXP Linux Team <[email protected]>
Cc: Pengutronix Kernel Team <[email protected]>
Cc: Richard Cochran <[email protected]>
Cc: Rob Herring <[email protected]>
Cc: Sascha Hauer <[email protected]>
Cc: Shawn Guo <[email protected]>
Cc: [email protected]
Cc: [email protected]
---

  arch/arm64/boot/dts/freescale/imx8mm.dtsi | 57 +++++++++++++++++++++++
  1 file changed, 57 insertions(+)
(quoted diff) +0 -0

b/arch/arm64/boot/dts/freescale/imx8mm.dtsi index
e311da7e87bdc..06495c225c94b 100644

arch/arm64/boot/dts/freescale/imx8mm.dtsi aips4: bus@32c00000 { · line 1124

Quoted 6 lines
arch/arm64/boot/dts/freescale/imx8mm.dtsi +2 -0
@@ -1119,6 +1119,63 @@ aips4: bus@32c00000 {
 
  			#size-cells = <1>;
  			ranges = <0x32c00000 0x32c00000 0x400000>;
 
+			lcdif: lcdif@32e00000 {
+				compatible = "fsl,imx8mm-lcdif",

"fsl,imx6sx-lcdif";

arch/arm64/boot/dts/freescale/imx8mm.dtsi aips4: bus@32c00000 { · line 1126

Quoted 2 lines
arch/arm64/boot/dts/freescale/imx8mm.dtsi +2 -0
+				reg = <0x32e00000 0x10000>;
+				clocks = <&clk

IMX8MM_CLK_LCDIF_PIXEL>,

arch/arm64/boot/dts/freescale/imx8mm.dtsi aips4: bus@32c00000 { · line 1127

Quoted 1 line
arch/arm64/boot/dts/freescale/imx8mm.dtsi +1 -0
+					 <&clk

IMX8MM_CLK_DISP_APB_ROOT>,

arch/arm64/boot/dts/freescale/imx8mm.dtsi aips4: bus@32c00000 { · line 1128

Quoted 1 line
arch/arm64/boot/dts/freescale/imx8mm.dtsi +1 -0
+					 <&clk

IMX8MM_CLK_DISP_AXI_ROOT>;

arch/arm64/boot/dts/freescale/imx8mm.dtsi aips4: bus@32c00000 { · line 1129

Quoted 1 line
arch/arm64/boot/dts/freescale/imx8mm.dtsi +1 -0
+				clock-names = "pix", "axi",

"disp_axi";

arch/arm64/boot/dts/freescale/imx8mm.dtsi aips4: bus@32c00000 { · line 1130

Quoted 1 line
arch/arm64/boot/dts/freescale/imx8mm.dtsi +1 -0
+				assigned-clocks = <&clk

IMX8MM_CLK_LCDIF_PIXEL>,

arch/arm64/boot/dts/freescale/imx8mm.dtsi aips4: bus@32c00000 { · line 1131

Quoted 1 line
arch/arm64/boot/dts/freescale/imx8mm.dtsi +1 -0
+						  <&clk

IMX8MM_CLK_DISP_AXI>,

arch/arm64/boot/dts/freescale/imx8mm.dtsi aips4: bus@32c00000 { · line 1132

Quoted 1 line
arch/arm64/boot/dts/freescale/imx8mm.dtsi +1 -0
+						  <&clk

IMX8MM_CLK_DISP_APB>;

arch/arm64/boot/dts/freescale/imx8mm.dtsi aips4: bus@32c00000 { · line 1133

Quoted 1 line
arch/arm64/boot/dts/freescale/imx8mm.dtsi +1 -0
+				assigned-clock-parents = <&clk

IMX8MM_VIDEO_PLL1_OUT>,

arch/arm64/boot/dts/freescale/imx8mm.dtsi aips4: bus@32c00000 { · line 1134

Quoted 1 line
arch/arm64/boot/dts/freescale/imx8mm.dtsi +1 -0
+							 <&clk

IMX8MM_SYS_PLL2_1000M>,

arch/arm64/boot/dts/freescale/imx8mm.dtsi aips4: bus@32c00000 { · line 1135

Quoted 1 line
arch/arm64/boot/dts/freescale/imx8mm.dtsi +1 -0
+							 <&clk

IMX8MM_SYS_PLL1_800M>;

arch/arm64/boot/dts/freescale/imx8mm.dtsi aips4: bus@32c00000 { · line 1136

Quoted 1 line
arch/arm64/boot/dts/freescale/imx8mm.dtsi +1 -0
+				assigned-clock-rates = <594000000>,

<500000000>, <200000000>;

arch/arm64/boot/dts/freescale/imx8mm.dtsi aips4: bus@32c00000 { · line 1137

Quoted 1 line
arch/arm64/boot/dts/freescale/imx8mm.dtsi +1 -0
+				interrupts = <GIC_SPI 5

IRQ_TYPE_LEVEL_HIGH>;

arch/arm64/boot/dts/freescale/imx8mm.dtsi aips4: bus@32c00000 { · line 1138

Quoted 1 line
arch/arm64/boot/dts/freescale/imx8mm.dtsi +1 -0
+				power-domains = <&disp_blk_ctrl

IMX8MM_DISPBLK_PD_LCDIF>;

arch/arm64/boot/dts/freescale/imx8mm.dtsi aips4: bus@32c00000 {

Quoted 5 lines
arch/arm64/boot/dts/freescale/imx8mm.dtsi +5 -0
+				status = "disabled";
+
+				port {
+					lcdif_to_dsim: endpoint {
+						remote-endpoint =

<&dsim_from_lcdif>;

Quoted 7 lines
Quoted 7 lines

arch/arm64/boot/dts/freescale/imx8mm.dtsi aips4: bus@32c00000 { · line 1149

Quoted 7 lines
arch/arm64/boot/dts/freescale/imx8mm.dtsi +7 -0
+					};
+				};
+			};
+
+			mipi_dsi: dsi@32e10000 {
+				#address-cells = <1>;
+				#size-cells = <0>;

I missed that. These are not necessary.

Quoted 28 lines
Quoted 28 lines

arch/arm64/boot/dts/freescale/imx8mm.dtsi aips4: bus@32c00000 {

Quoted 4 lines
arch/arm64/boot/dts/freescale/imx8mm.dtsi +4 -0
+				compatible = "fsl,imx8mm-mipi-dsim";
+				reg = <0x32e10000 0x400>;
+				clocks = <&clk IMX8MM_CLK_DSI_CORE>,
+					 <&clk

IMX8MM_CLK_DSI_PHY_REF>;

arch/arm64/boot/dts/freescale/imx8mm.dtsi aips4: bus@32c00000 { · line 1156

Quoted 2 lines
arch/arm64/boot/dts/freescale/imx8mm.dtsi +2 -0
+				clock-names = "bus_clk", "sclk_mipi";
+				assigned-clocks = <&clk

IMX8MM_CLK_DSI_CORE>,

arch/arm64/boot/dts/freescale/imx8mm.dtsi aips4: bus@32c00000 { · line 1157

Quoted 1 line
arch/arm64/boot/dts/freescale/imx8mm.dtsi +1 -0
+						  <&clk

IMX8MM_CLK_DSI_PHY_REF>;

arch/arm64/boot/dts/freescale/imx8mm.dtsi aips4: bus@32c00000 { · line 1158

Quoted 1 line
arch/arm64/boot/dts/freescale/imx8mm.dtsi +1 -0
+				assigned-clock-parents = <&clk

IMX8MM_SYS_PLL1_266M>,

arch/arm64/boot/dts/freescale/imx8mm.dtsi aips4: bus@32c00000 { · line 1159

Quoted 1 line
arch/arm64/boot/dts/freescale/imx8mm.dtsi +1 -0
+							 <&clk

IMX8MM_CLK_24M>;

arch/arm64/boot/dts/freescale/imx8mm.dtsi aips4: bus@32c00000 { · line 1160

Quoted 1 line
arch/arm64/boot/dts/freescale/imx8mm.dtsi +1 -0
+				assigned-clock-rates = <266000000>,

<24000000>;

Quoted 8 lines
Quoted 6 lines

arch/arm64/boot/dts/freescale/imx8mm.dtsi aips4: bus@32c00000 { · line 1161

Quoted 1 line
arch/arm64/boot/dts/freescale/imx8mm.dtsi +1 -0
+				samsung,pll-clock-frequency =

<24000000>;

What about samsung,burst-clock-frequency and samsung,esc-clock-frequency? Is there is sane default? Do they need to be provided in the board file?

Those two (burst and esc) are display or nearest-bridge specific and go into board files.

Thanks for clarification. With the nit from above fixed:

Signature · 4 lines
TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany
Amtsgericht München, HRB 105018
Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider
http://www.tq-group.com/
#5 lore raw

On 4/5/23 15:16, Alexander Stein wrote:

Hi,

[...]

Quoted 7 lines
Quoted 4 lines
Quoted 2 lines

What about samsung,burst-clock-frequency and samsung,esc-clock-frequency? Is there is sane default? Do they need to be provided in the board file?

Those two (burst and esc) are display or nearest-bridge specific and go into board files.

Thanks for clarification. With the nit from above fixed:

Should be fixed in V2 , thanks. I also bundled those patches into series there.