Skip to contentSkip to conversation

HID: apple: Set the tilde quirk flag on the Geyser 3

PATCH Applied Alex Henrie 2 participants 2 messages Apr 4, 2023 – Apr 13, 2023 HID

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 HID: apple: Set the tilde quirk flag on the Geyser 3

I was finally able to obtain a MacBook1,1 to test and I've now confirmed that it has the tilde key quirk as well:

Product Model Year System CPU Shape Labels Country Quirky
============================================================================
05ac:0218 A1181 2006 MacBook1,1 T2500 ISO British 13 Yes

---
It's probably too late to squash this into my previous patch, but you can if you want.

---
 drivers/hid/hid-apple.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/hid/hid-apple.c +2 -1
index 5c145775482b..e2c73a78b597 100644
@@ -875,7 +875,8 @@ static const struct hid_device_id apple_devices[] = {
 	{ HID_USB_DEVICE(USB_VENDOR_ID_APPLE, USB_DEVICE_ID_APPLE_GEYSER3_ANSI),
 		.driver_data = APPLE_NUMLOCK_EMULATION | APPLE_HAS_FN },
 	{ HID_USB_DEVICE(USB_VENDOR_ID_APPLE, USB_DEVICE_ID_APPLE_GEYSER3_ISO),
-		.driver_data = APPLE_NUMLOCK_EMULATION | APPLE_HAS_FN },
+		.driver_data = APPLE_NUMLOCK_EMULATION | APPLE_HAS_FN |
+			APPLE_ISO_TILDE_QUIRK },
 	{ HID_USB_DEVICE(USB_VENDOR_ID_APPLE, USB_DEVICE_ID_APPLE_GEYSER3_JIS),
 		.driver_data = APPLE_NUMLOCK_EMULATION | APPLE_HAS_FN |
 			APPLE_RDESC_JIS },
Signature · 1 line
2.40.0
#1 lore raw
Quoted 8 lines · Alex Henrie

I was finally able to obtain a MacBook1,1 to test and I've now confirmed that it has the tilde key quirk as well:

Product Model Year System CPU Shape Labels Country Quirky
============================================================================
05ac:0218 A1181 2006 MacBook1,1 T2500 ISO British 13 Yes

[...]

Applied to hid/hid.git (for-6.4/apple), thanks!

[1/1] HID: apple: Set the tilde quirk flag on the Geyser 3

      https://git.kernel.org/hid/hid/c/29e1ecc197d4

Cheers,

Signature · 1 line
Benjamin Tissoires <[email protected]>