wifi: ath12k: send WMI_PEER_REORDER_QUEUE_SETUP_CMDID when ADDBA session starts
PATCH 1/1 wifi: ath12k: send WMI_PEER_REORDER_QUEUE_SETUP_CMDID when ADDBA session starts
Low receive throughput is seen on WCN7850 because ADDBA related parameters are not updated to firmware when receive ADDBA session starts.
Fix it by sending WMI_PEER_REORDER_QUEUE_SETUP_CMDID again to firmware to update the ADDBA related parameters for chips which have false reoq_lut_support in hw_params. For chips which have true reoq_lut_support in hw_params don't need this command to send to firmware.
Tested-on: WCN7850 hw2.0 PCI WLAN.HMT.1.0-03427-QCAHMTSWPL_V1.0_V2.0_SILICONZ-1.15378.4
--- drivers/net/wireless/ath/ath12k/dp_rx.c | 3 +++ 1 file changed, 3 insertions(+)
drivers/net/wireless/ath/ath12k/dp_rx.c +3 -0
@@ -977,6 +977,9 @@ int ath12k_dp_rx_peer_tid_setup(struct ath12k *ar, const u8 *peer_mac, int vdev_ath12k_warn (ab,"failed to update reo for rx tid %d\n" , tid);return ret; } +if (!ab->hw_params->reoq_lut_support) + ret =ath12k_wmi_peer_rx_reorder_queue_setup (ar, vdev_id, peer_mac, + paddr, tid,1 , ba_win_sz);return ret; }
base-commit: bea046575a2e6d7d1cf63cc7ab032647a3585de5
Signature · 7 lines
2.25.1 -- ath12k mailing list [email protected] https://lists.infradead.org/mailman/listinfo/ath12k
Quoted 20 lines · Carl Huang
Low receive throughput is seen on WCN7850 because ADDBA related parameters are not updated to firmware when receive ADDBA session starts.
Fix it by sending
WMI_PEER_REORDER_QUEUE_SETUP_CMDIDagain to firmware to update the ADDBA related parameters for chips which have falsereoq_lut_supportinhw_params. For chips which have truereoq_lut_supportinhw_paramsdon't need this command to send to firmware.Tested-on: WCN7850 hw2.0 PCI WLAN.HMT.1.0-03427-QCAHMTSWPL_V1.0_V2.0_SILICONZ-1.15378.4
Signed-off-by Carl Huang <[email protected]>--- drivers/net/wireless/ath/ath12k/dp_rx.c | 3 +++ 1 file changed, 3 insertions(+)drivers/net/wireless/ath/ath12k/dp_rx.c +0
-0
drivers/net/wireless/ath/ath12k/dp_rx.c int ath12k_dp_rx_peer_tid_setup(struct ath12k *ar, const u8 *peer_mac, int vdev_ · line 985
Quoted 9 lines
drivers/net/wireless/ath/ath12k/dp_rx.c +3
-0@@ -977,6 +977,9 @@ int ath12k_dp_rx_peer_tid_setup(struct ath12k *ar, const u8 *peer_mac, int vdev_ath12k_warn (ab,"failed to update reo for rx tid %d\n" , tid);return ret; } +if (!ab->hw_params->reoq_lut_support) + ret =ath12k_wmi_peer_rx_reorder_queue_setup (ar, vdev_id, peer_mac, + paddr, tid,1 , ba_win_sz);return ret; }
This added new warnings:
drivers/net/wireless/ath/ath12k/dp_rx.c:981: line length of 91 exceeds 90 columns drivers/net/wireless/ath/ath12k/dp_rx.c:982: line length of 95 exceeds 90 columns
I fixed them in the pending branch. There was also no warning message if ath12k_wmi_peer_rx_reorder_queue_setup() fails, I added that as well:
Signature · 3 lines
https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
Quoted 8 lines · Carl Huang
Low receive throughput is seen on WCN7850 because ADDBA related parameters are not updated to firmware when receive ADDBA session starts.
Fix it by sending
WMI_PEER_REORDER_QUEUE_SETUP_CMDIDagain to firmware to update the ADDBA related parameters for chips which have falsereoq_lut_supportinhw_params. For chips which have truereoq_lut_supportinhw_paramsdon't need this command to send to firmware.
Quoted 4 lines
Tested-on: WCN7850 hw2.0 PCI WLAN.HMT.1.0-03427-QCAHMTSWPL_V1.0_V2.0_SILICONZ-1.15378.4
Signed-off-by Carl Huang <[email protected]>Signed-off-by Kalle Valo <[email protected]>
Patch applied to ath-next branch of ath.git, thanks.
e671fb86ecc0 wifi: ath12k: send WMI_PEER_REORDER_QUEUE_SETUP_CMDID when ADDBA session starts
Signature · 9 lines
https://patchwork.kernel.org/project/linux-wireless/patch/[email protected]/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches -- ath12k mailing list [email protected] https://lists.infradead.org/mailman/listinfo/ath12k