Skip to contentSkip to conversation

arm64: dts: rockchip: Add RTC support for RK3588

PATCH In review Shreeya Patel 2 participants 2 messages Apr 4, 2023

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 arm64: dts: rockchip: Add RTC support for RK3588

Add DT node to enable RTC support on RK3588 board.

---
 .../boot/dts/rockchip/rk3588-rock-5b.dts      | 27 +++++++++++++++++++
 1 file changed, 27 insertions(+)
arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts +27 -0
index 95805cb0adfa..a32bfa8d914a 100644
@@ -27,6 +27,31 @@ vcc5v0_sys: vcc5v0-sys-regulator {
 	};
 };
 
+&i2c6 {
+	status = "okay";
+
+	hym8563: hym8563@51 {
+		compatible = "haoyu,hym8563";
+		reg = <0x51>;
+		#clock-cells = <0>;
+		clock-frequency = <32768>;
+		clock-output-names = "hym8563";
+		pinctrl-names = "default";
+		pinctrl-0 = <&hym8563_int>;
+		interrupt-parent = <&gpio0>;
+		interrupts = <RK_PB0 IRQ_TYPE_LEVEL_LOW>;
+		wakeup-source;
+	};
+};
+
+&pinctrl {
+	hym8563 {
+		hym8563_int: hym8563-int {
+			rockchip,pins = <0 RK_PB0 RK_FUNC_GPIO &pcfg_pull_none>;
+		};
+	};
+};
+
 &sdhci {
 	bus-width = <8>;
 	no-sdio;
@@ -42,3 +67,5 @@ &uart2 {
 	pinctrl-0 = <&uart2m0_xfer>;
 	status = "okay";
 };
+
+
Signature · 1 line
2.30.2
Reviewed-by on v1 1/1
#1 lore raw

Hi Shreeya,

Quoted 3 lines · Shreeya Patel

Add DT node to enable RTC support on RK3588 board.

nit: It'd be great to make the subject something more descriptive about the supported hardware, since this patch doesn't enable the RTC for _all_ RK3588 boards your subject could be a bit misleading. Something like "arm64: dts: rockchip: Enable RTC support for Rock 5B" could be better.

Quoted 48 lines

---
 .../boot/dts/rockchip/rk3588-rock-5b.dts      | 27 +++++++++++++++++++

 1 file changed, 27 insertions(+)
arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts +0 -0
index 95805cb0adfa..a32bfa8d914a 100644
@@ -27,6 +27,31 @@ vcc5v0_sys: vcc5v0-sys-regulator {
         };
  };


+&i2c6 {
+       status = "okay";

arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts +23 -0
+
+       hym8563: hym8563@51 {
+               compatible = "haoyu,hym8563";
+               reg = <0x51>;
+               #clock-cells = <0>;
+               clock-frequency = <32768>;
+               clock-output-names = "hym8563";
+               pinctrl-names = "default";
+               pinctrl-0 = <&hym8563_int>;
+               interrupt-parent = <&gpio0>;
+               interrupts = <RK_PB0 IRQ_TYPE_LEVEL_LOW>;
+               wakeup-source;
+       };
+};
+
+&pinctrl {
+       hym8563 {
+               hym8563_int: hym8563-int {
+                       rockchip,pins = <0 RK_PB0 RK_FUNC_GPIO &pcfg_pull_none>;
+               };
+       };
+};
+

 &sdhci {
        bus-width = <8>;
        no-sdio;

arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts +2 -0
@@ -42,3 +67,5 @@ &uart2 {
         pinctrl-0 = <&uart2m0_xfer>;
         status = "okay";
  };
+
+
Signature · 1 line
2.30.2

_______________________________________________
Linux-rockchip mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-rockchip