nvmem: imx-ocotp: set varaiable imx_ocotp_layout storage-class-specifier to static
Subsystems (2)
PATCH 1/1 nvmem: imx-ocotp: set varaiable imx_ocotp_layout storage-class-specifier to static
smatch reportsdrivers/nvmem/imx-ocotp.c:599:21: warning: symbol
'imx_ocotp_layout' was not declared. Should it be static?
This variable is only used in one file so should be static.
Signed-off-by Tom Rix <[email protected]>
--- drivers/nvmem/imx-ocotp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/nvmem/imx-ocotp.c +1 -1
@@ -596,7 +596,7 @@ static void imx_ocotp_fixup_cell_info(struct nvmem_device *nvmem, cell->read_post_process = imx_ocotp_cell_pp; } -struct nvmem_layout imx_ocotp_layout = { +static struct nvmem_layout imx_ocotp_layout = { .fixup_cell_info = imx_ocotp_fixup_cell_info, };
Signature · 7 lines
2.27.0 _______________________________________________ linux-arm-kernel mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Quoted 8 lines · Tom Rix
smatch reports
drivers/nvmem/imx-ocotp.c:599:21: warning: symbol
'imx_ocotp_layout' was not declared. Should it be static?This variable is only used in one file so should be static.
Signed-off-by Tom Rix <[email protected]>---
Applied thanks,
--srini
Quoted 16 lines
drivers/nvmem/imx-ocotp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/nvmem/imx-ocotp.c +1
-1@@ -596,7 +596,7 @@ static void imx_ocotp_fixup_cell_info(struct nvmem_device *nvmem, cell->read_post_process = imx_ocotp_cell_pp; } -struct nvmem_layout imx_ocotp_layout = { +static struct nvmem_layout imx_ocotp_layout = { .fixup_cell_info = imx_ocotp_fixup_cell_info, };