Skip to contentSkip to conversation

remove crc32c_impl

PATCH In review Christoph Hellwig 3 participants 5 messages Apr 5, 2023

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

Hi all,

this series stops printing the crc32c implementation at btrfs load time as it's already printed at mount time, and then removes the now unused crc32c_impl function.

This series is on top of the btrfs for-next tree, which has a bunch of required crc32c-related work.

Diffstat:

 fs/btrfs/super.c       |    2 +-
 include/linux/crc32c.h |    1 -
 lib/libcrc32c.c        |    6 ------
 3 files changed, 1 insertion(+), 8 deletions(-)
#1 lore raw

PATCH 1/2 btrfs: don't print the crc32c implementtion at load time

Btrfs can use various different checksumming algorithms, and prints the one used for a given file system at mount time. Don't bother printing the crc32c implementation at module load time.

---
 fs/btrfs/super.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
fs/btrfs/super.c +1 -1
index 285c7189b92466..bf79e49157c5e5 100644
@@ -2412,7 +2412,7 @@ static int __init btrfs_print_mod_info(void)
 			", fsverity=no"
 #endif
 			;
-	pr_info("Btrfs loaded, crc32c=%s%s\n", crc32c_impl(), options);
+	pr_info("Btrfs loaded%s\n", options);
 	return 0;
 }
 
Signature · 1 line
2.39.2
#2 lore raw

PATCH 2/2 libcrc32c: remove crc32c_impl

In reply to Christoph Hellwig

This was only ever used by btrfs, and the btrfs users just went away.

---
 include/linux/crc32c.h | 1 -
 lib/libcrc32c.c        | 6 ------
 2 files changed, 7 deletions(-)
include/linux/crc32c.h +0 -1
index bd21af828ff6fd..357ae4611a4539 100644
@@ -5,7 +5,6 @@
 #include <linux/types.h>
 
 extern u32 crc32c(u32 crc, const void *address, unsigned int length);
-extern const char *crc32c_impl(void);
 
 /* This macro exists for backwards-compatibility. */
 #define crc32c_le crc32c
lib/libcrc32c.c +0 -6
index 5ca0d815a95df6..649e687413a0c1 100644
@@ -65,12 +65,6 @@ static void __exit libcrc32c_mod_fini(void)
 	crypto_free_shash(tfm);
 }
 
-const char *crc32c_impl(void)
-{
-	return crypto_shash_driver_name(tfm);
-}
-EXPORT_SYMBOL(crc32c_impl);
-
 module_init(libcrc32c_mod_init);
 module_exit(libcrc32c_mod_fini);
 
Signature · 1 line
2.39.2
maintainer Acked-by on v1 2/2
#3 lore raw

Re: [PATCH 2/2] libcrc32c: remove crc32c_impl

Quoted 7 lines · Christoph Hellwig

This was only ever used by btrfs, and the btrfs users just went away.

---
 include/linux/crc32c.h | 1 -
 lib/libcrc32c.c        | 6 ------
 2 files changed, 7 deletions(-)

Thanks,

Signature · 3 lines
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
#4 lore raw
In reply to Christoph Hellwig
Quoted 5 lines · Christoph Hellwig

Hi all,

this series stops printing the crc32c implementation at btrfs load time as it's already printed at mount time, and then removes the now unused crc32c_impl function.

Added to misc-next, with Herbert's ack, thanks.