Skip to contentSkip to conversation

nand: raw: octeontx: Make list static

PATCH Applied Bin Meng 3 participants 3 messages Apr 5, 2023 – Apr 17, 2023

Subsystems (2)
lore
Share & tools
lore

Bin Meng

author
#0 lore raw

PATCH 1/1 nand: raw: octeontx: Make list static

octeontx_bch_devices and octeontx_pci_nand_deferred_devices are only referenced in the files where they are defined. Make them static.

---

 drivers/mtd/nand/raw/octeontx_bch.c  | 2 +-
 drivers/mtd/nand/raw/octeontx_nand.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
drivers/mtd/nand/raw/octeontx_bch.c +1 -1
index fc16b77416..056a685782 100644
@@ -27,7 +27,7 @@
 #include <asm/arch/clock.h>
 #include "octeontx_bch.h"
 
-LIST_HEAD(octeontx_bch_devices);
+static LIST_HEAD(octeontx_bch_devices);
 static unsigned int num_vfs = BCH_NR_VF;
 static void *bch_pf;
 static void *bch_vf;
drivers/mtd/nand/raw/octeontx_nand.c +1 -1
index 1ffadad9ca..65a03d22c1 100644
@@ -354,7 +354,7 @@ struct octeontx_probe_device {
 
 static struct bch_vf *bch_vf;
 /** Deferred devices due to BCH not being ready */
-LIST_HEAD(octeontx_pci_nand_deferred_devices);
+static LIST_HEAD(octeontx_pci_nand_deferred_devices);
 
 /** default parameters used for probing chips */
 #define MAX_ONFI_MODE	5
Signature · 1 line
2.34.1
Acked-by on v1 1/1
#1 lore raw

Hi

Quoted 29 lines · Bin Meng

octeontx_bch_devices and octeontx_pci_nand_deferred_devices are only referenced in the files where they are defined. Make them static.

---

 drivers/mtd/nand/raw/octeontx_bch.c  | 2 +-
 drivers/mtd/nand/raw/octeontx_nand.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
drivers/mtd/nand/raw/octeontx_bch.c +1 -1
index fc16b77416..056a685782 100644
@@ -27,7 +27,7 @@
 #include <asm/arch/clock.h>
 #include "octeontx_bch.h"
 
-LIST_HEAD(octeontx_bch_devices);
+static LIST_HEAD(octeontx_bch_devices);
 static unsigned int num_vfs = BCH_NR_VF;
 static void *bch_pf;
 static void *bch_vf;
drivers/mtd/nand/raw/octeontx_nand.c +0 -0
index 1ffadad9ca..65a03d22c1 100644

drivers/mtd/nand/raw/octeontx_nand.c struct octeontx_probe_device {

Quoted 9 lines
drivers/mtd/nand/raw/octeontx_nand.c +1 -2
@@ -354,7 +354,7 @@ struct octeontx_probe_device {
 
 static struct bch_vf *bch_vf;
 /** Deferred devices due to BCH not being ready */
-LIST_HEAD(octeontx_pci_nand_deferred_devices);
+static LIST_HEAD(octeontx_pci_nand_deferred_devices);
 
 /** default parameters used for probing chips */
 #define MAX_ONFI_MODE  5
--

Michael

Quoted 2 lines

2.34.1

Signature · 11 lines
Michael Nazzareno Trimarchi
Co-Founder & Chief Executive Officer
M. +39 347 913 2170
[email protected]
__________________________________

Amarula Solutions BV
Joop Geesinkweg 125, 1114 AB, Amsterdam, NL
T. +31 (0)85 111 9172
[email protected]
www.amarulasolutions.com
#2 lore raw

Hi Bin,

Quoted 58 lines · Michael Nazzareno Trimarchi

Hi

Quoted 29 lines · Bin Meng

octeontx_bch_devices and octeontx_pci_nand_deferred_devices are only referenced in the files where they are defined. Make them static.

---

 drivers/mtd/nand/raw/octeontx_bch.c  | 2 +-
 drivers/mtd/nand/raw/octeontx_nand.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
drivers/mtd/nand/raw/octeontx_bch.c +1 -1
index fc16b77416..056a685782 100644
@@ -27,7 +27,7 @@
 #include <asm/arch/clock.h>
 #include "octeontx_bch.h"
 
-LIST_HEAD(octeontx_bch_devices);
+static LIST_HEAD(octeontx_bch_devices);
 static unsigned int num_vfs = BCH_NR_VF;
 static void *bch_pf;
 static void *bch_vf;
drivers/mtd/nand/raw/octeontx_nand.c +0 -0
index 1ffadad9ca..65a03d22c1 100644

drivers/mtd/nand/raw/octeontx_nand.c struct octeontx_probe_device {

Quoted 9 lines
drivers/mtd/nand/raw/octeontx_nand.c +1 -2
@@ -354,7 +354,7 @@ struct octeontx_probe_device {
 
 static struct bch_vf *bch_vf;
 /** Deferred devices due to BCH not being ready */
-LIST_HEAD(octeontx_pci_nand_deferred_devices);
+static LIST_HEAD(octeontx_pci_nand_deferred_devices);
 
 /** default parameters used for probing chips */
 #define MAX_ONFI_MODE  5
--

Michael

Quoted 2 lines

2.34.1

--
Michael Nazzareno Trimarchi
Co-Founder & Chief Executive Officer
M. +39 347 913 2170
[email protected]
__________________________________

Quoted 5 lines

Amarula Solutions BV
Joop Geesinkweg 125, 1114 AB, Amsterdam, NL
T. +31 (0)85 111 9172
[email protected]
www.amarulasolutions.com

Applied to nand-next,

Thanks and regards
Dario

Signature · 17 lines
Dario Binacchi

Senior Embedded Linux Developer

[email protected]

__________________________________


Amarula Solutions SRL

Via Le Canevare 30, 31100 Treviso, Veneto, IT

T. +39 042 243 5310
[email protected]

www.amarulasolutions.com