ASoC: dt-bindings: wm8904: Convert to dtschema
Subsystems (3)
PATCH 1/1 ASoC: dt-bindings: wm8904: Convert to dtschema
Convert the WM8904 audio CODEC bindings to DT schema
--- .../devicetree/bindings/sound/wlf,wm8904.yaml | 66 +++++++++++++++++++ .../devicetree/bindings/sound/wm8904.txt | 33 ---------- 2 files changed, 66 insertions(+), 33 deletions(-) create mode 100644 Documentation/devicetree/bindings/sound/wlf,wm8904.yaml delete mode 100644 Documentation/devicetree/bindings/sound/wm8904.txt
Documentation/devicetree/bindings/sound/wlf,wm8904.yaml new file +66 -0
@@ -0,0 +1,66 @@ +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/sound/wlf,wm8904.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: WM8904 audio CODEC + +description: | + Pins on the device (for linking into audio routes): + * IN1L + * IN1R + * IN2L + * IN2R + * IN3L + * IN3R + * HPOUTL + * HPOUTR + * LINEOUTL + * LINEOUTR + * MICBIAS + +maintainers: + - [email protected] + +allOf: + - $ref: dai-common.yaml# + +properties: + compatible: + enum: + - wlf,wm8904 + - wlf,wm8912 + + reg: + maxItems: 1 + + "#sound-dai-cells": + const: 0 + + clocks: + maxItems: 1 + + clock-names: + const: mclk + +required: + - compatible + - reg + - clock-names + - clocks + +unevaluatedProperties: false + +examples: + - | + i2c { + #address-cells = <1>; + #size-cells = <0>; + codec@1a { + compatible = "wlf,wm8904"; + reg = <0x1a>; + clocks = <&pck0>; + clock-names = "mclk"; + }; + };
Documentation/devicetree/bindings/sound/wm8904.txt deleted +0 -33
@@ -1,33 +0,0 @@ -WM8904 audio CODEC - -This device supports I2C only. - -Required properties: - - compatible: "wlf,wm8904" or "wlf,wm8912" - - reg: the I2C address of the device. - - clock-names: "mclk" - - clocks: reference to - <Documentation/devicetree/bindings/clock/clock-bindings.txt> - -Pins on the device (for linking into audio routes): - - * IN1L - * IN1R - * IN2L - * IN2R - * IN3L - * IN3R - * HPOUTL - * HPOUTR - * LINEOUTL - * LINEOUTR - * MICBIAS - -Examples: - -codec: wm8904@1a { - compatible = "wlf,wm8904"; - reg = <0x1a>; - clocks = <&pck0>; - clock-names = "mclk"; -};
Signature · 1 line
2.34.1
Rob Herring
maintainerQuoted 10 lines · Saalim Quadri
Convert the WM8904 audio CODEC bindings to DT schema
Signed-off-by Saalim Quadri <[email protected]>--- .../devicetree/bindings/sound/wlf,wm8904.yaml | 66 +++++++++++++++++++ .../devicetree/bindings/sound/wm8904.txt | 33 ---------- 2 files changed, 66 insertions(+), 33 deletions(-) create mode 100644 Documentation/devicetree/bindings/sound/wlf,wm8904.yaml delete mode 100644 Documentation/devicetree/bindings/sound/wm8904.txt
Running 'make dtbs_check' with the schema in this patch gives the following warnings. Consider if they are expected or the schema is incorrect. These may not be new warnings.
Note that it is not yet a requirement to have 0 warnings for dtbs_check. This will change in the future.
Full log is available here: https://patchwork.ozlabs.org/project/devicetree-bindings/patch/[email protected]
audio-codec@1a: Unevaluated properties are not allowed ('AVDD-supply', 'CPVDD-supply', 'DBVDD-supply', 'DCVDD-supply', 'MICVDD-supply' were unexpected)
arch/arm64/boot/dts/freescale/imx8mm-verdin-nonwifi-dahlia.dtb arch/arm64/boot/dts/freescale/imx8mm-verdin-wifi-dahlia.dtb
Quoted 14 lines · Rob Herring
Quoted 10 lines · Saalim Quadri
Convert the WM8904 audio CODEC bindings to DT schema
Signed-off-by Saalim Quadri <[email protected]>--- .../devicetree/bindings/sound/wlf,wm8904.yaml | 66 +++++++++++++++++++ .../devicetree/bindings/sound/wm8904.txt | 33 ---------- 2 files changed, 66 insertions(+), 33 deletions(-) create mode 100644 Documentation/devicetree/bindings/sound/wlf,wm8904.yaml delete mode 100644 Documentation/devicetree/bindings/sound/wm8904.txt
Quoted 4 lines
Running 'make
dtbs_check' with the schema in this patch gives the following warnings. Consider if they are expected or the schema is incorrect. These may not be new warnings.
So, these properties are present in some dts files! We need to evaluated if they are always expected
or can be optional.
Quoted 10 lines
Note that it is not yet a requirement to have 0 warnings for
dtbs_check. This will change in the future.Full log is available here: https://patchwork.ozlabs.org/project/devicetree-bindings/patch/[email protected]
audio-codec@1a: Unevaluated properties are not allowed ('AVDD-supply', 'CPVDD-supply', 'DBVDD-supply', 'DCVDD-supply', 'MICVDD-supply' were unexpected)
arch/arm64/boot/dts/freescale/imx8mm-verdin-nonwifi-dahlia.dtbarch/arm64/boot/dts/freescale/imx8mm-verdin-wifi-dahlia.dtb
Quoted 15 lines · Daniel Baluta
Quoted 14 lines · Rob Herring
Quoted 10 lines · Saalim Quadri
Convert the WM8904 audio CODEC bindings to DT schema
Signed-off-by Saalim Quadri <[email protected]>--- .../devicetree/bindings/sound/wlf,wm8904.yaml | 66 +++++++++++++++++++ .../devicetree/bindings/sound/wm8904.txt | 33 ---------- 2 files changed, 66 insertions(+), 33 deletions(-) create mode 100644 Documentation/devicetree/bindings/sound/wlf,wm8904.yaml delete mode 100644 Documentation/devicetree/bindings/sound/wm8904.txt
Quoted 7 lines
Quoted 4 lines
Running 'make
dtbs_check' with the schema in this patch gives the following warnings. Consider if they are expected or the schema is incorrect. These may not be new warnings.So, these properties are present in some dts files! We need to evaluated if they are always expected
or can be optional.
I assume the DTSes are tested when you submit new DT schema conversion...
Best regards,
Krzysztof