bpf: ensure all memory is initialized in bpf_get_current_comm
Subsystems (3)
BPF helpers that take an ARG_PTR_TO_UNINIT_MEM must ensure that all of the memory is set, including beyond the end of the string.
--- kernel/bpf/helpers.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
kernel/bpf/helpers.c +1 -1
@@ -257,7 +257,7 @@ BPF_CALL_2(bpf_get_current_comm, char *, buf, u32, size) goto err_clear;/* Verifier guarantees that size > 0 */ -strscpy (buf, task->comm, size); +strscpy_pad (buf, task->comm, size);return 0 ; err_clear:memset (buf,0 , size);
Signature · 1 line
2.40.0.348.gf938b09366-goog
Quoted 5 lines · Barret Rhoden
BPF helpers that take an
ARG_PTR_TO_UNINIT_MEMmust ensure that all of the memory is set, including beyond the end of the string.Signed-off-by Barret Rhoden <[email protected]>
The patch looks fine, but please rebase to bpf-next and resubmit with [PATCH bpf-next] subj, so it goes through BPF CI.
See Documentation/bpf/bpf_devel_QA.rst
PATCH 1/1 bpf: ensure all memory is initialized in bpf_get_current_comm
In reply to Barret RhodenBPF helpers that take an ARG_PTR_TO_UNINIT_MEM must ensure that all of the memory is set, including beyond the end of the string.
--- kernel/bpf/helpers.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
kernel/bpf/helpers.c +1 -1
@@ -258,7 +258,7 @@ BPF_CALL_2(bpf_get_current_comm, char *, buf, u32, size) goto err_clear;/* Verifier guarantees that size > 0 */ -strscpy (buf, task->comm, size); +strscpy_pad (buf, task->comm, size);return 0 ; err_clear:memset (buf,0 , size);
Signature · 1 line
2.40.0.577.gac1e443424-goog
This patch was applied to bpf/bpf-next.git (master) by Alexei Starovoitov <[email protected]>:
Hello:
This patch was applied to bpf/bpf-next.git (master) by Alexei Starovoitov <[email protected]>:
Quoted 7 lines · On Thu, 6 Apr 2023 20:18:08 -0400 you wrote:
BPF helpers that take an
ARG_PTR_TO_UNINIT_MEMmust ensure that all of the memory is set, including beyond the end of the string.Signed-off-by Barret Rhoden <[email protected]>--- kernel/bpf/helpers.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Here is the summary with links:
- [bpf-next] bpf: ensure all memory is initialized in bpf_get_current_comm
https://git.kernel.org/bpf/bpf-next/c/f3f213497797
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html