Skip to contentSkip to conversation

sched-numa-use-hash_32-to-mix-up-pids-accessing-vma.patch removed from -mm tree

merged mm-stable Andrew Morton 1 participant 1 message Apr 6, 2023

lore
Share & tools
lore

Andrew Morton

author tree notice Applied
#0 lore raw

The quilt patch titled
Subject: sched/numa: use hash_32 to mix up PIDs accessing VMA
has been removed from the -mm tree. Its filename was
sched-numa-use-hash_32-to-mix-up-pids-accessing-vma.patch

This patch was dropped because it was merged into the mm-stable branch of git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm

------------------------------------------------------
From: Raghavendra K T <[email protected]>
Subject: sched/numa: use hash_32 to mix up PIDs accessing VMA
Date: Wed, 1 Mar 2023 17:49:03 +0530

before: last 6 bits of PID is used as index to store information about tasks accessing VMA's.

after: hash_32 is used to take of cases where tasks are created over a period of time, and thus improve collision probability.

Result:
The patch series overall improves autonuma cost.

Kernbench around more than 5% improvement and system time in mmtest autonuma showed more than 80% improvement

---

 include/linux/mm.h  |    2 +-
 kernel/sched/fair.c |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
include/linux/mm.h renamed from include/linux/mm.h~sched-numa-use-hash_32-to-mix-up-pids-accessing-vma +1 -1
@@ -1691,7 +1691,7 @@ static inline void vma_set_access_pid_bi
 {
 	unsigned int pid_bit;
 
-	pid_bit = current->pid % BITS_PER_LONG;
+	pid_bit = hash_32(current->pid, ilog2(BITS_PER_LONG));
 	if (vma->numab_state && !test_bit(pid_bit, &vma->numab_state->access_pids[1])) {
 		__set_bit(pid_bit, &vma->numab_state->access_pids[1]);
 	}
kernel/sched/fair.c renamed from kernel/sched/fair.c~sched-numa-use-hash_32-to-mix-up-pids-accessing-vma +1 -1
@@ -2941,7 +2941,7 @@ static bool vma_is_accessed(struct vm_ar
 		return true;
 
 	pids = vma->numab_state->access_pids[0] | vma->numab_state->access_pids[1];
-	return test_bit(current->pid % BITS_PER_LONG, &pids);
+	return test_bit(hash_32(current->pid, ilog2(BITS_PER_LONG)), &pids);
 }
 
 #define VMA_PID_RESET_PERIOD (4 * sysctl_numa_balancing_scan_delay)

_

Patches currently in -mm which might be from [email protected] are