Skip to contentSkip to conversation

Improve IPsec limits, ESN and replay window

GIT PULL Applied Leon Romanovsky 2 participants 3 messages Apr 6, 2023 – Apr 8, 2023

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

This series overcomes existing hardware limitations in Mellanox ConnectX devices around handling IPsec soft and hard limits.

In addition, the ESN logic is tied and added an interface to configure replay window sequence numbers through existing iproute2 interface.

ip xfrm state ... [ replay-seq SEQ ] [ replay-oseq SEQ ]
[ replay-seq-hi SEQ ] [ replay-oseq-hi SEQ ]

----------------------------------------------------------------
Changelog:
v1:
* Added Steffen's Acked-by to XFRM patch
https://lore.kernel.org/all/[email protected]
* Fixed memory leak in "net/mlx5e: Generalize IPsec work structs" patch
https://lore.kernel.org/all/285a1550242363de181bab3a07a69296f66ad9a8.1680162300.git.leonro@nvidia.com

drivers/net/ethernet/mellanox/mlx5/core/en_accel/ipsec.c +2 -0
index 0916309cf296..9a4c4bc64155 100644
@@ -707,6 +707,7 @@ static int mlx5e_xfrm_add_state(struct xfrm_state *x,
 release_dwork:
        kfree(sa_entry->dwork);
 release_work:
+       kfree(sa_entry->work->data);
        kfree(sa_entry->work);
 err_xfrm:
        kfree(sa_entry);
@@ -750,6 +751,7 @@ static void mlx5e_xfrm_free_state(struct xfrm_state *x)
        mlx5e_accel_ipsec_fs_del_rule(sa_entry);
        mlx5_ipsec_free_sa_ctx(sa_entry);
        kfree(sa_entry->dwork);
+       kfree(sa_entry->work->data);
        kfree(sa_entry->work);
 sa_entry_free:
        kfree(sa_entry);

v0: https://lore.kernel.org/all/[email protected]
----------------------------------------------------------------

The following changes since commit 5a6cddb89b51d99a7702e63829644a5860dd9c41:

net/mlx5e: Update IPsec per SA packets/bytes count (2023-03-20 11:29:52 +0200)

are available in the Git repository at:

https://git.kernel.org/pub/scm/linux/kernel/git/mellanox/linux.git/ tags/ipsec-esn-replay

for you to fetch changes up to b2f7b01d36a9b94fbd7489bd1228025ea7e7a2f4:

net/mlx5e: Simulate missing IPsec TX limits hardware functionality (2023-04-06 10:12:03 +0300)

----------------------------------------------------------------
Leon Romanovsky (10):
net/mlx5e: Factor out IPsec ASO update function
net/mlx5e: Prevent zero IPsec soft/hard limits
net/mlx5e: Add SW implementation to support IPsec 64 bit soft and hard limits net/mlx5e: Overcome slow response for first IPsec ASO WQE
xfrm: don't require advance ESN callback for packet offload net/mlx5e: Remove ESN callbacks if it is not supported net/mlx5e: Set IPsec replay sequence numbers
net/mlx5e: Reduce contention in IPsec workqueue
net/mlx5e: Generalize IPsec work structs
net/mlx5e: Simulate missing IPsec TX limits hardware functionality

 .../ethernet/mellanox/mlx5/core/en_accel/ipsec.c   | 331 ++++++++++++++++++---
 .../ethernet/mellanox/mlx5/core/en_accel/ipsec.h   |  47 ++-
 .../mellanox/mlx5/core/en_accel/ipsec_fs.c         |  31 +-
 .../mellanox/mlx5/core/en_accel/ipsec_offload.c    | 198 +++++++++---
 net/xfrm/xfrm_device.c                             |   2 +-
 5 files changed, 498 insertions(+), 111 deletions(-)
#1 lore raw
Quoted 6 lines · Leon Romanovsky

This series overcomes existing hardware limitations in Mellanox ConnectX devices around handling IPsec soft and hard limits.

In addition, the ESN logic is tied and added an interface to configure replay window sequence numbers through existing iproute2 interface.

Quoted 6 lines

ip xfrm state ... [ replay-seq SEQ ] [ replay-oseq SEQ ]
[ replay-seq-hi SEQ ] [ replay-oseq-hi SEQ ]

----------------------------------------------------------------

Hi,

I see that this PR is marked as "Awaiting upstream". What does it mean in context of this PR?
https://patchwork.kernel.org/project/netdevbpf/patch/[email protected]/

Thanks

#2 lore raw
In reply to Leon Romanovsky
This pull request was applied to netdev/net-next.git (main) by Jakub Kicinski <[email protected]>:

Hello:

This pull request was applied to netdev/net-next.git (main) by Jakub Kicinski <[email protected]>:

Quoted 10 lines · On Thu, 6 Apr 2023 10:19:02 +0300 you wrote:

This series overcomes existing hardware limitations in Mellanox ConnectX devices around handling IPsec soft and hard limits.

In addition, the ESN logic is tied and added an interface to configure replay window sequence numbers through existing iproute2 interface.

ip xfrm state ... [ replay-seq SEQ ] [ replay-oseq SEQ ]
[ replay-seq-hi SEQ ] [ replay-oseq-hi SEQ ]

[...]

Here is the summary with links:
- [GIT,PULL,v1] Improve IPsec limits, ESN and replay window

    https://git.kernel.org/netdev/net-next/c/4bcdfc3ab217

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html