Skip to contentSkip to conversation

staging: greybus: drop loopback test files

PATCH In review Greg Kroah-Hartman 2 participants 2 messages Apr 6, 2023

Subsystems (2)
lore
Share & tools
lore

Greg Kroah-Hartman

author maintainer
#0 lore raw

PATCH 1/1 staging: greybus: drop loopback test files

The greybus loopback test tool does not belong burried down in a driver-specific directory. If it is needed, it should be somewhere else, like in the testing directory. But as the loopback driver is probably never going to be merged out of the staging directory, let's just delete the test alltogether for now. If it's needed in the future, it can be brought back with a revert.

Also, having an Android.mk file in the kernel source tree breaks some Android build systems when trying to build from a read-only source tree, the report of which prompted this being a good reason to remove it as well.

Cc Johan Hovold <[email protected]>
Cc Alex Elder <[email protected]>
Cc Jack Schofield <[email protected]>
Cc Vaibhav Nagare <[email protected]>
---
 drivers/staging/greybus/tools/.gitignore      |   2 -
 drivers/staging/greybus/tools/Android.mk      |  10 -
 drivers/staging/greybus/tools/Makefile        |  33 -
 drivers/staging/greybus/tools/README.loopback | 198 ----
 drivers/staging/greybus/tools/lbtest          | 169 ---
 drivers/staging/greybus/tools/loopback_test.c | 979 ------------------
 6 files changed, 1391 deletions(-)
 delete mode 100644 drivers/staging/greybus/tools/.gitignore
 delete mode 100644 drivers/staging/greybus/tools/Android.mk
 delete mode 100644 drivers/staging/greybus/tools/Makefile
 delete mode 100644 drivers/staging/greybus/tools/README.loopback
 delete mode 100755 drivers/staging/greybus/tools/lbtest
 delete mode 100644 drivers/staging/greybus/tools/loopback_test.c
drivers/staging/greybus/tools/.gitignore deleted +0 -2
deleted file mode 100644
index 1fd364aba774..000000000000
@@ -1,2 +0,0 @@
-# SPDX-License-Identifier: GPL-2.0-only
-loopback_test
drivers/staging/greybus/tools/Android.mk deleted +0 -10
deleted file mode 100644
index fdadbf611757..000000000000
@@ -1,10 +0,0 @@
-LOCAL_PATH:= $(call my-dir)
-
-include $(CLEAR_VARS)
-
-LOCAL_SRC_FILES:= loopback_test.c
-LOCAL_MODULE_TAGS := optional
-LOCAL_MODULE := gb_loopback_test
-
-include $(BUILD_EXECUTABLE)
-
drivers/staging/greybus/tools/Makefile deleted +0 -33
deleted file mode 100644
index a3bbd73171f2..000000000000
@@ -1,33 +0,0 @@
-# SPDX-License-Identifier: GPL-2.0
-ifeq ($(strip $(V)), 1)
-  Q =
-else
-  Q = @
-endif
-
-CFLAGS	+= -std=gnu99 -Wall -Wextra -g \
-	    -D_GNU_SOURCE \
-	    -Wno-unused-parameter \
-	    -Wmaybe-uninitialized \
-	    -Wredundant-decls \
-	    -Wcast-align \
-	    -Wsign-compare \
-	    -Wno-missing-field-initializers \
-	    -Wno-shift-negative-value
-
-CC	:= $(CROSS_COMPILE)gcc
-
-TOOLS = loopback_test
-
-all: $(TOOLS)
-
-%.o: %.c ../greybus_protocols.h
-	@echo '  TARGET_CC $@'
-	$(Q)$(CC) $(CFLAGS) -c $< -o $@
-
-loopback_%: loopback_%.o
-	@echo '  TARGET_LD $@'
-	$(Q)$(CC) $(CFLAGS) $(LDFLAGS) $^ -o $@
-
-clean::
-	rm -f *.o $(TOOLS)
drivers/staging/greybus/tools/README.loopback deleted +0 -198

198 lines not on this page · raw message

drivers/staging/greybus/tools/lbtest deleted +0 -169

169 lines not on this page · raw message

drivers/staging/greybus/tools/loopback_test.c deleted +0 -979

979 lines not on this page · raw message

Signature · 1 line
2.40.0
Acked-by on v1 1/1
#1 lore raw
Quoted 12 lines · Greg Kroah-Hartman

The greybus loopback test tool does not belong burried down in a driver-specific directory. If it is needed, it should be somewhere else, like in the testing directory. But as the loopback driver is probably never going to be merged out of the staging directory, let's just delete the test alltogether for now. If it's needed in the future, it can be brought back with a revert.

Also, having an Android.mk file in the kernel source tree breaks some Android build systems when trying to build from a read-only source tree, the report of which prompted this being a good reason to remove it as well.

Quoted 6 lines
Cc Johan Hovold <[email protected]>
Cc Alex Elder <[email protected]>
Cc Jack Schofield <[email protected]>
Cc Vaibhav Nagare <[email protected]>

That's a surprising amount of code. And perhaps there are better ways of exposing this type of information. Anyway, no objection here.

Quoted 15 lines
---
  drivers/staging/greybus/tools/.gitignore      |   2 -
  drivers/staging/greybus/tools/Android.mk      |  10 -
  drivers/staging/greybus/tools/Makefile        |  33 -
  drivers/staging/greybus/tools/README.loopback | 198 ----
  drivers/staging/greybus/tools/lbtest          | 169 ---
  drivers/staging/greybus/tools/loopback_test.c | 979 ------------------
  6 files changed, 1391 deletions(-)

delete mode 100644 drivers/staging/greybus/tools/.gitignore delete mode 100644 drivers/staging/greybus/tools/Android.mk delete mode 100644 drivers/staging/greybus/tools/Makefile delete mode 100644 drivers/staging/greybus/tools/README.loopback delete mode 100755 drivers/staging/greybus/tools/lbtest delete mode 100644 drivers/staging/greybus/tools/loopback_test.c