Skip to contentSkip to conversation

soc: apple: apple-pmgr-pwrstate: set varaiable apple_pmgr_reset_ops storage-class-specifier to static

PATCH New Tom Rix 1 participant 1 message Apr 6, 2023 Arm/Apple machine support

lore
Share & tools
lore

Tom Rix

author
#0 lore raw

PATCH 1/1 soc: apple: apple-pmgr-pwrstate: set varaiable apple_pmgr_reset_ops storage-class-specifier to static

smatch reports drivers/soc/apple/apple-pmgr-pwrstate.c:180:32: warning: symbol
'apple_pmgr_reset_ops' was not declared. Should it be static?

This variable is only used in one file so should be static.

---
 drivers/soc/apple/apple-pmgr-pwrstate.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/soc/apple/apple-pmgr-pwrstate.c +1 -1
index a3e2bc1d2686..e456f6e04658 100644
@@ -177,7 +177,7 @@ static int apple_pmgr_reset_status(struct reset_controller_dev *rcdev, unsigned
 	return !!(reg & APPLE_PMGR_RESET);
 }
 
-const struct reset_control_ops apple_pmgr_reset_ops = {
+static const struct reset_control_ops apple_pmgr_reset_ops = {
 	.assert		= apple_pmgr_reset_assert,
 	.deassert	= apple_pmgr_reset_deassert,
 	.reset		= apple_pmgr_reset_reset,
Signature · 1 line
2.27.0