Skip to contentSkip to conversation

ASoC: mediatek: mt8186: set variable aud_pinctrl to static

PATCH In review Tom Rix 2 participants 2 messages Apr 7, 2023

Subsystems (3)
lore
Share & tools
lore

Tom Rix

author
#0 lore raw

PATCH 1/1 ASoC: mediatek: mt8186: set variable aud_pinctrl to static

smatch reports sound/soc/mediatek/mt8186/mt8186-afe-gpio.c:14:16: warning: symbol
'aud_pinctrl' was not declared. Should it be static?

This variable is only used in one file so should be static.

---
 sound/soc/mediatek/mt8186/mt8186-afe-gpio.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
sound/soc/mediatek/mt8186/mt8186-afe-gpio.c +1 -1
index 20b9f5d810ec..f12e91cc4fcf 100644
@@ -11,7 +11,7 @@
 #include "mt8186-afe-common.h"
 #include "mt8186-afe-gpio.h"
 
-struct pinctrl *aud_pinctrl;
+static struct pinctrl *aud_pinctrl;
 
 enum mt8186_afe_gpio {
 	MT8186_AFE_GPIO_CLK_MOSI_OFF,
Signature · 1 line
2.27.0
maintainer
#1 lore raw
Quoted 8 lines · Tom Rix

smatch reports sound/soc/mediatek/mt8186/mt8186-afe-gpio.c:14:16: warning: symbol
'aud_pinctrl' was not declared. Should it be static?

This variable is only used in one file so should be static.

[...]

Applied to

broonie/sound.git for-next

Thanks!

[1/1] ASoC: mediatek: mt8186: set variable aud_pinctrl to static

      commit: 672029caa5708934817a331f3323bbe48d456c5c

All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

Thanks,
Mark