selftests/bpf: Use PERF_COUNT_HW_CPU_CYCLES event for get_branch_snapshot
Subsystems (3)
Song Liu
reviewerPATCH 1/1 selftests/bpf: Use PERF_COUNT_HW_CPU_CYCLES event for get_branch_snapshot
perf_event with type=PERF_TYPE_RAW and config=0x1b00 turned out to be not reliable in ensuring LBR is active. Thus, test_progs:get_branch_snapshot is not reliable in some systems. Replace it with PERF_COUNT_HW_CPU_CYCLES event, which gives more consistent results.
--- tools/testing/selftests/bpf/prog_tests/get_branch_snapshot.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
tools/testing/selftests/bpf/prog_tests/get_branch_snapshot.c +2 -2
@@ -37,8 +37,8 @@ static int create_perf_events(void)/* create perf event */ attr.size =sizeof (attr); - attr.type =PERF_TYPE_RAW ; - attr.config =0x1b00 ; + attr.type =PERF_TYPE_HARDWARE ; + attr.config =PERF_COUNT_HW_CPU_CYCLES ; attr.sample_type =PERF_SAMPLE_BRANCH_STACK ; attr.branch_sample_type =PERF_SAMPLE_BRANCH_KERNEL |PERF_SAMPLE_BRANCH_USER |PERF_SAMPLE_BRANCH_ANY ;
Signature · 1 line
2.34.1
Quoted 6 lines · Song Liu
perf_eventwith type=PERF_TYPE_RAW and config=0x1b00 turned out to be not reliable in ensuring LBR is active. Thus, test_progs:get_branch_snapshot is not reliable in some systems. Replace it withPERF_COUNT_HW_CPU_CYCLESevent, which gives more consistent results.Signed-off-by Song Liu <[email protected]>
jirka
Quoted 22 lines
--- tools/testing/selftests/bpf/prog_tests/get_branch_snapshot.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)tools/testing/selftests/bpf/prog_tests/get_branch_snapshot.c +2
-2@@ -37,8 +37,8 @@ static int create_perf_events(void)/* create perf event */ attr.size =sizeof (attr); - attr.type =PERF_TYPE_RAW ; - attr.config =0x1b00 ; + attr.type =PERF_TYPE_HARDWARE ; + attr.config =PERF_COUNT_HW_CPU_CYCLES ; attr.sample_type =PERF_SAMPLE_BRANCH_STACK ; attr.branch_sample_type =PERF_SAMPLE_BRANCH_KERNEL |PERF_SAMPLE_BRANCH_USER |PERF_SAMPLE_BRANCH_ANY ;Signature · 1 line
2.34.1
This patch was applied to bpf/bpf-next.git (master) by Andrii Nakryiko <[email protected]>:
Hello:
This patch was applied to bpf/bpf-next.git (master) by Andrii Nakryiko <[email protected]>:
Quoted 8 lines · On Fri, 7 Apr 2023 12:01:30 -0700 you wrote:
perf_eventwith type=PERF_TYPE_RAW and config=0x1b00 turned out to be not reliable in ensuring LBR is active. Thus, test_progs:get_branch_snapshot is not reliable in some systems. Replace it withPERF_COUNT_HW_CPU_CYCLESevent, which gives more consistent results.Signed-off-by Song Liu <[email protected]>[...]
Here is the summary with links:
- [bpf-next] selftests/bpf: Use PERF_COUNT_HW_CPU_CYCLES event for get_branch_snapshot
https://git.kernel.org/bpf/bpf-next/c/3ebf5212bf04
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html