mm: backing-dev: set variables dev_attr_min,max_bytes storage-class-specifier to static
Subsystems (2)
PATCH 1/1 mm: backing-dev: set variables dev_attr_min,max_bytes storage-class-specifier to static
smatch reportsmm/backing-dev.c:266:1: warning: symbol
'dev_attr_min_bytes' was not declared. Should it be static?mm/backing-dev.c:294:1: warning: symbol
'dev_attr_max_bytes' was not declared. Should it be static?
These variables are only used in one file so should be static.
Signed-off-by Tom Rix <[email protected]>
--- mm/backing-dev.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
mm/backing-dev.c +2 -2
@@ -263,7 +263,7 @@ static ssize_t min_bytes_store(struct device *dev,return ret; } -DEVICE_ATTR_RW (min_bytes); +static DEVICE_ATTR_RW (min_bytes); static ssize_t max_bytes_show(struct device *dev, struct device_attribute *attr,
@@ -291,7 +291,7 @@ static ssize_t max_bytes_store(struct device *dev,return ret; } -DEVICE_ATTR_RW (max_bytes); +static DEVICE_ATTR_RW (max_bytes); static ssize_t stable_pages_required_show(struct device *dev, struct device_attribute *attr,
Signature · 1 line
2.27.0
Looks good:
Reviewed-by Christoph Hellwig <[email protected]>