drm/qxl: remove variable count
Subsystems (4)
PATCH 1/1 drm/qxl: remove variable count
clang with W=1 reports drivers/gpu/drm/qxl/qxl_cmd.c:424:6: error: variable
'count' set but not used [-Werror,-Wunused-but-set-variable]
int count = 0;
^This variable is not used so remove it.
Signed-off-by Tom Rix <[email protected]>
--- drivers/gpu/drm/qxl/qxl_cmd.c | 2 -- 1 file changed, 2 deletions(-)
drivers/gpu/drm/qxl/qxl_cmd.c +0 -2
@@ -421,7 +421,6 @@ int qxl_surface_id_alloc(struct qxl_device *qdev, {uint32_t handle;int idr_ret; -int count =0 ; again:idr_preload (GFP_ATOMIC );spin_lock (&qdev->surf_id_idr_lock);
@@ -433,7 +432,6 @@ int qxl_surface_id_alloc(struct qxl_device *qdev, handle = idr_ret;if (handle >= qdev->rom->n_surfaces) { - count++;spin_lock (&qdev->surf_id_idr_lock);idr_remove (&qdev->surf_id_idr, handle);spin_unlock (&qdev->surf_id_idr_lock);
Signature · 1 line
2.27.0
Quoted 7 lines · Tom Rix
clang with W=1 reports
drivers/gpu/drm/qxl/qxl_cmd.c:424:6: error: variable
'count' set but not used [-Werror,-Wunused-but-set-variable]int count = 0; ^This variable is not used so remove it.
Thanks for the patch!
Fixes 64122c1f6ad ("drm: add new QXL driver. (v1.4)")
Reviewed-by Nick Desaulniers <[email protected]>
Quoted 29 lines
Signed-off-by Tom Rix <[email protected]>--- drivers/gpu/drm/qxl/qxl_cmd.c | 2 -- 1 file changed, 2 deletions(-)drivers/gpu/drm/qxl/qxl_cmd.c +0
-3@@ -421,7 +421,6 @@ int qxl_surface_id_alloc(struct qxl_device *qdev, {uint32_t handle;int idr_ret; -int count =0 ; again:idr_preload (GFP_ATOMIC );spin_lock (&qdev->surf_id_idr_lock);@@ -433,7 +432,6 @@ int qxl_surface_id_alloc(struct qxl_device *qdev, handle = idr_ret;if (handle >= qdev->rom->n_surfaces) { - count++;spin_lock (&qdev->surf_id_idr_lock);idr_remove (&qdev->surf_id_idr, handle);spin_unlock (&qdev->surf_id_idr_lock); --2.27.0
Signature · 2 lines
Thanks, ~Nick Desaulniers