Skip to contentSkip to conversation

tools: memory-model: Rename litmus test to avoid confusion with similar-named test

PATCH In review Joel Fernandes (Google) 2 participants 2 messages Apr 9, 2023 – Apr 10, 2023

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 tools: memory-model: Rename litmus test to avoid confusion with similar-named test

In order to differentiate the test Z6.0+pooncelock+poonceLock+pombonce.litmus from another test that only differs by a capital L, the following file has been renamed:

renamed: litmus-tests/Z6.0+pooncelock+poonceLock+pombonce.litmus -> litmus-tests/Z6.0+pooncelock+pooncelockmb+pombonce.litmus

This change should help avoid confusion between the two tests.

---
 ...mbonce.litmus => Z6.0+pooncelock+pooncelockmb+pombonce.litmus} | 0
 1 file changed, 0 insertions(+), 0 deletions(-)
 rename tools/memory-model/litmus-tests/{Z6.0+pooncelock+poonceLock+pombonce.litmus => Z6.0+pooncelock+pooncelockmb+pombonce.litmus} (100%)
tools/memory-model/litmus-tests/Z6.0+pooncelock+pooncelockmb+pombonce.litmus renamed from tools/memory-model/litmus-tests/Z6.0+pooncelock+poonceLock+pombonce.litmus +0 -0
similarity index 100%
rename from tools/memory-model/litmus-tests/Z6.0+pooncelock+poonceLock+pombonce.litmus
rename to tools/memory-model/litmus-tests/Z6.0+pooncelock+pooncelockmb+pombonce.litmus
Signature · 1 line
2.40.0.577.gac1e443424-goog
#1 lore raw

Hi Joel,

tools/memory-model/litmus-tests/Z6.0+pooncelock+pooncelockmb+pombonce.litmus

Quoted 19 lines · Joel Fernandes (Google)

In order to differentiate the test Z6.0+pooncelock+poonceLock+pombonce.litmus from another test that only differs by a capital L, the following file has been renamed:

renamed: litmus-tests/Z6.0+pooncelock+poonceLock+pombonce.litmus -> litmus-tests/Z6.0+pooncelock+pooncelockmb+pombonce.litmus

This change should help avoid confusion between the two tests.

---
 ...mbonce.litmus => Z6.0+pooncelock+pooncelockmb+pombonce.litmus} | 0
 1 file changed, 0 insertions(+), 0 deletions(-)
 rename tools/memory-model/litmus-tests/{Z6.0+pooncelock+poonceLock+pombonce.litmus => Z6.0+pooncelock+pooncelockmb+pombonce.litmus} (100%)
tools/memory-model/litmus-tests/Z6.0+pooncelock+pooncelockmb+pombonce.litmus renamed from tools/memory-model/litmus-tests/Z6.0+pooncelock+poonceLock+pombonce.litmus +0 -0
similarity index 100%
rename from tools/memory-model/litmus-tests/Z6.0+pooncelock+poonceLock+pombonce.litmus
rename to tools/memory-model/litmus-tests/Z6.0+pooncelock+pooncelockmb+pombonce.litmus

I must say simply changing the file name is only part of the job. You need to update comments/docs as well.

There are 4 hits after this patch is applied:

$ find . -type f -exec grep -nH --null -F -e Z6.0+pooncelock+poonceLock \{\} +
./tools/memory-model/Documentation/locking.txt187:	/* See Z6.0+pooncelock+poonceLock+pombonce.litmus. */
./tools/memory-model/Documentation/recipes.txt162:	/* See Z6.0+pooncelock+poonceLock+pombonce.litmus. */
./tools/memory-model/litmus-tests/Z6.0+pooncelock+pooncelockmb+pombonce.litmus1:C Z6.0+pooncelock+poonceLock+pombonce
./tools/memory-model/litmus-tests/README152:Z6.0+pooncelock+poonceLock+pombonce.litmus

Thanks, Akira