Skip to contentSkip to conversation

Dpaa2 driver using system("echo...")

DISCUSSION Stephen Hemminger 2 participants 2 messages Apr 10, 2023 – Apr 28, 2023

lore
Share & tools
lore
#1 lore raw
Quoted 9 lines · Stephen Hemminger

When the CodeQl (https://codeql.github.com/) is run against DPDK, one of the issues it reports is the unsafe usage of system() in code.

I reported and fixed one of these issues in the dpaa2 driver
https://patchwork.dpdk.org/project/dpdk/patch/[email protected]/
but it seems to have been ignored.

Could one of the maintainers of that driver review it?

Hello Stephen,
Apology for the delay and thanks for the changes suggested for dpaa2 driver improvement.

I have reviewed your changes and logically they look fine. When testing, found issue of memory corruption that I have fixed over your changes. I will send a 'v2' patch in context of your previous patch including this fix for dpaa2 platform.

Signature · 3 lines
Thanks,
Sachin Saxena
(NXP)