wifi: iwlwifi: mvm: fix the order of TIMING_MEASUREMENT notifications
PATCH 1/2 wifi: iwlwifi: mvm: fix the order of TIMING_MEASUREMENT notifications
From: Gregory Greenman <[email protected]>
Host commands and notifications are expected to be ordered in iwl_mvm_groups array. Fix the order of two new TIMING_MEASUREMENT notifications.
Fixes c7eca79def44 ("wifi: iwlwifi: mvm: report hardware timestamps in RX/TX status")
Reported-by Nathan Chancellor <[email protected]>
Signed-off-by Gregory Greenman <[email protected]>
--- drivers/net/wireless/intel/iwlwifi/mvm/ops.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/wireless/intel/iwlwifi/mvm/ops.c +1 -1
@@ -472,8 +472,8 @@ static const struct iwl_hcmd_names iwl_mvm_legacy_names[] = {HCMD_NAME (SCAN_OFFLOAD_PROFILES_QUERY_CMD ),HCMD_NAME (BT_COEX_UPDATE_REDUCED_TXP ),HCMD_NAME (BT_COEX_CI ), -HCMD_NAME (WNM_80211V_TIMING_MEASUREMENT_CONFIRM_NOTIFICATION ),HCMD_NAME (WNM_80211V_TIMING_MEASUREMENT_NOTIFICATION ), +HCMD_NAME (WNM_80211V_TIMING_MEASUREMENT_CONFIRM_NOTIFICATION ),HCMD_NAME (PHY_CONFIGURATION_CMD ),HCMD_NAME (CALIB_RES_NOTIF_PHY_DB ), HCMD_NAME(PHY_DB_CMD),
Signature · 1 line
2.38.1
PATCH 2/2 wifi: iwlwifi: fix duplicate entry in iwl_dev_info_table
From: Gregory Greenman <[email protected]>
There're two identical entries for ax1650 device in iwl_dev_info_table. Remove one of the duplicate entries.
Fixes 953e66a7238b ("iwlwifi: add new ax1650 killer device")
Signed-off-by Gregory Greenman <[email protected]>
--- drivers/net/wireless/intel/iwlwifi/pcie/drv.c | 1 - 1 file changed, 1 deletion(-)
drivers/net/wireless/intel/iwlwifi/pcie/drv.c +0 -1
@@ -565,7 +565,6 @@ static const struct iwl_dev_info iwl_dev_info_table[] = {IWL_DEV_INFO (0x43F0 ,0x1652 , killer1650i_2ax_cfg_qu_b0_hr_b0, iwl_ax201_killer_1650i_name),IWL_DEV_INFO (0x43F0 ,0x2074 , iwl_ax201_cfg_qu_hr,NULL ),IWL_DEV_INFO (0x43F0 ,0x4070 , iwl_ax201_cfg_qu_hr,NULL ), -IWL_DEV_INFO (0x43F0 ,0x1651 , killer1650s_2ax_cfg_qu_b0_hr_b0, iwl_ax201_killer_1650s_name),IWL_DEV_INFO (0xA0F0 ,0x0070 , iwl_ax201_cfg_qu_hr,NULL ),IWL_DEV_INFO (0xA0F0 ,0x0074 , iwl_ax201_cfg_qu_hr,NULL ), IWL_DEV_INFO(0xA0F0, 0x0078, iwl_ax201_cfg_qu_hr, NULL),
Signature · 1 line
2.38.1
Quoted 10 lines · On Mon, Apr 10, 2023 at 05:07:20PM +0300, [email protected] wrote:
From: Gregory Greenman <[email protected]>
Host commands and notifications are expected to be ordered in
iwl_mvm_groupsarray. Fix the order of two newTIMING_MEASUREMENTnotifications.Fixes c7eca79def44 ("wifi: iwlwifi: mvm: report hardware timestamps in RX/TX status")Reported-by Nathan Chancellor <[email protected]>Signed-off-by Gregory Greenman <[email protected]>
Thanks for the quick fix! It appears to work for me.
Tested-by Nathan Chancellor <[email protected]>
Quoted 21 lines
--- drivers/net/wireless/intel/iwlwifi/mvm/ops.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/net/wireless/intel/iwlwifi/mvm/ops.c +1
-1@@ -472,8 +472,8 @@ static const struct iwl_hcmd_names iwl_mvm_legacy_names[] = {HCMD_NAME (SCAN_OFFLOAD_PROFILES_QUERY_CMD ),HCMD_NAME (BT_COEX_UPDATE_REDUCED_TXP ),HCMD_NAME (BT_COEX_CI ), -HCMD_NAME (WNM_80211V_TIMING_MEASUREMENT_CONFIRM_NOTIFICATION ),HCMD_NAME (WNM_80211V_TIMING_MEASUREMENT_NOTIFICATION ), +HCMD_NAME (WNM_80211V_TIMING_MEASUREMENT_CONFIRM_NOTIFICATION ),HCMD_NAME (PHY_CONFIGURATION_CMD ),HCMD_NAME (CALIB_RES_NOTIF_PHY_DB ), HCMD_NAME(PHY_DB_CMD),Signature · 1 line
2.38.1