Skip to contentSkip to conversation

Add Dell G15 5525 Ryzen Edition to quirks list for acp6x so that internal DMIC works.

PATCH Superseded Cem Kaya 3 participants 3 messages Apr 10, 2023

Subsystems (3)

v1 of 3 Superseded Latest is v3 →

lore
Share & tools
lore

Cem Kaya

author
#0 lore raw

PATCH 1/1 Add Dell G15 5525 Ryzen Edition to quirks list for acp6x so that internal DMIC works.

sound/soc/amd/yc/acp6x-mach.c +7 -0
index a428e17f0325..e044d811496e 100644
@@ -45,6 +45,13 @@ static struct snd_soc_card acp6x_card = {
 };
 
 static const struct dmi_system_id yc_acp_quirk_table[] = {
+	{
+		.driver_data = &acp6x_card,
+		.matches = {
+			DMI_MATCH(DMI_BOARD_VENDOR, "Dell Inc."),
+			DMI_MATCH(DMI_PRODUCT_NAME, "Dell G15 5525"),
+		}
+	},
 	{
 		.driver_data = &acp6x_card,
 		.matches = {
Signature · 1 line
2.40.0
#1 lore raw

[Public]

Quoted 19 lines
sound/soc/amd/yc/acp6x- renamed from sound/soc/amd/yc/acp6x-mach.c +0 -0

mach.c
index a428e17f0325..e044d811496e 100644

sound/soc/amd/yc/acp6x-mach.c +7 -0
@@ -45,6 +45,13 @@ static struct snd_soc_card acp6x_card = {
 };
 
 static const struct dmi_system_id yc_acp_quirk_table[] = {
+	{
+		.driver_data = &acp6x_card,
+		.matches = {
+			DMI_MATCH(DMI_BOARD_VENDOR, "Dell Inc."),
+			DMI_MATCH(DMI_PRODUCT_NAME, "Dell G15
 5525"),
+		}
+	},
 	{
 		.driver_data = &acp6x_card,
Quoted 3 lines

.matches = {
--
2.40.0

Hi,

Thanks for sending this up, but you'll need to add a few things:

1) You need to add a commit message explaining the why
2) You're missing a SoB tag (IE Signed-off-by: Foo Bar <[email protected]>)
3) As this came from a kernel Bugzilla originally, suggest you to add Link tag:

4) When you resubmit, please change PATCH to "PATCH v2"

#2 lore raw
In reply to Cem Kaya

[Public]

Quoted 19 lines
sound/soc/amd/yc/acp6x- renamed from sound/soc/amd/yc/acp6x-mach.c +0 -0

mach.c
index a428e17f0325..e044d811496e 100644

sound/soc/amd/yc/acp6x-mach.c +7 -0
@@ -45,6 +45,13 @@ static struct snd_soc_card acp6x_card = {
 };
 
 static const struct dmi_system_id yc_acp_quirk_table[] = {
+	{
+		.driver_data = &acp6x_card,
+		.matches = {
+			DMI_MATCH(DMI_BOARD_VENDOR, "Dell Inc."),
+			DMI_MATCH(DMI_PRODUCT_NAME, "Dell G15
 5525"),
+		}
+	},
 	{
 		.driver_data = &acp6x_card,
Quoted 3 lines

.matches = {
--
2.40.0

Hi,

Thanks for sending this up, but you'll need to add a few things:

1) You need to add a commit message explaining the why
2) You're missing a SoB tag (IE Signed-off-by: Foo Bar <[email protected]>)
3) As this came from a kernel Bugzilla originally, suggest you to add Link tag:

4) When you resubmit, please change PATCH to "PATCH v2"