Skip to contentSkip to conversation

bus: vexpress-config: Add explicit of_platform.h include

PATCH Applied Rob Herring 3 participants 4 messages Apr 10, 2023 – Apr 17, 2023 Arm/versatile express platform

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 bus: vexpress-config: Add explicit of_platform.h include

vexpress-config uses of_platform_* functions which are declared in of_platform.h. of_platform.h gets implicitly included by of_device.h, but that is going to be removed soon. Nothing else depends on of_device.h so it can be dropped.

---
 drivers/bus/vexpress-config.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/bus/vexpress-config.c +1 -1
index a58ac0c8e282..472a570bd53a 100644
@@ -10,7 +10,7 @@
 #include <linux/module.h>
 #include <linux/of.h>
 #include <linux/platform_device.h>
-#include <linux/of_device.h>
+#include <linux/of_platform.h>
 #include <linux/sched/signal.h>
 #include <linux/slab.h>
 #include <linux/vexpress.h>
Signature · 1 line
2.39.2
maintainer Acked-by on v1 1/1
#1 lore raw
Quoted 6 lines · Rob Herring

vexpress-config uses of_platform_* functions which are declared in of_platform.h. of_platform.h gets implicitly included by of_device.h, but that is going to be removed soon. Nothing else depends on of_device.h so it can be dropped.

I'm expecting Sudeep will pick this one up through his tree, if not please let me know.

Best regards,
Liviu

Quoted 20 lines
---
 drivers/bus/vexpress-config.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/bus/vexpress-config.c +1 -1
index a58ac0c8e282..472a570bd53a 100644
@@ -10,7 +10,7 @@
 #include <linux/module.h>
 #include <linux/of.h>
 #include <linux/platform_device.h>
-#include <linux/of_device.h>
+#include <linux/of_platform.h>
 #include <linux/sched/signal.h>
 #include <linux/slab.h>
 #include <linux/vexpress.h>
Signature · 1 line
2.39.2
Signature · 8 lines
====================
| I would like to |
| fix the world,  |
| but they're not |
| giving me the   |
 \ source code!  /
  ---------------
    ¯\_(ツ)_/¯
#2 lore raw
Quoted 6 lines · Liviu Dudau
Quoted 5 lines · Rob Herring

vexpress-config uses of_platform_* functions which are declared in of_platform.h. of_platform.h gets implicitly included by of_device.h, but that is going to be removed soon. Nothing else depends on of_device.h so it can be dropped.

Quoted 6 lines
Quoted 1 line

I'm expecting Sudeep will pick this one up through his tree, if not please let me know.

I have several other drivers/bus/ patches, so I can take this too. Maybe drivers/bus/ needs a maintainer...

Rob

Applied
#3 lore raw
In reply to Rob Herring
Quoted 5 lines · Rob Herring

vexpress-config uses of_platform_* functions which are declared in of_platform.h. of_platform.h gets implicitly included by of_device.h, but that is going to be removed soon. Nothing else depends on of_device.h so it can be dropped.

Applied to sudeep.holla/linux (for-next/vexpress), thanks!

[1/1] bus: vexpress-config: Add explicit of_platform.h include

      https://git.kernel.org/sudeep.holla/c/04ebdc354895

--
Regards,
Sudeep