RISC-V Hardware Probing User Interface
Subsystems (3)
v6 cover RISC-V Hardware Probing User Interface
There's been a bunch of off-list discussions about this, including at Plumbers. The original plan was to do something involving providing an ISA string to userspace, but ISA strings just aren't sufficient for a stable ABI any more: in order to parse an ISA string users need the version of the specifications that the string is written to, the version of each extension (sometimes at a finer granularity than the RISC-V releases/versions encode), and the expected use case for the ISA string (ie, is it a U-mode or M-mode string). That's a lot of complexity to try and keep ABI compatible and it's probably going to continue to grow, as even if there's no more complexity in the specifications we'll have to deal with the various ISA string parsing oddities that end up all over userspace.
Instead this patch set takes a very different approach and provides a set of key/value pairs that encode various bits about the system. The big advantage here is that we can clearly define what these mean so we can ensure ABI stability, but it also allows us to encode information that's unlikely to ever appear in an ISA string (see the misaligned access performance, for example). The resulting interface looks a lot like what arm64 and x86 do, and will hopefully fit well into something like ACPI in the future.
The actual user interface is a syscall, with a vDSO function in front of it. The vDSO function can answer some queries without a syscall at all, and falls back to the syscall for cases it doesn't have answers to. Currently we prepopulate it with an array of answers for all keys and a CPU set of "all CPUs". This can be adjusted as necessary to provide fast answers to the most common queries.
An example series in glibc exposing this syscall and using it in an ifunc selector for memcpy can be found at [1].
I was asked about the performance delta between this and something like sysfs. I created a small test program [2] and ran it on a Nezha D1 Allwinner board. Doing each operation 100000 times and dividing, these operations take the following amount of time:
- open()+read()+close() of /sys/kernel/cpu_byteorder: 3.8us
- access("/sys/kernel/cpu_byteorder", R_OK): 1.3us
- riscv_hwprobe() vDSO and syscall: .0094us
- riscv_hwprobe() vDSO with no syscall: 0.0091us
These numbers get farther apart if we query multiple keys, as sysfs will scale linearly with the number of keys, where the dedicated syscall stays the same. To frame these numbers, I also did a tight fork/exec/wait loop, which I measured as 4.8ms. So doing 4 open/read/close operations is a delta of about 0.3%, versus a single vDSO call is a delta of essentially zero.
[1] https://patchwork.ozlabs.org/project/glibc/list/?series=343050
[2] https://pastebin.com/x84NEKaS
Changes in v6:
- Remove spurious blank line (Conorbot)
- Update copyrights (Paul)
- Update copyrights (Paul)
- Wrap init_hwprobe_vdso_data() in CONFIG_MMU to fix nommu build break (Conorbot)
- Update copyrights (Paul)
Changes in v5:
- Added tags
- Fixed misuse of ISA_EXT_c as bitmap, changed to use riscv_isa_extension_available() (Heiko, Conor)
- Document the alternatives approach in the commit message (Conor and Heiko).
- Fix __init call warnings by making probe_vendor_features() and thead_feature_probe_func() __init_or_module.
- Fixed compat vdso compilation failure (lkp).
Changes in v4:
- Used real types in syscall prototypes (Arnd)
- Fixed static line break in do_riscv_hwprobe() (Conor)
- Added newlines between documentation lists (Conor)
- Crispen up size types to size_t, and cpu indices to int (Joe)
- Fix copy_from_user() return logic bug (found via kselftests!)
- Add __user to SYSCALL_DEFINE() to fix warning
- More newlines in BASE_BEHAVIOR_IMA documentation (Conor)
- Add newlines to CPUPERF_0 documentation (Conor)
- Add UNSUPPORTED value (Conor)
- Switched from DT to alternatives-based probing (Rob)
- Crispen up cpu index type to always be int (Conor)
- Fixed selftests commit description, no more tiny libc (Mark Brown)
- Fixed selftest syscall prototype types to match v4.
- Added a prototype to fix -Wmissing-prototype warning ([email protected])
- Fixed rv32 build failure ([email protected])
- Make vdso prototype match syscall types update
Changes in v3:
- Updated copyright date in cpufeature.h
- Fixed typo in cpufeature.h comment (Conor)
- Refactored functions so that kernel mode can query too, in preparation for the vDSO data population.
- Changed the vendor/arch/imp IDs to return a value of -1 on mismatch rather than failing the whole call.
- Const cpumask pointer in hwprobe_mid()
- Embellished documentation WRT cpu_set and the returned values.
- Renamed hwprobe_mid() to hwprobe_arch_id() (Conor)
- Fixed machine ID doc warnings, changed elements to c:macro:.
- Completed dangling unistd.h comment (Conor)
- Fixed line breaks and minor logic optimization (Conor).
- Use riscv_cached_mxxxid() (Conor)
- Refactored base ISA behavior probe to allow kernel probing as well, in prep for vDSO data initialization.
- Fixed doc warnings in IMA text list, use :c:macro:.
- Have hwprobe_misaligned return int instead of long.
- Constify cpumask pointer in hwprobe_misaligned()
- Fix warnings in _PERF_O list documentation, use :c:macro:.
- Move include cpufeature.h to misaligned patch.
- Fix documentation mismatch for RISCV_HWPROBE_KEY_CPUPERF_0 (Conor)
- Use for_each_possible_cpu() instead of NR_CPUS (Conor)
- Break early in misaligned access iteration (Conor)
- Increase MISALIGNED_MASK from 2 bits to 3 for possible UNSUPPORTED future value (Conor)
- Introduced vDSO function
Changes in v2:
- Factored the move of struct riscv_cpuinfo to its own header
- Changed the interface to look more like poll(). Rather than supplying key_offset and getting back an array of values with numerically contiguous keys, have the user pre-fill the key members of the array, and the kernel will fill in the corresponding values. For any key it doesn't recognize, it will set the key of that element to -1. This allows usermode to quickly ask for exactly the elements it cares about, and not get bogged down in a back and forth about newer keys that older kernels might not recognize. In other words, the kernel can communicate that it doesn't recognize some of the keys while still providing the data for the keys it does know.
- Added a shortcut to the cpuset parameters that if a size of 0 and NULL is provided for the CPU set, the kernel will use a cpu mask of all online CPUs. This is convenient because I suspect most callers will only want to act on a feature if it's supported on all CPUs, and it's a headache to dynamically allocate an array of all 1s, not to mention a waste to have the kernel loop over all of the offline bits.
- Fixed logic error in if(of_property_read_string...) that caused crash
- Include cpufeature.h in cpufeature.h to avoid undeclared variable warning.
- Added a _MASK define
- Fix random checkpatch complaints
- Updated the selftests to the new API and added some more.
- Fixed indentation, comments in .S, and general checkpatch complaints.
Evan Green (6):
RISC-V: Move struct riscv_cpuinfo to new header
RISC-V: Add a syscall for HW probing
RISC-V: hwprobe: Add support for RISCV_HWPROBE_BASE_BEHAVIOR_IMA
RISC-V: hwprobe: Support probing of misaligned access performance
selftests: Test the new RISC-V hwprobe interface
RISC-V: Add hwprobe vDSO function and data
Documentation/riscv/hwprobe.rst | 86 +++++++ Documentation/riscv/index.rst | 1 + arch/riscv/Kconfig | 1 + arch/riscv/errata/thead/errata.c | 10 + arch/riscv/include/asm/alternative.h | 5 + arch/riscv/include/asm/cpufeature.h | 23 ++ arch/riscv/include/asm/hwprobe.h | 13 + arch/riscv/include/asm/syscall.h | 4 + arch/riscv/include/asm/vdso/data.h | 17 ++ arch/riscv/include/asm/vdso/gettimeofday.h | 8 + arch/riscv/include/uapi/asm/hwprobe.h | 37 +++ arch/riscv/include/uapi/asm/unistd.h | 9 + arch/riscv/kernel/alternative.c | 19 ++ arch/riscv/kernel/compat_vdso/Makefile | 2 +- arch/riscv/kernel/cpu.c | 8 +- arch/riscv/kernel/cpufeature.c | 3 + arch/riscv/kernel/smpboot.c | 1 + arch/riscv/kernel/sys_riscv.c | 228 +++++++++++++++++- arch/riscv/kernel/vdso.c | 6 - arch/riscv/kernel/vdso/Makefile | 4 + arch/riscv/kernel/vdso/hwprobe.c | 52 ++++ arch/riscv/kernel/vdso/sys_hwprobe.S | 15 ++ arch/riscv/kernel/vdso/vdso.lds.S | 3 + tools/testing/selftests/Makefile | 1 + tools/testing/selftests/riscv/Makefile | 58 +++++ .../testing/selftests/riscv/hwprobe/Makefile | 10 + .../testing/selftests/riscv/hwprobe/hwprobe.c | 90 +++++++ .../selftests/riscv/hwprobe/sys_hwprobe.S | 12 + 28 files changed, 712 insertions(+), 14 deletions(-) create mode 100644 Documentation/riscv/hwprobe.rst create mode 100644 arch/riscv/include/asm/cpufeature.h create mode 100644 arch/riscv/include/asm/hwprobe.h create mode 100644 arch/riscv/include/asm/vdso/data.h create mode 100644 arch/riscv/include/uapi/asm/hwprobe.h create mode 100644 arch/riscv/kernel/vdso/hwprobe.c create mode 100644 arch/riscv/kernel/vdso/sys_hwprobe.S create mode 100644 tools/testing/selftests/riscv/Makefile create mode 100644 tools/testing/selftests/riscv/hwprobe/Makefile create mode 100644 tools/testing/selftests/riscv/hwprobe/hwprobe.c create mode 100644 tools/testing/selftests/riscv/hwprobe/sys_hwprobe.S
Signature · 1 line
2.25.1
PATCH v6 1/6 RISC-V: Move struct riscv_cpuinfo to new header
In preparation for tracking and exposing microarchitectural details to userspace (like whether or not unaligned accesses are fast), move the riscv_cpuinfo struct out to its own new cpufeatures.h header. It will need to be used by more than just cpu.c.
---
(no changes since v5)
Changes in v5:
- Added tags
Changes in v3:
- Updated copyright date in cpufeature.h
- Fixed typo in cpufeature.h comment (Conor)
Changes in v2:
- Factored the move of struct riscv_cpuinfo to its own header
arch/riscv/include/asm/cpufeature.h | 21 +++++++++++++++++++++ arch/riscv/kernel/cpu.c | 8 ++------ 2 files changed, 23 insertions(+), 6 deletions(-) create mode 100644 arch/riscv/include/asm/cpufeature.h
arch/riscv/include/asm/cpufeature.h new file +21 -0
@@ -0,0 +1,21 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ +/* +* Copyright 2022-2023 Rivos, Inc +*/ + +#ifndef _ASM_CPUFEATURE_H +#define _ASM_CPUFEATURE_H + +/* +* These are probed via a device_initcall(), via either the SBI or directly +* from the corresponding CSRs. +*/ +struct riscv_cpuinfo { +unsigned long mvendorid; +unsigned long marchid; +unsigned long mimpid; +}; + +DECLARE_PER_CPU(struct riscv_cpuinfo, riscv_cpuinfo); + +#endif
arch/riscv/kernel/cpu.c +2 -6
@@ -7,6 +7,7 @@#include <linux/init.h> #include <linux/seq_file.h> #include <linux/of.h> +#include <asm/cpufeature.h> #include <asm/csr.h> #include <asm/hwcap.h> #include <asm/sbi.h>
@@ -70,12 +71,7 @@ int riscv_of_parent_hartid(struct device_node *node, unsigned long *hartid)return -1 ; } -struct riscv_cpuinfo { -unsigned long mvendorid; -unsigned long marchid; -unsigned long mimpid; -}; -static DEFINE_PER_CPU(struct riscv_cpuinfo, riscv_cpuinfo); +DEFINE_PER_CPU(struct riscv_cpuinfo, riscv_cpuinfo);unsigned long riscv_cached_mvendorid (unsigned int cpu_id) {
Signature · 1 line
2.25.1
Re: [PATCH v6 1/6] RISC-V: Move struct riscv_cpuinfo to new header
This series was applied to riscv/linux.git (for-next) by Palmer Dabbelt <[email protected]>:
Hello:
This series was applied to riscv/linux.git (for-next) by Palmer Dabbelt <[email protected]>:
Quoted 5 lines · On Fri, 7 Apr 2023 16:10:58 -0700 you wrote:
In preparation for tracking and exposing microarchitectural details to userspace (like whether or not unaligned accesses are fast), move the
riscv_cpuinfostruct out to its own newcpufeatures.hheader. It will need to be used by more than justcpu.c.
Quoted 7 lines
Signed-off-by Evan Green <[email protected]>Reviewed-by Conor Dooley <[email protected]>Reviewed-by Heiko Stuebner <[email protected]>Tested-by Heiko Stuebner <[email protected]>Reviewed-by Paul Walmsley <[email protected]>[...]
Here is the summary with links:
- [v6,1/6] RISC-V: Move struct riscv_cpuinfo to new header
https://git.kernel.org/riscv/c/ff77cf5b2e03 - [v6,2/6] RISC-V: Add a syscall for HW probing https://git.kernel.org/riscv/c/ea3de9ce8aa2 - [v6,3/6] RISC-V: hwprobe: Add support for RISCV_HWPROBE_BASE_BEHAVIOR_IMA https://git.kernel.org/riscv/c/00e76e2c6a2b - [v6,4/6] RISC-V: hwprobe: Support probing of misaligned access performance https://git.kernel.org/riscv/c/62a31d6e38bd - [v6,5/6] selftests: Test the new RISC-V hwprobe interface https://git.kernel.org/riscv/c/287dcc2b0c83 - [v6,6/6] RISC-V: Add hwprobe vDSO function and data https://git.kernel.org/riscv/c/aa5af0aa90ba
You are awesome, thank you!
Signature · 9 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html _______________________________________________ linux-riscv mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-riscv
PATCH v6 2/6 RISC-V: Add a syscall for HW probing
In reply to Evan GreenWe don't have enough space for these all in ELF_HWCAP{,2} and there's no system call that quite does this, so let's just provide an arch-specific one to probe for hardware capabilities. This currently just provides m{arch,imp,vendor}id, but with the key-value pairs we can pass more in the future.
---
Changes in v6:
- Remove spurious blank line (Conorbot)
- Update copyrights (Paul)
Changes in v4:
- Used real types in syscall prototypes (Arnd)
- Fixed static line break in do_riscv_hwprobe() (Conor)
- Added newlines between documentation lists (Conor)
- Crispen up size types to size_t, and cpu indices to int (Joe)
- Fix copy_from_user() return logic bug (found via kselftests!)
- Add __user to SYSCALL_DEFINE() to fix warning
Changes in v3:
- Refactored functions so that kernel mode can query too, in preparation for the vDSO data population.
- Changed the vendor/arch/imp IDs to return a value of -1 on mismatch rather than failing the whole call.
- Const cpumask pointer in hwprobe_mid()
- Embellished documentation WRT cpu_set and the returned values.
- Renamed hwprobe_mid() to hwprobe_arch_id() (Conor)
- Fixed machine ID doc warnings, changed elements to c:macro:.
- Completed dangling unistd.h comment (Conor)
- Fixed line breaks and minor logic optimization (Conor).
- Use riscv_cached_mxxxid() (Conor)
Changes in v2:
- Changed the interface to look more like poll(). Rather than supplying key_offset and getting back an array of values with numerically contiguous keys, have the user pre-fill the key members of the array, and the kernel will fill in the corresponding values. For any key it doesn't recognize, it will set the key of that element to -1. This allows usermode to quickly ask for exactly the elements it cares about, and not get bogged down in a back and forth about newer keys that older kernels might not recognize. In other words, the kernel can communicate that it doesn't recognize some of the keys while still providing the data for the keys it does know.
- Added a shortcut to the cpuset parameters that if a size of 0 and NULL is provided for the CPU set, the kernel will use a cpu mask of all online CPUs. This is convenient because I suspect most callers will only want to act on a feature if it's supported on all CPUs, and it's a headache to dynamically allocate an array of all 1s, not to mention a waste to have the kernel loop over all of the offline bits.
--- Documentation/riscv/hwprobe.rst | 41 ++++++++ Documentation/riscv/index.rst | 1 + arch/riscv/include/asm/hwprobe.h | 13 +++ arch/riscv/include/asm/syscall.h | 4 + arch/riscv/include/uapi/asm/hwprobe.h | 25 +++++ arch/riscv/include/uapi/asm/unistd.h | 9 ++ arch/riscv/kernel/sys_riscv.c | 135 +++++++++++++++++++++++++- 7 files changed, 227 insertions(+), 1 deletion(-) create mode 100644 Documentation/riscv/hwprobe.rst create mode 100644 arch/riscv/include/asm/hwprobe.h create mode 100644 arch/riscv/include/uapi/asm/hwprobe.h
Documentation/riscv/hwprobe.rst new file +41 -0
@@ -0,0 +1,41 @@ +.. SPDX-License-Identifier: GPL-2.0 + +RISC-V Hardware Probing Interface +--------------------------------- + +The RISC-V hardware probing interface is based around a single syscall, which +is defined in <asm/hwprobe.h>:: + + struct riscv_hwprobe { + __s64 key; + __u64 value; + }; + + long sys_riscv_hwprobe(struct riscv_hwprobe *pairs, size_t pair_count, + size_t cpu_count, cpu_set_t *cpus, + unsigned int flags); + +The arguments are split into three groups: an array of key-value pairs, a CPU +set, and some flags. The key-value pairs are supplied with a count. Userspace +must prepopulate the key field for each element, and the kernel will fill in the +value if the key is recognized. If a key is unknown to the kernel, its key field +will be cleared to -1, and its value set to 0. The CPU set is defined by +CPU_SET(3). For value-like keys (eg. vendor/arch/impl), the returned value will +be only be valid if all CPUs in the given set have the same value. Otherwise -1 +will be returned. For boolean-like keys, the value returned will be a logical +AND of the values for the specified CPUs. Usermode can supply NULL for cpus and +0 for cpu_count as a shortcut for all online CPUs. There are currently no flags, +this value must be zero for future compatibility. + +On success 0 is returned, on failure a negative error code is returned. + +The following keys are defined: + +* :c:macro:`RISCV_HWPROBE_KEY_MVENDORID`: Contains the value of ``mvendorid``, + as defined by the RISC-V privileged architecture specification. + +* :c:macro:`RISCV_HWPROBE_KEY_MARCHID`: Contains the value of ``marchid``, as + defined by the RISC-V privileged architecture specification. + +* :c:macro:`RISCV_HWPROBE_KEY_MIMPLID`: Contains the value of ``mimplid``, as + defined by the RISC-V privileged architecture specification.
Documentation/riscv/index.rst +1 -0
@@ -7,6 +7,7 @@ RISC-V architecture boot-image-header vm-layout + hwprobe patch-acceptance uabi
arch/riscv/include/asm/hwprobe.h new file +13 -0
@@ -0,0 +1,13 @@ +/* SPDX-License-Identifier: GPL-2.0 WITH Linux-syscall-note */ +/* +* Copyright 2023 Rivos, Inc +*/ + +#ifndef _ASM_HWPROBE_H +#define _ASM_HWPROBE_H + +#include <uapi/asm/hwprobe.h> + +#define RISCV_HWPROBE_MAX_KEY 2 + +#endif
arch/riscv/include/asm/syscall.h +4 -0
@@ -10,6 +10,7 @@#ifndef _ASM_RISCV_SYSCALL_H#define _ASM_RISCV_SYSCALL_H +#include <asm/hwprobe.h> #include <uapi/linux/audit.h> #include <linux/sched.h> #include <linux/err.h>
@@ -75,4 +76,7 @@ static inline int syscall_get_arch(struct task_struct *task) }asmlinkage long sys_riscv_flush_icache (uintptr_t ,uintptr_t ,uintptr_t ); + +asmlinkage long sys_riscv_hwprobe (struct riscv_hwprobe *,size_t ,size_t , +unsigned long *,unsigned int );#endif /* _ASM_RISCV_SYSCALL_H */
arch/riscv/include/uapi/asm/hwprobe.h new file +25 -0
@@ -0,0 +1,25 @@ +/* SPDX-License-Identifier: GPL-2.0 WITH Linux-syscall-note */ +/* +* Copyright 2023 Rivos, Inc +*/ + +#ifndef _UAPI_ASM_HWPROBE_H +#define _UAPI_ASM_HWPROBE_H + +#include <linux/types.h> + +/* +* Interface for probing hardware capabilities from userspace, see +* Documentation/riscv/hwprobe.rst for more information. +*/ +struct riscv_hwprobe { +__s64 key; +__u64 value; +}; + +#define RISCV_HWPROBE_KEY_MVENDORID 0 +#define RISCV_HWPROBE_KEY_MARCHID 1 +#define RISCV_HWPROBE_KEY_MIMPID 2 +/* Increase RISCV_HWPROBE_MAX_KEY when adding items. */ + +#endif
arch/riscv/include/uapi/asm/unistd.h +9 -0
@@ -43,3 +43,12 @@#define __NR_riscv_flush_icache (__NR_arch_specific_syscall + 15)#endif __SYSCALL (__NR_riscv_flush_icache, sys_riscv_flush_icache) + +/* +* Allows userspace to query the kernel for CPU architecture and +* microarchitecture details across a given set of CPUs. + */ +#ifndef __NR_riscv_hwprobe +#define __NR_riscv_hwprobe (__NR_arch_specific_syscall + 14) +#endif +__SYSCALL (__NR_riscv_hwprobe, sys_riscv_hwprobe)
arch/riscv/kernel/sys_riscv.c +134 -1
145 lines not on this page · raw message
Signature · 1 line
2.25.1
PATCH v6 3/6 RISC-V: hwprobe: Add support for RISCV_HWPROBE_BASE_BEHAVIOR_IMA
In reply to Evan GreenWe have an implicit set of base behaviors that userspace depends on, which are mostly defined in various ISA specifications.
---
(no changes since v5)
Changes in v5:
- Fixed misuse of ISA_EXT_c as bitmap, changed to use riscv_isa_extension_available() (Heiko, Conor)
Changes in v4:
- More newlines in BASE_BEHAVIOR_IMA documentation (Conor)
Changes in v3:
- Refactored base ISA behavior probe to allow kernel probing as well, in prep for vDSO data initialization.
- Fixed doc warnings in IMA text list, use :c:macro:.
Documentation/riscv/hwprobe.rst | 24 ++++++++++++++++++++++++ arch/riscv/include/asm/hwprobe.h | 2 +- arch/riscv/include/uapi/asm/hwprobe.h | 5 +++++ arch/riscv/kernel/sys_riscv.c | 20 ++++++++++++++++++++ 4 files changed, 50 insertions(+), 1 deletion(-)
Documentation/riscv/hwprobe.rst +24 -0
@@ -39,3 +39,27 @@ The following keys are defined: * :c:macro:`RISCV_HWPROBE_KEY_MIMPLID`: Contains the value of ``mimplid``, as defined by the RISC-V privileged architecture specification. + +* :c:macro:`RISCV_HWPROBE_KEY_BASE_BEHAVIOR`: A bitmask containing the base + user-visible behavior that this kernel supports. The following base user ABIs + are defined: + + * :c:macro:`RISCV_HWPROBE_BASE_BEHAVIOR_IMA`: Support for rv32ima or + rv64ima, as defined by version 2.2 of the user ISA and version 1.10 of the + privileged ISA, with the following known exceptions (more exceptions may be + added, but only if it can be demonstrated that the user ABI is not broken): + + * The :fence.i: instruction cannot be directly executed by userspace + programs (it may still be executed in userspace via a + kernel-controlled mechanism such as the vDSO). + +* :c:macro:`RISCV_HWPROBE_KEY_IMA_EXT_0`: A bitmask containing the extensions + that are compatible with the :c:macro:`RISCV_HWPROBE_BASE_BEHAVIOR_IMA`: + base system behavior. + + * :c:macro:`RISCV_HWPROBE_IMA_FD`: The F and D extensions are supported, as + defined by commit cd20cee ("FMIN/FMAX now implement + minimumNumber/maximumNumber, not minNum/maxNum") of the RISC-V ISA manual. + + * :c:macro:`RISCV_HWPROBE_IMA_C`: The C extension is supported, as defined + by version 2.2 of the RISC-V ISA manual.
arch/riscv/include/asm/hwprobe.h +1 -1
@@ -8,6 +8,6 @@#include <uapi/asm/hwprobe.h> -#define RISCV_HWPROBE_MAX_KEY 2 +#define RISCV_HWPROBE_MAX_KEY 4#endif
arch/riscv/include/uapi/asm/hwprobe.h +5 -0
@@ -20,6 +20,11 @@ struct riscv_hwprobe {#define RISCV_HWPROBE_KEY_MVENDORID 0#define RISCV_HWPROBE_KEY_MARCHID 1#define RISCV_HWPROBE_KEY_MIMPID 2 +#define RISCV_HWPROBE_KEY_BASE_BEHAVIOR 3 +#define RISCV_HWPROBE_BASE_BEHAVIOR_IMA (1 << 0) +#define RISCV_HWPROBE_KEY_IMA_EXT_0 4 +#define RISCV_HWPROBE_IMA_FD (1 << 0) +#define RISCV_HWPROBE_IMA_C (1 << 1)/* Increase RISCV_HWPROBE_MAX_KEY when adding items. */ #endif
arch/riscv/kernel/sys_riscv.c +20 -0
@@ -9,6 +9,7 @@#include <asm/cacheflush.h> #include <asm/hwprobe.h> #include <asm/sbi.h> +#include <asm/switch_to.h> #include <asm/uaccess.h> #include <asm/unistd.h> #include <asm-generic/mman-common.h>
@@ -125,6 +126,25 @@ static void hwprobe_one_pair(struct riscv_hwprobe *pair,case RISCV_HWPROBE_KEY_MIMPID :hwprobe_arch_id (pair, cpus);break ; +/* +* The kernel already assumes that the base single-letter ISA +* extensions are supported on all harts, and only supports the +* IMA base, so just cheat a bit here and tell that to +* userspace. +*/ +case RISCV_HWPROBE_KEY_BASE_BEHAVIOR : + pair->value =RISCV_HWPROBE_BASE_BEHAVIOR_IMA ; +break ; + +case RISCV_HWPROBE_KEY_IMA_EXT_0 : + pair->value =0 ; +if (has_fpu ()) + pair->value |=RISCV_HWPROBE_IMA_FD ; + +if (riscv_isa_extension_available (NULL , c)) + pair->value |=RISCV_HWPROBE_IMA_C ; + +break ;/* * For forward compatibility, unknown keys don't fail the whole
Signature · 7 lines
2.25.1 _______________________________________________ linux-riscv mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-riscv
Re: [PATCH v6 3/6] RISC-V: hwprobe: Add support for RISCV_HWPROBE_BASE_BEHAVIOR_IMA
Quoted 9 lines · Evan Green
We have an implicit set of base behaviors that userspace depends on, which are mostly defined in various ISA specifications.
Co-developed-by Palmer Dabbelt <[email protected]>Signed-off-by Palmer Dabbelt <[email protected]>Signed-off-by Evan Green <[email protected]>Reviewed-by Conor Dooley <[email protected]>Reviewed-by Heiko Stuebner <[email protected]>Tested-by Heiko Stuebner <[email protected]>
- Paul
PATCH v6 4/6 RISC-V: hwprobe: Support probing of misaligned access performance
In reply to Evan GreenThis allows userspace to select various routines to use based on the performance of misaligned access on the target hardware.
Rather than adding DT bindings, this change taps into the alternatives mechanism used to probe CPU errata. Add a new function pointer alongside the vendor-specific errata_patch_func() that probes for desirable errata (otherwise known as "features"). Unlike the errata_patch_func(), this function is called on each CPU as it comes up, so it can save feature information per-CPU.
The T-head C906 has fast unaligned access, both as defined by GCC [1], and in performing a basic benchmark, which determined that byte copies are >50% slower than a misaligned word copy of the same data size (source for this test at [2]):
bytecopy size f000 count 50000 offset 0 took 31664899 us wordcopy size f000 count 50000 offset 0 took 5180919 us wordcopy size f000 count 50000 offset 1 took 13416949 us
[1] https://github.com/gcc-mirror/gcc/blob/master/gcc/config/riscv/riscv.cc#L353
[2] https://pastebin.com/EPXvDHSW
---
(no changes since v5)
Changes in v5:
- Document the alternatives approach in the commit message (Conor and Heiko).
- Fix __init call warnings by making probe_vendor_features() and thead_feature_probe_func() __init_or_module.
Changes in v4:
- Add newlines to CPUPERF_0 documentation (Conor)
- Add UNSUPPORTED value (Conor)
- Switched from DT to alternatives-based probing (Rob)
- Crispen up cpu index type to always be int (Conor)
Changes in v3:
- Have hwprobe_misaligned return int instead of long.
- Constify cpumask pointer in hwprobe_misaligned()
- Fix warnings in _PERF_O list documentation, use :c:macro:.
- Move include cpufeature.h to misaligned patch.
- Fix documentation mismatch for RISCV_HWPROBE_KEY_CPUPERF_0 (Conor)
- Use for_each_possible_cpu() instead of NR_CPUS (Conor)
- Break early in misaligned access iteration (Conor)
- Increase MISALIGNED_MASK from 2 bits to 3 for possible UNSUPPORTED future value (Conor)
Changes in v2:
- Fixed logic error in if(of_property_read_string...) that caused crash
- Include cpufeature.h in cpufeature.h to avoid undeclared variable warning.
- Added a _MASK define
- Fix random checkpatch complaints
Documentation/riscv/hwprobe.rst | 21 ++++++++++++++++++++ arch/riscv/errata/thead/errata.c | 10 ++++++++++ arch/riscv/include/asm/alternative.h | 5 +++++ arch/riscv/include/asm/cpufeature.h | 2 ++ arch/riscv/include/asm/hwprobe.h | 2 +- arch/riscv/include/uapi/asm/hwprobe.h | 7 +++++++ arch/riscv/kernel/alternative.c | 19 ++++++++++++++++++ arch/riscv/kernel/cpufeature.c | 3 +++ arch/riscv/kernel/smpboot.c | 1 + arch/riscv/kernel/sys_riscv.c | 28 +++++++++++++++++++++++++++ 10 files changed, 97 insertions(+), 1 deletion(-)
Documentation/riscv/hwprobe.rst +21 -0
@@ -63,3 +63,24 @@ The following keys are defined: * :c:macro:`RISCV_HWPROBE_IMA_C`: The C extension is supported, as defined by version 2.2 of the RISC-V ISA manual. + +* :c:macro:`RISCV_HWPROBE_KEY_CPUPERF_0`: A bitmask that contains performance + information about the selected set of processors. + + * :c:macro:`RISCV_HWPROBE_MISALIGNED_UNKNOWN`: The performance of misaligned + accesses is unknown. + + * :c:macro:`RISCV_HWPROBE_MISALIGNED_EMULATED`: Misaligned accesses are + emulated via software, either in or below the kernel. These accesses are + always extremely slow. + + * :c:macro:`RISCV_HWPROBE_MISALIGNED_SLOW`: Misaligned accesses are supported + in hardware, but are slower than the cooresponding aligned accesses + sequences. + + * :c:macro:`RISCV_HWPROBE_MISALIGNED_FAST`: Misaligned accesses are supported + in hardware and are faster than the cooresponding aligned accesses + sequences. + + * :c:macro:`RISCV_HWPROBE_MISALIGNED_UNSUPPORTED`: Misaligned accesses are + not supported at all and will generate a misaligned address fault.
arch/riscv/errata/thead/errata.c +10 -0
@@ -11,7 +11,9 @@#include <linux/uaccess.h> #include <asm/alternative.h> #include <asm/cacheflush.h> +#include <asm/cpufeature.h> #include <asm/errata_list.h> +#include <asm/hwprobe.h> #include <asm/patch.h> #include <asm/vendorid_list.h>
@@ -115,3 +117,11 @@ void __init_or_module thead_errata_patch_func(struct alt_entry *begin, struct alif (stage ==RISCV_ALTERNATIVES_EARLY_BOOT )local_flush_icache_all (); } + +void __init_or_module thead_feature_probe_func(unsigned int cpu, +unsigned long archid, +unsigned long impid) +{ +if ((archid ==0 ) && (impid ==0 )) +per_cpu (misaligned_access_speed, cpu) =RISCV_HWPROBE_MISALIGNED_FAST ; +}
arch/riscv/include/asm/alternative.h +5 -0
@@ -28,6 +28,7 @@#define ALT_OLD_PTR (a) __ALT_PTR(a, old_offset)#define ALT_ALT_PTR (a) __ALT_PTR(a, alt_offset) +void __init probe_vendor_features (unsigned int cpu);void __init apply_boot_alternatives (void );void __init apply_early_boot_alternatives (void );void apply_module_alternatives (void *start,size_t length);
@@ -55,11 +56,15 @@ void thead_errata_patch_func(struct alt_entry *begin, struct alt_entry *end, unsigned long archid, unsigned long impid, unsigned int stage); +void thead_feature_probe_func (unsigned int cpu,unsigned long archid, +unsigned long impid); +void riscv_cpufeature_patch_func (struct alt_entry *begin,struct alt_entry *end,unsigned int stage);#else /* CONFIG_RISCV_ALTERNATIVE */ +static inline void probe_vendor_features (unsigned int cpu) { }static inline void apply_boot_alternatives (void ) { }static inline void apply_early_boot_alternatives (void ) { }static inline void apply_module_alternatives (void *start,size_t length) { }
arch/riscv/include/asm/cpufeature.h +2 -0
@@ -18,4 +18,6 @@ struct riscv_cpuinfo { DECLARE_PER_CPU(struct riscv_cpuinfo, riscv_cpuinfo); +DECLARE_PER_CPU (long, misaligned_access_speed); +#endif
arch/riscv/include/asm/hwprobe.h +1 -1
@@ -8,6 +8,6 @@#include <uapi/asm/hwprobe.h> -#define RISCV_HWPROBE_MAX_KEY 4 +#define RISCV_HWPROBE_MAX_KEY 5#endif
arch/riscv/include/uapi/asm/hwprobe.h +7 -0
@@ -25,6 +25,13 @@ struct riscv_hwprobe {#define RISCV_HWPROBE_KEY_IMA_EXT_0 4#define RISCV_HWPROBE_IMA_FD (1 << 0)#define RISCV_HWPROBE_IMA_C (1 << 1) +#define RISCV_HWPROBE_KEY_CPUPERF_0 5 +#define RISCV_HWPROBE_MISALIGNED_UNKNOWN (0 << 0) +#define RISCV_HWPROBE_MISALIGNED_EMULATED (1 << 0) +#define RISCV_HWPROBE_MISALIGNED_SLOW (2 << 0) +#define RISCV_HWPROBE_MISALIGNED_FAST (3 << 0) +#define RISCV_HWPROBE_MISALIGNED_UNSUPPORTED (4 << 0) +#define RISCV_HWPROBE_MISALIGNED_MASK (7 << 0)/* Increase RISCV_HWPROBE_MAX_KEY when adding items. */ #endif
arch/riscv/kernel/alternative.c +19 -0
@@ -27,6 +27,8 @@ struct cpu_manufacturer_info_t {void (*patch_func)(struct alt_entry *begin,struct alt_entry *end,unsigned long archid,unsigned long impid,unsigned int stage); +void (*feature_probe_func)(unsigned int cpu,unsigned long archid, +unsigned long impid); }; static void __init_or_module riscv_fill_cpu_mfr_info(struct cpu_manufacturer_info_t *cpu_mfr_info)
@@ -41,6 +43,7 @@ static void __init_or_module riscv_fill_cpu_mfr_info(struct cpu_manufacturer_inf cpu_mfr_info->imp_id =sbi_get_mimpid ();#endif + cpu_mfr_info->feature_probe_func =NULL ;switch (cpu_mfr_info->vendor_id) {#ifdef CONFIG_ERRATA_SIFIVE case SIFIVE_VENDOR_ID :
@@ -50,6 +53,7 @@ static void __init_or_module riscv_fill_cpu_mfr_info(struct cpu_manufacturer_inf#ifdef CONFIG_ERRATA_THEAD case THEAD_VENDOR_ID : cpu_mfr_info->patch_func = thead_errata_patch_func; + cpu_mfr_info->feature_probe_func = thead_feature_probe_func;break ;#endif default :
@@ -139,6 +143,20 @@ void riscv_alternative_fix_offsets(void *alt_ptr, unsigned int len, } } +/* Called on each CPU as it starts */ +void __init_or_module probe_vendor_features(unsigned int cpu) +{ +struct cpu_manufacturer_info_t cpu_mfr_info; + +riscv_fill_cpu_mfr_info (&cpu_mfr_info); +if (!cpu_mfr_info.feature_probe_func) +return ; + + cpu_mfr_info.feature_probe_func (cpu, + cpu_mfr_info.arch_id, + cpu_mfr_info.imp_id); +} +/* * This is called very early in the boot process (directly after we run * a feature detect on the boot CPU). No need to worry about other CPUs
@@ -193,6 +211,7 @@ void __init apply_boot_alternatives(void)/* If called on non-boot cpu things could go wrong */ WARN_ON (smp_processor_id () !=0 ); +probe_vendor_features (0 );_apply_alternatives ((struct alt_entry *)__alt_start, (struct alt_entry *)__alt_end,RISCV_ALTERNATIVES_BOOT );
arch/riscv/kernel/cpufeature.c +3 -0
@@ -30,6 +30,9 @@ unsigned long elf_hwcap __read_mostly;/* Host ISA bitmap */ static DECLARE_BITMAP(riscv_isa, RISCV_ISA_EXT_MAX) __read_mostly; +/* Performance information */ +DEFINE_PER_CPU (long , misaligned_access_speed); +/** * riscv_isa_extension_base() - Get base extension word *
arch/riscv/kernel/smpboot.c +1 -0
@@ -168,6 +168,7 @@ asmlinkage __visible void smp_callin(void)notify_cpu_starting (curr_cpuid);numa_add_cpu (curr_cpuid);set_cpu_online (curr_cpuid,1 ); +probe_vendor_features (curr_cpuid);/* * Remote TLB flushes are ignored while the CPU is offline, so emit
arch/riscv/kernel/sys_riscv.c +28 -0
@@ -7,6 +7,7 @@#include <linux/syscalls.h> #include <asm/cacheflush.h> +#include <asm/cpufeature.h> #include <asm/hwprobe.h> #include <asm/sbi.h> #include <asm/switch_to.h>
@@ -117,6 +118,29 @@ static void hwprobe_arch_id(struct riscv_hwprobe *pair, pair->value = id; } +static u64 hwprobe_misaligned (const struct cpumask *cpus) +{ +int cpu; +u64 perf =-1ULL ; + +for_each_cpu (cpu, cpus) { +int this_perf =per_cpu (misaligned_access_speed, cpu); + +if (perf ==-1ULL ) + perf = this_perf; + +if (perf != this_perf) { + perf =RISCV_HWPROBE_MISALIGNED_UNKNOWN ; +break ; + } + } + +if (perf ==-1ULL ) +return RISCV_HWPROBE_MISALIGNED_UNKNOWN ; + +return perf; +} +static void hwprobe_one_pair (struct riscv_hwprobe *pair,const struct cpumask *cpus) {
@@ -146,6 +170,10 @@ static void hwprobe_one_pair(struct riscv_hwprobe *pair,break ; +case RISCV_HWPROBE_KEY_CPUPERF_0 : + pair->value =hwprobe_misaligned (cpus); +break ; +/* * For forward compatibility, unknown keys don't fail the whole * call, but get their element key set to -1 and value set to 0
Signature · 7 lines
2.25.1 _______________________________________________ linux-riscv mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-riscv
Re: [PATCH v6 4/6] RISC-V: hwprobe: Support probing of misaligned access performance
Quoted 19 lines · Evan Green
This allows userspace to select various routines to use based on the performance of misaligned access on the target hardware.
Rather than adding DT bindings, this change taps into the alternatives mechanism used to probe CPU errata. Add a new function pointer alongside the vendor-specific
errata_patch_func()that probes for desirable errata (otherwise known as "features"). Unlike theerrata_patch_func(), this function is called on each CPU as it comes up, so it can save feature information per-CPU.The T-head C906 has fast unaligned access, both as defined by GCC [1], and in performing a basic benchmark, which determined that byte copies are >50% slower than a misaligned word copy of the same data size (source for this test at [2]):
bytecopy size f000 count 50000 offset 0 took 31664899 us wordcopy size f000 count 50000 offset 0 took 5180919 us wordcopy size f000 count 50000 offset 1 took 13416949 us
Quoted 8 lines
[1] https://github.com/gcc-mirror/gcc/blob/master/gcc/config/riscv/riscv.cc#L353
[2] https://pastebin.com/EPXvDHSWCo-developed-by Palmer Dabbelt <[email protected]>Signed-off-by Palmer Dabbelt <[email protected]>Signed-off-by Evan Green <[email protected]>Reviewed-by Heiko Stuebner <[email protected]>Tested-by Heiko Stuebner <[email protected]>
I think I had given you an R-b a few versions back, guess it was dropped due to changes or w/e :)
Perhaps at some point the "errata" naming of those files should change, but today is not that day.
Cheers,
Conor.
Re: [PATCH v6 4/6] RISC-V: hwprobe: Support probing of misaligned access performance
In reply to Evan GreenQuoted 19 lines · Evan Green
This allows userspace to select various routines to use based on the performance of misaligned access on the target hardware.
Rather than adding DT bindings, this change taps into the alternatives mechanism used to probe CPU errata. Add a new function pointer alongside the vendor-specific
errata_patch_func()that probes for desirable errata (otherwise known as "features"). Unlike theerrata_patch_func(), this function is called on each CPU as it comes up, so it can save feature information per-CPU.The T-head C906 has fast unaligned access, both as defined by GCC [1], and in performing a basic benchmark, which determined that byte copies are >50% slower than a misaligned word copy of the same data size (source for this test at [2]):
bytecopy size f000 count 50000 offset 0 took 31664899 us wordcopy size f000 count 50000 offset 0 took 5180919 us wordcopy size f000 count 50000 offset 1 took 13416949 us
Quoted 8 lines
[1] https://github.com/gcc-mirror/gcc/blob/master/gcc/config/riscv/riscv.cc#L353
[2] https://pastebin.com/EPXvDHSWCo-developed-by Palmer Dabbelt <[email protected]>Signed-off-by Palmer Dabbelt <[email protected]>Signed-off-by Evan Green <[email protected]>Reviewed-by Heiko Stuebner <[email protected]>Tested-by Heiko Stuebner <[email protected]>
- Paul
PATCH v6 5/6 selftests: Test the new RISC-V hwprobe interface
In reply to Evan GreenThis adds a test for the recently added RISC-V interface for probing hardware capabilities. It happens to be the first selftest we have for RISC-V, so I've added some infrastructure for those as well.
---
Changes in v6:
- Update copyrights (Paul)
Changes in v4:
- Fixed selftests commit description, no more tiny libc (Mark Brown)
- Fixed selftest syscall prototype types to match v4.
Changes in v2:
- Updated the selftests to the new API and added some more.
- Fixed indentation, comments in .S, and general checkpatch complaints.
--- tools/testing/selftests/Makefile | 1 + tools/testing/selftests/riscv/Makefile | 58 ++++++++++++ .../testing/selftests/riscv/hwprobe/Makefile | 10 +++ .../testing/selftests/riscv/hwprobe/hwprobe.c | 90 +++++++++++++++++++ .../selftests/riscv/hwprobe/sys_hwprobe.S | 12 +++ 5 files changed, 171 insertions(+) create mode 100644 tools/testing/selftests/riscv/Makefile create mode 100644 tools/testing/selftests/riscv/hwprobe/Makefile create mode 100644 tools/testing/selftests/riscv/hwprobe/hwprobe.c create mode 100644 tools/testing/selftests/riscv/hwprobe/sys_hwprobe.S
tools/testing/selftests/Makefile +1 -0
@@ -63,6 +63,7 @@ TARGETS += pstore TARGETS += ptrace TARGETS += openat2 TARGETS += resctrl +TARGETS += riscv TARGETS += rlimits TARGETS += rseq TARGETS += rtc
tools/testing/selftests/riscv/Makefile new file +58 -0
58 lines not on this page · raw message
tools/testing/selftests/riscv/hwprobe/Makefile new file +10 -0
@@ -0,0 +1,10 @@ +# SPDX-License-Identifier: GPL-2.0 +# Copyright (C) 2021 ARM Limited +# Originally tools/testing/arm64/abi/Makefile + +TEST_GEN_PROGS := hwprobe + +include ../../lib.mk + +$(OUTPUT)/hwprobe: hwprobe.c sys_hwprobe.S + $(CC) -o$@ $(CFLAGS) $(LDFLAGS) $^
tools/testing/selftests/riscv/hwprobe/hwprobe.c new file +90 -0
90 lines not on this page · raw message
tools/testing/selftests/riscv/hwprobe/sys_hwprobe.S new file +12 -0
@@ -0,0 +1,12 @@ +/* SPDX-License-Identifier: GPL-2.0 */ +/* Copyright (C) 2023 Rivos, Inc */ + +.text +.global riscv_hwprobe +riscv_hwprobe: + # Put __NR_riscv_hwprobe in the syscall number register, then just shim + # back the kernel's return. This doesn't do any sort of errno + # handling, the caller can deal with it. + li a7, 258 + ecall + ret
Signature · 7 lines
2.25.1 _______________________________________________ linux-riscv mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-riscv
PATCH v6 6/6 RISC-V: Add hwprobe vDSO function and data
In reply to Evan GreenAdd a vDSO function __vdso_riscv_hwprobe, which can sit in front of the riscv_hwprobe syscall and answer common queries. We stash a copy of static answers for the "all CPUs" case in the vDSO data page. This data is private to the vDSO, so we can decide later to change what's stored there or under what conditions we defer to the syscall. Currently all data can be discovered at boot, so the vDSO function answers all queries when the cpumask is set to the "all CPUs" hint.
There's also a boolean in the data that lets the vDSO function know that all CPUs are the same. In that case, the vDSO will also answer queries for arbitrary CPU masks in addition to the "all CPUs" hint.
---
Changes in v6:
- Wrap init_hwprobe_vdso_data() in CONFIG_MMU to fix nommu build break (Conorbot)
- Update copyrights (Paul)
Changes in v5:
- Fixed compat vdso compilation failure (lkp).
Changes in v4:
- Added a prototype to fix -Wmissing-prototype warning ([email protected])
- Fixed rv32 build failure ([email protected])
- Make vdso prototype match syscall types update
Changes in v3:
- Introduced vDSO function
One aspect of this that's less than perfect is that there are two copies of the arch_vdso_data in the data page. This stems from the fact that vdso_data is arrayed by CS_BASES. Since we're very far away from filling up the page, and this is not ABI, I left it for now. If things get full we can move this data out to its own page, or refactor vdso_data tree-wide to allow for non-arrayed data.
--- arch/riscv/Kconfig | 1 + arch/riscv/include/asm/vdso/data.h | 17 +++++++ arch/riscv/include/asm/vdso/gettimeofday.h | 8 ++++ arch/riscv/kernel/compat_vdso/Makefile | 2 +- arch/riscv/kernel/sys_riscv.c | 45 +++++++++++++++++++ arch/riscv/kernel/vdso.c | 6 --- arch/riscv/kernel/vdso/Makefile | 4 ++ arch/riscv/kernel/vdso/hwprobe.c | 52 ++++++++++++++++++++++ arch/riscv/kernel/vdso/sys_hwprobe.S | 15 +++++++ arch/riscv/kernel/vdso/vdso.lds.S | 3 ++ 10 files changed, 146 insertions(+), 7 deletions(-) create mode 100644 arch/riscv/include/asm/vdso/data.h create mode 100644 arch/riscv/kernel/vdso/hwprobe.c create mode 100644 arch/riscv/kernel/vdso/sys_hwprobe.S
arch/riscv/Kconfig +1 -0
@@ -33,6 +33,7 @@ config RISCV select ARCH_HAS_STRICT_MODULE_RWX if MMU && !XIP_KERNEL select ARCH_HAS_TICK_BROADCAST if GENERIC_CLOCKEVENTS_BROADCAST select ARCH_HAS_UBSAN_SANITIZE_ALL + select ARCH_HAS_VDSO_DATA select ARCH_OPTIONAL_KERNEL_RWX if ARCH_HAS_STRICT_KERNEL_RWX select ARCH_OPTIONAL_KERNEL_RWX_DEFAULT select ARCH_STACKWALK
arch/riscv/include/asm/vdso/data.h new file +17 -0
@@ -0,0 +1,17 @@ +/* SPDX-License-Identifier: GPL-2.0 */ +#ifndef __RISCV_ASM_VDSO_DATA_H +#define __RISCV_ASM_VDSO_DATA_H + +#include <linux/types.h> +#include <vdso/datapage.h> +#include <asm/hwprobe.h> + +struct arch_vdso_data { +/* Stash static answers to the hwprobe queries when all CPUs are selected. */ +__u64 all_cpu_hwprobe_values[RISCV_HWPROBE_MAX_KEY +1 ]; + +/* Boolean indicating all CPUs have the same static hwprobe values. */ +__u8 homogeneous_cpus; +}; + +#endif /* __RISCV_ASM_VDSO_DATA_H */
arch/riscv/include/asm/vdso/gettimeofday.h +8 -0
@@ -9,6 +9,12 @@#include <asm/csr.h> #include <uapi/linux/time.h> +/* +* 32-bit land is lacking generic time vsyscalls as well as the legacy 32-bit +* time syscalls like gettimeofday. Skip these definitions since on 32-bit. +*/ +#ifdef CONFIG_GENERIC_TIME_VSYSCALL +#define VDSO_HAS_CLOCK_GETRES 1 static __always_inline
@@ -60,6 +66,8 @@ int clock_getres_fallback(clockid_t _clkid, struct __kernel_timespec *_ts)return ret; } +#endif /* CONFIG_GENERIC_TIME_VSYSCALL */ + static __always_inline u64 __arch_get_hw_counter(s32 clock_mode,const struct vdso_data *vd) {
arch/riscv/kernel/compat_vdso/Makefile +1 -1
@@ -22,7 +22,7 @@ targets := $(obj-compat_vdso) compat_vdso.so compat_vdso.so.dbg compat_vdso.lds obj-compat_vdso := $(addprefix $(obj)/, $(obj-compat_vdso)) obj-y += compat_vdso.o -CPPFLAGS_compat_vdso.lds += -P -C -U$(ARCH) +CPPFLAGS_compat_vdso.lds += -P -C -DCOMPAT_VDSO -U$(ARCH) # Disable profiling and instrumentation for VDSO code GCOV_PROFILE := n
arch/riscv/kernel/sys_riscv.c +45 -0
57 lines not on this page · raw message
arch/riscv/kernel/vdso.c +0 -6
@@ -14,13 +14,7 @@#include <asm/page.h> #include <asm/vdso.h> #include <linux/time_namespace.h> - -#ifdef CONFIG_GENERIC_TIME_VSYSCALL #include <vdso/datapage.h> -#else -struct vdso_data { -}; -#endif enum vvar_pages {VVAR_DATA_PAGE_OFFSET ,
arch/riscv/kernel/vdso/Makefile +4 -0
@@ -12,6 +12,8 @@ vdso-syms += vgettimeofday endif vdso-syms += getcpu vdso-syms += flush_icache +vdso-syms += hwprobe +vdso-syms += sys_hwprobe # Files to link into the vdso obj-vdso = $(patsubst %, %.o, $(vdso-syms)) note.o
@@ -23,6 +25,8 @@ ifneq ($(c-gettimeofday-y),) CFLAGS_vgettimeofday.o += -fPIC -include $(c-gettimeofday-y) endif +CFLAGS_hwprobe.o += -fPIC + # Build rules targets := $(obj-vdso) vdso.so vdso.so.dbg vdso.lds obj-vdso := $(addprefix $(obj)/, $(obj-vdso))
arch/riscv/kernel/vdso/hwprobe.c new file +52 -0
52 lines not on this page · raw message
arch/riscv/kernel/vdso/sys_hwprobe.S new file +15 -0
@@ -0,0 +1,15 @@ +/* SPDX-License-Identifier: GPL-2.0 */ +/* Copyright (C) 2023 Rivos, Inc */ + +#include <linux/linkage.h> +#include <asm/unistd.h> + +.text +ENTRY(riscv_hwprobe) + .cfi_startproc + li a7, __NR_riscv_hwprobe + ecall + ret + + .cfi_endproc +ENDPROC(riscv_hwprobe)
arch/riscv/kernel/vdso/vdso.lds.S +3 -0
@@ -82,6 +82,9 @@ VERSION #endif __vdso_getcpu; __vdso_flush_icache; +#ifndef COMPAT_VDSO + __vdso_riscv_hwprobe; +#endif local: *; }; }
Signature · 7 lines
2.25.1 _______________________________________________ linux-riscv mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-riscv
Hey Evan,
Quoted 42 lines · Evan Green
There's been a bunch of off-list discussions about this, including at Plumbers. The original plan was to do something involving providing an ISA string to userspace, but ISA strings just aren't sufficient for a stable ABI any more: in order to parse an ISA string users need the version of the specifications that the string is written to, the version of each extension (sometimes at a finer granularity than the RISC-V releases/versions encode), and the expected use case for the ISA string (ie, is it a U-mode or M-mode string). That's a lot of complexity to try and keep ABI compatible and it's probably going to continue to grow, as even if there's no more complexity in the specifications we'll have to deal with the various ISA string parsing oddities that end up all over userspace.
Instead this patch set takes a very different approach and provides a set of key/value pairs that encode various bits about the system. The big advantage here is that we can clearly define what these mean so we can ensure ABI stability, but it also allows us to encode information that's unlikely to ever appear in an ISA string (see the misaligned access performance, for example). The resulting interface looks a lot like what arm64 and x86 do, and will hopefully fit well into something like ACPI in the future.
The actual user interface is a syscall, with a vDSO function in front of it. The vDSO function can answer some queries without a syscall at all, and falls back to the syscall for cases it doesn't have answers to. Currently we prepopulate it with an array of answers for all keys and a CPU set of "all CPUs". This can be adjusted as necessary to provide fast answers to the most common queries.
An example series in glibc exposing this syscall and using it in an ifunc selector for memcpy can be found at [1].
I was asked about the performance delta between this and something like sysfs. I created a small test program [2] and ran it on a Nezha D1 Allwinner board. Doing each operation 100000 times and dividing, these operations take the following amount of time:
- open()+read()+close() of/sys/kernel/cpu_byteorder: 3.8us
-access("/sys/kernel/cpu_byteorder", R_OK): 1.3us
-riscv_hwprobe()vDSO and syscall: .0094us
-riscv_hwprobe()vDSO with no syscall: 0.0091us
Quoted 6 lines
These numbers get farther apart if we query multiple keys, as sysfs will scale linearly with the number of keys, where the dedicated syscall stays the same. To frame these numbers, I also did a tight fork/exec/wait loop, which I measured as 4.8ms. So doing 4 open/read/close operations is a delta of about 0.3%, versus a single vDSO call is a delta of essentially zero.
Two nits w.r.t. build bot complaints...
On patch 2:arch/riscv/include/uapi/asm/unistd.h:54:1: warning: initializer overrides prior initialization of this subobject [-Winitializer-overrides] I think this one is kinda spurious, all of the syscalls complain like
this (and do on arm64 too IIRC). There was a patch from Guo somewhere to
disable -Winitializer-overrides in this case, I should go find out what
happened to it.
On patch 4:arch/riscv/kernel/cpufeature.c:29:1: warning: symbol '__pcpu_scope_misaligned_access_speed' was not declared. Should it be static?
Probably because cos cpufeature.c doesn't include the header of the same name... Perhaps Palmer could fix that one up on application?
Cheers,
Conor.
_______________________________________________
linux-riscv mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-riscv
Palmer Dabbelt
AppliedQuoted 13 lines · Evan Green
There's been a bunch of off-list discussions about this, including at Plumbers. The original plan was to do something involving providing an ISA string to userspace, but ISA strings just aren't sufficient for a stable ABI any more: in order to parse an ISA string users need the version of the specifications that the string is written to, the version of each extension (sometimes at a finer granularity than the RISC-V releases/versions encode), and the expected use case for the ISA string (ie, is it a U-mode or M-mode string). That's a lot of complexity to try and keep ABI compatible and it's probably going to continue to grow, as even if there's no more complexity in the specifications we'll have to deal with the various ISA string parsing oddities that end up all over userspace.
Quoted 1 line
[...]
Applied, thanks!
[1/6] RISC-V: Move struct riscv_cpuinfo to new header
https://git.kernel.org/palmer/c/ff77cf5b2e03 [2/6] RISC-V: Add a syscall for HW probing https://git.kernel.org/palmer/c/ea3de9ce8aa2 [3/6] RISC-V: hwprobe: Add support for RISCV_HWPROBE_BASE_BEHAVIOR_IMA https://git.kernel.org/palmer/c/00e76e2c6a2b [4/6] RISC-V: hwprobe: Support probing of misaligned access performance https://git.kernel.org/palmer/c/62a31d6e38bd [5/6] selftests: Test the new RISC-V hwprobe interface https://git.kernel.org/palmer/c/287dcc2b0c83 [6/6] RISC-V: Add hwprobe vDSO function and data https://git.kernel.org/palmer/c/aa5af0aa90ba
Best regards,
Signature · 1 line
Palmer Dabbelt <[email protected]>