Skip to contentSkip to conversation

drm/amdgpu: fix introduce gc_*_mes_2.bin v2

PATCH In review Li Ma 3 participants 3 messages Apr 11, 2023

Subsystems (2)
lore
Share & tools
lore

Li Ma

author
#0 lore raw

PATCH 1/1 drm/amdgpu: fix introduce gc_*_mes_2.bin v2

Rename MODULE_FIRMWARE declaration of gc_11_0_4_mes to gc_11_0_4_mes_2

---
 drivers/gpu/drm/amd/amdgpu/mes_v11_0.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/amd/amdgpu/mes_v11_0.c +1 -1
index 67f7557d545d..7e8c15cd8dc2 100644
@@ -40,7 +40,7 @@ MODULE_FIRMWARE("amdgpu/gc_11_0_2_mes_2.bin");
 MODULE_FIRMWARE("amdgpu/gc_11_0_2_mes1.bin");
 MODULE_FIRMWARE("amdgpu/gc_11_0_3_mes_2.bin");
 MODULE_FIRMWARE("amdgpu/gc_11_0_3_mes1.bin");
-MODULE_FIRMWARE("amdgpu/gc_11_0_4_mes.bin");
+MODULE_FIRMWARE("amdgpu/gc_11_0_4_mes_2.bin");
 MODULE_FIRMWARE("amdgpu/gc_11_0_4_mes1.bin");
 
 static int mes_v11_0_hw_fini(void *handle);
Signature · 1 line
2.25.1
#1 lore raw

[AMD Official Use Only - General]

Please add

Fixes 0f486b64b8d4 ("drm/amd/amdgpu: introduce gc_*_mes_2.bin v2")

With this fixed, patch Reviewed-by: Yifan Zhang <[email protected]>

Best Regards,
Yifan

-----Original Message-----
From: Ma, Li <[email protected]>
Sent: Tuesday, April 11, 2023 10:36 AM
To: [email protected]
Cc: Deucher, Alexander <[email protected]>; Zhang, Yifan <[email protected]>; Huang, Tim <[email protected]>; Du, Xiaojian <[email protected]>; Ma, Li <[email protected]>
Subject: [PATCH] drm/amdgpu: fix introduce gc_*_mes_2.bin v2

Rename MODULE_FIRMWARE declaration of gc_11_0_4_mes to gc_11_0_4_mes_2

---
 drivers/gpu/drm/amd/amdgpu/mes_v11_0.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/amd/amdgpu/mes_v11_0.c +1 -1
index 67f7557d545d..7e8c15cd8dc2 100644
@@ -40,7 +40,7 @@ MODULE_FIRMWARE("amdgpu/gc_11_0_2_mes_2.bin");
 MODULE_FIRMWARE("amdgpu/gc_11_0_2_mes1.bin");
 MODULE_FIRMWARE("amdgpu/gc_11_0_3_mes_2.bin");
 MODULE_FIRMWARE("amdgpu/gc_11_0_3_mes1.bin");
-MODULE_FIRMWARE("amdgpu/gc_11_0_4_mes.bin");
+MODULE_FIRMWARE("amdgpu/gc_11_0_4_mes_2.bin");
 MODULE_FIRMWARE("amdgpu/gc_11_0_4_mes1.bin");
 
 static int mes_v11_0_hw_fini(void *handle);
Signature · 1 line
2.25.1
#2 lore raw
In reply to Li Ma

[AMD Official Use Only - General]

Quoted 23 lines

-----Original Message-----
From: Ma, Li <[email protected]>
Sent: Monday, April 10, 2023 10:36 PM
To: [email protected]
Cc: Deucher, Alexander <[email protected]>; Zhang, Yifan <[email protected]>; Huang, Tim <[email protected]>; Du, Xiaojian <[email protected]>; Ma, Li <[email protected]>
Subject: [PATCH] drm/amdgpu: fix introduce gc_*_mes_2.bin v2

Rename MODULE_FIRMWARE declaration of gc_11_0_4_mes to gc_11_0_4_mes_2

---
 drivers/gpu/drm/amd/amdgpu/mes_v11_0.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/amd/amdgpu/mes_v11_0.c +0 -0
index 67f7557d545d..7e8c15cd8dc2 100644

drivers/gpu/drm/amd/amdgpu/mes_v11_0.c line 44

Quoted 5 lines
drivers/gpu/drm/amd/amdgpu/mes_v11_0.c +0 -1
@@ -40,7 +40,7 @@
 MODULE_FIRMWARE("amdgpu/gc_11_0_2_mes_2.bin");
 MODULE_FIRMWARE("amdgpu/gc_11_0_2_mes1.bin");
 MODULE_FIRMWARE("amdgpu/gc_11_0_3_mes_2.bin");
 MODULE_FIRMWARE("amdgpu/gc_11_0_3_mes1.bin");
-MODULE_FIRMWARE("amdgpu/gc_11_0_4_mes.bin");

I don't think you need to remove the old ones, they should still be available as a fallback if the new ones don't exist.

Alex

Quoted 6 lines
drivers/gpu/drm/amd/amdgpu/mes_v11_0.c +1 -0
+MODULE_FIRMWARE("amdgpu/gc_11_0_4_mes_2.bin");
 MODULE_FIRMWARE("amdgpu/gc_11_0_4_mes1.bin");
 

static int mes_v11_0_hw_fini(void *handle);
--
2.25.1