* Update drivers/net/gve/base code for DQO *

PATCH Applied Rushil Gupta 3 participants 13 messages Apr 11, 2023 – May 4, 2023 Network drivers

lore

Share & tools

lore

Rushil Gupta

author

2023-04-11 04:59 UTC #0 lore raw

cover *** Update drivers/net/gve/base code for DQO ***

This patch is dependent on https://patchwork.dpdk.org/project/dpdk/patch/[email protected]/

Rushil Gupta (1):
net/gve: update base code for DQO

 drivers/net/gve/base/gve.h          |  1 +
 drivers/net/gve/base/gve_adminq.c   | 10 +++++-----
 drivers/net/gve/base/gve_desc_dqo.h |  4 ----
 3 files changed, 6 insertions(+), 9 deletions(-)

Signature · 1 line

2.40.0.577.gac1e443424-goog

Rushil Gupta

author

2023-04-11 04:59 UTC #1 lore raw

PATCH 1/1 net/gve: update base code for DQO

Update gve base code to support DQO.

This patch is based on this:
https://patchwork.dpdk.org/project/dpdk/list/?series=27647&state=*

Signed-off-by Rushil Gupta <[email protected]>

Signed-off-by Junfeng Guo <[email protected]>

---
 drivers/net/gve/base/gve.h          |  1 +
 drivers/net/gve/base/gve_adminq.c   | 10 +++++-----
 drivers/net/gve/base/gve_desc_dqo.h |  4 ----
 3 files changed, 6 insertions(+), 9 deletions(-)

drivers/net/gve/base/gve.h +1 -0

index 2dc4507acb..2b7cf7d99b 100644
@@ -7,6 +7,7 @@
 #define _GVE_H_
 
 #include "gve_desc.h"
+#include "gve_desc_dqo.h"
 
 #define GVE_VERSION		"1.3.0"
 #define GVE_VERSION_PREFIX	"GVE-"

drivers/net/gve/base/gve_adminq.c +5 -5

index e745b709b2..e963f910a0 100644
@@ -497,11 +497,11 @@ static int gve_adminq_create_tx_queue(struct gve_priv *priv, u32 queue_index)
 		cmd.create_tx_queue.queue_page_list_id = cpu_to_be32(qpl_id);
 	} else {
 		cmd.create_tx_queue.tx_ring_size =
-			cpu_to_be16(txq->nb_tx_desc);
+			cpu_to_be16(priv->tx_desc_cnt);
 		cmd.create_tx_queue.tx_comp_ring_addr =
-			cpu_to_be64(txq->complq->tx_ring_phys_addr);
+			cpu_to_be64(txq->compl_ring_phys_addr);
 		cmd.create_tx_queue.tx_comp_ring_size =
-			cpu_to_be16(priv->tx_compq_size);
+			cpu_to_be16(priv->tx_compq_size * DQO_TX_MULTIPLIER);
 	}
 
 	return gve_adminq_issue_cmd(priv, &cmd);

@@ -549,9 +549,9 @@ static int gve_adminq_create_rx_queue(struct gve_priv *priv, u32 queue_index)
 		cmd.create_rx_queue.rx_ring_size =
 			cpu_to_be16(priv->rx_desc_cnt);
 		cmd.create_rx_queue.rx_desc_ring_addr =
-			cpu_to_be64(rxq->rx_ring_phys_addr);
+			cpu_to_be64(rxq->compl_ring_phys_addr);
 		cmd.create_rx_queue.rx_data_ring_addr =
-			cpu_to_be64(rxq->bufq->rx_ring_phys_addr);
+			cpu_to_be64(rxq->rx_ring_phys_addr);
 		cmd.create_rx_queue.packet_buffer_size =
 			cpu_to_be16(rxq->rx_buf_len);
 		cmd.create_rx_queue.rx_buff_ring_size =

drivers/net/gve/base/gve_desc_dqo.h +0 -4

index ee1afdecb8..bb4a18d4d1 100644
@@ -13,10 +13,6 @@
 #define GVE_TX_MAX_HDR_SIZE_DQO 255
 #define GVE_TX_MIN_TSO_MSS_DQO 88
 
-#ifndef __LITTLE_ENDIAN_BITFIELD
-#error "Only little endian supported"
-#endif
-
 /* Basic TX descriptor (DTYPE 0x0C) */
 struct gve_tx_pkt_desc_dqo {
 	__le64 buf_addr;

Signature · 1 line

2.40.0.577.gac1e443424-goog

Ferruh Yigit

2023-04-12 08:51 UTC #3 lore raw

Re: [PATCH 1/1] net/gve: update base code for DQO

On 4/11/2023 7:51 AM, Guo, Junfeng wrote:

Hi Junfeng, message moved down.

Quoted 17 lines

Quoted 10 lines
-----Original Message-----
From: Rushil Gupta <[email protected]>
Sent: Tuesday, April 11, 2023 12:59
To: Zhang, Qi Z <[email protected]>; [email protected]
Cc: Richardson, Bruce <[email protected]>; [email protected]; Rushil Gupta <[email protected]>; Guo, Junfeng <[email protected]>
Subject: [PATCH 1/1] net/gve: update base code for DQO
Quoted 7 lines
Update gve base code to support DQO.
This patch is based on this:
https://patchwork.dpdk.org/project/dpdk/list/?series=27647&state=*
Signed-off-by Rushil Gupta <[email protected]>
Signed-off-by Junfeng Guo <[email protected]>

Quoted 8 lines

Hi Ferruh & Bruce,
This patch contains few lines change for the MIT licensed gve base code. Note that there is no new files added, just some minor code update.
Do we need to ask for special approval from the Tech Board for this? Please help give some advice and also help review this patch. Thanks!

Once the MIT license exception is in place, as far as I know no more approval is required per change.

Quoted 4 lines

BTW, Google will also help replace all the base code under MIT license with the ones under BSD-3 license soon, which would make things more easier.

Is this different from base code under DPDK is changing license [1] ?

[1]
https://patches.dpdk.org/project/dpdk/list/?series=27570&state=%2A&archive=both

Guo, Junfeng

2023-04-12 09:09 UTC #4 lore raw

RE: [PATCH 1/1] net/gve: update base code for DQO

Quoted 37 lines

-----Original Message-----
From: Ferruh Yigit <[email protected]>
Sent: Wednesday, April 12, 2023 16:50
To: Guo, Junfeng <[email protected]>; Richardson, Bruce <[email protected]>
Cc: [email protected]; Zhang, Qi Z <[email protected]>; Rushil Gupta <[email protected]>
Subject: Re: [PATCH 1/1] net/gve: update base code for DQO
On 4/11/2023 7:51 AM, Guo, Junfeng wrote:
Hi Junfeng, message moved down.
Quoted 22 lines
Quoted 10 lines
-----Original Message-----
From: Rushil Gupta <[email protected]>
Sent: Tuesday, April 11, 2023 12:59
To: Zhang, Qi Z <[email protected]>; [email protected]
Cc: Richardson, Bruce <[email protected]>; [email protected]; Rushil Gupta <[email protected]>; Guo, Junfeng <[email protected]>
Subject: [PATCH 1/1] net/gve: update base code for DQO
Quoted 7 lines
Update gve base code to support DQO.
This patch is based on this:
https://patchwork.dpdk.org/project/dpdk/list/?series=27647&state=*
Signed-off-by Rushil Gupta <[email protected]>
Signed-off-by Junfeng Guo <[email protected]>
Hi Ferruh & Bruce,
This patch contains few lines change for the MIT licensed gve base code. Note that there is no new files added, just some minor code update.

Quoted 6 lines

Quoted 3 lines
Do we need to ask for special approval from the Tech Board for this? Please help give some advice and also help review this patch. Thanks!
Once the MIT license exception is in place, as far as I know no more approval is required per change.

Got it, thanks the comment!

Then we may also need your help to review, as well as the coming patch set for GVE PMD enhancement for DPDK 23.07. Thanks in advance!

Quoted 6 lines

Quoted 5 lines
BTW, Google will also help replace all the base code under MIT license with the ones under BSD-3 license soon, which would make things more easier.

Quoted 7 lines

Is this different from base code under DPDK is changing license [1] ?
[1]
https://patches.dpdk.org/project/dpdk/list/?series=27570&state=%2A&ar
chive=both

The patch set of the above link only contains the processing of replace the MIT licensed base code with the BSD-3 licensed base code. After some discussion, we think Google is in the right place to do that work. And they are working on that now.

This patch is mainly for the feature upstreaming of DPDK 23.07. It contains only the code part, following previous license statements, without any license change.

This patch is separated and sent by Google, to ensure there is no license violation.

BTW, about the feature of GVE PMD enhancement, the rest code are all about BSD-3 licensed files, and that patch set will be sent out soon.

Thanks!

Ferruh Yigit

2023-04-12 09:34 UTC #5 lore raw

Re: [PATCH 1/1] net/gve: update base code for DQO

Quoted 63 lines · Junfeng

Quoted 37 lines
-----Original Message-----
From: Ferruh Yigit <[email protected]>
Sent: Wednesday, April 12, 2023 16:50
To: Guo, Junfeng <[email protected]>; Richardson, Bruce <[email protected]>
Cc: [email protected]; Zhang, Qi Z <[email protected]>; Rushil Gupta <[email protected]>
Subject: Re: [PATCH 1/1] net/gve: update base code for DQO
On 4/11/2023 7:51 AM, Guo, Junfeng wrote:
Hi Junfeng, message moved down.
Quoted 22 lines
Quoted 10 lines
-----Original Message-----
From: Rushil Gupta <[email protected]>
Sent: Tuesday, April 11, 2023 12:59
To: Zhang, Qi Z <[email protected]>; [email protected]
Cc: Richardson, Bruce <[email protected]>; [email protected]; Rushil Gupta <[email protected]>; Guo, Junfeng <[email protected]>
Subject: [PATCH 1/1] net/gve: update base code for DQO
Quoted 7 lines
Update gve base code to support DQO.
This patch is based on this:
https://patchwork.dpdk.org/project/dpdk/list/?series=27647&state=*
Signed-off-by Rushil Gupta <[email protected]>
Signed-off-by Junfeng Guo <[email protected]>
Hi Ferruh & Bruce,
This patch contains few lines change for the MIT licensed gve base code. Note that there is no new files added, just some minor code update.
Quoted 6 lines
Quoted 3 lines
Do we need to ask for special approval from the Tech Board for this? Please help give some advice and also help review this patch. Thanks!
Once the MIT license exception is in place, as far as I know no more approval is required per change.
Got it, thanks the comment!
Then we may also need your help to review, as well as the coming patch set for GVE PMD enhancement for DPDK 23.07. Thanks in advance!
Quoted 6 lines
Quoted 5 lines
BTW, Google will also help replace all the base code under MIT license with the ones under BSD-3 license soon, which would make things more easier.
Quoted 7 lines
Is this different from base code under DPDK is changing license [1] ?
[1]
https://patches.dpdk.org/project/dpdk/list/?series=27570&state=%2A&ar
chive=both

Quoted 5 lines

The patch set of the above link only contains the processing of replace the MIT licensed base code with the BSD-3 licensed base code. After some discussion, we think Google is in the right place to do that work. And they are working on that now.

Is the Google GVE driver [2] in the process of changing license from MIT to BSD-3?

[2]
https://github.com/GoogleCloudPlatform/compute-virtual-ethernet-linux/tree/v1.3.0/google/gve

Quoted 11 lines

This patch is mainly for the feature upstreaming of DPDK 23.07. It contains only the code part, following previous license statements, without any license change.
This patch is separated and sent by Google, to ensure there is no license violation.
BTW, about the feature of GVE PMD enhancement, the rest code are all about BSD-3 licensed files, and that patch set will be sent out soon.
Thanks!

Guo, Junfeng

2023-04-12 09:41 UTC #6 lore raw

RE: [PATCH 1/1] net/gve: update base code for DQO

Quoted 89 lines

-----Original Message-----
From: Ferruh Yigit <[email protected]>
Sent: Wednesday, April 12, 2023 17:35
To: Guo, Junfeng <[email protected]>; Richardson, Bruce <[email protected]>
Cc: [email protected]; Zhang, Qi Z <[email protected]>; Rushil Gupta <[email protected]>
Subject: Re: [PATCH 1/1] net/gve: update base code for DQO
Quoted 13 lines · Junfeng
Quoted 13 lines
-----Original Message-----
From: Ferruh Yigit <[email protected]>
Sent: Wednesday, April 12, 2023 16:50
To: Guo, Junfeng <[email protected]>; Richardson, Bruce <[email protected]>
Cc: [email protected]; Zhang, Qi Z <[email protected]>; Rushil Gupta <[email protected]>
Subject: Re: [PATCH 1/1] net/gve: update base code for DQO
On 4/11/2023 7:51 AM, Guo, Junfeng wrote:
Quoted 8 lines
Quoted 8 lines
Hi Junfeng, message moved down.
Quoted 6 lines
Quoted 6 lines
-----Original Message-----
From: Rushil Gupta <[email protected]>
Sent: Tuesday, April 11, 2023 12:59
To: Zhang, Qi Z <[email protected]>; [email protected]
Cc: Richardson, Bruce <[email protected]>;
[email protected];
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
Rushil Gupta <[email protected]>; Guo, Junfeng <[email protected]>
Subject: [PATCH 1/1] net/gve: update base code for DQO
Update gve base code to support DQO.
This patch is based on this:
https://patchwork.dpdk.org/project/dpdk/list/?series=27647&state=*
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 3 lines
Signed-off-by Rushil Gupta <[email protected]>
Signed-off-by Junfeng Guo <[email protected]>
Hi Ferruh & Bruce,
This patch contains few lines change for the MIT licensed gve base
code.
Quoted 6 lines
Quoted 6 lines
Quoted 5 lines
Note that there is no new files added, just some minor code update.
Do we need to ask for special approval from the Tech Board for this? Please help give some advice and also help review this patch. Thanks!
Quoted 10 lines
Quoted 2 lines
Once the MIT license exception is in place, as far as I know no more approval is required per change.
Got it, thanks the comment!
Then we may also need your help to review, as well as the coming patch set for GVE PMD enhancement for DPDK 23.07. Thanks in advance!
Quoted 2 lines
Quoted 2 lines
BTW, Google will also help replace all the base code under MIT
license
Quoted 1 line
Quoted 1 line
Quoted 1 line
with the ones under BSD-3 license soon, which would make things
more
Quoted 8 lines
Quoted 8 lines
Quoted 2 lines
easier.
Is this different from base code under DPDK is changing license [1] ?
[1]
https://patches.dpdk.org/project/dpdk/list/?series=27570&state=%2A&ar
Quoted 4 lines
Quoted 2 lines
chive=both
The patch set of the above link only contains the processing of replace
the
Quoted 2 lines
MIT licensed base code with the BSD-3 licensed base code. After some discussion, we think Google is in the right place to do that work. And
they
Quoted 2 lines
are working on that now.

Quoted 8 lines

Is the Google GVE driver [2] in the process of changing license from MIT to BSD-3?
[2]
https://github.com/GoogleCloudPlatform/compute-virtual-ethernet-
linux/tree/v1.3.0/google/gve

I'm not sure, I don't know much about Google's plans. Maybe they could provide some info here. Thanks!

@Rushil Gupta

Quoted 14 lines

Quoted 3 lines
This patch is mainly for the feature upstreaming of DPDK 23.07. It
contains
Quoted 10 lines
only the code part, following previous license statements, without any license change.
This patch is separated and sent by Google, to ensure there is no license violation.
BTW, about the feature of GVE PMD enhancement, the rest code are all about BSD-3 licensed files, and that patch set will be sent out soon.
Thanks!

Rushil Gupta

author

2023-04-12 15:42 UTC #7 lore raw

Re: [PATCH 1/1] net/gve: update base code for DQO

Quoted 112 lines · Junfeng

Quoted 89 lines
-----Original Message-----
From: Ferruh Yigit <[email protected]>
Sent: Wednesday, April 12, 2023 17:35
To: Guo, Junfeng <[email protected]>; Richardson, Bruce <[email protected]>
Cc: [email protected]; Zhang, Qi Z <[email protected]>; Rushil Gupta <[email protected]>
Subject: Re: [PATCH 1/1] net/gve: update base code for DQO
Quoted 13 lines · Junfeng
Quoted 13 lines
-----Original Message-----
From: Ferruh Yigit <[email protected]>
Sent: Wednesday, April 12, 2023 16:50
To: Guo, Junfeng <[email protected]>; Richardson, Bruce <[email protected]>
Cc: [email protected]; Zhang, Qi Z <[email protected]>; Rushil Gupta <[email protected]>
Subject: Re: [PATCH 1/1] net/gve: update base code for DQO
On 4/11/2023 7:51 AM, Guo, Junfeng wrote:
Quoted 8 lines
Quoted 8 lines
Hi Junfeng, message moved down.
Quoted 6 lines
Quoted 6 lines
-----Original Message-----
From: Rushil Gupta <[email protected]>
Sent: Tuesday, April 11, 2023 12:59
To: Zhang, Qi Z <[email protected]>; [email protected]
Cc: Richardson, Bruce <[email protected]>;
[email protected];
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
Rushil Gupta <[email protected]>; Guo, Junfeng <[email protected]>
Subject: [PATCH 1/1] net/gve: update base code for DQO
Update gve base code to support DQO.
This patch is based on this:
https://patchwork.dpdk.org/project/dpdk/list/?series=27647&state=*
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 3 lines
Signed-off-by Rushil Gupta <[email protected]>
Signed-off-by Junfeng Guo <[email protected]>
Hi Ferruh & Bruce,
This patch contains few lines change for the MIT licensed gve base
code.
Quoted 6 lines
Quoted 6 lines
Quoted 5 lines
Note that there is no new files added, just some minor code update.
Do we need to ask for special approval from the Tech Board for this? Please help give some advice and also help review this patch. Thanks!
Quoted 10 lines
Quoted 2 lines
Once the MIT license exception is in place, as far as I know no more approval is required per change.
Got it, thanks the comment!
Then we may also need your help to review, as well as the coming patch set for GVE PMD enhancement for DPDK 23.07. Thanks in advance!
Quoted 2 lines
Quoted 2 lines
BTW, Google will also help replace all the base code under MIT
license
Quoted 1 line
Quoted 1 line
Quoted 1 line
with the ones under BSD-3 license soon, which would make things
more
Quoted 8 lines
Quoted 8 lines
Quoted 2 lines
easier.
Is this different from base code under DPDK is changing license [1] ?
[1]
https://patches.dpdk.org/project/dpdk/list/?series=27570&state=%2A&ar
Quoted 4 lines
Quoted 2 lines
chive=both
The patch set of the above link only contains the processing of replace
the
Quoted 2 lines
MIT licensed base code with the BSD-3 licensed base code. After some discussion, we think Google is in the right place to do that work. And
they
Quoted 2 lines
are working on that now.
Quoted 8 lines
Is the Google GVE driver [2] in the process of changing license from MIT to BSD-3?
[2]
https://github.com/GoogleCloudPlatform/compute-virtual-ethernet-
linux/tree/v1.3.0/google/gve
I'm not sure, I don't know much about Google's plans. Maybe they could provide some info here. Thanks!
@Rushil Gupta
Quoted 8 lines
Quoted 3 lines
This patch is mainly for the feature upstreaming of DPDK 23.07. It
contains
Quoted 4 lines
only the code part, following previous license statements, without any license change.
This patch is separated and sent by Google, to ensure there is no
license

Quoted 8 lines

Quoted 6 lines
Quoted 6 lines
violation.
BTW, about the feature of GVE PMD enhancement, the rest code are all about BSD-3 licensed files, and that patch set will be sent out soon.
Thanks!
I have got the green light internally to switch to BSD-3 license for code

under base directory. If it is ok with the tech board, I can send a patch right away with all of the base files changed to BSD-3 which can be merged after this patch. Please let me know what you think.
We are also about to upstream driver code:
https://github.com/GoogleCloudPlatform/compute-virtual-ethernet-freebsd to FreeBSD as well so you will see similar code under BSD license soon in freebsd repo.

Ferruh Yigit

2023-04-12 16:03 UTC #8 lore raw

Re: [PATCH 1/1] net/gve: update base code for DQO

Quoted 151 lines · Rushil Gupta

Quoted 2 lines · On Wed, Apr 12, 2023 at 2:41 AM Guo, Junfeng <[email protected]…

-----Original Message-----
From: Ferruh Yigit <[email protected]

    <mailto:[email protected]>>
    > Sent: Wednesday, April 12, 2023 17:35
    > To: Guo, Junfeng <[email protected]
    <mailto:[email protected]>>; Richardson, Bruce
    > <[email protected] <mailto:[email protected]>>
    > Cc: [email protected] <mailto:[email protected]>; Zhang, Qi Z
    <[email protected] <mailto:[email protected]>>; Rushil Gupta
    > <[email protected] <mailto:[email protected]>>
    > Subject: Re: [PATCH 1/1] net/gve: update base code for DQO
    >
    > On 4/12/2023 10:09 AM, Guo, Junfeng wrote:
    > >
    > >
    > >> -----Original Message-----
    > >> From: Ferruh Yigit <[email protected]
    <mailto:[email protected]>>
    > >> Sent: Wednesday, April 12, 2023 16:50
    > >> To: Guo, Junfeng <[email protected]
    <mailto:[email protected]>>; Richardson, Bruce
    > >> <[email protected] <mailto:[email protected]>>
    > >> Cc: [email protected] <mailto:[email protected]>; Zhang, Qi Z
    <[email protected] <mailto:[email protected]>>; Rushil Gupta
    > >> <[email protected] <mailto:[email protected]>>
    > >> Subject: Re: [PATCH 1/1] net/gve: update base code for DQO
    > >>
    > >> On 4/11/2023 7:51 AM, Guo, Junfeng wrote:
    > >>
    > >> Hi Junfeng, message moved down.
    > >>
    > >>>
    > >>>> -----Original Message-----
    > >>>> From: Rushil Gupta <[email protected]
    <mailto:[email protected]>>
    > >>>> Sent: Tuesday, April 11, 2023 12:59
    > >>>> To: Zhang, Qi Z <[email protected]
    <mailto:[email protected]>>; [email protected]
    <mailto:[email protected]>
    > >>>> Cc: Richardson, Bruce <[email protected]
    <mailto:[email protected]>>;
    > [email protected] <mailto:[email protected]>;
    > >>>> Rushil Gupta <[email protected]
    <mailto:[email protected]>>; Guo, Junfeng
    > >>>> <[email protected] <mailto:[email protected]>>
    > >>>> Subject: [PATCH 1/1] net/gve: update base code for DQO
    > >>>>
    > >>>> Update gve base code to support DQO.
    > >>>>
    > >>>> This patch is based on this:
    > >>>>
    > https://patchwork.dpdk.org/project/dpdk/list/?series=27647&state=*
    <https://patchwork.dpdk.org/project/dpdk/list/?series=27647&state=*>
    > >>>>
    > >>>> Signed-off-by: Rushil Gupta <[email protected]
    <mailto:[email protected]>>
    > >>>> Signed-off-by: Junfeng Guo <[email protected]
    <mailto:[email protected]>>
    > >>> Hi Ferruh & Bruce,
    > >>>
    > >>> This patch contains few lines change for the MIT licensed gve base
    > code.
    > >>> Note that there is no new files added, just some minor code
    update.
    > >>>
    > >>> Do we need to ask for special approval from the Tech Board for
    this?
    > >>> Please help give some advice and also help review this patch.
    Thanks!
    > >>>
    > >>
    > >> Once the MIT license exception is in place, as far as I know no
    more
    > >> approval is required per change.
    > >
    > > Got it, thanks the comment!
    > >
    > > Then we may also need your help to review, as well as the coming
    patch
    > > set for GVE PMD enhancement for DPDK 23.07. Thanks in advance!
    > >
    > >>
    > >>> BTW, Google will also help replace all the base code under MIT
    > license
    > >>> with the ones under BSD-3 license soon, which would make things
    > more
    > >>> easier.
    > >>>
    > >>
    > >> Is this different from base code under DPDK is changing license
    [1] ?
    > >>
    > >>
    > >> [1]
    > >>
    >
    https://patches.dpdk.org/project/dpdk/list/?series=27570&state=%2A&ar <https://patches.dpdk.org/project/dpdk/list/?series=27570&state=%2A&ar>
    > >> chive=both
    > >>
    > >
    > > The patch set of the above link only contains the processing of
    replace
    > the
    > > MIT licensed base code with the BSD-3 licensed base code. After some
    > > discussion, we think Google is in the right place to do that
    work. And
    > they
    > > are working on that now.
    > >
    >
    > Is the Google GVE driver [2] in the process of changing license
    from MIT
    > to BSD-3?
    >
    >
    > [2]
    > https://github.com/GoogleCloudPlatform/compute-virtual-ethernet-
    <https://github.com/GoogleCloudPlatform/compute-virtual-ethernet->
    > linux/tree/v1.3.0/google/gve
    >

    I'm not sure, I don't know much about Google's plans.
    Maybe they could provide some info here. Thanks!

    @Rushil Gupta

    >
    >
    > > This patch is mainly for the feature upstreaming of DPDK 23.07. It
    > contains
    > > only the code part, following previous license statements,
    without any
    > > license change.
    > >
    > > This patch is separated and sent by Google, to ensure there is
    no license
    > > violation.
    > >
    > > BTW, about the feature of GVE PMD enhancement, the rest code are all
    > > about BSD-3 licensed files, and that patch set will be sent out
    soon.
    > >
    > > Thanks!

Quoted 6 lines

I have got the green light internally to switch to BSD-3 license for
code under base directory. If it is ok with the tech board, I can send a
patch right away with all of the base files changed to BSD-3 which can
be merged after this patch. Please let me know what you think.
We are also about to upstream driver
code: https://github.com/GoogleCloudPlatform/compute-virtual-ethernet-freebsd <https://github.com/GoogleCloudPlatform/compute-virtual-ethernet-freebsd> to FreeBSD as well so you will see similar code under BSD license soon in freebsd repo.

+techboard

There is already a patch [1] to change dpdk gve driver license from MIT to BSD-3, what will be different in the patch you are planning to send?

Or overall I am trying to understand what is this new development on top of existing patch.

Rushil Gupta

author

2023-04-12 18:04 UTC #9 lore raw

Re: [PATCH 1/1] net/gve: update base code for DQO

Sorry for the confusion. I was talking about the same patch (titled net/gve: update copyright holders); however, I am not able to find it on patchwork.

Quoted 184 lines · Ferruh Yigit

Quoted 61 lines · Rushil Gupta
Quoted 2 lines · On Wed, Apr 12, 2023 at 2:41 AM Guo, Junfeng <[email protected]…
-----Original Message-----
From: Ferruh Yigit <[email protected]
<mailto:[email protected]>>
> Sent: Wednesday, April 12, 2023 17:35
> To: Guo, Junfeng <[email protected] <mailto:[email protected]>>; Richardson, Bruce
> <[email protected] <mailto:[email protected]>> > Cc: [email protected] <mailto:[email protected]>; Zhang, Qi Z <[email protected] <mailto:[email protected]>>; Rushil Gupta > <[email protected] <mailto:[email protected]>>
> Subject: Re: [PATCH 1/1] net/gve: update base code for DQO >
> On 4/12/2023 10:09 AM, Guo, Junfeng wrote:
> >
> >
> >> -----Original Message-----
> >> From: Ferruh Yigit <[email protected] <mailto:[email protected]>>
> >> Sent: Wednesday, April 12, 2023 16:50
> >> To: Guo, Junfeng <[email protected] <mailto:[email protected]>>; Richardson, Bruce
> >> <[email protected] <mailto:[email protected]
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Cc [email protected] <mailto:[email protected]>; Zhang, Qi Z
    <[email protected] <mailto:[email protected]>>; Rushil Gupta
    > >> <[email protected] <mailto:[email protected]>>
    > >> Subject: Re: [PATCH 1/1] net/gve: update base code for DQO
    > >>
    > >> On 4/11/2023 7:51 AM, Guo, Junfeng wrote:
    > >>
    > >> Hi Junfeng, message moved down.
    > >>
    > >>>
    > >>>> -----Original Message-----
    > >>>> From: Rushil Gupta <[email protected]
    <mailto:[email protected]>>
    > >>>> Sent: Tuesday, April 11, 2023 12:59
    > >>>> To: Zhang, Qi Z <[email protected]
    <mailto:[email protected]>>; [email protected]
    <mailto:[email protected]>
    > >>>> Cc: Richardson, Bruce <[email protected]
    <mailto:[email protected]>>;
    > [email protected] <mailto:[email protected]>;
    > >>>> Rushil Gupta <[email protected]
    <mailto:[email protected]>>; Guo, Junfeng
    > >>>> <[email protected] <mailto:[email protected]>>
    > >>>> Subject: [PATCH 1/1] net/gve: update base code for DQO
    > >>>>
    > >>>> Update gve base code to support DQO.
    > >>>>
    > >>>> This patch is based on this:
    > >>>>
    > https://patchwork.dpdk.org/project/dpdk/list/?series=27647&state=*
    <https://patchwork.dpdk.org/project/dpdk/list/?series=27647&state=*>
Quoted 8 lines
    > >>>>
    > >>>> Signed-off-by: Rushil Gupta <[email protected]
    <mailto:[email protected]>>
    > >>>> Signed-off-by: Junfeng Guo <[email protected]
    <mailto:[email protected]>>
    > >>> Hi Ferruh & Bruce,
    > >>>
    > >>> This patch contains few lines change for the MIT licensed gve
base
Quoted 27 lines
Quoted 2 lines
code.
Quoted 1 line
Quoted 1 line
Quoted 1 line
Note that there is no new files added, just some minor code
    update.
    > >>>
    > >>> Do we need to ask for special approval from the Tech Board for
    this?
    > >>> Please help give some advice and also help review this patch.
    Thanks!
    > >>>
    > >>
    > >> Once the MIT license exception is in place, as far as I know no
    more
    > >> approval is required per change.
    > >
    > > Got it, thanks the comment!
    > >
    > > Then we may also need your help to review, as well as the coming
    patch
    > > set for GVE PMD enhancement for DPDK 23.07. Thanks in advance!
    > >
    > >>
    > >>> BTW, Google will also help replace all the base code under MIT
    > license
    > >>> with the ones under BSD-3 license soon, which would make things
    > more
    > >>> easier.
    > >>>
Quoted 9 lines
    > >>
    > >> Is this different from base code under DPDK is changing license
    [1] ?
    > >>
    > >>
    > >> [1]
    > >>
    >
https://patches.dpdk.org/project/dpdk/list/?series=27570&state=%2A&ar <
https://patches.dpdk.org/project/dpdk/list/?series=27570&state=%2A&ar>
Quoted 7 lines
Quoted 4 lines
Quoted 4 lines
Quoted 2 lines
chive=both
The patch set of the above link only contains the processing of
replace
> the
> > MIT licensed base code with the BSD-3 licensed base code. After
some
Quoted 17 lines
Quoted 1 line
Quoted 1 line
discussion, we think Google is in the right place to do that
    work. And
    > they
    > > are working on that now.
    > >
    >
    > Is the Google GVE driver [2] in the process of changing license
    from MIT
    > to BSD-3?
    >
    >
    > [2]
    > https://github.com/GoogleCloudPlatform/compute-virtual-ethernet-
    <https://github.com/GoogleCloudPlatform/compute-virtual-ethernet->
    > linux/tree/v1.3.0/google/gve
    >
Quoted 8 lines
    I'm not sure, I don't know much about Google's plans.
    Maybe they could provide some info here. Thanks!

    @Rushil Gupta

    >
    >
    > > This patch is mainly for the feature upstreaming of DPDK 23.07.
It
Quoted 10 lines
Quoted 2 lines
contains
Quoted 1 line
only the code part, following previous license statements,
without any
> > license change.
> >
> > This patch is separated and sent by Google, to ensure there is no license
> > violation.
> >
> > BTW, about the feature of GVE PMD enhancement, the rest code are
all
Quoted 11 lines
Quoted 1 line
Quoted 1 line
about BSD-3 licensed files, and that patch set will be sent out
    soon.
    > >
    > > Thanks!
I have got the green light internally to switch to BSD-3 license for code under base directory. If it is ok with the tech board, I can send a patch right away with all of the base files changed to BSD-3 which can be merged after this patch. Please let me know what you think. We are also about to upstream driver
code:
https://github.com/GoogleCloudPlatform/compute-virtual-ethernet-freebsd <
https://github.com/GoogleCloudPlatform/compute-virtual-ethernet-freebsd>
to FreeBSD as well so you will see similar code under BSD license soon in freebsd repo.
+techboard
There is already a patch [1] to change dpdk gve driver license from MIT to BSD-3, what will be different in the patch you are planning to send?
Or overall I am trying to understand what is this new development on top of existing patch.

Rushil Gupta

author

2023-04-14 05:18 UTC #10 lore raw

Re: [PATCH 1/1] net/gve: update base code for DQO

I want to highlight that we wish to keep license changes separate from this patch (probably for 23.11). This patch is to simply support basic structures for the DQO data path.

Quoted 194 lines · Rushil Gupta

Sorry for the confusion. I was talking about the same patch (titled net/gve: update copyright holders); however, I am not able to find it on patchwork.
Quoted 187 lines · Ferruh Yigit
Quoted 52 lines · Rushil Gupta
Quoted 2 lines · On Wed, Apr 12, 2023 at 2:41 AM Guo, Junfeng <[email protected]…
-----Original Message-----
From: Ferruh Yigit <[email protected]
<mailto:[email protected]>>
> Sent: Wednesday, April 12, 2023 17:35
> To: Guo, Junfeng <[email protected] <mailto:[email protected]>>; Richardson, Bruce
> <[email protected] <mailto:[email protected]>> > Cc: [email protected] <mailto:[email protected]>; Zhang, Qi Z <[email protected] <mailto:[email protected]>>; Rushil Gupta > <[email protected] <mailto:[email protected]>>
> Subject: Re: [PATCH 1/1] net/gve: update base code for DQO >
> On 4/12/2023 10:09 AM, Guo, Junfeng wrote:
> >
> >
> >> -----Original Message-----
> >> From: Ferruh Yigit <[email protected] <mailto:[email protected]>>
> >> Sent: Wednesday, April 12, 2023 16:50
> >> To: Guo, Junfeng <[email protected] <mailto:[email protected]>>; Richardson, Bruce
> >> <[email protected] <mailto:[email protected]
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Cc [email protected] <mailto:[email protected]>; Zhang, Qi Z
    <[email protected] <mailto:[email protected]>>; Rushil Gupta
    > >> <[email protected] <mailto:[email protected]>>
    > >> Subject: Re: [PATCH 1/1] net/gve: update base code for DQO
    > >>
    > >> On 4/11/2023 7:51 AM, Guo, Junfeng wrote:
    > >>
    > >> Hi Junfeng, message moved down.
    > >>
    > >>>
    > >>>> -----Original Message-----
    > >>>> From: Rushil Gupta <[email protected]
    <mailto:[email protected]>>
    > >>>> Sent: Tuesday, April 11, 2023 12:59
    > >>>> To: Zhang, Qi Z <[email protected]
    <mailto:[email protected]>>; [email protected]
    <mailto:[email protected]>
    > >>>> Cc: Richardson, Bruce <[email protected]
    <mailto:[email protected]>>;
    > [email protected] <mailto:[email protected]>;
    > >>>> Rushil Gupta <[email protected]
    <mailto:[email protected]>>; Guo, Junfeng
Quoted 8 lines
    > >>>> <[email protected] <mailto:[email protected]>>
    > >>>> Subject: [PATCH 1/1] net/gve: update base code for DQO
    > >>>>
    > >>>> Update gve base code to support DQO.
    > >>>>
    > >>>> This patch is based on this:
    > >>>>
    >
https://patchwork.dpdk.org/project/dpdk/list/?series=27647&state=*
Quoted 10 lines
<https://patchwork.dpdk.org/project/dpdk/list/?series=27647&state=*
> >>>>
> >>>> Signed-off-by: Rushil Gupta <[email protected] <mailto:[email protected]>>
> >>>> Signed-off-by: Junfeng Guo <[email protected] <mailto:[email protected]>>
> >>> Hi Ferruh & Bruce,
> >>>
> >>> This patch contains few lines change for the MIT licensed gve
base
Quoted 16 lines
Quoted 2 lines
code.
Quoted 1 line
Quoted 1 line
Quoted 1 line
Note that there is no new files added, just some minor code
update.
> >>>
> >>> Do we need to ask for special approval from the Tech Board for this?
> >>> Please help give some advice and also help review this patch. Thanks!
> >>>
> >>
> >> Once the MIT license exception is in place, as far as I know no more
> >> approval is required per change.
> >
> > Got it, thanks the comment!
> >
Quoted 8 lines
> > Then we may also need your help to review, as well as the coming patch
> > set for GVE PMD enhancement for DPDK 23.07. Thanks in advance! > >
> >>
> >>> BTW, Google will also help replace all the base code under MIT > license
> >>> with the ones under BSD-3 license soon, which would make
things
Quoted 4 lines
Quoted 4 lines
more
Quoted 3 lines
Quoted 3 lines
Quoted 2 lines
easier.
Quoted 8 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Is this different from base code under DPDK is changing license
    [1] ?
    > >>
    > >>
    > >> [1]
    > >>
    >
https://patches.dpdk.org/project/dpdk/list/?series=27570&state=%2A&ar <
https://patches.dpdk.org/project/dpdk/list/?series=27570&state=%2A&ar>
Quoted 7 lines
Quoted 4 lines
Quoted 4 lines
Quoted 2 lines
chive=both
The patch set of the above link only contains the processing of
replace
> the
> > MIT licensed base code with the BSD-3 licensed base code. After
some
Quoted 17 lines
Quoted 1 line
Quoted 1 line
discussion, we think Google is in the right place to do that
    work. And
    > they
    > > are working on that now.
    > >
    >
    > Is the Google GVE driver [2] in the process of changing license
    from MIT
    > to BSD-3?
    >
    >
    > [2]
    > https://github.com/GoogleCloudPlatform/compute-virtual-ethernet-
    <https://github.com/GoogleCloudPlatform/compute-virtual-ethernet->
    > linux/tree/v1.3.0/google/gve
    >
Quoted 8 lines
    I'm not sure, I don't know much about Google's plans.
    Maybe they could provide some info here. Thanks!

    @Rushil Gupta

    >
    >
    > > This patch is mainly for the feature upstreaming of DPDK 23.07.
It
Quoted 10 lines
Quoted 2 lines
contains
Quoted 1 line
only the code part, following previous license statements,
without any
> > license change.
> >
> > This patch is separated and sent by Google, to ensure there is no license
> > violation.
> >
> > BTW, about the feature of GVE PMD enhancement, the rest code
are all
Quoted 11 lines
Quoted 1 line
Quoted 1 line
about BSD-3 licensed files, and that patch set will be sent out
    soon.
    > >
    > > Thanks!
I have got the green light internally to switch to BSD-3 license for code under base directory. If it is ok with the tech board, I can send a patch right away with all of the base files changed to BSD-3 which can be merged after this patch. Please let me know what you think. We are also about to upstream driver
code:
https://github.com/GoogleCloudPlatform/compute-virtual-ethernet-freebsd <
https://github.com/GoogleCloudPlatform/compute-virtual-ethernet-freebsd>
to FreeBSD as well so you will see similar code under BSD license soon in freebsd repo.
+techboard
There is already a patch [1] to change dpdk gve driver license from MIT to BSD-3, what will be different in the patch you are planning to send?
Or overall I am trying to understand what is this new development on top of existing patch.

Ferruh Yigit

2023-04-14 11:00 UTC #11 lore raw

Re: [PATCH 1/1] net/gve: update base code for DQO

Quoted 4 lines · Rushil Gupta

I want to highlight that we wish to keep license changes separate from this patch (probably for 23.11). This patch is to simply support basic structures for the DQO data path.

+1 to separate it license patch.

Ferruh Yigit

Applied

2023-05-04 08:30 UTC #12 lore raw

Re: [PATCH 1/1] net/gve: update base code for DQO

In reply to Rushil Gupta

Quoted 7 lines · Rushil Gupta

Update gve base code to support DQO.
This patch is based on this:
https://patchwork.dpdk.org/project/dpdk/list/?series=27647&state=*
Signed-off-by Rushil Gupta <[email protected]>
Signed-off-by Junfeng Guo <[email protected]>

Applied to dpdk-next-net/main, thanks.