usb: dwc3: core: add support for disabling High-speed park mode
Subsystems (3)
PATCH v2 1/2 usb: dwc3: core: add support for disabling High-speed park mode
Setting the PARKMODE_DISABLE_HS bit in the DWC3_USB3_GUCTL1. When this bit is set to '1' all HS bus instances in park mode are disabled
For some USB wifi devices, if enable this feature it will reduce the performance. Therefore, add an option for disabling HS park mode by device-tree.
In Synopsys's dwc3 data book:
In a few high speed devices when an IN request is sent within 900ns of the ACK of the previous packet, these devices send a NAK. When connected to these devices, if required, the software can disable the park mode if you see performance drop in your system. When park mode is disabled, pipelining of multiple packet is disabled and instead one packet at a time is requested by the scheduler. This allows up to 12 NAKs in a micro-frame and improves performance of these slow devices.
--- drivers/usb/dwc3/core.c | 5 +++++ drivers/usb/dwc3/core.h | 4 ++++ 2 files changed, 9 insertions(+)
drivers/usb/dwc3/core.c +5 -0
@@ -1233,6 +1233,9 @@ static int dwc3_core_init(struct dwc3 *dwc)if (dwc->parkmode_disable_ss_quirk) reg |=DWC3_GUCTL1_PARKMODE_DISABLE_SS ; +if (dwc->parkmode_disable_hs_quirk) + reg |=DWC3_GUCTL1_PARKMODE_DISABLE_HS ; + if (DWC3_VER_IS_WITHIN(DWC3, 290A, ANY) && (dwc->maximum_speed ==USB_SPEED_HIGH || dwc->maximum_speed ==USB_SPEED_FULL ))
@@ -1555,6 +1558,8 @@ static void dwc3_get_properties(struct dwc3 *dwc) "snps,resume-hs-terminations"); dwc->parkmode_disable_ss_quirk =device_property_read_bool (dev,"snps,parkmode-disable-ss-quirk" ); + dwc->parkmode_disable_hs_quirk =device_property_read_bool (dev, +"snps,parkmode-disable-hs-quirk" ); dwc->gfladj_refclk_lpm_sel =device_property_read_bool (dev,"snps,gfladj-refclk-lpm-sel-quirk" );
drivers/usb/dwc3/core.h +4 -0
@@ -263,6 +263,7 @@#define DWC3_GUCTL1_DEV_FORCE_20_CLK_FOR_30_CLK BIT(26)#define DWC3_GUCTL1_DEV_L1_EXIT_BY_HW BIT(24)#define DWC3_GUCTL1_PARKMODE_DISABLE_SS BIT(17) +#define DWC3_GUCTL1_PARKMODE_DISABLE_HS BIT(16)#define DWC3_GUCTL1_RESUME_OPMODE_HS_HOST BIT(10)/* Global Status Register */
@@ -1102,6 +1103,8 @@ struct dwc3_scratchpad_array {* generation after resume from suspend. * @parkmode_disable_ss_quirk: set if we need to disable all SuperSpeed * instances in park mode. +* @parkmode_disable_hs_quirk: set if we need to disable all HishSpeed +* instances in park mode. * @tx_de_emphasis_quirk: set if we enable Tx de-emphasis quirk * @tx_de_emphasis: Tx de-emphasis value * 0 - -6dB de-emphasis
@@ -1318,6 +1321,7 @@ struct dwc3 { unsigned dis_tx_ipgap_linecheck_quirk:1; unsigned resume_hs_terminations:1; unsigned parkmode_disable_ss_quirk:1; + unsigned parkmode_disable_hs_quirk:1; unsigned gfladj_refclk_lpm_sel:1; unsigned tx_de_emphasis_quirk:1;
Signature · 1 line
2.34.1
PATCH v2 2/2 dt-bindings: usb: snps,dwc3: Add 'snps,parkmode-disable-hs-quirk' quirk
Add a new 'snps,parkmode-disable-hs-quirk' DT quirk to dwc3 core for disable the high-speed parkmode.
--- Documentation/devicetree/bindings/usb/snps,dwc3.yaml | 5 +++++ 1 file changed, 5 insertions(+)
Documentation/devicetree/bindings/usb/snps,dwc3.yaml +5 -0
@@ -232,6 +232,11 @@ properties: When set, all SuperSpeed bus instances in park mode are disabled. type: boolean + snps,parkmode-disable-hs-quirk: + description: + When set, all HighSpeed bus instances in park mode are disabled. + type: boolean + snps,dis_metastability_quirk: description: When set, disable metastability workaround. CAUTION! Use only if you are
Signature · 1 line
2.34.1
Re: [PATCH v2 2/2] dt-bindings: usb: snps,dwc3: Add 'snps,parkmode-disable-hs-quirk' quirk
+Rob
Quoted 27 lines · Stanley Chang
Add a new 'snps,parkmode-disable-hs-quirk' DT quirk to dwc3 core for disable the high-speed parkmode.
Signed-off-by Stanley Chang <[email protected]>--- Documentation/devicetree/bindings/usb/snps,dwc3.yaml | 5 +++++ 1 file changed, 5 insertions(+)Documentation/devicetree/bindings/usb/snps,dwc3.yaml +5
-0@@ -232,6 +232,11 @@ properties: When set, all SuperSpeed bus instances in park mode are disabled. type: boolean + snps,parkmode-disable-hs-quirk: + description: + When set, all HighSpeed bus instances in park mode are disabled. + type: boolean + snps,dis_metastability_quirk: description: When set, disable metastability workaround. CAUTION! Use only if you areSignature · 1 line
2.34.1
Please also Cc the devicetree maintainer.
Thanks,
Thinh
Re: [PATCH v2 2/2] dt-bindings: usb: snps,dwc3: Add 'snps,parkmode-disable-hs-quirk' quirk
Quoted 19 lines · Thinh Nguyen
+Rob
Quoted 16 lines · Stanley Chang
Add a new 'snps,parkmode-disable-hs-quirk' DT quirk to dwc3 core for disable the high-speed parkmode.
Signed-off-by Stanley Chang <[email protected]>--- Documentation/devicetree/bindings/usb/snps,dwc3.yaml | 5 +++++ 1 file changed, 5 insertions(+)Documentation/devicetree/bindings/usb/snps,dwc3.yaml +0
-0@@ -232,6 +232,11 @@ properties: When set, all SuperSpeed bus instances in park mode are disabled. type: boolean
Quoted 14 lines
Quoted 11 lines
Documentation/devicetree/bindings/usb/snps,dwc3.yaml +5
-0+ snps,parkmode-disable-hs-quirk: + description: + When set, all HighSpeed bus instances in park mode are disabled. + type: boolean + snps,dis_metastability_quirk: description: When set, disable metastability workaround. CAUTION! Use only if you areSignature · 1 line
2.34.1Please also Cc the devicetree maintainer.
No, please use scripts/get_maintainers.pl
Best regards,
Krzysztof
Re: [PATCH v2 2/2] dt-bindings: usb: snps,dwc3: Add 'snps,parkmode-disable-hs-quirk' quirk
In reply to Stanley ChangQuoted 7 lines · Stanley Chang
Add a new 'snps,parkmode-disable-hs-quirk' DT quirk to dwc3 core for disable the high-speed parkmode.
Signed-off-by Stanley Chang <[email protected]>--- Documentation/devicetree/bindings/usb/snps,dwc3.yaml | 5 +++++ 1 file changed, 5 insertions(+)
NAK, so Greg won't pick it up too fast. :)
Please use scripts/get_maintainers.pl to get a list of necessary people and lists to CC. It might happen, that command when run on an older kernel, gives you outdated entries. Therefore please be sure you base your patches on recent Linux kernel.
Best regards,
Krzysztof
RE: [PATCH v2 2/2] dt-bindings: usb: snps,dwc3: Add 'snps,parkmode-disable-hs-quirk' quirk
Quoted 11 lines · Stanley Chang
Quoted 7 lines
Add a new 'snps,parkmode-disable-hs-quirk' DT quirk to dwc3 core for disable the high-speed parkmode.
Signed-off-by Stanley Chang <[email protected]>--- Documentation/devicetree/bindings/usb/snps,dwc3.yaml | 5 +++++ 1 file changed, 5 insertions(+)NAK, so Greg won't pick it up too fast. :)
Quoted 8 lines
Please use
scripts/get_maintainers.plto get a list of necessary people and lists to CC. It might happen, that command when run on an older kernel, gives you outdated entries. Therefore please be sure you base your patches on recent Linux kernel.Best regards,
Krzysztof
CC more maintainers by using scripts/get_maintainers.pl
Thanks,
Stanley
Re: [PATCH v2 2/2] dt-bindings: usb: snps,dwc3: Add 'snps,parkmode-disable-hs-quirk' quirk
Quoted 16 lines · Stanley Chang[昌育德]
Quoted 16 lines · Stanley Chang
Quoted 7 lines
Add a new 'snps,parkmode-disable-hs-quirk' DT quirk to dwc3 core for disable the high-speed parkmode.
Signed-off-by Stanley Chang <[email protected]>--- Documentation/devicetree/bindings/usb/snps,dwc3.yaml | 5 +++++ 1 file changed, 5 insertions(+)NAK, so Greg won't pick it up too fast. :)
Please use
scripts/get_maintainers.plto get a list of necessary people and lists to CC. It might happen, that command when run on an older kernel, gives you outdated entries. Therefore please be sure you base your patches on recent Linux kernel.
Quoted 6 lines
Quoted 3 lines
Best regards,
KrzysztofCC more maintainers by using
scripts/get_maintainers.pl
This does not work like this.
Best regards,
Krzysztof
PATCH v2 2/2 dt-bindings: usb: snps,dwc3: Add 'snps,parkmode-disable-hs-quirk' quirk
In reply to Stanley ChangAdd a new 'snps,parkmode-disable-hs-quirk' DT quirk to dwc3 core for disable the high-speed parkmode.
--- Documentation/devicetree/bindings/usb/snps,dwc3.yaml | 5 +++++ 1 file changed, 5 insertions(+)
Documentation/devicetree/bindings/usb/snps,dwc3.yaml +5 -0
@@ -232,6 +232,11 @@ properties: When set, all SuperSpeed bus instances in park mode are disabled. type: boolean + snps,parkmode-disable-hs-quirk: + description: + When set, all HighSpeed bus instances in park mode are disabled. + type: boolean + snps,dis_metastability_quirk: description: When set, disable metastability workaround. CAUTION! Use only if you are
Signature · 1 line
2.34.1
Re: [PATCH v2 2/2] dt-bindings: usb: snps,dwc3: Add 'snps,parkmode-disable-hs-quirk' quirk
Quoted 2 lines · Stanley Chang
Add a new 'snps,parkmode-disable-hs-quirk' DT quirk to dwc3 core for disable the high-speed parkmode.
Please use scripts/get_maintainers.pl to get a list of necessary people and lists to CC. It might happen, that command when run on an older kernel, gives you outdated entries. Therefore please be sure you base your patches on recent Linux kernel.
It's the second time I am writing it. I don't understand why you keep ignoring it.
Your commit msg does not explain why do we need it.
Quoted 11 lines
Signed-off-by Stanley Chang <[email protected]>--- Documentation/devicetree/bindings/usb/snps,dwc3.yaml | 5 +++++ 1 file changed, 5 insertions(+)Documentation/devicetree/bindings/usb/snps,dwc3.yaml +0
-0
Documentation/devicetree/bindings/usb/snps,dwc3.yaml properties: · line 237
Quoted 6 lines
Documentation/devicetree/bindings/usb/snps,dwc3.yaml +3
-0@@ -232,6 +232,11 @@ properties: When set, all SuperSpeed bus instances in park mode are disabled. type: boolean + snps,parkmode-disable-hs-quirk: + description: + When set, all HighSpeed bus instances in park mode are disabled.
Why?
Best regards,
Krzysztof
RE: [PATCH v2 2/2] dt-bindings: usb: snps,dwc3: Add 'snps,parkmode-disable-hs-quirk' quirk
Quoted 12 lines · Stanley Chang
Quoted 2 lines
Add a new 'snps,parkmode-disable-hs-quirk' DT quirk to dwc3 core for disable the high-speed parkmode.
Please use
scripts/get_maintainers.plto get a list of necessary people and lists to CC. It might happen, that command when run on an older kernel, gives you outdated entries. Therefore please be sure you base your patches on recent Linux kernel.It's the second time I am writing it. I don't understand why you keep ignoring it.
Sorry for the confusion.
In the beginning I didn't have cc all maintainers. I'll resubmit a new review thread.
Please ignore this email.
Quoted 1 line
Your commit msg does not explain why do we need it.
I will add it at new patch.
Quoted 15 lines
Quoted 15 lines
Signed-off-by Stanley Chang <[email protected]>--- Documentation/devicetree/bindings/usb/snps,dwc3.yaml | 5 +++++ 1 file changed, 5 insertions(+)Documentation/devicetree/bindings/usb/snps,dwc3.yaml +0
-0@@ -232,6 +232,11 @@ properties: When set, all SuperSpeed bus instances in park mode are disabled. type: boolean
Quoted 6 lines
Documentation/devicetree/bindings/usb/snps,dwc3.yaml properties: · line 237
Quoted 3 lines
Documentation/devicetree/bindings/usb/snps,dwc3.yaml +3
-0+ snps,parkmode-disable-hs-quirk: + description: + When set, all HighSpeed bus instances in park mode are disabled.Why?
For some USB wifi devices, if enable this feature it will reduce the performance. Therefore, add an option for disabling HS park mode by device-tree.
Thanks,
Stanley
Quoted 77 lines · Stanley Chang
Setting the
PARKMODE_DISABLE_HSbit in theDWC3_USB3_GUCTL1. When this bit is set to '1' all HS bus instances in park mode are disabledFor some USB wifi devices, if enable this feature it will reduce the performance. Therefore, add an option for disabling HS park mode by device-tree.
In Synopsys's dwc3 data book:
In a few high speed devices when an IN request is sent within 900ns of the ACK of the previous packet, these devices send a NAK. When connected to these devices, if required, the software can disable the park mode if you see performance drop in your system. When park mode is disabled, pipelining of multiple packet is disabled and instead one packet at a time is requested by the scheduler. This allows up to 12 NAKs in a micro-frame and improves performance of these slow devices.Signed-off-by Stanley Chang <[email protected]>--- drivers/usb/dwc3/core.c | 5 +++++ drivers/usb/dwc3/core.h | 4 ++++ 2 files changed, 9 insertions(+)drivers/usb/dwc3/core.c +5
-0@@ -1233,6 +1233,9 @@ static int dwc3_core_init(struct dwc3 *dwc)if (dwc->parkmode_disable_ss_quirk) reg |=DWC3_GUCTL1_PARKMODE_DISABLE_SS ; +if (dwc->parkmode_disable_hs_quirk) + reg |=DWC3_GUCTL1_PARKMODE_DISABLE_HS ; + if (DWC3_VER_IS_WITHIN(DWC3, 290A, ANY) && (dwc->maximum_speed ==USB_SPEED_HIGH || dwc->maximum_speed ==USB_SPEED_FULL ))@@ -1555,6 +1558,8 @@ static void dwc3_get_properties(struct dwc3 *dwc) "snps,resume-hs-terminations"); dwc->parkmode_disable_ss_quirk =device_property_read_bool (dev,"snps,parkmode-disable-ss-quirk" ); + dwc->parkmode_disable_hs_quirk =device_property_read_bool (dev, +"snps,parkmode-disable-hs-quirk" ); dwc->gfladj_refclk_lpm_sel =device_property_read_bool (dev,"snps,gfladj-refclk-lpm-sel-quirk" );drivers/usb/dwc3/core.h +4
-0@@ -263,6 +263,7 @@#define DWC3_GUCTL1_DEV_FORCE_20_CLK_FOR_30_CLK BIT(26)#define DWC3_GUCTL1_DEV_L1_EXIT_BY_HW BIT(24)#define DWC3_GUCTL1_PARKMODE_DISABLE_SS BIT(17) +#define DWC3_GUCTL1_PARKMODE_DISABLE_HS BIT(16)#define DWC3_GUCTL1_RESUME_OPMODE_HS_HOST BIT(10)/* Global Status Register */ @@ -1102,6 +1103,8 @@ struct dwc3_scratchpad_array {* generation after resume from suspend. * @parkmode_disable_ss_quirk: set if we need to disable all SuperSpeed * instances in park mode. +* @parkmode_disable_hs_quirk: set if we need to disable all HishSpeed +* instances in park mode. * @tx_de_emphasis_quirk: set if we enable Tx de-emphasis quirk * @tx_de_emphasis: Tx de-emphasis value * 0 - -6dB de-emphasis @@ -1318,6 +1321,7 @@ struct dwc3 { unsigned dis_tx_ipgap_linecheck_quirk:1; unsigned resume_hs_terminations:1; unsigned parkmode_disable_ss_quirk:1; + unsigned parkmode_disable_hs_quirk:1; unsigned gfladj_refclk_lpm_sel:1; unsigned tx_de_emphasis_quirk:1;Signature · 1 line
2.34.1
Thanks,
Thinh
CC more maintainers by using scripts/get_maintainers.pl
Greg Kroah-Hartman
maintainerQuoted 3 lines · Stanley Chang[昌育德]
CC more maintainers by using
scripts/get_maintainers.pl
I do not see any message here, so I am totally confused.
You have to use the script when determining who to send the patch to, you can't do it after the fact like this as it will not work at all.
greg k-h
Quoted 6 lines · Stanley Chang[昌育德]
Quoted 3 lines
CC more maintainers by using
scripts/get_maintainers.pl
Quoted 7 lines
I do not see any message here, so I am totally confused.
You have to use the script when determining who to send the patch to, you can't do it after the fact like this as it will not work at all.
greg k-h
Sorry for the confusion.
In the beginning I didn't have cc all maintainers. I'll resubmit a new review thread.
Please ignore this email.