roms: add back edk2-basetools target
PATCH 1/1 roms: add back edk2-basetools target
The efi nic boot rom builds depend on this, they need the EfiRom utility from edk2 BaseTools.
--- roms/Makefile | 3 +++ 1 file changed, 3 insertions(+)
roms/Makefile +3 -0
@@ -153,6 +153,9 @@ efi: rm -f ../pc-bios/edk2-*.fd.bz2 bzip2 --verbose ../pc-bios/edk2-*.fd +edk2-basetools: + python3 edk2-build.py --config edk2-build.config -m none + opensbi32-generic: $(MAKE) -C opensbi \ CROSS_COMPILE=$(riscv32_cross_prefix) \
Signature · 1 line
2.39.2
Tue, 11 Apr 2023 12:17:09 +0200 Gerd Hoffmann <[email protected]>:
roms/Makefile efi: · line 157
Quoted 1 line
roms/Makefile +1
-0+ python3 edk2-build.py --config edk2-build.config -m none
Is '-m none' correct?
I think previously the result was just a native build. Now that introduced .config attempts cross builds.
Maybe that detail must be mentioned in the release notes, and the build requirements.
Olaf
Quoted 5 lines · Olaf Hering
Tue, 11 Apr 2023 12:17:09 +0200 Gerd Hoffmann <[email protected]>:
roms/Makefile efi: · line 157
Quoted 1 line
roms/Makefile +1
-0+ python3 edk2-build.py --config edk2-build.config -m noneIs '-m none' correct?
Yes. BaseTools are built no matter what because any edk2 stuff depends on them.
take care,
Gerd
Tue, 11 Apr 2023 12:17:09 +0200 Gerd Hoffmann <[email protected]>:
roms/Makefile efi: · line 157
Quoted 3 lines
+++ b/roms/Makefile
roms/Makefile +2
-0+edk2-basetools: + python3 edk2-build.py --config edk2-build.config -m none
I think that needs to be $(PYTHON), because plain 'python3' may not be the required python version.
In addition, a global EDK2_OPTIONS may allow to pass arbitrary options to their build wrapper, like -j1.
Olaf