mtd: onenand: omap2: Drop obsolete dependency on COMPILE_TEST
Subsystems (3)
PATCH RESEND 1/1 mtd: onenand: omap2: Drop obsolete dependency on COMPILE_TEST
Since commit 0166dc11be91 ("of: make CONFIG_OF user selectable"), it is possible to test-build any driver which depends on OF on any architecture by explicitly selecting OF. Therefore depending on COMPILE_TEST as an alternative is no longer needed.
It is actually better to always build such drivers with OF enabled, so that the test builds are closer to how each driver will actually be built on its intended target. Building them without OF may not test much as the compiler will optimize out potentially large parts of the code. In the worst case, this could even pop false positive warnings. Dropping COMPILE_TEST here improves the quality of our testing and avoids wasting time on non-existent issues.
---
Even though this was supposedly accepted a few months ago already, I can't find this commit, neither upstream nor in the nand/next, therefore resending.
drivers/mtd/nand/onenand/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/mtd/nand/onenand/Kconfig +1 -1
@@ -25,7 +25,7 @@ config MTD_ONENAND_GENERIC config MTD_ONENAND_OMAP2 tristate "OneNAND on OMAP2/OMAP3 support" depends on ARCH_OMAP2 || ARCH_OMAP3 || (COMPILE_TEST && ARM) - depends on OF || COMPILE_TEST + depends on OF depends on OMAP_GPMC help Support for a OneNAND flash device connected to an OMAP2/OMAP3 SoC
Signature · 2 lines
Jean Delvare SUSE L3 Support
Miquel Raynal
maintainerHi Jean,
[email protected] wrote on Fri, 7 Apr 2023 19:04:53 +0200:
Quoted 18 lines
Since commit
0166dc11be91("of: makeCONFIG_OFuser selectable"), it is possible to test-build any driver which depends on OF on any architecture by explicitly selecting OF. Therefore depending onCOMPILE_TESTas an alternative is no longer needed.It is actually better to always build such drivers with OF enabled, so that the test builds are closer to how each driver will actually be built on its intended target. Building them without OF may not test much as the compiler will optimize out potentially large parts of the code. In the worst case, this could even pop false positive warnings. Dropping
COMPILE_TESThere improves the quality of our testing and avoids wasting time on non-existent issues.Signed-off-by Jean Delvare <[email protected]>Cc Kyungmin Park <[email protected]>Cc Miquel Raynal <[email protected]>Cc Richard Weinberger <[email protected]>Cc Vignesh Raghavendra <[email protected]>
Quoted 4 lines
---
Even though this was supposedly accepted a few months ago already, I can't find this commit, neither upstream nor in the nand/next, therefore resending.
I have no idea what I did wrong but I definitely messed up, I can't find this patch while it is marked Accepted in patchwork and I actually answered that I applied it. It is especially strange since its cousin applying to raw NAND was correctly taken. Sorry for the mess, I'll really take it this time.
Quoted 9 lines
drivers/mtd/nand/onenand/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/mtd/nand/onenand/Kconfig config MTD_ONENAND_GENERIC · line 31
Quoted 8 lines
drivers/mtd/nand/onenand/Kconfig +1
-1@@ -25,7 +25,7 @@ config MTD_ONENAND_GENERIC config MTD_ONENAND_OMAP2 tristate "OneNAND on OMAP2/OMAP3 support" depends on ARCH_OMAP2 || ARCH_OMAP3 || (COMPILE_TEST && ARM) - depends on OF || COMPILE_TEST + depends on OF depends on OMAP_GPMC help Support for a OneNAND flash device connected to an OMAP2/OMAP3 SoC
Thanks,
Miquèl
Quoted 13 lines · Jean Delvare
Since commit
0166dc11be91("of: makeCONFIG_OFuser selectable"), it is possible to test-build any driver which depends on OF on any architecture by explicitly selecting OF. Therefore depending onCOMPILE_TESTas an alternative is no longer needed.It is actually better to always build such drivers with OF enabled, so that the test builds are closer to how each driver will actually be built on its intended target. Building them without OF may not test much as the compiler will optimize out potentially large parts of the code. In the worst case, this could even pop false positive warnings. Dropping
COMPILE_TESThere improves the quality of our testing and avoids wasting time on non-existent issues.
Quoted 5 lines
Signed-off-by Jean Delvare <[email protected]>Cc Kyungmin Park <[email protected]>Cc Miquel Raynal <[email protected]>Cc Richard Weinberger <[email protected]>Cc Vignesh Raghavendra <[email protected]>
Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git nand/next, thanks.
Miquel