Add support for Thecus N2350 board
Subsystems (3)
v2 cover Add support for Thecus N2350 board
Thecus N2350 is a NAS based on Marvell Armada 385 SoC.
Board Specification:
- Marvel MV88F6820 Dual Core at 1GHz
- 1 GiB DDR4 RAM
- 4MB Macronix mx25l3205d SPI flash
- 512MB Hynix H27U4G8F2DTR-BC NAND flash
- I2C
- 2x USB 3.0
- 1x GBE LAN port (PHY: Marvell 88E1510)
- 2x SATA (hot swap slots)
- 3x buttons
- 10x LEDS
- serial console
Changes in v2:
- Add marvell,38x.yaml. For now, add this binding to the Marvell directory to keep it consistent with other Marvell yaml files. At a later date and a separate patch, consolidate the Marvell yaml files into marvell.yaml.
- Fix various DT bindings conformance (too numerous to list)
- Vendor prefix is not necessary, so remove it.
Tony Dinh (2):
ARM: dts: mvebu: Add device tree binding for Marvell Armada 38x
ARM: dts: mvebu: add Thecus N2350 board DTS
.../bindings/arm/marvell/armada-38x.yaml | 27 ++ arch/arm/boot/dts/Makefile | 1 + arch/arm/boot/dts/armada-385-thecus-n2350.dts | 432 ++++++++++++++++++ 3 files changed, 460 insertions(+) create mode 100644 Documentation/devicetree/bindings/arm/marvell/armada-38x.yaml create mode 100644 arch/arm/boot/dts/armada-385-thecus-n2350.dts
Signature · 1 line
2.30.2
PATCH v2 1/2 ARM: dts: mvebu: Add device tree binding for Marvell Armada 38x
Add device tree binding for Marvell Armada 38x.
---
Changes in v2:
- Add marvell,38x.yaml. For now, add this binding to the Marvell directory to keep it consistent with other Marvell yaml files. At a later date and a separate patch, consolidate the Marvell yaml files into marvell.yaml.
.../bindings/arm/marvell/armada-38x.yaml | 27 +++++++++++++++++++ 1 file changed, 27 insertions(+) create mode 100644 Documentation/devicetree/bindings/arm/marvell/armada-38x.yaml
Documentation/devicetree/bindings/arm/marvell/armada-38x.yaml new file +27 -0
@@ -0,0 +1,27 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/arm/marvell/marvell,38x.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Marvell Armada 38x Platforms + +maintainers: + - Gregory CLEMENT <[email protected]> + - Andrew Lunn <[email protected]> + +properties: + $nodename: + const: '/' + compatible: + oneOf: + + - description: Armada 380 SoC + items: + - const: marvell,armada380 + + - description: Armada 385 SoC + items: + - const: marvell,armada385 + +additionalProperties: true
Signature · 1 line
2.30.2
Re: [PATCH v2 1/2] ARM: dts: mvebu: Add device tree binding for Marvell Armada 38x
Quoted 3 lines · Tony Dinh
Add device tree binding for Marvell Armada 38x.
Signed-off-by Tony Dinh <[email protected]>
Use subject prefixes matching the subsystem (which you can get for example with git log --oneline -- DIRECTORY_OR_FILE on the directory your patch is touching).
This is not DTS. These are bindings.
Quoted 11 lines
---
Changes in v2:
- Add marvell,38x.yaml. For now, add this binding to the Marvell directory to keep it consistent with other Marvell yaml files. At a later date and a separate patch, consolidate the Marvell yaml files intomarvell.yaml..../bindings/arm/marvell/armada-38x.yaml | 27 +++++++++++++++++++ 1 file changed, 27 insertions(+) create mode 100644 Documentation/devicetree/bindings/arm/marvell/armada-38x.yaml
marvell,armada-38x.yaml
Or just squash it with existing armada bindings... Keeping one binding per one SoC group is a bit a lot.
Documentation/devicetree/bindings/arm/marvell/armada-38x.yaml line 4
Quoted 11 lines
Documentation/devicetree/bindings/arm/marvell/armada-38x.yaml new file +4
-0@@ -0,0 +1,27 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/arm/marvell/marvell,38x.yaml#
Does not look like you tested the bindings. Please run make dt_binding_check (see Documentation/devicetree/bindings/writing-schema.rst for instructions).
Best regards,
Krzysztof
Rob Herring
maintainerRe: [PATCH v2 1/2] ARM: dts: mvebu: Add device tree binding for Marvell Armada 38x
In reply to Tony DinhQuoted 11 lines · Tony Dinh
Add device tree binding for Marvell Armada 38x.
Signed-off-by Tony Dinh <[email protected]>---
Changes in v2:
- Add marvell,38x.yaml. For now, add this binding to the Marvell directory to keep it consistent with other Marvell yaml files. At a later date and a separate patch, consolidate the Marvell yaml files intomarvell.yaml.
Quoted 4 lines
.../bindings/arm/marvell/armada-38x.yaml | 27 +++++++++++++++++++ 1 file changed, 27 insertions(+) create mode 100644 Documentation/devicetree/bindings/arm/marvell/armada-38x.yaml
My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13):
yamllint warnings/errors:
dtschema/dtc warnings/errors:./Documentation/devicetree/bindings/arm/marvell/armada-38x.yaml: $id: relative path/filename doesn't match actual path or filename
expected: http://devicetree.org/schemas/arm/marvell/armada-38x.yaml#
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/[email protected]
The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
Re: [PATCH v2 1/2] ARM: dts: mvebu: Add device tree binding for Marvell Armada 38x
Hi Rob,
Hi Krzysztof,
Quoted 39 lines · Rob Herring
Quoted 11 lines · Tony Dinh
Add device tree binding for Marvell Armada 38x.
Signed-off-by Tony Dinh <[email protected]>---
Changes in v2:
- Add marvell,38x.yaml. For now, add this binding to the Marvell directory to keep it consistent with other Marvell yaml files. At a later date and a separate patch, consolidate the Marvell yaml files intomarvell.yaml.Quoted 4 lines
.../bindings/arm/marvell/armada-38x.yaml | 27 +++++++++++++++++++ 1 file changed, 27 insertions(+) create mode 100644 Documentation/devicetree/bindings/arm/marvell/armada-38x.yamlMy bot found errors running 'make DT_CHECKER_FLAGS=-m
dt_binding_check' on your patch (DT_CHECKER_FLAGSis new in v5.13):yamllint warnings/errors:
dtschema/dtc warnings/errors:
./Documentation/devicetree/bindings/arm/marvell/armada-38x.yaml: $id: relative path/filename doesn't match actual path or filename
expected: http://devicetree.org/schemas/arm/marvell/armada-38x.yaml#doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/[email protected]
The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch.
If you already ran 'make
dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date:
Quoted 6 lines
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note that
DT_SCHEMA_FILEScan be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
Thanks for the reviews. After running make dt_binding_check for it seems like hours (on a dual-core 1.8GHz ARM box), I got impatient and used
make CHECK_DTBS=y armada-385-thecus-n2350.dtb
I'll move this to another faster box and run make dt_binding_check.
All the best,
Tony
Re: [PATCH v2 1/2] ARM: dts: mvebu: Add device tree binding for Marvell Armada 38x
Quoted 50 lines · Tony Dinh
Hi Rob,
Hi Krzysztof,Quoted 39 lines · Rob Herring
Quoted 11 lines · Tony Dinh
Add device tree binding for Marvell Armada 38x.
Signed-off-by Tony Dinh <[email protected]>---
Changes in v2:
- Add marvell,38x.yaml. For now, add this binding to the Marvell directory to keep it consistent with other Marvell yaml files. At a later date and a separate patch, consolidate the Marvell yaml files intomarvell.yaml.Quoted 4 lines
.../bindings/arm/marvell/armada-38x.yaml | 27 +++++++++++++++++++ 1 file changed, 27 insertions(+) create mode 100644 Documentation/devicetree/bindings/arm/marvell/armada-38x.yamlMy bot found errors running 'make DT_CHECKER_FLAGS=-m
dt_binding_check' on your patch (DT_CHECKER_FLAGSis new in v5.13):yamllint warnings/errors:
dtschema/dtc warnings/errors:
./Documentation/devicetree/bindings/arm/marvell/armada-38x.yaml: $id: relative path/filename doesn't match actual path or filename
expected: http://devicetree.org/schemas/arm/marvell/armada-38x.yaml#doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/[email protected]
The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch.
If you already ran 'make
dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date:Quoted 6 lines
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note that
DT_SCHEMA_FILEScan be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
Quoted 6 lines
Thanks for the reviews. After running make
dt_binding_checkfor it seems like hours (on a dual-core 1.8GHz ARM box), I got impatient and used
make CHECK_DTBS=y armada-385-thecus-n2350.dtbI'll move this to another faster box and run make
dt_binding_check.
So many questions...
1. Why do you have to run it on arm? Not on regular machine for work? No one of us does like that...
2. You are now mixing now two different commands. You were asked to run DT_SCHEMA_FILES
3. Read the provided guide how to speed it up. It runs within few seconds.
Best regards,
Krzysztof
Re: [PATCH v2 1/2] ARM: dts: mvebu: Add device tree binding for Marvell Armada 38x
Hi Krzysztof,
Quoted 57 lines · Krzysztof Kozlowski
Quoted 55 lines · Tony Dinh
Hi Rob,
Hi Krzysztof,Quoted 39 lines · Rob Herring
Quoted 11 lines · Tony Dinh
Add device tree binding for Marvell Armada 38x.
Signed-off-by Tony Dinh <[email protected]>---
Changes in v2:
- Add marvell,38x.yaml. For now, add this binding to the Marvell directory to keep it consistent with other Marvell yaml files. At a later date and a separate patch, consolidate the Marvell yaml files intomarvell.yaml.Quoted 4 lines
.../bindings/arm/marvell/armada-38x.yaml | 27 +++++++++++++++++++ 1 file changed, 27 insertions(+) create mode 100644 Documentation/devicetree/bindings/arm/marvell/armada-38x.yamlMy bot found errors running 'make DT_CHECKER_FLAGS=-m
dt_binding_check' on your patch (DT_CHECKER_FLAGSis new in v5.13):yamllint warnings/errors:
dtschema/dtc warnings/errors:
./Documentation/devicetree/bindings/arm/marvell/armada-38x.yaml: $id: relative path/filename doesn't match actual path or filename
expected: http://devicetree.org/schemas/arm/marvell/armada-38x.yaml#doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/[email protected]
The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch.
If you already ran 'make
dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date:Quoted 6 lines
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note that
DT_SCHEMA_FILEScan be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.Thanks for the reviews. After running make
dt_binding_checkfor it seems like hours (on a dual-core 1.8GHz ARM box), I got impatient and used
make CHECK_DTBS=y armada-385-thecus-n2350.dtb
Quoted 5 lines
Quoted 1 line
I'll move this to another faster box and run make
dt_binding_check.So many questions...
1. Why do you have to run it on arm? Not on regular machine for work? No one of us does like that...
It's just more convenient for me to run on ARM (I also build ARM kernels natively with distcc). This is not work related, so I cannot use machines at work. I can use my personal 4-core laptop, though.
Quoted 2 lines
2. You are now mixing now two different commands. You were asked to run
DT_SCHEMA_FILES
OK. As you can see, I have no experience with schema before.
Quoted 1 line
3. Read the provided guide how to speed it up. It runs within few seconds.
Good to know there is a way. Thanks for the advice!
All the best,
Tony
Quoted 5 lines
Best regards,
Krzysztof
Re: [PATCH v2 1/2] ARM: dts: mvebu: Add device tree binding for Marvell Armada 38x
In reply to Rob HerringHi Rob,
Quoted 39 lines · Rob Herring
Quoted 11 lines · Tony Dinh
Add device tree binding for Marvell Armada 38x.
Signed-off-by Tony Dinh <[email protected]>---
Changes in v2:
- Add marvell,38x.yaml. For now, add this binding to the Marvell directory to keep it consistent with other Marvell yaml files. At a later date and a separate patch, consolidate the Marvell yaml files intomarvell.yaml.Quoted 4 lines
.../bindings/arm/marvell/armada-38x.yaml | 27 +++++++++++++++++++ 1 file changed, 27 insertions(+) create mode 100644 Documentation/devicetree/bindings/arm/marvell/armada-38x.yamlMy bot found errors running 'make DT_CHECKER_FLAGS=-m
dt_binding_check' on your patch (DT_CHECKER_FLAGSis new in v5.13):yamllint warnings/errors:
dtschema/dtc warnings/errors:
./Documentation/devicetree/bindings/arm/marvell/armada-38x.yaml: $id: relative path/filename doesn't match actual path or filename
expected: http://devicetree.org/schemas/arm/marvell/armada-38x.yaml#doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/[email protected]
The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch.
If you already ran 'make
dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date:
Quoted 6 lines
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note that
DT_SCHEMA_FILEScan be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
Would dt-schema in Debian 12 work? or must it be the latest dtschema installed by pip3 or from GitHub?
Thanks,
Tony
Re: [PATCH v2 1/2] ARM: dts: mvebu: Add device tree binding for Marvell Armada 38x
Quoted 44 lines · Tony Dinh
Hi Rob,
Quoted 41 lines · Rob Herring
Quoted 11 lines · Tony Dinh
Add device tree binding for Marvell Armada 38x.
Signed-off-by Tony Dinh <[email protected]>---
Changes in v2:
- Add marvell,38x.yaml. For now, add this binding to the Marvell directory to keep it consistent with other Marvell yaml files. At a later date and a separate patch, consolidate the Marvell yaml files intomarvell.yaml.Quoted 4 lines
.../bindings/arm/marvell/armada-38x.yaml | 27 +++++++++++++++++++ 1 file changed, 27 insertions(+) create mode 100644 Documentation/devicetree/bindings/arm/marvell/armada-38x.yamlMy bot found errors running 'make DT_CHECKER_FLAGS=-m
dt_binding_check' on your patch (DT_CHECKER_FLAGSis new in v5.13):yamllint warnings/errors:
dtschema/dtc warnings/errors:
./Documentation/devicetree/bindings/arm/marvell/armada-38x.yaml: $id: relative path/filename doesn't match actual path or filename
expected: http://devicetree.org/schemas/arm/marvell/armada-38x.yaml#doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/[email protected]
The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch.
If you already ran 'make
dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date:pip3 install dtschema --upgrade
Quoted 7 lines
Quoted 4 lines
Please check and re-submit after running the above command yourself. Note that
DT_SCHEMA_FILEScan be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.Would dt-schema in Debian 12 work? or must it be the latest dtschema installed by pip3 or from GitHub?
If Debian 12 has latest schema, it would work.
Best regards,
Krzysztof
PATCH v2 2/2 ARM: dts: mvebu: add Thecus N2350 board DTS
In reply to Tony DinhAdd Thecus N2350 board DTS and Makefile.
---
Changes in v2:
- Fix various DT bindings conformance (too numerous to list)
- Vendor prefix is not necessary, so remove it.
arch/arm/boot/dts/Makefile | 1 + arch/arm/boot/dts/armada-385-thecus-n2350.dts | 432 ++++++++++++++++++ 2 files changed, 433 insertions(+) create mode 100644 arch/arm/boot/dts/armada-385-thecus-n2350.dts
arch/arm/boot/dts/Makefile +1 -0
@@ -1535,6 +1535,7 @@ dtb-$(CONFIG_MACH_ARMADA_38X) += \ armada-385-linksys-rango.dtb \ armada-385-linksys-shelby.dtb \ armada-385-synology-ds116.dtb \ + armada-385-thecus-n2350.dtb \ armada-385-turris-omnia.dtb \ armada-388-clearfog.dtb \ armada-388-clearfog-base.dtb \
arch/arm/boot/dts/armada-385-thecus-n2350.dts new file +432 -0
432 lines not on this page · raw message
Signature · 1 line
2.30.2
Andrew Lunn
maintainerRe: [PATCH v2 2/2] ARM: dts: mvebu: add Thecus N2350 board DTS
arch/arm/boot/dts/armada-385-thecus-n2350.dts line 16
Quoted 4 lines
arch/arm/boot/dts/armada-385-thecus-n2350.dts new file +4
-0+ +/ { + model = "Thecus N2350"; + compatible = "marvell,armada385";
If you look at all the other armarda-385 .dts files, they all have a board compatible. It might not be needed now, but it could be useful in the future and allow backwards compatibility.
arch/arm/boot/dts/armada-385-thecus-n2350.dts line 263
Quoted 5 lines
+&mdio {
arch/arm/boot/dts/armada-385-thecus-n2350.dts new file +4
-0+ phy0: ethernet-phy@0 { + reg = <1>; + }; +};
Since you have ref = <1>, this should be ethernet-phy@1.
Re: [PATCH v2 2/2] ARM: dts: mvebu: add Thecus N2350 board DTS
Hi Andrew,
Quoted 10 lines · Andrew Lunn
arch/arm/boot/dts/armada-385-thecus-n2350.dts line 16
Quoted 5 lines
arch/arm/boot/dts/armada-385-thecus-n2350.dts new file +4
-0+ +/ { + model = "Thecus N2350"; + compatible = "marvell,armada385";If you look at all the other armarda-385 .dts files, they all have a board compatible. It might not be needed now, but it could be useful in the future and allow backwards compatibility.
Quoted 8 lines
arch/arm/boot/dts/armada-385-thecus-n2350.dts line 263
Quoted 5 lines
+&mdio {
arch/arm/boot/dts/armada-385-thecus-n2350.dts new file +4
-0+ phy0: ethernet-phy@0 { + reg = <1>; + }; +};Since you have ref = <1>, this should be ethernet-phy@1.
Thanks! somehow I kept missing that change.
All the best,
Tony