Skip to contentSkip to conversation

virt: acrn: Replace obsolete memalign() with posix_memalign()

PATCH New Deming Wang 1 participant 1 message Apr 12, 2023

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 virt: acrn: Replace obsolete memalign() with posix_memalign()

memalign() is obsolete according to its manpage.

Replace memalign() with posix_memalign() and remove malloc.h include that was there for memalign().

As a pointer is passed into posix_memalign(), initialize *p to NULL to silence a warning about the function's return value being used as uninitialized (which is not valid anyway because the error is properly checked before p is returned).

---
 samples/acrn/vm-sample.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)
samples/acrn/vm-sample.c +2 -3
index 7abd68b20153..2656189093ef 100644
@@ -13,7 +13,6 @@
 #include <stdint.h>
 #include <stdlib.h>
 #include <string.h>
-#include <malloc.h>
 #include <fcntl.h>
 #include <unistd.h>
 #include <signal.h>
@@ -54,8 +53,8 @@ int main(int argc, char **argv)
 	argc = argc;
 	argv = argv;
 
-	guest_memory = memalign(4096, GUEST_MEMORY_SIZE);
-	if (!guest_memory) {
+	ret = posix_memalign(&guest_memory, 4096, GUEST_MEMORY_SIZE);
+	if (ret < 0) {
 		printf("No enough memory!\n");
 		return -1;
 	}
Signature · 1 line
2.27.0