Skip to contentSkip to conversation

event: add bb.event.ParseError

PATCH New [email protected] 1 participant 1 message Apr 12, 2023

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 event: add bb.event.ParseError

From: Mingli Yu <[email protected]>

Add bb.event.ParseError to let error-report can catch this kind of error.

---
 lib/bb/cooker.py | 5 +++--
 lib/bb/event.py  | 8 ++++++++
 2 files changed, 11 insertions(+), 2 deletions(-)
lib/bb/cooker.py +3 -2
index 1797a1d4..c8ff3ce0 100644
@@ -2223,7 +2223,7 @@ class CookerParser(object):
 
             self.results = itertools.chain(self.results, self.parse_generator())
 
-    def shutdown(self, clean=True):
+    def shutdown(self, clean=True, eventmsg="Parsing halted due to errors"):
         if not self.toparse:
             return
         if self.haveshutdown:
@@ -2238,6 +2238,7 @@ class CookerParser(object):
 
             bb.event.fire(event, self.cfgdata)
         else:
+            bb.event.fire(bb.event.ParseError(eventmsg), self.cfgdata)
             bb.error("Parsing halted due to errors, see error messages above")
 
         # Cleanup the queue before call process.join(), otherwise there might be
@@ -2355,7 +2356,7 @@ class CookerParser(object):
         except bb.parse.ParseError as exc:
             self.error += 1
             logger.error(str(exc))
-            self.shutdown(clean=False)
+            self.shutdown(clean=False, eventmsg=str(exc))
             return False
         except bb.data_smart.ExpansionError as exc:
             self.error += 1
lib/bb/event.py +8 -0
index 37cc630c..0d0e0a68 100644
@@ -856,3 +856,11 @@ class FindSigInfoResult(Event):
     def __init__(self, result):
         Event.__init__(self)
         self.result = result
+
+class ParseError(Event):
+    """
+    Event to indicate parse failed
+    """
+    def __init__(self, msg):
+        super().__init__()
+        self._msg = msg
Signature · 1 line
2.25.1