Skip to contentSkip to conversation

Updating hardcoded "of-display" devices

PATCH Applied Cyril Brulebois 8 participants 21 messages Apr 12, 2023 – Jul 10, 2023

Subsystems (6)
lore
Share & tools
lore
#0 lore raw

Hi,

We've spotted a regression with the Debian Installer on ppc64el, and I've confirmed that the first patch fixes fbdev/offb as expected (or at least works around the regression, see last part of the commit message):
- [PATCH 1/2] fbdev/offb: Update expected device name

Since I've spotted that drm/ofdrm is affected as well, I'm submitting a similar patch for it, but I can't really test it. I suppose Thomas who introduced this new driver during the v6.2 release cycle will be able to take it from there if needed:
- [PATCH 2/2] drm/ofdrm: Update expected device name

Cheers,

Signature · 1 line
Cyril Brulebois -- Debian Consultant @ DEBAMAX -- https://debamax.com/
#1 lore raw

PATCH 1/2 fbdev/offb: Update expected device name

Since commit 241d2fb56a18 ("of: Make OF framebuffer device names unique"), as spotted by Frédéric Bonnard, the historical "of-display" device is
gone: the updated logic creates "of-display.0" instead, then as many "of-display.N" as required.

This means that offb no longer finds the expected device, which prevents the Debian Installer from setting up its interface, at least on ppc64el.

It might be better to iterate on all possible nodes, but updating the hardcoded device from "of-display" to "of-display.0" is confirmed to fix the Debian Installer at the very least.

Fixes 241d2fb56a18 ("of: Make OF framebuffer device names unique")
---
 drivers/video/fbdev/offb.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/video/fbdev/offb.c +1 -1
index b97d251d894b..6264c7184457 100644
@@ -698,7 +698,7 @@ MODULE_DEVICE_TABLE(of, offb_of_match_display);
 
 static struct platform_driver offb_driver_display = {
 	.driver = {
-		.name = "of-display",
+		.name = "of-display.0",
 		.of_match_table = offb_of_match_display,
 	},
 	.probe = offb_probe_display,
Signature · 1 line
2.30.2
#2 lore raw

Re: [PATCH 1/2] fbdev/offb: Update expected device name

Hi

looping in as well the regressions list (hoping not doing any mistake with the regzbot commands):

Quoted 26 lines · Cyril Brulebois

Since commit 241d2fb56a18 ("of: Make OF framebuffer device names unique"), as spotted by Frédéric Bonnard, the historical "of-display" device is
gone: the updated logic creates "of-display.0" instead, then as many "of-display.N" as required.

This means that offb no longer finds the expected device, which prevents the Debian Installer from setting up its interface, at least on ppc64el.

It might be better to iterate on all possible nodes, but updating the hardcoded device from "of-display" to "of-display.0" is confirmed to fix the Debian Installer at the very least.

Fixes 241d2fb56a18 ("of: Make OF framebuffer device names unique")
---
 drivers/video/fbdev/offb.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/video/fbdev/offb.c +0 -0
index b97d251d894b..6264c7184457 100644

drivers/video/fbdev/offb.c MODULE_DEVICE_TABLE(of, offb_of_match_display); · line 704

Quoted 8 lines
drivers/video/fbdev/offb.c +1 -1
@@ -698,7 +698,7 @@ MODULE_DEVICE_TABLE(of, offb_of_match_display);
 
 static struct platform_driver offb_driver_display = {
 	.driver = {
-		.name = "of-display",
+		.name = "of-display.0",
 		.of_match_table = offb_of_match_display,
 	},
 	.probe = offb_probe_display,

#regzbot ^introduced 241d2fb56a18
#regzbot title: Open Firmware framebuffer cannot find of-display
#regzbot link: https://bugzilla.kernel.org/show_bug.cgi?id=217328
#regzbot link: https://lore.kernel.org/all/[email protected]/T/#m34493480243a2cad2ae359abfd9db5e755f41add
#regzbot link: https://bugs.debian.org/1033058

Regards,
Salvatore

#3 lore raw

Re: [PATCH 1/2] fbdev/offb: Update expected device name

Quoted 13 lines · Salvatore Bonaccorso
Quoted 11 lines · Cyril Brulebois

Since commit 241d2fb56a18 ("of: Make OF framebuffer device names unique"), as spotted by Frédéric Bonnard, the historical "of-display" device is
gone: the updated logic creates "of-display.0" instead, then as many "of-display.N" as required.

This means that offb no longer finds the expected device, which prevents the Debian Installer from setting up its interface, at least on ppc64el.

It might be better to iterate on all possible nodes, but updating the hardcoded device from "of-display" to "of-display.0" is confirmed to fix the Debian Installer at the very least.

Quoted 6 lines

[...]
#regzbot ^introduced 241d2fb56a18
#regzbot title: Open Firmware framebuffer cannot find of-display
#regzbot link: https://bugzilla.kernel.org/show_bug.cgi?id=217328
#regzbot link: https://lore.kernel.org/all/[email protected]/T/#m34493480243a2cad2ae359abfd9db5e755f41add
#regzbot link: https://bugs.debian.org/1033058

No reply to my status inquiry[1] a few weeks ago, so I have to assume nobody cares anymore. If somebody still cares, holler!

#regzbot inconclusive: no answer to a status inquiry #regzbot ignore-activity

[1]
https://lore.kernel.org/lkml/[email protected]/

Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat) --
Everything you wanna know about Linux kernel regression tracking:
https://linux-regtracking.leemhuis.info/about/#tldr
If I did something stupid, please tell me, as explained on that page.

#4 lore raw

Re: [PATCH 1/2] fbdev/offb: Update expected device name

Hi

Am 15.06.23 um 15:03 schrieb Linux regression tracking (Thorsten Leemhuis):

Quoted 21 lines · Salvatore Bonaccorso
Quoted 13 lines · Cyril Brulebois
Quoted 11 lines

Since commit 241d2fb56a18 ("of: Make OF framebuffer device names unique"), as spotted by Frédéric Bonnard, the historical "of-display" device is
gone: the updated logic creates "of-display.0" instead, then as many "of-display.N" as required.

This means that offb no longer finds the expected device, which prevents the Debian Installer from setting up its interface, at least on ppc64el.

It might be better to iterate on all possible nodes, but updating the hardcoded device from "of-display" to "of-display.0" is confirmed to fix the Debian Installer at the very least.

Quoted 6 lines

[...]
#regzbot ^introduced 241d2fb56a18
#regzbot title: Open Firmware framebuffer cannot find of-display
#regzbot link: https://bugzilla.kernel.org/show_bug.cgi?id=217328
#regzbot link: https://lore.kernel.org/all/[email protected]/T/#m34493480243a2cad2ae359abfd9db5e755f41add
#regzbot link: https://bugs.debian.org/1033058

Quoted 2 lines

No reply to my status inquiry[1] a few weeks ago, so I have to assume nobody cares anymore. If somebody still cares, holler!

I'd take a look if anyone can point me to an example of Geert's proposal.

Best regards
Thomas

Quoted 12 lines

#regzbot inconclusive: no answer to a status inquiry #regzbot ignore-activity

[1]
https://lore.kernel.org/lkml/[email protected]/

Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat) --
Everything you wanna know about Linux kernel regression tracking:
https://linux-regtracking.leemhuis.info/about/#tldr
If I did something stupid, please tell me, as explained on that page.

Signature · 6 lines
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstrasse 146, 90461 Nuernberg, Germany
GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman
HRB 36809 (AG Nuernberg)
#5 lore raw

Re: [PATCH 1/2] fbdev/offb: Update expected device name

Hello,

Quoted 17 lines · Thomas Zimmermann

Hi

Am 15.06.23 um 15:03 schrieb Linux regression tracking (Thorsten Leemhuis):

Quoted 14 lines · Salvatore Bonaccorso
Quoted 13 lines · Cyril Brulebois
Quoted 11 lines

Since commit 241d2fb56a18 ("of: Make OF framebuffer device names unique"), as spotted by Frédéric Bonnard, the historical "of-display" device is
gone: the updated logic creates "of-display.0" instead, then as many "of-display.N" as required.

This means that offb no longer finds the expected device, which prevents the Debian Installer from setting up its interface, at least on ppc64el.

It might be better to iterate on all possible nodes, but updating the hardcoded device from "of-display" to "of-display.0" is confirmed to fix the Debian Installer at the very least.

At the time this was proposed it was said that "of-display", is wrong, and that "of-display.0" must be used for the first device instead, and if something breaks an alias can be provided.

So how does one provide an alias so that offb can find "of-display.0" as "of-display"?

Thanks

Michal

Quoted 35 lines
Quoted 9 lines
Quoted 6 lines

[...]
#regzbot ^introduced 241d2fb56a18
#regzbot title: Open Firmware framebuffer cannot find of-display
#regzbot link: https://bugzilla.kernel.org/show_bug.cgi?id=217328
#regzbot link: https://lore.kernel.org/all/[email protected]/T/#m34493480243a2cad2ae359abfd9db5e755f41add
#regzbot link: https://bugs.debian.org/1033058

No reply to my status inquiry[1] a few weeks ago, so I have to assume nobody cares anymore. If somebody still cares, holler!

I'd take a look if anyone can point me to an example of Geert's proposal.

Best regards
Thomas

Quoted 12 lines

#regzbot inconclusive: no answer to a status inquiry #regzbot ignore-activity

[1]
https://lore.kernel.org/lkml/[email protected]/

Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat) --
Everything you wanna know about Linux kernel regression tracking:
https://linux-regtracking.leemhuis.info/about/#tldr
If I did something stupid, please tell me, as explained on that page.

Signature · 6 lines
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstrasse 146, 90461 Nuernberg, Germany
GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman
HRB 36809 (AG Nuernberg)
maintainer
#6 lore raw

Re: [PATCH 1/2] fbdev/offb: Update expected device name

Quoted 21 lines · Michal Suchánek

Hello,

Quoted 17 lines · Thomas Zimmermann

Hi

Am 15.06.23 um 15:03 schrieb Linux regression tracking (Thorsten Leemhuis):

Quoted 14 lines · Salvatore Bonaccorso
Quoted 13 lines · Cyril Brulebois
Quoted 11 lines

Since commit 241d2fb56a18 ("of: Make OF framebuffer device names unique"), as spotted by Frédéric Bonnard, the historical "of-display" device is
gone: the updated logic creates "of-display.0" instead, then as many "of-display.N" as required.

This means that offb no longer finds the expected device, which prevents the Debian Installer from setting up its interface, at least on ppc64el.

It might be better to iterate on all possible nodes, but updating the hardcoded device from "of-display" to "of-display.0" is confirmed to fix the Debian Installer at the very least.

Quoted 6 lines

At the time this was proposed it was said that "of-display", is wrong, and that "of-display.0" must be used for the first device instead, and if something breaks an alias can be provided.

So how does one provide an alias so that offb can find "of-display.0" as "of-display"?

I'm not aware of any way. There isn't because device names and paths are not considered ABI. There are mechanisms for getting stable class device indices (e.g. i2c0, mmcblk0, fb0, fb1, etc.) though not implemented for fbN (and please don't add it).

In any case, this should be an easy fix. Though if "linux,opened" or "linux,boot-display" is not set, then you'd still get "of-display.0":

drivers/of/platform.c +1 -1
index 78ae84187449..e46482cef9c7 100644
@@ -553,7 +553,7 @@ static int __init of_platform_default_populate_init(void)
                        if (!of_get_property(node, "linux,opened", NULL) ||
                            !of_get_property(node, "linux,boot-display", NULL))
                                continue;
-                       dev = of_platform_device_create(node, "of-display.0", NULL);
+                       dev = of_platform_device_create(node, "of-display", NULL);
                        of_node_put(node);
                        if (WARN_ON(!dev))
                                return -ENOMEM;
#7 lore raw

Re: [PATCH 1/2] fbdev/offb: Update expected device name

Hi Rob,

Rob Herring <[email protected]> (2023-06-15):

Quoted 21 lines · Michal Suchánek
Quoted 6 lines

At the time this was proposed it was said that "of-display", is wrong, and that "of-display.0" must be used for the first device instead, and if something breaks an alias can be provided.

So how does one provide an alias so that offb can find "of-display.0" as "of-display"?

I'm not aware of any way. There isn't because device names and paths are not considered ABI. There are mechanisms for getting stable class device indices (e.g. i2c0, mmcblk0, fb0, fb1, etc.) though not implemented for fbN (and please don't add it).

In any case, this should be an easy fix. Though if "linux,opened" or "linux,boot-display" is not set, then you'd still get "of-display.0":

drivers/of/platform.c +0 -0
index 78ae84187449..e46482cef9c7 100644

drivers/of/platform.c static int __init of_platform_default_populate_init(void) · line 559

Quoted 8 lines
drivers/of/platform.c +1 -1
@@ -553,7 +553,7 @@ static int __init of_platform_default_populate_init(void)
                        if (!of_get_property(node, "linux,opened", NULL) ||
                            !of_get_property(node, "linux,boot-display", NULL))
                                continue;
-                       dev = of_platform_device_create(node, "of-display.0", NULL);
+                       dev = of_platform_device_create(node, "of-display", NULL);
                        of_node_put(node);
                        if (WARN_ON(!dev))
                                return -ENOMEM;

I've just replaced my clueless workaround with this patch on top of the kernel found in Debian 12 (Bookworm), i.e. 6.1.27 at this point, and it indeed fixes the black screen problem in the installer's context.

I didn't run a full installation to check whether this kernel is also fine after rebooting into the installed system, but as far as I understood for the original bug report[1], it wasn't affected in the first place.

1. https://bugs.debian.org/1033058

Will somebody else pick up the torch from here, and submit that for inclusion in master? Or should I re-submit the above patch on my own?

I see my Debian colleagues have already pushed an updated v6.4-rc6 in experimental, so it should be rather easy to combine checking latest master with the distribution's packaging. Once that's done, I'm quite familiar with building an updated installer image on top of it…

Thanks,

Signature · 1 line
Cyril Brulebois -- Debian Consultant @ DEBAMAX -- https://debamax.com/
maintainer
#8 lore raw

Re: [PATCH 1/2] fbdev/offb: Update expected device name

Quoted 19 lines · Cyril Brulebois

Hi Rob,

Rob Herring <[email protected]> (2023-06-15):

Quoted 16 lines · Michal Suchánek
Quoted 6 lines

At the time this was proposed it was said that "of-display", is wrong, and that "of-display.0" must be used for the first device instead, and if something breaks an alias can be provided.

So how does one provide an alias so that offb can find "of-display.0" as "of-display"?

I'm not aware of any way. There isn't because device names and paths are not considered ABI. There are mechanisms for getting stable class device indices (e.g. i2c0, mmcblk0, fb0, fb1, etc.) though not implemented for fbN (and please don't add it).

In any case, this should be an easy fix. Though if "linux,opened" or "linux,boot-display" is not set, then you'd still get "of-display.0":

Quoted 13 lines

drivers/of/platform.c static int __init of_platform_default_populate_init(void) · line 559

Quoted 13 lines
drivers/of/platform.c +1 -1
index 78ae84187449..e46482cef9c7 100644
@@ -553,7 +553,7 @@ static int __init of_platform_default_populate_init(void)
                         if (!of_get_property(node, "linux,opened", NULL) ||
                             !of_get_property(node, "linux,boot-display", NULL))
                                 continue;
-                       dev = of_platform_device_create(node, "of-display.0", NULL);
+                       dev = of_platform_device_create(node, "of-display", NULL);
                         of_node_put(node);
                         if (WARN_ON(!dev))
                                 return -ENOMEM;

Michal, does that patch look correct?
I don't have that hardware, but that way the boot-display gets named "of-display" while all others get "of-display.x"....

Quoted 3 lines

I've just replaced my clueless workaround with this patch on top of the kernel found in Debian 12 (Bookworm), i.e. 6.1.27 at this point, and it indeed fixes the black screen problem in the installer's context.

... at least it fixes the issue.

Quoted 8 lines

I didn't run a full installation to check whether this kernel is also fine after rebooting into the installed system, but as far as I understood for the original bug report[1], it wasn't affected in the first place.

1. https://bugs.debian.org/1033058

Will somebody else pick up the torch from here, and submit that for inclusion in master? Or should I re-submit the above patch on my own?

It would be good to get some more feedback, but in general if you or Rob send me a patch I can include it in the fbdev git tree for futher testing (and if nobody else disagrees).

Helge

#9 lore raw

Re: [PATCH 1/2] fbdev/offb: Update expected device name

Quoted 29 lines · Helge Deller
Quoted 28 lines · Cyril Brulebois

Hi Rob,

Rob Herring <[email protected]> (2023-06-15):

Quoted 25 lines · Michal Suchánek
Quoted 6 lines

At the time this was proposed it was said that "of-display", is wrong, and that "of-display.0" must be used for the first device instead, and if something breaks an alias can be provided.

So how does one provide an alias so that offb can find "of-display.0" as "of-display"?

I'm not aware of any way. There isn't because device names and paths are not considered ABI. There are mechanisms for getting stable class device indices (e.g. i2c0, mmcblk0, fb0, fb1, etc.) though not implemented for fbN (and please don't add it).

In any case, this should be an easy fix. Though if "linux,opened" or "linux,boot-display" is not set, then you'd still get "of-display.0":

drivers/of/platform.c +0 -1
index 78ae84187449..e46482cef9c7 100644
@@ -553,7 +553,7 @@ static int __init of_platform_default_populate_init(void)
                         if (!of_get_property(node, "linux,opened", NULL) ||
                             !of_get_property(node, "linux,boot-display", NULL))
                                 continue;
-                       dev = of_platform_device_create(node, "of-display.0", NULL);
Quoted 8 lines
Quoted 4 lines

drivers/of/platform.c static int __init of_platform_default_populate_init(void) · line 559

Quoted 4 lines
drivers/of/platform.c +1 -0
+                       dev = of_platform_device_create(node, "of-display", NULL);
                         of_node_put(node);
                         if (WARN_ON(!dev))
                                 return -ENOMEM;

Michal, does that patch look correct?
I don't have that hardware, but that way the boot-display gets named "of-display" while all others get "of-display.x"....

Yes, that's inconsistent, and IIRC it's what I originally proposed to preserve compatibility as much as possible.

The patch went through multiple iteration by me and Rob and the final version that was merged uses the consistent but incompatible naming.

The other option would be to adapt the offb driver, presumably.

I don't understand how the device name figures in attaching the driver to the device, the only other occurence of of-display is the name of the offb and ofdrm drivers.

Quoted 5 lines
Quoted 3 lines

I've just replaced my clueless workaround with this patch on top of the kernel found in Debian 12 (Bookworm), i.e. 6.1.27 at this point, and it indeed fixes the black screen problem in the installer's context.

... at least it fixes the issue.

I would expect as much. I don't have the hardware either but keeping what was there before, and only adding on top is kind of the least disruptive way of adding new stuff.

Thanks

Michal

#10 lore raw

Re: [PATCH 1/2] fbdev/offb: Update expected device name

In reply to Linux regression tracking (Thorsten Leemhuis)

Linux regression tracking (Thorsten Leemhuis) <[email protected]> (2023-06-15):

Quoted 2 lines

No reply to my status inquiry[1] a few weeks ago, so I have to assume nobody cares anymore. If somebody still cares, holler!

I still care about a proper bugfix, for upstream and for the Debian distribution, and so does Salvatore. But fixing kernel regressions isn't my day job, so I haven't got around to working on it.

Cheers,

Signature · 1 line
Cyril Brulebois -- Debian Consultant @ DEBAMAX -- https://debamax.com/
maintainer Applied
#11 lore raw

Re: [PATCH 1/2] fbdev/offb: Update expected device name

In reply to Cyril Brulebois
Quoted 12 lines · Cyril Brulebois

Since commit 241d2fb56a18 ("of: Make OF framebuffer device names unique"), as spotted by Frédéric Bonnard, the historical "of-display" device is
gone: the updated logic creates "of-display.0" instead, then as many "of-display.N" as required.

This means that offb no longer finds the expected device, which prevents the Debian Installer from setting up its interface, at least on ppc64el.

It might be better to iterate on all possible nodes, but updating the hardcoded device from "of-display" to "of-display.0" is confirmed to fix the Debian Installer at the very least.

Quoted 5 lines
Fixes 241d2fb56a18 ("of: Make OF framebuffer device names unique")

I've applied the series (2 patches, one of them in drm) to the fbdev git tree.

Thanks!
Helge

Quoted 17 lines
---
  drivers/video/fbdev/offb.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
drivers/video/fbdev/offb.c +1 -1
index b97d251d894b..6264c7184457 100644
@@ -698,7 +698,7 @@ MODULE_DEVICE_TABLE(of, offb_of_match_display);
 
  static struct platform_driver offb_driver_display = {
  	.driver = {
-		.name = "of-display",
+		.name = "of-display.0",
  		.of_match_table = offb_of_match_display,
  	},
  	.probe = offb_probe_display,
#12 lore raw

Re: [PATCH 1/2] fbdev/offb: Update expected device name

In reply to Cyril Brulebois

Hi Cyril,

CC DT

Quoted 12 lines · Cyril Brulebois

Since commit 241d2fb56a18 ("of: Make OF framebuffer device names unique"), as spotted by Frédéric Bonnard, the historical "of-display" device is
gone: the updated logic creates "of-display.0" instead, then as many "of-display.N" as required.

This means that offb no longer finds the expected device, which prevents the Debian Installer from setting up its interface, at least on ppc64el.

It might be better to iterate on all possible nodes, but updating the hardcoded device from "of-display" to "of-display.0" is confirmed to fix the Debian Installer at the very least.

Quoted 5 lines
Fixes 241d2fb56a18 ("of: Make OF framebuffer device names unique")

Thanks for your patch, which is now commit 27c74ea74be805cc ("fbdev/offb: Update expected device name") in fbdev/for-next

drivers/video/fbdev/offb.c MODULE_DEVICE_TABLE(of, offb_of_match_display); · line 704

Quoted 11 lines
drivers/video/fbdev/offb.c +1 -1
@@ -698,7 +698,7 @@ MODULE_DEVICE_TABLE(of, offb_of_match_display);
 
 static struct platform_driver offb_driver_display = {
        .driver = {
-               .name = "of-display",
+               .name = "of-display.0",
                .of_match_table = offb_of_match_display,
        },
        .probe = offb_probe_display,

This looks like the wrong fix for me: platform drivers' names must not contain the device index, and DT-based devices are probed using the compatible value (which is "display") instead of the node name.

I think the problem is with the of_platform_default_populate_init() function, which should create proper name@unit-address device nodes, with unique unit addresses, and with the correct compatible value.

Gr{oetje,eeting}s,

Geert

Signature · 5 lines
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
Reviewed-by on v1 1/2
#13 lore raw

Re: [PATCH 1/2] fbdev/offb: Update expected device name

In reply to Cyril Brulebois
Quoted 12 lines · Cyril Brulebois

Since commit 241d2fb56a18 ("of: Make OF framebuffer device names unique"), as spotted by Frédéric Bonnard, the historical "of-display" device is
gone: the updated logic creates "of-display.0" instead, then as many "of-display.N" as required.

This means that offb no longer finds the expected device, which prevents the Debian Installer from setting up its interface, at least on ppc64el.

It might be better to iterate on all possible nodes, but updating the hardcoded device from "of-display" to "of-display.0" is confirmed to fix the Debian Installer at the very least.

Quoted 5 lines
Fixes 241d2fb56a18 ("of: Make OF framebuffer device names unique")

Thanks

Michal

Quoted 20 lines
---
 drivers/video/fbdev/offb.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/video/fbdev/offb.c +1 -1
index b97d251d894b..6264c7184457 100644
@@ -698,7 +698,7 @@ MODULE_DEVICE_TABLE(of, offb_of_match_display);
 
 static struct platform_driver offb_driver_display = {
 	.driver = {
-		.name = "of-display",
+		.name = "of-display.0",
 		.of_match_table = offb_of_match_display,
 	},
 	.probe = offb_probe_display,
Signature · 1 line
2.30.2
#14 lore raw

PATCH 2/2 drm/ofdrm: Update expected device name

In reply to Cyril Brulebois

Since commit 241d2fb56a18 ("of: Make OF framebuffer device names unique"), as spotted by Frédéric Bonnard, the historical "of-display" device is
gone: the updated logic creates "of-display.0" instead, then as many "of-display.N" as required.

This means that offb no longer finds the expected device, which prevents the Debian Installer from setting up its interface, at least on ppc64el.

Given the code similarity it is likely to affect ofdrm in the same way.

It might be better to iterate on all possible nodes, but updating the hardcoded device from "of-display" to "of-display.0" is likely to help as a first step.

Fixes 241d2fb56a18 ("of: Make OF framebuffer device names unique")
---
 drivers/gpu/drm/tiny/ofdrm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/tiny/ofdrm.c +1 -1
index 6e349ca42485..92df021d71df 100644
@@ -1390,7 +1390,7 @@ MODULE_DEVICE_TABLE(of, ofdrm_of_match_display);
 
 static struct platform_driver ofdrm_platform_driver = {
 	.driver = {
-		.name = "of-display",
+		.name = "of-display.0",
 		.of_match_table = ofdrm_of_match_display,
 	},
 	.probe = ofdrm_probe,
Signature · 1 line
2.30.2
#15 lore raw

Re: [PATCH 2/2] drm/ofdrm: Update expected device name

Hi Cyril,

CC DT

Quoted 14 lines · Cyril Brulebois

Since commit 241d2fb56a18 ("of: Make OF framebuffer device names unique"), as spotted by Frédéric Bonnard, the historical "of-display" device is
gone: the updated logic creates "of-display.0" instead, then as many "of-display.N" as required.

This means that offb no longer finds the expected device, which prevents the Debian Installer from setting up its interface, at least on ppc64el.

Given the code similarity it is likely to affect ofdrm in the same way.

It might be better to iterate on all possible nodes, but updating the hardcoded device from "of-display" to "of-display.0" is likely to help as a first step.

Quoted 5 lines
Fixes 241d2fb56a18 ("of: Make OF framebuffer device names unique")

Thanks for your patch, which is now commit 3a9d8ea2539ebebd ("drm/ofdrm: Update expected device name") in fbdev/for-next.

drivers/gpu/drm/tiny/ofdrm.c MODULE_DEVICE_TABLE(of, ofdrm_of_match_display); · line 1396

Quoted 11 lines
drivers/gpu/drm/tiny/ofdrm.c +1 -1
@@ -1390,7 +1390,7 @@ MODULE_DEVICE_TABLE(of, ofdrm_of_match_display);
 
 static struct platform_driver ofdrm_platform_driver = {
        .driver = {
-               .name = "of-display",
+               .name = "of-display.0",
                .of_match_table = ofdrm_of_match_display,
        },
        .probe = ofdrm_probe,

Same comment as for "[PATCH 1/2] fbdev/offb: Update expected device name".

https://lore.kernel.org/r/CAMuHMdVGEeAsmb4tAuuqqGJ-4+BBETwEwYJA+M9NyJv0BJ_hNg@mail.gmail.com

Gr{oetje,eeting}s,

Geert

Signature · 5 lines
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
#16 lore raw

Re: [PATCH 2/2] drm/ofdrm: Update expected device name

Hi

Am 24.04.23 um 09:33 schrieb Geert Uytterhoeven:

Quoted 43 lines

Hi Cyril,

CC DT

Quoted 14 lines · Cyril Brulebois

Since commit 241d2fb56a18 ("of: Make OF framebuffer device names unique"), as spotted by Frédéric Bonnard, the historical "of-display" device is
gone: the updated logic creates "of-display.0" instead, then as many "of-display.N" as required.

This means that offb no longer finds the expected device, which prevents the Debian Installer from setting up its interface, at least on ppc64el.

Given the code similarity it is likely to affect ofdrm in the same way.

It might be better to iterate on all possible nodes, but updating the hardcoded device from "of-display" to "of-display.0" is likely to help as a first step.

Quoted 5 lines
Fixes 241d2fb56a18 ("of: Make OF framebuffer device names unique")

Thanks for your patch, which is now commit 3a9d8ea2539ebebd ("drm/ofdrm: Update expected device name") in fbdev/for-next.

drivers/gpu/drm/tiny/ofdrm.c MODULE_DEVICE_TABLE(of, ofdrm_of_match_display); · line 1396

Quoted 11 lines
drivers/gpu/drm/tiny/ofdrm.c +1 -1
@@ -1390,7 +1390,7 @@ MODULE_DEVICE_TABLE(of, ofdrm_of_match_display);
 
  static struct platform_driver ofdrm_platform_driver = {
         .driver = {
-               .name = "of-display",
+               .name = "of-display.0",
                 .of_match_table = ofdrm_of_match_display,
         },
         .probe = ofdrm_probe,

Same comment as for "[PATCH 1/2] fbdev/offb: Update expected device name".

Quoted 1 line

https://lore.kernel.org/r/CAMuHMdVGEeAsmb4tAuuqqGJ-4+BBETwEwYJA+M9NyJv0BJ_hNg@mail.gmail.com

Sorry that I missed this patch. I agree that it's probably not correct. At least in ofdrm, we want to be able to use multiple framebuffers at the same time; a feature that has been broken by this change.

Best regards
Thomas

Quoted 5 lines

Gr{oetje,eeting}s,

Geert

Signature · 6 lines
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstrasse 146, 90461 Nuernberg, Germany
GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman
HRB 36809 (AG Nuernberg)
maintainer
#17 lore raw

Re: [PATCH 2/2] drm/ofdrm: Update expected device name

Quoted 46 lines · Thomas Zimmermann

Hi

Am 24.04.23 um 09:33 schrieb Geert Uytterhoeven:

Quoted 43 lines

Hi Cyril,

CC DT

Quoted 14 lines · Cyril Brulebois

Since commit 241d2fb56a18 ("of: Make OF framebuffer device names unique"), as spotted by Frédéric Bonnard, the historical "of-display" device is
gone: the updated logic creates "of-display.0" instead, then as many "of-display.N" as required.

This means that offb no longer finds the expected device, which prevents the Debian Installer from setting up its interface, at least on ppc64el.

Given the code similarity it is likely to affect ofdrm in the same way.

It might be better to iterate on all possible nodes, but updating the hardcoded device from "of-display" to "of-display.0" is likely to help as a first step.

Quoted 5 lines
Fixes 241d2fb56a18 ("of: Make OF framebuffer device names unique")

Thanks for your patch, which is now commit 3a9d8ea2539ebebd ("drm/ofdrm: Update expected device name") in fbdev/for-next.

drivers/gpu/drm/tiny/ofdrm.c MODULE_DEVICE_TABLE(of, ofdrm_of_match_display); · line 1396

Quoted 11 lines
drivers/gpu/drm/tiny/ofdrm.c +1 -1
@@ -1390,7 +1390,7 @@ MODULE_DEVICE_TABLE(of, ofdrm_of_match_display);
 
   static struct platform_driver ofdrm_platform_driver = {
          .driver = {
-               .name = "of-display",
+               .name = "of-display.0",
                  .of_match_table = ofdrm_of_match_display,
          },
          .probe = ofdrm_probe,

Same comment as for "[PATCH 1/2] fbdev/offb: Update expected device name".

Quoted 6 lines
Quoted 1 line

https://lore.kernel.org/r/CAMuHMdVGEeAsmb4tAuuqqGJ-4+BBETwEwYJA+M9NyJv0BJ_hNg@mail.gmail.com

Sorry that I missed this patch. I agree that it's probably not correct. At least in ofdrm, we want to be able to use multiple framebuffers at the same time; a feature that has been broken by this change.

Geert & Thomas, thanks for the review!

I've dropped both patches from fbdev tree for now.
Would be great to find another good solution though, as it breaks the debian installer.

Helge

#18 lore raw

Re: [PATCH 2/2] drm/ofdrm: Update expected device name

Hi, Thorsten here, the Linux kernel's regression tracker. Top-posting for once, to make this easily accessible to everyone.

Was a proper solution for the regression the initial mail in this thread is about ever found? Doesn't look like it for here, but maybe I'm missing something.

Reminder, the problem afaik is caused by 241d2fb56a ("of: Make OF framebuffer device names unique") [merged for v6.2-rc8, authored by Michal Suchanek; committed by Rob Herring].

Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat) --
Everything you wanna know about Linux kernel regression tracking:
https://linux-regtracking.leemhuis.info/about/#tldr
If I did something stupid, please tell me, as explained on that page.

#regzbot poke

Quoted 60 lines · Helge Deller
Quoted 44 lines · Thomas Zimmermann

Am 24.04.23 um 09:33 schrieb Geert Uytterhoeven:

Quoted 43 lines
Quoted 17 lines · Cyril Brulebois

Since commit 241d2fb56a18 ("of: Make OF framebuffer device names unique"),
as spotted by Frédéric Bonnard, the historical "of-display" device is
gone: the updated logic creates "of-display.0" instead, then as many "of-display.N" as required.

This means that offb no longer finds the expected device, which prevents
the Debian Installer from setting up its interface, at least on ppc64el.

Given the code similarity it is likely to affect ofdrm in the same way.

It might be better to iterate on all possible nodes, but updating the hardcoded device from "of-display" to "of-display.0" is likely to help as a first step.

Quoted 5 lines
Fixes 241d2fb56a18 ("of: Make OF framebuffer device names unique")

Thanks for your patch, which is now commit 3a9d8ea2539ebebd ("drm/ofdrm: Update expected device name") in fbdev/for-next.

drivers/gpu/drm/tiny/ofdrm.c MODULE_DEVICE_TABLE(of, ofdrm_of_match_display); · line 1396

Quoted 11 lines
drivers/gpu/drm/tiny/ofdrm.c +1 -1
@@ -1390,7 +1390,7 @@ MODULE_DEVICE_TABLE(of, ofdrm_of_match_display);
 
   static struct platform_driver ofdrm_platform_driver = {
          .driver = {
-               .name = "of-display",
+               .name = "of-display.0",
                  .of_match_table = ofdrm_of_match_display,
          },
          .probe = ofdrm_probe,

Same comment as for "[PATCH 1/2] fbdev/offb: Update expected device name".

Quoted 6 lines
Quoted 1 line

https://lore.kernel.org/r/CAMuHMdVGEeAsmb4tAuuqqGJ-4+BBETwEwYJA+M9NyJv0BJ_hNg@mail.gmail.com

Sorry that I missed this patch. I agree that it's probably not correct. At least in ofdrm, we want to be able to use multiple framebuffers at the same time; a feature that has been broken by this change.

Geert & Thomas, thanks for the review!

I've dropped both patches from fbdev tree for now.
Would be great to find another good solution though, as it breaks the debian
installer.

Helge

#19 lore raw

Re: [PATCH 2/2] drm/ofdrm: Update expected device name

In reply to Thomas Zimmermann
Quoted 46 lines · Thomas Zimmermann

Hi

Am 24.04.23 um 09:33 schrieb Geert Uytterhoeven:

Quoted 43 lines

Hi Cyril,

CC DT

Quoted 14 lines · Cyril Brulebois

Since commit 241d2fb56a18 ("of: Make OF framebuffer device names unique"), as spotted by Frédéric Bonnard, the historical "of-display" device is
gone: the updated logic creates "of-display.0" instead, then as many "of-display.N" as required.

This means that offb no longer finds the expected device, which prevents the Debian Installer from setting up its interface, at least on ppc64el.

Given the code similarity it is likely to affect ofdrm in the same way.

It might be better to iterate on all possible nodes, but updating the hardcoded device from "of-display" to "of-display.0" is likely to help as a first step.

Quoted 5 lines
Fixes 241d2fb56a18 ("of: Make OF framebuffer device names unique")

Thanks for your patch, which is now commit 3a9d8ea2539ebebd ("drm/ofdrm: Update expected device name") in fbdev/for-next.

drivers/gpu/drm/tiny/ofdrm.c MODULE_DEVICE_TABLE(of, ofdrm_of_match_display); · line 1396

Quoted 11 lines
drivers/gpu/drm/tiny/ofdrm.c +1 -1
@@ -1390,7 +1390,7 @@ MODULE_DEVICE_TABLE(of, ofdrm_of_match_display);
 
  static struct platform_driver ofdrm_platform_driver = {
         .driver = {
-               .name = "of-display",
+               .name = "of-display.0",
                 .of_match_table = ofdrm_of_match_display,
         },
         .probe = ofdrm_probe,

Same comment as for "[PATCH 1/2] fbdev/offb: Update expected device name".

Quoted 5 lines
Quoted 1 line

https://lore.kernel.org/r/CAMuHMdVGEeAsmb4tAuuqqGJ-4+BBETwEwYJA+M9NyJv0BJ_hNg@mail.gmail.com

Sorry that I missed this patch. I agree that it's probably not correct. At least in ofdrm, we want to be able to use multiple framebuffers at the same time; a feature that has been broken by this change.

How did it work before, though?

We did not have this device name clash, then we did, and it was solved by renaming the devices to numnered.

Now matching the first device should restore the previously available functionality, mathing any of the numbered devices would potentially allow to use multiple devices.

Or am I missing something?

Thanks

Michal

Reviewed-by on v1 2/2
#20 lore raw

Re: [PATCH 2/2] drm/ofdrm: Update expected device name

In reply to Cyril Brulebois
Quoted 14 lines · Cyril Brulebois

Since commit 241d2fb56a18 ("of: Make OF framebuffer device names unique"), as spotted by Frédéric Bonnard, the historical "of-display" device is
gone: the updated logic creates "of-display.0" instead, then as many "of-display.N" as required.

This means that offb no longer finds the expected device, which prevents the Debian Installer from setting up its interface, at least on ppc64el.

Given the code similarity it is likely to affect ofdrm in the same way.

It might be better to iterate on all possible nodes, but updating the hardcoded device from "of-display" to "of-display.0" is likely to help as a first step.

Quoted 5 lines
Fixes 241d2fb56a18 ("of: Make OF framebuffer device names unique")
Quoted 20 lines
---
 drivers/gpu/drm/tiny/ofdrm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/tiny/ofdrm.c +1 -1
index 6e349ca42485..92df021d71df 100644
@@ -1390,7 +1390,7 @@ MODULE_DEVICE_TABLE(of, ofdrm_of_match_display);
 
 static struct platform_driver ofdrm_platform_driver = {
 	.driver = {
-		.name = "of-display",
+		.name = "of-display.0",
 		.of_match_table = ofdrm_of_match_display,
 	},
 	.probe = ofdrm_probe,
Signature · 1 line
2.30.2