vmxnet3: upgrade to version 7
Subsystems (2)
cover vmxnet3: upgrade to version 7
vmxnet3 emulation has recently added several new features including support for uniform passthrough(UPT). To make UPT work vmxnet3 has to be enhanced as per the new specification. This patch series extends the vmxnet3 driver to leverage these new features.
Compatibility is maintained using existing vmxnet3 versioning mechanism as follows:
- new features added to vmxnet3 emulation are associated with new vmxnet3 version viz. vmxnet3 version 7.
- emulation advertises all the versions it supports to the driver.
- during initialization, vmxnet3 driver picks the highest version number supported by both the emulation and the driver and configures emulation to run at that version.
In particular, following changes are introduced:
Patch 1:
This patch introduces utility macros for vmxnet3 version 7 comparison and updates Copyright information.
Patch 2:
This patch adds new capability registers to fine control enablement of individual features based on emulation and passthrough.
Patch 3:
This patch adds support for large passthrough BAR register.
Patch 4:
This patch introduces new command to set ring buffer sizes to pass this information to the hardware.
Patch 5:
For better performance, hardware has a requirement to limit number of TSO descriptors. This patch adds that support.
Patch 6:
Avoid updating rxprod register when in UPT for performance reasons.
Patch 7:
With all vmxnet3 version 7 changes incorporated in the vmxnet3 driver, with this patch, the driver can configure emulation to run at vmxnet3 version 7.
Ronak Doshi (7):
vmxnet3: prepare for version 7 changes
vmxnet3: add support for capability registers
vmxnet3: add support for large passthrough BAR register
vmxnet3: add command to set ring buffer sizes
vmxnet3: limit number of TXDs used for TSO packet
vmxnet3: avoid updating rxprod register frequently
vmxnet3: update to version 7
drivers/net/vmxnet3/base/vmxnet3_defs.h | 74 +++++++++++++++++++--- drivers/net/vmxnet3/vmxnet3_ethdev.c | 106 +++++++++++++++++++++++++++++++- drivers/net/vmxnet3/vmxnet3_ethdev.h | 16 +++++ drivers/net/vmxnet3/vmxnet3_ring.h | 2 +- drivers/net/vmxnet3/vmxnet3_rxtx.c | 48 +++++++++++---- lib/ethdev/rte_ethdev.h | 2 + 6 files changed, 226 insertions(+), 22 deletions(-)
Signature · 1 line
2.11.0
PATCH 1/7 vmxnet3: prepare for version 7 changes
vmxnet3 is currently at version 6 and this patch initiates the preparation to accommodate changes for upto version 7. Introduced utility macros for vmxnet3 version 7 comparison.
--- drivers/net/vmxnet3/vmxnet3_ethdev.h | 2 ++ 1 file changed, 2 insertions(+)
drivers/net/vmxnet3/vmxnet3_ethdev.h +2 -0
@@ -124,6 +124,7 @@ struct vmxnet3_hw {UPT1_RxStats snapshot_rx_stats[VMXNET3_MAX_RX_QUEUES ]; }; +#define VMXNET3_REV_7 6/* Vmxnet3 Rev. 7 */ #define VMXNET3_REV_6 5/* Vmxnet3 Rev. 6 */ #define VMXNET3_REV_5 4/* Vmxnet3 Rev. 5 */ #define VMXNET3_REV_4 3/* Vmxnet3 Rev. 4 */
@@ -131,6 +132,7 @@ struct vmxnet3_hw {#define VMXNET3_REV_2 1/* Vmxnet3 Rev. 2 */ #define VMXNET3_REV_1 0/* Vmxnet3 Rev. 1 */ +#define VMXNET3_VERSION_GE_7 (hw) ((hw)->version >= VMXNET3_REV_7 + 1)#define VMXNET3_VERSION_GE_6 (hw) ((hw)->version >= VMXNET3_REV_6 + 1)#define VMXNET3_VERSION_GE_5 (hw) ((hw)->version >= VMXNET3_REV_5 + 1)#define VMXNET3_VERSION_GE_4 (hw) ((hw)->version >= VMXNET3_REV_4 + 1)
Signature · 1 line
2.11.0
Re: [PATCH next 1/7] vmxnet3: prepare for version 7 changes
Quoted 2 lines · Ronak Doshi
vmxnet3 is currently at version 6 and this patch initiates the preparation to accommodate changes for upto version 7. Introduced
s/upto/up to/
(this is highlighted by checkpatch, please address all checkpatch warnings)
Quoted 4 lines
utility macros for vmxnet3 version 7 comparison.
Signed-off-by Ronak Doshi <[email protected]>Acked-by Jochen Behrens <[email protected]>
<...>
PATCH 2/7 vmxnet3: add support for capability registers
In reply to Ronak DoshiThis patch enhances vmxnet3 to suuport capability registers which allows it to enable features selectively. The DCR register tracks the capabilities vmxnet3 device supports. The PTCR register states the capabilities that the passthrough device supports.
With the help of these registers, vmxnet3 can enable only those features which the passthrough device supoprts. This allows smooth trasition to Uniform-Passthrough (UPT) mode if the virtual nic requests it. If PTCR register returns nothing or error it means UPT is not being requested and vnic will continue in emulation mode.
--- drivers/net/vmxnet3/base/vmxnet3_defs.h | 44 +++++++++++++++++--- drivers/net/vmxnet3/vmxnet3_ethdev.c | 71 +++++++++++++++++++++++++++++++++ drivers/net/vmxnet3/vmxnet3_ethdev.h | 11 +++++ lib/ethdev/rte_ethdev.h | 2 + 4 files changed, 123 insertions(+), 5 deletions(-)
drivers/net/vmxnet3/base/vmxnet3_defs.h +39 -5
@@ -26,6 +26,12 @@#define VMXNET3_REG_MACH 0x30/* MAC Address High */ #define VMXNET3_REG_ICR 0x38/* Interrupt Cause Register */ #define VMXNET3_REG_ECR 0x40/* Event Cause Register */ +#define VMXNET3_REG_DCR 0x48/* Device capability register, +* from 0x48 to 0x80 +*/ +#define VMXNET3_REG_PTCR 0x88/* Passthru capbility register +* from 0x88 to 0xb0 +*/ #define VMXNET3_REG_WSAL 0xF00/* Wireless Shared Address Lo */ #define VMXNET3_REG_WSAH 0xF08/* Wireless Shared Address Hi */
@@ -103,11 +109,13 @@ typedef enum {VMXNET3_CMD_GET_CONF_INTR ,VMXNET3_CMD_GET_ADAPTIVE_RING_INFO ,VMXNET3_CMD_GET_TXDATA_DESC_SIZE , -VMXNET3_CMD_RESERVED5 , -VMXNET3_CMD_RESERVED6 , -VMXNET3_CMD_RESERVED7 , -VMXNET3_CMD_RESERVED8 , -VMXNET3_CMD_GET_MAX_QUEUES_CONF , +VMXNET3_CMD_RESERVED5 , +VMXNET3_CMD_RESERVED6 , +VMXNET3_CMD_RESERVED7 , +VMXNET3_CMD_RESERVED8 , +VMXNET3_CMD_GET_MAX_QUEUES_CONF , +VMXNET3_CMD_GET_MAX_CAPABILITIES , +VMXNET3_CMD_GET_DCR0_REG , } Vmxnet3_Cmd;/* Adaptive Ring Info Flags */
@@ -877,4 +885,30 @@ do {\#define VMXNET3_DID_PASSTHRU 0xFFFF +#define VMXNET3_DCR_ERROR 31/* error when bit 31 of DCR is set */ +#define VMXNET3_CAP_UDP_RSS 0/* bit 0 of DCR 0 */ +#define VMXNET3_CAP_ESP_RSS_IPV4 1/* bit 1 of DCR 0 */ +#define VMXNET3_CAP_GENEVE_CHECKSUM_OFFLOAD 2/* bit 2 of DCR 0 */ +#define VMXNET3_CAP_GENEVE_TSO 3/* bit 3 of DCR 0 */ +#define VMXNET3_CAP_VXLAN_CHECKSUM_OFFLOAD 4/* bit 4 of DCR 0 */ +#define VMXNET3_CAP_VXLAN_TSO 5/* bit 5 of DCR 0 */ +#define VMXNET3_CAP_GENEVE_OUTER_CHECKSUM_OFFLOAD 6/* bit 6 of DCR 0 */ +#define VMXNET3_CAP_VXLAN_OUTER_CHECKSUM_OFFLOAD 7/* bit 7 of DCR 0 */ +#define VMXNET3_CAP_PKT_STEERING_IPV4 8/* bit 8 of DCR 0 */ +#define VMXNET3_CAP_VERSION_4_MAX VMXNET3_CAP_PKT_STEERING_IPV4 +#define VMXNET3_CAP_ESP_RSS_IPV6 9/* bit 9 of DCR 0 */ +#define VMXNET3_CAP_VERSION_5_MAX VMXNET3_CAP_ESP_RSS_IPV6 +#define VMXNET3_CAP_ESP_OVER_UDP_RSS 10/* bit 10 of DCR 0 */ +#define VMXNET3_CAP_INNER_RSS 11/* bit 11 of DCR 0 */ +#define VMXNET3_CAP_INNER_ESP_RSS 12/* bit 12 of DCR 0 */ +#define VMXNET3_CAP_CRC32_HASH_FUNC 13/* bit 13 of DCR 0 */ +#define VMXNET3_CAP_VERSION_6_MAX VMXNET3_CAP_CRC32_HASH_FUNC +#define VMXNET3_CAP_OAM_FILTER 14/* bit 14 of DCR 0 */ +#define VMXNET3_CAP_ESP_QS 15/* bit 15 of DCR 0 */ +#define VMXNET3_CAP_LARGE_BAR 16/* bit 16 of DCR 0 */ +#define VMXNET3_CAP_OOORX_COMP 17/* bit 17 of DCR 0 */ +#define VMXNET3_CAP_VERSION_7_MAX 18 +/* when new capability is introduced, update VMXNET3_CAP_MAX */ +#define VMXNET3_CAP_MAX VMXNET3_CAP_VERSION_7_MAX +#endif /* _VMXNET3_DEFS_H_ */
drivers/net/vmxnet3/vmxnet3_ethdev.c +71 -0
89 lines not on this page · raw message
drivers/net/vmxnet3/vmxnet3_ethdev.h +11 -0
@@ -122,6 +122,17 @@ struct vmxnet3_hw {UPT1_RxStats saved_rx_stats[VMXNET3_EXT_MAX_RX_QUEUES ];UPT1_TxStats snapshot_tx_stats[VMXNET3_MAX_TX_QUEUES ];UPT1_RxStats snapshot_rx_stats[VMXNET3_MAX_RX_QUEUES ]; +/* device capability bit map */ +uint32_t DCR_capabilities[8 ]; +/* pass-through capability bit map */ +uint32_t PTCR_capabilities[8 ]; +/* max number of capabilities */ +uint32_t max_capabilities[8 ]; +/* used device capability bit map */ +uint32_t used_DCR_capabilities[8 ]; +/* used pass-through capability bit map */ +uint32_t used_PTCR_capabilities[8 ]; +bool uptv2_enabled; };#define VMXNET3_REV_7 6/* Vmxnet3 Rev. 7 */
lib/ethdev/rte_ethdev.h +2 -0
@@ -1606,6 +1606,8 @@ struct rte_eth_conf {#define RTE_ETH_DEV_CAPA_FLOW_RULE_KEEP RTE_BIT64(3)/** Device supports keeping shared flow objects across restart. */ #define RTE_ETH_DEV_CAPA_FLOW_SHARED_OBJECT_KEEP RTE_BIT64(4) +/**< (vmxnet3) Device supports smart NIC pass through queues */ +#define RTE_ETH_DEV_CAPA_PASS_THRU RTE_BIT64(5)/**@}*/ /*
Signature · 1 line
2.11.0
Re: [PATCH next 2/7] vmxnet3: add support for capability registers
Quoted 1 line · Ronak Doshi
This patch enhances vmxnet3 to suuport capability registers which
s/suuport/support/
Quoted 6 lines
allows it to enable features selectively. The DCR register tracks the capabilities vmxnet3 device supports. The PTCR register states the capabilities that the passthrough device supports.
With the help of these registers, vmxnet3 can enable only those features which the passthrough device supoprts. This allows
s/supoprts/supports/
Quoted 1 line
smooth trasition to Uniform-Passthrough (UPT) mode if the virtual
s/trasition/transition/
Quoted 1 line
nic requests it. If PTCR register returns nothing or error it means
s/nic/NIC/
Quoted 4 lines
UPT is not being requested and vnic will continue in emulation mode.
Signed-off-by Ronak Doshi <[email protected]>Acked-by Jochen Behrens <[email protected]>
<...>
Quoted 35 lines
drivers/net/vmxnet3/vmxnet3_ethdev.c +35
-0+static int +eth_vmxnet3_setup_capabilities (struct vmxnet3_hw *hw, +struct rte_eth_dev *eth_dev) +{ +uint32_t dcr, ptcr, value; +struct rte_pci_device *pci_dev =RTE_ETH_DEV_TO_PCI (eth_dev); + +VMXNET3_WRITE_BAR1_REG (hw,VMXNET3_REG_CMD , +VMXNET3_CMD_GET_MAX_CAPABILITIES ); + value =VMXNET3_READ_BAR1_REG (hw,VMXNET3_REG_CMD ); + hw->max_capabilities[0 ] = value; + dcr =VMXNET3_READ_BAR1_REG (hw,VMXNET3_REG_DCR ); + hw->DCR_capabilities[0 ] = dcr; + hw->used_DCR_capabilities[0 ] =0 ; + ptcr =VMXNET3_READ_BAR1_REG (hw,VMXNET3_REG_PTCR ); + hw->PTCR_capabilities[0 ] = ptcr; + hw->used_PTCR_capabilities[0 ] =0 ; + +if (hw->uptv2_enabled && !(ptcr & (1 <<VMXNET3_DCR_ERROR ))) { +PMD_DRV_LOG (NOTICE ,"UPTv2 enabled" ); + hw->used_PTCR_capabilities[0 ] = ptcr; + }else { +/* Use all DCR capabilities, but disable large bar */ + hw->used_DCR_capabilities[0 ] = dcr & + (~(1UL <<VMXNET3_CAP_LARGE_BAR )); +PMD_DRV_LOG (NOTICE ,"UPTv2 disabled" ); + } +if (hw->DCR_capabilities[0 ] & (1UL <<VMXNET3_CAP_OOORX_COMP ) && + hw->PTCR_capabilities[0 ] & (1UL <<VMXNET3_CAP_OOORX_COMP )) { +if (hw->uptv2_enabled) { + hw->used_PTCR_capabilities[0 ] |= + (1UL <<VMXNET3_CAP_OOORX_COMP ); + } + } +if (hw->used_PTCR_capabilities[0 ]) {
drivers/net/vmxnet3/vmxnet3_ethdev.c eth_vmxnet3_txdata_get(struct vmxnet3_hw *hw) · line 346
Quoted 10 lines
drivers/net/vmxnet3/vmxnet3_ethdev.c +10
-0+VMXNET3_WRITE_BAR1_REG (hw,VMXNET3_REG_DCR , + hw->used_PTCR_capabilities[0 ]); + }else if (hw->used_DCR_capabilities[0 ]) { +VMXNET3_WRITE_BAR1_REG (hw,VMXNET3_REG_DCR , + hw->used_DCR_capabilities[0 ]); + } +VMXNET3_WRITE_BAR1_REG (hw,VMXNET3_REG_CMD ,VMXNET3_CMD_GET_DCR0_REG ); + dcr =VMXNET3_READ_BAR1_REG (hw,VMXNET3_REG_CMD ); + hw->used_DCR_capabilities[0 ] = dcr; + PMD_DRV_LOG(NOTICE, "Dev "PCI_PRI_FMT", vmxnet3 v%d, UPT enabled: %s, "
Checkpatch complains about syntax:
HECK:CONCATENATED_STRING: Concatenated strings should use spaces between elements
#200: FILE: drivers/net/vmxnet3/vmxnet3_ethdev.c:346:
+ PMD_DRV_LOG(NOTICE, "Dev "PCI_PRI_FMT", vmxnet3 v%d, UPT enabled: %s, "
drivers/net/vmxnet3/vmxnet3_ethdev.c eth_vmxnet3_txdata_get(struct vmxnet3_hw *hw) · line 353
Quoted 7 lines
drivers/net/vmxnet3/vmxnet3_ethdev.c +7
-0+"DCR0=0x%08x, used DCR=0x%08x, " +"PTCR=0x%08x, used PTCR=0x%08x" , + pci_dev->addr.domain, pci_dev->addr.bus, + pci_dev->addr.devid, pci_dev->addr.function, hw->version, + hw->uptv2_enabled ?"true" :"false" , + hw->DCR_capabilities[0 ], hw->used_DCR_capabilities[0 ], + hw->PTCR_capabilities[0], hw->used_PTCR_capabilities[0]);
This log level is NOTICE, making it visible by default. And this function always called when vesion >= 7.
Are you sure to make log this verbose? Or can it be DEBUG level?
<...>
lib/ethdev/rte_ethdev.h struct rte_eth_conf { · line 1610
Quoted 8 lines
lib/ethdev/rte_ethdev.h +2
-0@@ -1606,6 +1606,8 @@ struct rte_eth_conf {#define RTE_ETH_DEV_CAPA_FLOW_RULE_KEEP RTE_BIT64(3)/** Device supports keeping shared flow objects across restart. */ #define RTE_ETH_DEV_CAPA_FLOW_SHARED_OBJECT_KEEP RTE_BIT64(4) +/**< (vmxnet3) Device supports smart NIC pass through queues */ +#define RTE_ETH_DEV_CAPA_PASS_THRU RTE_BIT64(5)
'dev_info->dev_capa' is for generic device capabilities, we can't have device specific capability here.
Can you please describe why it is required to expose this capability to user, what user should do with this information?
PATCH 3/7 vmxnet3: add support for large passthrough BAR register
In reply to Ronak DoshiFor vmxnet3 to work in UPT mode, the BAR sizes have been increased. The PT page has been extended to 2 pages and also includes OOB pages as a part of PT BAR. This patch enhances vmxnet3 to use appropriate BAR offsets based on the capability registered. To use new offsets, VMXNET3_CAP_LARGE_BAR needs to be set by the device. If it is not set then the device will use legacy PT page layout.
--- drivers/net/vmxnet3/base/vmxnet3_defs.h | 13 +++++++++++-- drivers/net/vmxnet3/vmxnet3_ethdev.c | 11 +++++++++++ drivers/net/vmxnet3/vmxnet3_ethdev.h | 2 ++ drivers/net/vmxnet3/vmxnet3_rxtx.c | 13 +++++++------ 4 files changed, 31 insertions(+), 8 deletions(-)
drivers/net/vmxnet3/base/vmxnet3_defs.h +11 -2
@@ -43,8 +43,16 @@#define VMXNET3_REG_RXPROD 0x800/* Rx Producer Index for ring 1 */ #define VMXNET3_REG_RXPROD2 0xA00/* Rx Producer Index for ring 2 */ -#define VMXNET3_PT_REG_SIZE 4096/* BAR 0 */ -#define VMXNET3_VD_REG_SIZE 4096/* BAR 1 */ +/* For Large PT BAR, the following offset to DB register */ +#define VMXNET3_REG_LB_TXPROD 0x1000/* Tx Producer Index */ +#define VMXNET3_REG_LB_RXPROD 0x1400/* Rx Producer Index for ring 1 */ +#define VMXNET3_REG_LB_RXPROD2 0x1800/* Rx Producer Index for ring 2 */ + +#define VMXNET3_PT_REG_SIZE 4096/* BAR 0 */ +#define VMXNET3_LARGE_PT_REG_SIZE 8192/* large PT pages */ +#define VMXNET3_VD_REG_SIZE 4096/* BAR 1 */ +#define VMXNET3_LARGE_BAR0_REG_SIZE (4096 * 4096)/* LARGE BAR 0 */ +#define VMXNET3_OOB_REG_SIZE (4094 * 4096)/* OOB pages */ /* * The two Vmxnet3 MMIO Register PCI BARs (BAR 0 at offset 10h and BAR 1 at
@@ -56,6 +64,7 @@* VMXNET3_MSIX_BAR_SIZE is defined in "vmxnet3Int.h" */ #define VMXNET3_PHYSMEM_PAGES 4 +#define VMXNET3_PHYSMEM_LB_PAGES 4099/* 4096 + 1 + 2 */ #define VMXNET3_REG_ALIGN 8/* All registers are 8-byte aligned. */ #define VMXNET3_REG_ALIGN_MASK 0x7
drivers/net/vmxnet3/vmxnet3_ethdev.c +11 -0
@@ -456,6 +456,17 @@ eth_vmxnet3_dev_init(struct rte_eth_dev *eth_dev) hw->uptv2_enabled = TRUE;eth_vmxnet3_setup_capabilities (hw, eth_dev); } + +if (hw->used_DCR_capabilities[0 ] & (1 <<VMXNET3_CAP_LARGE_BAR )) { + hw->tx_prod_offset =VMXNET3_REG_LB_TXPROD ; + hw->rx_prod_offset[0 ] =VMXNET3_REG_LB_RXPROD ; + hw->rx_prod_offset[1 ] =VMXNET3_REG_LB_RXPROD2 ; + }else { + hw->tx_prod_offset =VMXNET3_REG_TXPROD ; + hw->rx_prod_offset[0 ] =VMXNET3_REG_RXPROD ; + hw->rx_prod_offset[1 ] =VMXNET3_REG_RXPROD2 ; + } +/* Getting MAC Address */ mac_lo =VMXNET3_READ_BAR1_REG (hw,VMXNET3_REG_MACL ); mac_hi =VMXNET3_READ_BAR1_REG (hw,VMXNET3_REG_MACH );
drivers/net/vmxnet3/vmxnet3_ethdev.h +2 -0
@@ -122,6 +122,8 @@ struct vmxnet3_hw {UPT1_RxStats saved_rx_stats[VMXNET3_EXT_MAX_RX_QUEUES ];UPT1_TxStats snapshot_tx_stats[VMXNET3_MAX_TX_QUEUES ];UPT1_RxStats snapshot_rx_stats[VMXNET3_MAX_RX_QUEUES ]; +uint16_t tx_prod_offset; +uint16_t rx_prod_offset[2 ];/* device capability bit map */ uint32_t DCR_capabilities[8 ];/* pass-through capability bit map */
drivers/net/vmxnet3/vmxnet3_rxtx.c +7 -6
@@ -57,8 +57,6 @@#define VMXNET3_TX_OFFLOAD_NOTSUP_MASK \ (RTE_MBUF_F_TX_OFFLOAD_MASK ^ VMXNET3_TX_OFFLOAD_MASK) -static const uint32_t rxprod_reg[2 ] = {VMXNET3_REG_RXPROD ,VMXNET3_REG_RXPROD2 }; -static int vmxnet3_post_rx_bufs (vmxnet3_rx_queue_t *,uint8_t );static void vmxnet3_tq_tx_complete (vmxnet3_tx_queue_t *);#ifdef RTE_LIBRTE_VMXNET3_DEBUG_DRIVER_NOT_USED
@@ -577,7 +575,7 @@ vmxnet3_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts,if (deferred >=rte_le_to_cpu_32 (txq_ctrl->txThreshold)) { txq_ctrl->txNumDeferred =0 ;/* Notify vSwitch that packets are available. */ -VMXNET3_WRITE_BAR0_REG (hw, (VMXNET3_REG_TXPROD + txq->queue_id *VMXNET3_REG_ALIGN ), +VMXNET3_WRITE_BAR0_REG (hw, (hw->tx_prod_offset + txq->queue_id *VMXNET3_REG_ALIGN ), txq->cmd_ring.next2fill); }
@@ -1000,7 +998,8 @@ vmxnet3_recv_pkts(void *rx_queue, struct rte_mbuf **rx_pkts, uint16_t nb_pkts)/* It's time to renew descriptors */ vmxnet3_renew_desc (rxq, ring_idx, newm);if (unlikely (rxq->shared->ctrl.updateRxProd)) { -VMXNET3_WRITE_BAR0_REG (hw, rxprod_reg[ring_idx] + (rxq->queue_id *VMXNET3_REG_ALIGN ), +VMXNET3_WRITE_BAR0_REG (hw, hw->rx_prod_offset[ring_idx] + + (rxq->queue_id *VMXNET3_REG_ALIGN ), rxq->cmd_ring[ring_idx].next2fill); }
@@ -1027,7 +1026,8 @@ vmxnet3_recv_pkts(void *rx_queue, struct rte_mbuf **rx_pkts, uint16_t nb_pkts) }if (unlikely (rxq->shared->ctrl.updateRxProd)) {for (ring_idx =0 ; ring_idx <VMXNET3_RX_CMDRING_SIZE ; ring_idx++) { -VMXNET3_WRITE_BAR0_REG (hw, rxprod_reg[ring_idx] + (rxq->queue_id *VMXNET3_REG_ALIGN ), +VMXNET3_WRITE_BAR0_REG (hw, hw->rx_prod_offset[ring_idx] + + (rxq->queue_id *VMXNET3_REG_ALIGN ), rxq->cmd_ring[ring_idx].next2fill); } }
@@ -1322,7 +1322,8 @@ vmxnet3_dev_rxtx_init(struct rte_eth_dev *dev)* mbufs for coming packets. */ if (unlikely (rxq->shared->ctrl.updateRxProd)) { -VMXNET3_WRITE_BAR0_REG (hw, rxprod_reg[j] + (rxq->queue_id *VMXNET3_REG_ALIGN ), +VMXNET3_WRITE_BAR0_REG (hw, hw->rx_prod_offset[j] + + (rxq->queue_id *VMXNET3_REG_ALIGN ), rxq->cmd_ring[j].next2fill); } }
Signature · 1 line
2.11.0
PATCH 4/7 vmxnet3: add command to set ring buffer sizes
In reply to Ronak DoshiThis patch adds a new command to set ring buffer sizes. This is required to pass the buffer size information to passthrough devices. Also, ring sizes are round down to power of 2.
--- drivers/net/vmxnet3/base/vmxnet3_defs.h | 15 +++++++++++++++ drivers/net/vmxnet3/vmxnet3_ethdev.c | 18 ++++++++++++++++++ drivers/net/vmxnet3/vmxnet3_ethdev.h | 1 + drivers/net/vmxnet3/vmxnet3_rxtx.c | 7 +++++++ 4 files changed, 41 insertions(+)
drivers/net/vmxnet3/base/vmxnet3_defs.h +15 -0
@@ -105,6 +105,9 @@ typedef enum {VMXNET3_CMD_RESERVED4 ,VMXNET3_CMD_REGISTER_MEMREGS ,VMXNET3_CMD_SET_RSS_FIELDS , +VMXNET3_CMD_RESERVED9 , +VMXNET3_CMD_RESERVED10 , +VMXNET3_CMD_SET_RING_BUFFER_SIZE ,VMXNET3_CMD_FIRST_GET =0xF00D0000 , VMXNET3_CMD_GET_QUEUE_STATUS = VMXNET3_CMD_FIRST_GET,
@@ -822,6 +825,17 @@ typedef enum Vmxnet3_RSSField {VMXNET3_RSS_FIELDS_ESPIP6 =0x0020 , } Vmxnet3_RSSField; +typedef +#include "vmware_pack_begin.h" +struct Vmxnet3_RingBufferSize { +__le16 ring1BufSizeType0; +__le16 ring1BufSizeType1; +__le16 ring2BufSizeType1; +__le16 pad; +} +#include "vmware_pack_end.h" +Vmxnet3_RingBufferSize; +/* * If the command data <= 16 bytes, use the shared memory direcly. * Otherwise, use the variable length configuration descriptor.
@@ -832,6 +846,7 @@ union Vmxnet3_CmdInfo {Vmxnet3_VariableLenConfDesc varConf;Vmxnet3_SetPolling setPolling;Vmxnet3_RSSField setRSSFields; +Vmxnet3_RingBufferSize ringBufSize;__le16 reserved[2 ];__le64 data[2 ]; }
drivers/net/vmxnet3/vmxnet3_ethdev.c +18 -0
@@ -1018,6 +1018,22 @@ vmxnet3_setup_driver_shared(struct rte_eth_dev *dev)return VMXNET3_SUCCESS ; } +static void +vmxnet3_init_bufsize (struct vmxnet3_hw *hw) +{ +struct Vmxnet3_DriverShared *shared = hw->shared; +union Vmxnet3_CmdInfo *cmd_info = &shared->cu.cmdInfo; + +if (!VMXNET3_VERSION_GE_7 (hw)) +return ; + + cmd_info->ringBufSize.ring1BufSizeType0 = hw->rxdata_buf_size; + cmd_info->ringBufSize.ring1BufSizeType1 =0 ; + cmd_info->ringBufSize.ring2BufSizeType1 = hw->rxdata_buf_size; +VMXNET3_WRITE_BAR1_REG (hw,VMXNET3_REG_CMD , +VMXNET3_CMD_SET_RING_BUFFER_SIZE ); +} +/* * Configure device link speed and setup link. * Must be called after eth_vmxnet3_dev_init. Other wise it might fail
@@ -1101,6 +1117,8 @@ vmxnet3_dev_start(struct rte_eth_dev *dev)return ret; } +vmxnet3_init_bufsize (hw); + hw->adapter_stopped = FALSE;/* Setting proper Rx Mode and issue Rx Mode Update command */
drivers/net/vmxnet3/vmxnet3_ethdev.h +1 -0
@@ -96,6 +96,7 @@ struct vmxnet3_hw {uint16_t txdata_desc_size;/* tx data ring buffer size */ uint16_t rxdata_desc_size;/* rx data ring buffer size */ +uint16_t rxdata_buf_size;/* rx data buffer size */ uint8_t num_intrs;
drivers/net/vmxnet3/vmxnet3_rxtx.c +7 -0
@@ -1113,6 +1113,8 @@ vmxnet3_dev_tx_queue_setup(struct rte_eth_dev *dev,return -EINVAL ; }else { ring->size = nb_desc; +if (VMXNET3_VERSION_GE_7 (hw)) + ring->size =rte_align32prevpow2 (nb_desc); ring->size &= ~VMXNET3_RING_SIZE_MASK ; } comp_ring->size = data_ring->size = ring->size;
@@ -1193,6 +1195,9 @@ vmxnet3_dev_rx_queue_setup(struct rte_eth_dev *dev, } rxq->mp = mp; +/* Remember buffer size for initialization in dev start. */ + hw->rxdata_buf_size = +rte_pktmbuf_data_room_size (mp) -RTE_PKTMBUF_HEADROOM ; rxq->queue_id = queue_idx; rxq->port_id = dev->data->port_id; rxq->shared =NULL ;/* set in vmxnet3_setup_driver_shared() */
@@ -1217,6 +1222,8 @@ vmxnet3_dev_rx_queue_setup(struct rte_eth_dev *dev,return -EINVAL ; }else { ring0->size = nb_desc; +if (VMXNET3_VERSION_GE_7 (hw)) + ring0->size =rte_align32prevpow2 (nb_desc); ring0->size &= ~VMXNET3_RING_SIZE_MASK ; ring1->size = ring0->size; }
Signature · 1 line
2.11.0
Re: [PATCH next 4/7] vmxnet3: add command to set ring buffer sizes
Quoted 32 lines · Ronak Doshi
This patch adds a new command to set ring buffer sizes. This is required to pass the buffer size information to passthrough devices. Also, ring sizes are round down to power of 2.
Signed-off-by Ronak Doshi <[email protected]>Acked-by Jochen Behrens <[email protected]>--- drivers/net/vmxnet3/base/vmxnet3_defs.h | 15 +++++++++++++++ drivers/net/vmxnet3/vmxnet3_ethdev.c | 18 ++++++++++++++++++ drivers/net/vmxnet3/vmxnet3_ethdev.h | 1 + drivers/net/vmxnet3/vmxnet3_rxtx.c | 7 +++++++ 4 files changed, 41 insertions(+)drivers/net/vmxnet3/base/vmxnet3_defs.h +4
-0@@ -105,6 +105,9 @@ typedef enum {VMXNET3_CMD_RESERVED4 ,VMXNET3_CMD_REGISTER_MEMREGS ,VMXNET3_CMD_SET_RSS_FIELDS , +VMXNET3_CMD_RESERVED9 , +VMXNET3_CMD_RESERVED10 , +VMXNET3_CMD_SET_RING_BUFFER_SIZE ,VMXNET3_CMD_FIRST_GET =0xF00D0000 , VMXNET3_CMD_GET_QUEUE_STATUS = VMXNET3_CMD_FIRST_GET,@@ -822,6 +825,17 @@ typedef enum Vmxnet3_RSSField {VMXNET3_RSS_FIELDS_ESPIP6 =0x0020 , } Vmxnet3_RSSField; +typedef
drivers/net/vmxnet3/base/vmxnet3_defs.h typedef enum Vmxnet3_RSSField { · line 838
Quoted 10 lines
drivers/net/vmxnet3/base/vmxnet3_defs.h +10
-0+#include "vmware_pack_begin.h" +struct Vmxnet3_RingBufferSize { +__le16 ring1BufSizeType0; +__le16 ring1BufSizeType1; +__le16 ring2BufSizeType1; +__le16 pad; +} +#include "vmware_pack_end.h" +Vmxnet3_RingBufferSize; +
As far as I can see these "vmware_pack_begin.h" & "vmware_pack_end.h" has only file license comment, and I can see this is used in a few other type declaration.
What is the reasoning behind using these headers?
Re: [PATCH next 4/7] vmxnet3: add command to set ring buffer sizes
Quoted 5 lines · On 4/26/23, 9:58 AM, "Ferruh Yigit" <[email protected]…
As far as I can see these "
vmware_pack_begin.h" & "vmware_pack_end.h" has only file license comment, and I can see this is used in a few other type declaration.What is the reasoning behind using these headers?
This has been the case since driver was added to dpdk. The information is present in README. I did not want to change the format being used for the declarations in the driver.
Thanks,
Ronak
Re: [PATCH next 4/7] vmxnet3: add command to set ring buffer sizes
Quoted 4 lines · Ronak Doshi
On 4/26/23, 9:58 AM, "Ferruh Yigit" <[email protected] <mailto:[email protected]>> wrote:
Quoted 9 lines
Quoted 5 lines
As far as I can see these "
vmware_pack_begin.h" & "vmware_pack_end.h" has only file license comment, and I can see this is used in a few other type declaration.What is the reasoning behind using these headers?
This has been the case since driver was added to dpdk. The information is present in README. I did not want to change the format being used for the declarations in the driver.
README doesn't say much.
The usage is not standard, and intention is not clear.
Can you please dig this issue more to learn the the intention, may be we can find a better way or get rid of them completely?
Just to record, usage is:
typedef
#include "vmware_pack_begin.h"
struct Vmxnet3_RingBufferSize {
__le16 ring1BufSizeType0; __le16 ring1BufSizeType1; __le16 ring2BufSizeType1; __le16 pad;
}
#include "vmware_pack_end.h"
Vmxnet3_RingBufferSize;
Content of "vmware_pack_begin.h":
``` /* SPDX-License-Identifier: BSD-3-Clause * Copyright(c) 2010-2014 Intel Corporation */ ```
"vmware_pack_end.h":
``` /* SPDX-License-Identifier: BSD-3-Clause * Copyright(c) 2010-2014 Intel Corporation */ ```
Re: [PATCH next 4/7] vmxnet3: add command to set ring buffer sizes
Quoted 6 lines · > On 4/27/23, 1:51 AM, "Ferruh Yigit" <[email protected]…
README doesn't say much.
The usage is not standard, and intention is not clear.
Can you please dig this issue more to learn the the intention, may be we can find a better way or get rid of them completely?
Sure, I can take this up, but it will be better if that is investigated and done as a separate patch as lot of definitions include those header files. The intention of this patch series is completely different, and I don't want to break or delay this patch series. Is that OK?
Thanks,
Ronak
Re: [PATCH next 4/7] vmxnet3: add command to set ring buffer sizes
Quoted 5 lines · Ronak Doshi
Quoted 3 lines · > On 4/27/23, 1:51 AM, "Ferruh Yigit" <[email protected]…
README doesn't say much.
Quoted 8 lines
Quoted 3 lines
The usage is not standard, and intention is not clear.
Can you please dig this issue more to learn the the intention, may be we can find a better way or get rid of them completely?Sure, I can take this up, but it will be better if that is investigated and done as a separate patch as lot of definitions include those header files. The intention of this patch series is completely different, and I don't want to break or delay this patch series. Is that OK?
OK to address it as a separate patch, but please follow the issue.
PATCH 5/7 vmxnet3: limit number of TXDs used for TSO packet
In reply to Ronak DoshiCurrently, vmxnet3 does not have a limit on number of descriptors used for a TSO packet. However, with UPT, for hardware performance reasons, this patch limits the number of transmit descriptors to 24 for a TSO packet.
--- drivers/net/vmxnet3/base/vmxnet3_defs.h | 2 ++ drivers/net/vmxnet3/vmxnet3_rxtx.c | 18 ++++++++++++++---- 2 files changed, 16 insertions(+), 4 deletions(-)
drivers/net/vmxnet3/base/vmxnet3_defs.h +2 -0
@@ -419,6 +419,8 @@ typedef union Vmxnet3_GenericDesc {/* max # of tx descs for a non-tso pkt */ #define VMXNET3_MAX_TXD_PER_PKT 16 +/* max # of tx descs for a tso pkt */ +#define VMXNET3_MAX_TSO_TXD_PER_PKT 24/* Max size of a single rx buffer */ #define VMXNET3_MAX_RX_BUF_SIZE ((1 << 14) - 1)
drivers/net/vmxnet3/vmxnet3_rxtx.c +14 -4
@@ -364,6 +364,14 @@ vmxnet3_prep_pkts(__rte_unused void *tx_queue, struct rte_mbuf **tx_pkts, rte_errno =EINVAL ;return i; } +/* TSO packet cannot occupy more than +* VMXNET3_MAX_TSO_TXD_PER_PKT TX descriptors. +*/ +if ((ol_flags &RTE_MBUF_F_TX_TCP_SEG ) !=0 && + m->nb_segs >VMXNET3_MAX_TSO_TXD_PER_PKT ) { + rte_errno =EINVAL ; +return i; + }/* check that only supported TX offloads are requested. */ if ((ol_flags & VMXNET3_TX_OFFLOAD_NOTSUP_MASK) != 0 ||
@@ -444,10 +452,12 @@ vmxnet3_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts,continue ; } -/* Drop non-TSO packet that is excessively fragmented */ -if (unlikely (!tso && count >VMXNET3_MAX_TXD_PER_PKT )) { -PMD_TX_LOG (ERR ,"Non-TSO packet cannot occupy more than %d tx " -"descriptors. Packet dropped." ,VMXNET3_MAX_TXD_PER_PKT ); +/* Drop non-TSO or TSO packet that is excessively fragmented */ +if (unlikely ((!tso && count >VMXNET3_MAX_TXD_PER_PKT ) || + (tso && count >VMXNET3_MAX_TSO_TXD_PER_PKT ))) { +PMD_TX_LOG (ERR ,"Non-TSO or TSO packet cannot occupy more than " +"%d or %d tx descriptors respectively. Packet dropped." , +VMXNET3_MAX_TXD_PER_PKT ,VMXNET3_MAX_TSO_TXD_PER_PKT ); txq->stats.drop_too_many_segs++; txq->stats.drop_total++;rte_pktmbuf_free (txm);
Signature · 1 line
2.11.0
PATCH 6/7 vmxnet3: avoid updating rxprod register frequently
In reply to Ronak DoshiWhen UPT is enabled, the driver updates rxprod register to let the device know that it has processed the received packets and new buffers are available. However, updating it too frequently can lead to reduced performance.
This patch adds code to avoid updating the register frequently.
--- drivers/net/vmxnet3/vmxnet3_rxtx.c | 14 +++++++++----- 1 file changed, 9 insertions(+), 5 deletions(-)
drivers/net/vmxnet3/vmxnet3_rxtx.c +9 -5
@@ -1007,7 +1007,8 @@ vmxnet3_recv_pkts(void *rx_queue, struct rte_mbuf **rx_pkts, uint16_t nb_pkts)/* It's time to renew descriptors */ vmxnet3_renew_desc (rxq, ring_idx, newm); -if (unlikely (rxq->shared->ctrl.updateRxProd)) { +if (unlikely (rxq->shared->ctrl.updateRxProd && + (rxq->cmd_ring[ring_idx].next2fill &0xf ) ==0 )) {VMXNET3_WRITE_BAR0_REG (hw, hw->rx_prod_offset[ring_idx] + (rxq->queue_id *VMXNET3_REG_ALIGN ), rxq->cmd_ring[ring_idx].next2fill);
@@ -1027,18 +1028,21 @@ vmxnet3_recv_pkts(void *rx_queue, struct rte_mbuf **rx_pkts, uint16_t nb_pkts)if (unlikely (nb_rxd ==0 )) {uint32_t avail; +uint32_t posted =0 ;for (ring_idx =0 ; ring_idx <VMXNET3_RX_CMDRING_SIZE ; ring_idx++) { avail =vmxnet3_cmd_ring_desc_avail (&rxq->cmd_ring[ring_idx]);if (unlikely (avail >0 )) {/* try to alloc new buf and renew descriptors */ -vmxnet3_post_rx_bufs (rxq, ring_idx); +if (vmxnet3_post_rx_bufs (rxq, ring_idx) >0 ) + posted |= (1 << ring_idx); } }if (unlikely (rxq->shared->ctrl.updateRxProd)) {for (ring_idx =0 ; ring_idx <VMXNET3_RX_CMDRING_SIZE ; ring_idx++) { -VMXNET3_WRITE_BAR0_REG (hw, hw->rx_prod_offset[ring_idx] + - (rxq->queue_id *VMXNET3_REG_ALIGN ), - rxq->cmd_ring[ring_idx].next2fill); +if (posted & (1 << ring_idx)) +VMXNET3_WRITE_BAR0_REG (hw, hw->rx_prod_offset[ring_idx] + + (rxq->queue_id *VMXNET3_REG_ALIGN ), + rxq->cmd_ring[ring_idx].next2fill); } } }
Signature · 1 line
2.11.0
PATCH 7/7 vmxnet3: update to version 7
In reply to Ronak DoshiWith all vmxnet3 version 7 changes incorporated in the vmxnet3 driver, the driver can configure emulation to run at vmxnet3 version 7, provided the emulation advertises support for version 7.
--- drivers/net/vmxnet3/vmxnet3_ethdev.c | 6 +++++- drivers/net/vmxnet3/vmxnet3_ring.h | 2 +- 2 files changed, 6 insertions(+), 2 deletions(-)
drivers/net/vmxnet3/vmxnet3_ethdev.c +5 -1
@@ -410,7 +410,11 @@ eth_vmxnet3_dev_init(struct rte_eth_dev *eth_dev)/* Check h/w version compatibility with driver. */ ver =VMXNET3_READ_BAR1_REG (hw,VMXNET3_REG_VRRS ); -if (ver & (1 <<VMXNET3_REV_6 )) { +if (ver & (1 <<VMXNET3_REV_7 )) { +VMXNET3_WRITE_BAR1_REG (hw,VMXNET3_REG_VRRS , +1 <<VMXNET3_REV_7 ); + hw->version =VMXNET3_REV_7 +1 ; + }else if (ver & (1 <<VMXNET3_REV_6 )) {VMXNET3_WRITE_BAR1_REG (hw,VMXNET3_REG_VRRS ,1 <<VMXNET3_REV_6 ); hw->version =VMXNET3_REV_6 +1 ;
drivers/net/vmxnet3/vmxnet3_ring.h +1 -1
@@ -7,7 +7,7 @@#define VMXNET3_RX_CMDRING_SIZE 2 -#define VMXNET3_DRIVER_VERSION_NUM 0x01012000 +#define VMXNET3_DRIVER_VERSION_NUM 0x01013000/* Default ring size */ #define VMXNET3_DEF_TX_RING_SIZE 512
Signature · 1 line
2.11.0
Quoted 43 lines · Ronak Doshi
vmxnet3 emulation has recently added several new features including support for uniform passthrough(UPT). To make UPT work vmxnet3 has to be enhanced as per the new specification. This patch series extends the vmxnet3 driver to leverage these new features.
Compatibility is maintained using existing vmxnet3 versioning mechanism as follows:
- new features added to vmxnet3 emulation are associated with new vmxnet3 version viz. vmxnet3 version 7.
- emulation advertises all the versions it supports to the driver.
- during initialization, vmxnet3 driver picks the highest version number supported by both the emulation and the driver and configures emulation to run at that version.In particular, following changes are introduced:
Patch 1:
This patch introduces utility macros for vmxnet3 version 7 comparison and updates Copyright information.Patch 2:
This patch adds new capability registers to fine control enablement of individual features based on emulation and passthrough.Patch 3:
This patch adds support for large passthrough BAR register.Patch 4:
This patch introduces new command to set ring buffer sizes to pass this information to the hardware.Patch 5:
For better performance, hardware has a requirement to limit number of TSO descriptors. This patch adds that support.Patch 6:
Avoid updating rxprod register when in UPT for performance reasons.Patch 7:
With all vmxnet3 version 7 changes incorporated in the vmxnet3 driver, with this patch, the driver can configure emulation to run at vmxnet3 version 7.
Quoted 9 lines
Ronak Doshi (7):
vmxnet3: prepare for version 7 changes
vmxnet3: add support for capability registers
vmxnet3: add support for large passthrough BAR register
vmxnet3: add command to set ring buffer sizes
vmxnet3: limit number of TXDs used for TSO packet
vmxnet3: avoid updating rxprod register frequently
vmxnet3: update to version 7
Can you please start the patch title with component: "net/vmxnet3: ..."
Quoted 8 lines
drivers/net/vmxnet3/base/vmxnet3_defs.h | 74 +++++++++++++++++++--- drivers/net/vmxnet3/vmxnet3_ethdev.c | 106 +++++++++++++++++++++++++++++++- drivers/net/vmxnet3/vmxnet3_ethdev.h | 16 +++++ drivers/net/vmxnet3/vmxnet3_ring.h | 2 +- drivers/net/vmxnet3/vmxnet3_rxtx.c | 48 +++++++++++---- lib/ethdev/rte_ethdev.h | 2 + 6 files changed, 226 insertions(+), 22 deletions(-)
Can you please update release notes to document the driver update?
Also what do you think to update driver documentation to document uniform passthrough(UPT) support, how to use it etc? Or other features coming with V7?
Quoted 65 lines · Ferruh Yigit
Quoted 43 lines · Ronak Doshi
vmxnet3 emulation has recently added several new features including support for uniform passthrough(UPT). To make UPT work vmxnet3 has to be enhanced as per the new specification. This patch series extends the vmxnet3 driver to leverage these new features.
Compatibility is maintained using existing vmxnet3 versioning mechanism as follows:
- new features added to vmxnet3 emulation are associated with new vmxnet3 version viz. vmxnet3 version 7.
- emulation advertises all the versions it supports to the driver.
- during initialization, vmxnet3 driver picks the highest version number supported by both the emulation and the driver and configures emulation to run at that version.In particular, following changes are introduced:
Patch 1:
This patch introduces utility macros for vmxnet3 version 7 comparison and updates Copyright information.Patch 2:
This patch adds new capability registers to fine control enablement of individual features based on emulation and passthrough.Patch 3:
This patch adds support for large passthrough BAR register.Patch 4:
This patch introduces new command to set ring buffer sizes to pass this information to the hardware.Patch 5:
For better performance, hardware has a requirement to limit number of TSO descriptors. This patch adds that support.Patch 6:
Avoid updating rxprod register when in UPT for performance reasons.Patch 7:
With all vmxnet3 version 7 changes incorporated in the vmxnet3 driver, with this patch, the driver can configure emulation to run at vmxnet3 version 7.Quoted 9 lines
Ronak Doshi (7):
vmxnet3: prepare for version 7 changes
vmxnet3: add support for capability registers
vmxnet3: add support for large passthrough BAR register
vmxnet3: add command to set ring buffer sizes
vmxnet3: limit number of TXDs used for TSO packet
vmxnet3: avoid updating rxprod register frequently
vmxnet3: update to version 7Can you please start the patch title with component: "net/vmxnet3: ..."
Quoted 8 lines
drivers/net/vmxnet3/base/vmxnet3_defs.h | 74 +++++++++++++++++++--- drivers/net/vmxnet3/vmxnet3_ethdev.c | 106 +++++++++++++++++++++++++++++++- drivers/net/vmxnet3/vmxnet3_ethdev.h | 16 +++++ drivers/net/vmxnet3/vmxnet3_ring.h | 2 +- drivers/net/vmxnet3/vmxnet3_rxtx.c | 48 +++++++++++---- lib/ethdev/rte_ethdev.h | 2 + 6 files changed, 226 insertions(+), 22 deletions(-)
Quoted 6 lines
Can you please update release notes to document the driver update?
Also what do you think to update driver documentation to document uniform passthrough(UPT) support, how to use it etc? Or other features coming with V7?
btw, while checking the driver documentation, it seems it is not updated for a while, the paper it refers is old.
Do you have any newer version of documentation to reference?
Quoted 4 lines · > On 4/26/23, 11:16 AM, "Ferruh Yigit" <[email protected]…
btw, while checking the driver documentation, it seems it is not updated for a while, the paper it refers is old.
Do you have any newer version of documentation to reference?
I don’t think we have any other document for perf, but let me update the document with some details regarding features supported. Also, I will update release notes for these patches.
Thanks,
Ronak
Quoted 10 lines · Ronak Doshi
Quoted 4 lines · > On 4/26/23, 11:16 AM, "Ferruh Yigit" <[email protected]…
btw, while checking the driver documentation, it seems it is not updated for a while, the paper it refers is old.
Do you have any newer version of documentation to reference?I don’t think we have any other document for perf, but let me update the document with some details regarding features supported. Also, I will update release notes for these patches.
That document focuses on 1G and 10G network speeds, and uses "AMD Opteron 2384 Processors" (which seems discontinued at this point). I would expect there is an up to date version of the document, but if there isn't is the existing one still relevant to keep?
Quoted 7 lines · On 4/27/23, 2:16 AM, "Ferruh Yigit" <[email protected]…
That document focuses on 1G and 10G network speeds, and uses "AMD Opteron 2384 Processors" (which seems discontinued at this point). I would expect there is an up to date version of the document, but if there isn't is the existing one still relevant to keep?
I don't think there is any recent public facing performance measurement document for vmxnet3. I will remove the reference to this old document and will update the doc once we have new document in the future.
Thanks,
Ronak
Quoted 12 lines · Ronak Doshi
Quoted 7 lines · On 4/27/23, 2:16 AM, "Ferruh Yigit" <[email protected]…
That document focuses on 1G and 10G network speeds, and uses "AMD Opteron 2384 Processors" (which seems discontinued at this point). I would expect there is an up to date version of the document, but if there isn't is the existing one still relevant to keep?
I don't think there is any recent public facing performance measurement document for vmxnet3. I will remove the reference to this old document and will update the doc once we have new document in the future.
OK, it is good to keep documentation up to date.