Skip to contentSkip to conversation

selftests: damon: add config file

PATCH Applied Anders Roxell 3 participants 4 messages Apr 12, 2023 – Jun 12, 2023

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 selftests: damon: add config file

Building and running the subsuite 'damon' of kselftest, shows the following issues:
selftests: damon: debugfs_attrs.sh
/sys/kernel/debug/damon not found

By creating a config file enabling DAMON fragments in the selftests/damon/ directory the tests pass.

Fixes b348eb7abd09 ("mm/damon: add user space selftests")
---
 tools/testing/selftests/damon/config | 7 +++++++
 1 file changed, 7 insertions(+)
 create mode 100644 tools/testing/selftests/damon/config
tools/testing/selftests/damon/config new file +7 -0
new file mode 100644
index 000000000000..0daf38974eb0
@@ -0,0 +1,7 @@
+CONFIG_DAMON=y
+CONFIG_DAMON_SYSFS=y
+CONFIG_DAMON_DBGFS=y
+CONFIG_DAMON_PADDR=y
+CONFIG_DAMON_VADDR=y
+CONFIG_DAMON_RECLAIM=y
+CONFIG_DAMON_LRU_SORT=y
Signature · 1 line
2.39.2
maintainer Reviewed-by on v2 1/1
#1 lore raw

Hi Anders,

Quoted 10 lines · On Wed, 12 Apr 2023 11:28:54 +0200 Anders Roxell <[email protected]>…

Building and running the subsuite 'damon' of kselftest, shows the following issues:
selftests: damon: debugfs_attrs.sh
/sys/kernel/debug/damon not found

By creating a config file enabling DAMON fragments in the selftests/damon/ directory the tests pass.

Fixes b348eb7abd09 ("mm/damon: add user space selftests")

checkpatch.pl is warning as below:

WARNING: Reported-by: should be immediately followed by Link: with a URL to the report #20:

The reason for the warning can be found from commit d7f1d71e5ef6 ("checkpatch:
warn when Reported-by: is not followed by Link:")'s commit message. Do you have a link to put here? I guess the report was made inside Linaro, so might have no publicly available link. Maybe better to add some notes or some funny tag like "Link: N/A # no publicly-available link of the report" for convincing the tool, but I don't think this should be a blocker for this patch.

Quoted 1 line

Thanks,
SJ

Quoted 20 lines
---
 tools/testing/selftests/damon/config | 7 +++++++
 1 file changed, 7 insertions(+)
 create mode 100644 tools/testing/selftests/damon/config
tools/testing/selftests/damon/config new file +7 -0
new file mode 100644
index 000000000000..0daf38974eb0
@@ -0,0 +1,7 @@
+CONFIG_DAMON=y
+CONFIG_DAMON_SYSFS=y
+CONFIG_DAMON_DBGFS=y
+CONFIG_DAMON_PADDR=y
+CONFIG_DAMON_VADDR=y
+CONFIG_DAMON_RECLAIM=y
+CONFIG_DAMON_LRU_SORT=y
Signature · 1 line
2.39.2
maintainer
#2 lore raw
Quoted 29 lines · On Wed, 12 Apr 2023 16:58:06 +0000 SeongJae Park <[email protected]> wrote:

Hi Anders,

Quoted 10 lines · On Wed, 12 Apr 2023 11:28:54 +0200 Anders Roxell <[email protected]>…

Building and running the subsuite 'damon' of kselftest, shows the following issues:
selftests: damon: debugfs_attrs.sh
/sys/kernel/debug/damon not found

By creating a config file enabling DAMON fragments in the selftests/damon/ directory the tests pass.

Fixes b348eb7abd09 ("mm/damon: add user space selftests")

checkpatch.pl is warning as below:

WARNING: Reported-by: should be immediately followed by Link: with a URL to the report #20:

The reason for the warning can be found from commit d7f1d71e5ef6 ("checkpatch:
warn when Reported-by: is not followed by Link:")'s commit message. Do you have a link to put here? I guess the report was made inside Linaro, so might have no publicly available link. Maybe better to add some notes or some funny tag like "Link: N/A # no publicly-available link of the report" for convincing the tool, but I don't think this should be a blocker for this patch.

Quoted 3 lines
Quoted 1 line

Shuah, may I ask your opinion on this patch?

I'm also cc-ing Andrew, as he may also interested in picking this patch.

Thanks,
SJ

Quoted 26 lines

Thanks,
SJ

Quoted 20 lines
---
 tools/testing/selftests/damon/config | 7 +++++++
 1 file changed, 7 insertions(+)
 create mode 100644 tools/testing/selftests/damon/config
tools/testing/selftests/damon/config new file +7 -0
new file mode 100644
index 000000000000..0daf38974eb0
@@ -0,0 +1,7 @@
+CONFIG_DAMON=y
+CONFIG_DAMON_SYSFS=y
+CONFIG_DAMON_DBGFS=y
+CONFIG_DAMON_PADDR=y
+CONFIG_DAMON_VADDR=y
+CONFIG_DAMON_RECLAIM=y
+CONFIG_DAMON_LRU_SORT=y
Signature · 1 line
2.39.2
maintainer Acked-by
#3 lore raw
Quoted 31 lines · SeongJae Park
Quoted 29 lines · On Wed, 12 Apr 2023 16:58:06 +0000 SeongJae Park <[email protected]> wrote:

Hi Anders,

Quoted 10 lines · On Wed, 12 Apr 2023 11:28:54 +0200 Anders Roxell <[email protected]>…

Building and running the subsuite 'damon' of kselftest, shows the following issues:
selftests: damon: debugfs_attrs.sh
/sys/kernel/debug/damon not found

By creating a config file enabling DAMON fragments in the selftests/damon/ directory the tests pass.

Fixes b348eb7abd09 ("mm/damon: add user space selftests")

checkpatch.pl is warning as below:

WARNING: Reported-by: should be immediately followed by Link: with a URL to the report #20:

The reason for the warning can be found from commit d7f1d71e5ef6 ("checkpatch:
warn when Reported-by: is not followed by Link:")'s commit message. Do you have a link to put here? I guess the report was made inside Linaro, so might have no publicly available link. Maybe better to add some notes or some funny tag like "Link: N/A # no publicly-available link of the report" for convincing the tool, but I don't think this should be a blocker for this patch.

Quoted 8 lines
Quoted 3 lines
Quoted 1 line

Shuah, may I ask your opinion on this patch?

I'm also cc-ing Andrew, as he may also interested in picking this patch.

If Andrew wants to pick this up:

thanks,
-- Shuah