Skip to contentSkip to conversation

SPI loopback testing framework updates

PATCH In review Rohit Ner 2 participants 4 messages Apr 12, 2023 – Apr 13, 2023 SPI

lore
Share & tools
lore

Rohit Ner

author
#0 lore raw

v2 cover SPI loopback testing framework updates

---
V1 Changes : Add module param for iteration length
---
V1->V2 Changes : Fix patch format
---

Rohit Ner (1):
spi: spi-loopback-test: Add module param for iteration length

 drivers/spi/spi-loopback-test.c | 8 ++++++++
 1 file changed, 8 insertions(+)
Signature · 1 line
2.40.0.577.gac1e443424-goog
author
#1 lore raw

PATCH v2 1/1 spi: spi-loopback-test: Add module param for iteration length

SPI test framework is designed to run each test case for a list of lengths.
Introduce a module parameter to limit the iterations to a single value among the list of lengths.

---
 drivers/spi/spi-loopback-test.c | 8 ++++++++
 1 file changed, 8 insertions(+)
drivers/spi/spi-loopback-test.c +8 -0
index 313106eb8d40..675a73cf1579 100644
@@ -53,6 +53,12 @@ module_param(no_cs, int, 0);
 MODULE_PARM_DESC(no_cs,
 		 "if set Chip Select (CS) will not be used");
 
+/* run tests only for a specific length */
+static int run_only_iter_len = -1;
+module_param(run_only_iter_len, int, 0);
+MODULE_PARM_DESC(run_only_iter_len,
+		 "only run tests for a length of this number in iterate_len list");
+
 /* run only a specific test */
 static int run_only_test = -1;
 module_param(run_only_test, int, 0);
@@ -1033,6 +1039,8 @@ int spi_test_run_test(struct spi_device *spi, const struct spi_test *test,
 
 	for (idx_len = 0; idx_len < SPI_TEST_MAX_ITERATE &&
 	     (len = test->iterate_len[idx_len]) != -1; idx_len++) {
+		if ((run_only_iter_len > -1) && len != run_only_iter_len)
+			continue;
 		FOR_EACH_ALIGNMENT(tx_align) {
 			FOR_EACH_ALIGNMENT(rx_align) {
 				/* and run the iteration */
Signature · 1 line
2.40.0.577.gac1e443424-goog
maintainer
#2 lore raw
In reply to Rohit Ner
Quoted 5 lines · Rohit Ner

---
V1 Changes : Add module param for iteration length
---
V1->V2 Changes : Fix patch format
---

Please don't send cover letters for single patches, if there is anything that needs saying put it in the changelog of the patch or after the --- if it's administrative stuff. This reduces mail volume and ensures that any important information is recorded in the changelog rather than being lost.

maintainer
#3 lore raw
In reply to Rohit Ner
Quoted 2 lines · Rohit Ner

Applied to

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next

Thanks!

[1/1] spi: spi-loopback-test: Add module param for iteration length

      commit: 6d87552c0b86b9677d762002082df5f5b7e3c33f

All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

Thanks,
Mark