Skip to contentSkip to conversation

tools: ynl: Remove absolute paths to yaml files from ethtool testing tool

PATCH Applied Rahul Rameshbabu 3 participants 5 messages Apr 13, 2023 – Apr 14, 2023

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/2 tools: ynl: Remove absolute paths to yaml files from ethtool testing tool

Absolute paths for the spec and schema files make the ethtool testing tool unusable with freshly checked-out source trees. Replace absolute paths with relative paths for both files in the Documentation/ directory.

Issue seen before the change

Traceback (most recent call last):
File "/home/binary-eater/Documents/mlx/linux/tools/net/ynl/./ethtool", line 424, in <module>
main()
File "/home/binary-eater/Documents/mlx/linux/tools/net/ynl/./ethtool", line 158, in main
ynl = YnlFamily(spec, schema)
File "/home/binary-eater/Documents/mlx/linux/tools/net/ynl/lib/ynl.py", line 342, in __init__
super().__init__(def_path, schema)
File "/home/binary-eater/Documents/mlx/linux/tools/net/ynl/lib/nlspec.py", line 333, in __init__
with open(spec_path, "r") as stream:
FileNotFoundError: [Errno 2] No such file or directory: '/usr/local/google/home/sdf/src/linux/Documentation/netlink/specs/ethtool.yaml'

Fixes f3d07b02b2b8 ("tools: ynl: ethtool testing tool")
---
 tools/net/ynl/ethtool | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
tools/net/ynl/ethtool +2 -2
index 5fb1d670693a..6c9f7e31250c 100755
@@ -152,8 +152,8 @@ def main():
     global args
     args = parser.parse_args()
 
-    spec = '/usr/local/google/home/sdf/src/linux/Documentation/netlink/specs/ethtool.yaml'
-    schema = '/usr/local/google/home/sdf/src/linux/Documentation/netlink/genetlink-legacy.yaml'
+    spec = '../../../Documentation/netlink/specs/ethtool.yaml'
+    schema = '../../../Documentation/netlink/genetlink-legacy.yaml'
 
     ynl = YnlFamily(spec, schema)
 
Signature · 1 line
2.38.4
#1 lore raw

PATCH 2/2 tools: ynl: Rename ethtool to ethtool.py

Make it explicit that this tool is not a drop-in replacement for ethtool. This tool is intended for testing ethtool functionality implemented in the kernel and should use a name that differentiates it from the ethtool utility.

---
 tools/net/ynl/{ethtool => ethtool.py} | 0
 1 file changed, 0 insertions(+), 0 deletions(-)
 rename tools/net/ynl/{ethtool => ethtool.py} (100%)
tools/net/ynl/ethtool.py renamed from tools/net/ynl/ethtool +0 -0
similarity index 100%
rename from tools/net/ynl/ethtool
rename to tools/net/ynl/ethtool.py
Signature · 1 line
2.38.4
#2 lore raw
In reply to Rahul Rameshbabu
This series was applied to netdev/net-next.git (main) by Jakub Kicinski <[email protected]>:

Hello:

This series was applied to netdev/net-next.git (main) by Jakub Kicinski <[email protected]>:

Quoted 17 lines · On Wed, 12 Apr 2023 18:22:51 -0700 you wrote:

Absolute paths for the spec and schema files make the ethtool testing tool unusable with freshly checked-out source trees. Replace absolute paths with relative paths for both files in the Documentation/ directory.

Issue seen before the change

Traceback (most recent call last):
File "/home/binary-eater/Documents/mlx/linux/tools/net/ynl/./ethtool", line 424, in <module>
main()
File "/home/binary-eater/Documents/mlx/linux/tools/net/ynl/./ethtool", line 158, in main
ynl = YnlFamily(spec, schema)
File "/home/binary-eater/Documents/mlx/linux/tools/net/ynl/lib/ynl.py", line 342, in __init__
super().__init__(def_path, schema)
File "/home/binary-eater/Documents/mlx/linux/tools/net/ynl/lib/nlspec.py", line 333, in __init__
with open(spec_path, "r") as stream:
FileNotFoundError: [Errno 2] No such file or directory: '/usr/local/google/home/sdf/src/linux/Documentation/netlink/specs/ethtool.yaml'

Quoted 1 line

[...]

Here is the summary with links:
- [net-next,1/2] tools: ynl: Remove absolute paths to yaml files from ethtool testing tool (no matching commit)
- [net-next,2/2] tools: ynl: Rename ethtool to ethtool.py

    https://git.kernel.org/netdev/net-next/c/f2b3b6a22df7

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
maintainer
#3 lore raw

pw bot mismatches on pure rename patches (was: Re: [PATCH net-next 1/2] tools: ynl: Remove absolute paths to yaml files from ethtool testing tool)

Quoted 7 lines · On Thu, 13 Apr 2023 04:20:18 +0000 [email protected] wrote:

Here is the summary with links:
- [net-next,1/2] tools: ynl: Remove absolute paths to yaml files from ethtool testing tool (no matching commit)
- [net-next,2/2] tools: ynl: Rename ethtool to ethtool.py

    https://git.kernel.org/netdev/net-next/c/f2b3b6a22df7

You are awesome, thank you!

Hi Konstantin,

this may be worth investigating, looks like a generic bug. The patch:
https://lore.kernel.org/all/[email protected]/
has no diff, so I'm guessing it confused the bot and the bot matched on whatever got pushed into the tree next.

#4 lore raw
In reply to Rahul Rameshbabu
This series was applied to netdev/net-next.git (main) by Jakub Kicinski <[email protected]>:

Hello:

This series was applied to netdev/net-next.git (main) by Jakub Kicinski <[email protected]>:

Quoted 17 lines · On Wed, 12 Apr 2023 18:22:51 -0700 you wrote:

Absolute paths for the spec and schema files make the ethtool testing tool unusable with freshly checked-out source trees. Replace absolute paths with relative paths for both files in the Documentation/ directory.

Issue seen before the change

Traceback (most recent call last):
File "/home/binary-eater/Documents/mlx/linux/tools/net/ynl/./ethtool", line 424, in <module>
main()
File "/home/binary-eater/Documents/mlx/linux/tools/net/ynl/./ethtool", line 158, in main
ynl = YnlFamily(spec, schema)
File "/home/binary-eater/Documents/mlx/linux/tools/net/ynl/lib/ynl.py", line 342, in __init__
super().__init__(def_path, schema)
File "/home/binary-eater/Documents/mlx/linux/tools/net/ynl/lib/nlspec.py", line 333, in __init__
with open(spec_path, "r") as stream:
FileNotFoundError: [Errno 2] No such file or directory: '/usr/local/google/home/sdf/src/linux/Documentation/netlink/specs/ethtool.yaml'

Quoted 1 line

[...]

Here is the summary with links:
- [net-next,1/2] tools: ynl: Remove absolute paths to yaml files from ethtool testing tool

    https://git.kernel.org/netdev/net-next/c/3ea31e66644b

- [net-next,2/2] tools: ynl: Rename ethtool to ethtool.py (no matching commit)

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html