gve PMD enhancement
Subsystems (2)
cover gve PMD enhancement
This patch set includs two main enhancements for gve PMD:
- support basic data path with DQO queue format
- support jumbo frame with GQI queue format
This patch set is based on this:
patchwork.dpdk.org/project/dpdk/list/?series=27653&state=*
Junfeng Guo (10):
net/gve: add Tx queue setup for DQO
net/gve: add Rx queue setup for DQO
net/gve: support device start and close for DQO
net/gve: support queue release and stop for DQO
net/gve: support basic Tx data path for DQO
net/gve: support basic Rx data path for DQO
net/gve: support basic stats for DQO
net/gve: enable Tx checksum offload for DQO
net/gve: add maintainers for GVE
net/gve: support jumbo frame for GQI
MAINTAINERS | 3 + drivers/net/gve/gve_ethdev.c | 88 +++++++- drivers/net/gve/gve_ethdev.h | 69 +++++- drivers/net/gve/gve_rx.c | 140 +++++++++---- drivers/net/gve/gve_rx_dqo.c | 353 +++++++++++++++++++++++++++++++ drivers/net/gve/gve_tx.c | 3 + drivers/net/gve/gve_tx_dqo.c | 393 +++++++++++++++++++++++++++++++++++ drivers/net/gve/meson.build | 2 + 8 files changed, 1005 insertions(+), 46 deletions(-) create mode 100644 drivers/net/gve/gve_rx_dqo.c create mode 100644 drivers/net/gve/gve_tx_dqo.c
Signature · 1 line
2.34.1
PATCH 1/10 net/gve: add Tx queue setup for DQO
Add support for tx_queue_setup_dqo ops.
DQO format has submission and completion queue pair for each Tx/Rx queue. Note that with DQO format all descriptors and doorbells, as well as counters are written in little-endian.
--- drivers/net/gve/gve_ethdev.c | 21 +++- drivers/net/gve/gve_ethdev.h | 27 ++++- drivers/net/gve/gve_tx_dqo.c | 185 +++++++++++++++++++++++++++++++++++ drivers/net/gve/meson.build | 1 + 4 files changed, 230 insertions(+), 4 deletions(-) create mode 100644 drivers/net/gve/gve_tx_dqo.c
drivers/net/gve/gve_ethdev.c +18 -3
@@ -298,6 +298,7 @@ gve_dev_info_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info) dev_info->default_txconf = (struct rte_eth_txconf ) { .tx_free_thresh =GVE_DEFAULT_TX_FREE_THRESH , + .tx_rs_thresh =GVE_DEFAULT_TX_RS_THRESH , .offloads =0 , };
@@ -528,6 +529,21 @@ static const struct eth_dev_ops gve_eth_dev_ops = { .xstats_get_names = gve_xstats_get_names, }; +static const struct eth_dev_ops gve_eth_dev_ops_dqo = { + .dev_configure = gve_dev_configure, + .dev_start = gve_dev_start, + .dev_stop = gve_dev_stop, + .dev_close = gve_dev_close, + .dev_infos_get = gve_dev_info_get, + .tx_queue_setup = gve_tx_queue_setup_dqo, + .link_update = gve_link_update, + .stats_get = gve_dev_stats_get, + .stats_reset = gve_dev_stats_reset, + .mtu_set = gve_dev_mtu_set, + .xstats_get = gve_xstats_get, + .xstats_get_names = gve_xstats_get_names, +}; +static void gve_free_counter_array (struct gve_priv *priv) {
@@ -770,8 +786,6 @@ gve_dev_init(struct rte_eth_dev *eth_dev)rte_be32_t *db_bar;int err; - eth_dev->dev_ops = &gve_eth_dev_ops; -if (rte_eal_process_type () !=RTE_PROC_PRIMARY )return 0 ;
@@ -807,10 +821,11 @@ gve_dev_init(struct rte_eth_dev *eth_dev)return err;if (gve_is_gqi (priv)) { + eth_dev->dev_ops = &gve_eth_dev_ops; eth_dev->rx_pkt_burst = gve_rx_burst; eth_dev->tx_pkt_burst = gve_tx_burst; }else { -PMD_DRV_LOG (ERR ,"DQO_RDA is not implemented and will be added in the future" ); + eth_dev->dev_ops = &gve_eth_dev_ops_dqo; } eth_dev->data->mac_addrs = &priv->dev_addr;
drivers/net/gve/gve_ethdev.h +26 -1
@@ -28,7 +28,8 @@#define PCI_MSIX_FLAGS_QSIZE 0x07FF/* Table size */ #define GVE_DEFAULT_RX_FREE_THRESH 512 -#define GVE_DEFAULT_TX_FREE_THRESH 256 +#define GVE_DEFAULT_TX_FREE_THRESH 32 +#define GVE_DEFAULT_TX_RS_THRESH 32#define GVE_TX_MAX_FREE_SZ 512#define GVE_MIN_BUF_SIZE 1024
@@ -53,6 +54,13 @@ union gve_tx_desc {struct gve_tx_seg_desc seg;/* subsequent descs for a packet */ }; +/* Tx desc for DQO format */ +union gve_tx_desc_dqo { +struct gve_tx_pkt_desc_dqo pkt; +struct gve_tx_tso_context_desc_dqo tso_ctx; +struct gve_tx_general_context_desc_dqo general_ctx; +}; +/* Offload features */ union gve_tx_offload {uint64_t data;
@@ -100,8 +108,10 @@ struct gve_tx_queue {uint32_t tx_tail;uint16_t nb_tx_desc;uint16_t nb_free; +uint16_t nb_used;uint32_t next_to_clean;uint16_t free_thresh; +uint16_t rs_thresh;/* Only valid for DQO_QPL queue format */ uint16_t sw_tail;
@@ -128,7 +138,15 @@ struct gve_tx_queue {struct gve_queue_resources *qres;/* newly added for DQO */ +volatile union gve_tx_desc_dqo *tx_ring; +struct gve_tx_compl_desc *compl_ring; +const struct rte_memzone *compl_ring_mz;uint64_t compl_ring_phys_addr; +uint32_t complq_tail; +uint16_t sw_size; +uint8_t cur_gen_bit; +uint32_t last_desc_cleaned; +void **txqs;/* Only valid for DQO_RDA queue format */ struct gve_tx_queue *complq;
@@ -342,4 +360,11 @@ gve_rx_burst(void *rxq, struct rte_mbuf **rx_pkts, uint16_t nb_pkts);uint16_t gve_tx_burst (void *txq,struct rte_mbuf **tx_pkts,uint16_t nb_pkts); +/* Below functions are used for DQO */ + +int +gve_tx_queue_setup_dqo (struct rte_eth_dev *dev,uint16_t queue_id, +uint16_t nb_desc,unsigned int socket_id, +const struct rte_eth_txconf *conf); +#endif /* _GVE_ETHDEV_H_ */
drivers/net/gve/gve_tx_dqo.c new file +185 -0
185 lines not on this page · raw message
drivers/net/gve/meson.build +1 -0
@@ -11,6 +11,7 @@ sources = files( 'base/gve_adminq.c', 'gve_rx.c', 'gve_tx.c', + 'gve_tx_dqo.c', 'gve_ethdev.c', ) includes += include_directories('base')
Signature · 1 line
2.34.1
PATCH 2/10 net/gve: add Rx queue setup for DQO
In reply to Junfeng GuoAdd support for rx_queue_setup_dqo ops.
--- drivers/net/gve/gve_ethdev.c | 1 + drivers/net/gve/gve_ethdev.h | 11 +++ drivers/net/gve/gve_rx_dqo.c | 156 +++++++++++++++++++++++++++++++++++ drivers/net/gve/meson.build | 1 + 4 files changed, 169 insertions(+) create mode 100644 drivers/net/gve/gve_rx_dqo.c
drivers/net/gve/gve_ethdev.c +1 -0
@@ -535,6 +535,7 @@ static const struct eth_dev_ops gve_eth_dev_ops_dqo = { .dev_stop = gve_dev_stop, .dev_close = gve_dev_close, .dev_infos_get = gve_dev_info_get, + .rx_queue_setup = gve_rx_queue_setup_dqo, .tx_queue_setup = gve_tx_queue_setup_dqo, .link_update = gve_link_update, .stats_get = gve_dev_stats_get,
drivers/net/gve/gve_ethdev.h +11 -0
@@ -167,6 +167,7 @@ struct gve_rx_queue {uint16_t nb_rx_desc;uint16_t expected_seqno;/* the next expected seqno */ uint16_t free_thresh; +uint16_t nb_rx_hold;uint32_t next_avail;uint32_t nb_avail;
@@ -189,7 +190,12 @@ struct gve_rx_queue {uint16_t rx_buf_len;/* newly added for DQO */ +volatile struct gve_rx_desc_dqo *rx_ring; +struct gve_rx_compl_desc_dqo *compl_ring; +const struct rte_memzone *compl_ring_mz;uint64_t compl_ring_phys_addr; +uint8_t cur_gen_bit; +uint16_t bufq_tail;/* Only valid for DQO_RDA queue format */ struct gve_rx_queue *bufq;
@@ -362,6 +368,11 @@ gve_tx_burst(void *txq, struct rte_mbuf **tx_pkts, uint16_t nb_pkts);/* Below functions are used for DQO */ +int +gve_rx_queue_setup_dqo (struct rte_eth_dev *dev,uint16_t queue_id, +uint16_t nb_desc,unsigned int socket_id, +const struct rte_eth_rxconf *conf, +struct rte_mempool *pool); int gve_tx_queue_setup_dqo(struct rte_eth_dev *dev, uint16_t queue_id, uint16_t nb_desc, unsigned int socket_id,
drivers/net/gve/gve_rx_dqo.c new file +156 -0
156 lines not on this page · raw message
drivers/net/gve/meson.build +1 -0
@@ -11,6 +11,7 @@ sources = files( 'base/gve_adminq.c', 'gve_rx.c', 'gve_tx.c', + 'gve_rx_dqo.c', 'gve_tx_dqo.c', 'gve_ethdev.c', )
Signature · 1 line
2.34.1
PATCH 3/10 net/gve: support device start and close for DQO
In reply to Junfeng GuoAdd device start and close support for DQO.
--- drivers/net/gve/gve_ethdev.c | 43 +++++++++++++++++++++++++++++++++++- 1 file changed, 42 insertions(+), 1 deletion(-)
drivers/net/gve/gve_ethdev.c +42 -1
@@ -78,6 +78,9 @@ gve_free_qpls(struct gve_priv *priv)uint16_t nb_rxqs = priv->max_nb_rxq;uint32_t i; +if (priv->queue_format !=GVE_GQI_QPL_FORMAT ) +return ; +for (i =0 ; i < nb_txqs + nb_rxqs; i++) {if (priv->qpl[i].mz !=NULL )rte_memzone_free (priv->qpl[i].mz);
@@ -138,6 +141,41 @@ gve_refill_pages(struct gve_rx_queue *rxq)return 0 ; } +static int +gve_refill_dqo (struct gve_rx_queue *rxq) +{ +struct rte_mbuf *nmb; +uint16_t i; +int diag; + + diag =rte_pktmbuf_alloc_bulk (rxq->mpool, &rxq->sw_ring[0 ], rxq->nb_rx_desc); +if (diag <0 ) { +for (i =0 ; i < rxq->nb_rx_desc -1 ; i++) { + nmb =rte_pktmbuf_alloc (rxq->mpool); +if (!nmb) +break ; + rxq->sw_ring[i] = nmb; + } +if (i < rxq->nb_rx_desc -1 ) +return -ENOMEM ; + } + +for (i =0 ; i < rxq->nb_rx_desc; i++) { +if (i == rxq->nb_rx_desc -1 ) +break ; + nmb = rxq->sw_ring[i]; + rxq->rx_ring[i].buf_addr =rte_cpu_to_le_64 (rte_mbuf_data_iova_default (nmb)); + rxq->rx_ring[i].buf_id =rte_cpu_to_le_16 (i); + } + + rxq->nb_rx_hold =0 ; + rxq->bufq_tail = rxq->nb_rx_desc -1 ; + +rte_write32 (rxq->bufq_tail, rxq->qrx_tail); + +return 0 ; +} +static int gve_link_update(struct rte_eth_dev *dev, __rte_unused int wait_to_complete) {
@@ -206,7 +244,10 @@ gve_dev_start(struct rte_eth_dev *dev)rte_write32 (rte_cpu_to_be_32 (GVE_IRQ_MASK ), rxq->ntfy_addr); - err =gve_refill_pages (rxq); +if (gve_is_gqi (priv)) + err =gve_refill_pages (rxq); +else + err =gve_refill_dqo (rxq);if (err) {PMD_DRV_LOG (ERR ,"Failed to refill for RX" ); goto err_rx;
Signature · 1 line
2.34.1
PATCH 4/10 net/gve: support queue release and stop for DQO
In reply to Junfeng GuoAdd support for queue operations:
- gve_tx_queue_release_dqo
- gve_rx_queue_release_dqo
- gve_stop_tx_queues_dqo
- gve_stop_rx_queues_dqo
--- drivers/net/gve/gve_ethdev.c | 18 +++++++++--- drivers/net/gve/gve_ethdev.h | 12 ++++++++ drivers/net/gve/gve_rx.c | 3 ++ drivers/net/gve/gve_rx_dqo.c | 57 ++++++++++++++++++++++++++++++++++++ drivers/net/gve/gve_tx.c | 3 ++ drivers/net/gve/gve_tx_dqo.c | 55 ++++++++++++++++++++++++++++++++++ 6 files changed, 144 insertions(+), 4 deletions(-)
drivers/net/gve/gve_ethdev.c +14 -4
@@ -292,11 +292,19 @@ gve_dev_close(struct rte_eth_dev *dev)PMD_DRV_LOG (ERR ,"Failed to stop dev." ); } -for (i =0 ; i < dev->data->nb_tx_queues; i++) -gve_tx_queue_release (dev, i); +if (gve_is_gqi (priv)) { +for (i =0 ; i < dev->data->nb_tx_queues; i++) +gve_tx_queue_release (dev, i); + +for (i =0 ; i < dev->data->nb_rx_queues; i++) +gve_rx_queue_release (dev, i); + }else { +for (i =0 ; i < dev->data->nb_tx_queues; i++) +gve_tx_queue_release_dqo (dev, i); -for (i =0 ; i < dev->data->nb_rx_queues; i++) -gve_rx_queue_release (dev, i); +for (i =0 ; i < dev->data->nb_rx_queues; i++) +gve_rx_queue_release_dqo (dev, i); + }gve_free_qpls (priv);rte_free (priv->adminq);
@@ -578,6 +586,8 @@ static const struct eth_dev_ops gve_eth_dev_ops_dqo = { .dev_infos_get = gve_dev_info_get, .rx_queue_setup = gve_rx_queue_setup_dqo, .tx_queue_setup = gve_tx_queue_setup_dqo, + .rx_queue_release = gve_rx_queue_release_dqo, + .tx_queue_release = gve_tx_queue_release_dqo, .link_update = gve_link_update, .stats_get = gve_dev_stats_get, .stats_reset = gve_dev_stats_reset,
drivers/net/gve/gve_ethdev.h +12 -0
@@ -378,4 +378,16 @@ gve_tx_queue_setup_dqo(struct rte_eth_dev *dev, uint16_t queue_id, uint16_t nb_desc, unsigned int socket_id, const struct rte_eth_txconf *conf); +void +gve_tx_queue_release_dqo (struct rte_eth_dev *dev,uint16_t qid); + +void +gve_rx_queue_release_dqo (struct rte_eth_dev *dev,uint16_t qid); + +void +gve_stop_tx_queues_dqo (struct rte_eth_dev *dev); + +void +gve_stop_rx_queues_dqo (struct rte_eth_dev *dev); +#endif /* _GVE_ETHDEV_H_ */
drivers/net/gve/gve_rx.c +3 -0
@@ -359,6 +359,9 @@ gve_stop_rx_queues(struct rte_eth_dev *dev)uint16_t i;int err; +if (!gve_is_gqi (hw)) +return gve_stop_rx_queues_dqo (dev); + err =gve_adminq_destroy_rx_queues (hw, dev->data->nb_rx_queues);if (err !=0 )PMD_DRV_LOG (WARNING ,"failed to destroy rxqs" );
drivers/net/gve/gve_rx_dqo.c +57 -0
72 lines not on this page · raw message
drivers/net/gve/gve_tx.c +3 -0
@@ -672,6 +672,9 @@ gve_stop_tx_queues(struct rte_eth_dev *dev)uint16_t i;int err; +if (!gve_is_gqi (hw)) +return gve_stop_tx_queues_dqo (dev); + err =gve_adminq_destroy_tx_queues (hw, dev->data->nb_tx_queues);if (err !=0 )PMD_DRV_LOG (WARNING ,"failed to destroy txqs" );
drivers/net/gve/gve_tx_dqo.c +55 -0
70 lines not on this page · raw message
Signature · 1 line
2.34.1
PATCH 5/10 net/gve: support basic Tx data path for DQO
In reply to Junfeng GuoAdd basic Tx data path support for DQO.
--- drivers/net/gve/gve_ethdev.c | 1 + drivers/net/gve/gve_ethdev.h | 4 + drivers/net/gve/gve_tx_dqo.c | 141 +++++++++++++++++++++++++++++++++++ 3 files changed, 146 insertions(+)
drivers/net/gve/gve_ethdev.c +1 -0
@@ -878,6 +878,7 @@ gve_dev_init(struct rte_eth_dev *eth_dev) eth_dev->tx_pkt_burst = gve_tx_burst; }else { eth_dev->dev_ops = &gve_eth_dev_ops_dqo; + eth_dev->tx_pkt_burst = gve_tx_burst_dqo; } eth_dev->data->mac_addrs = &priv->dev_addr;
drivers/net/gve/gve_ethdev.h +4 -0
@@ -147,6 +147,7 @@ struct gve_tx_queue {uint8_t cur_gen_bit;uint32_t last_desc_cleaned;void **txqs; +uint16_t re_cnt;/* Only valid for DQO_RDA queue format */ struct gve_tx_queue *complq;
@@ -390,4 +391,7 @@ gve_stop_tx_queues_dqo(struct rte_eth_dev *dev);void gve_stop_rx_queues_dqo (struct rte_eth_dev *dev); +uint16_t +gve_tx_burst_dqo (void *txq,struct rte_mbuf **tx_pkts,uint16_t nb_pkts); +#endif /* _GVE_ETHDEV_H_ */
drivers/net/gve/gve_tx_dqo.c +141 -0
147 lines not on this page · raw message
Signature · 1 line
2.34.1
PATCH 6/10 net/gve: support basic Rx data path for DQO
In reply to Junfeng GuoAdd basic Rx data path support for DQO.
--- drivers/net/gve/gve_ethdev.c | 1 + drivers/net/gve/gve_ethdev.h | 3 + drivers/net/gve/gve_rx_dqo.c | 128 +++++++++++++++++++++++++++++++++++ 3 files changed, 132 insertions(+)
drivers/net/gve/gve_ethdev.c +1 -0
@@ -878,6 +878,7 @@ gve_dev_init(struct rte_eth_dev *eth_dev) eth_dev->tx_pkt_burst = gve_tx_burst; }else { eth_dev->dev_ops = &gve_eth_dev_ops_dqo; + eth_dev->rx_pkt_burst = gve_rx_burst_dqo; eth_dev->tx_pkt_burst = gve_tx_burst_dqo; }
drivers/net/gve/gve_ethdev.h +3 -0
@@ -391,6 +391,9 @@ gve_stop_tx_queues_dqo(struct rte_eth_dev *dev);void gve_stop_rx_queues_dqo (struct rte_eth_dev *dev); +uint16_t +gve_rx_burst_dqo (void *rxq,struct rte_mbuf **rx_pkts,uint16_t nb_pkts); +uint16_t gve_tx_burst_dqo (void *txq,struct rte_mbuf **tx_pkts,uint16_t nb_pkts);
drivers/net/gve/gve_rx_dqo.c +128 -0
134 lines not on this page · raw message
Signature · 1 line
2.34.1
PATCH 7/10 net/gve: support basic stats for DQO
In reply to Junfeng GuoAdd basic stats support for DQO.
--- drivers/net/gve/gve_ethdev.c | 5 ++++- drivers/net/gve/gve_rx_dqo.c | 14 +++++++++++++- drivers/net/gve/gve_tx_dqo.c | 7 +++++++ 3 files changed, 24 insertions(+), 2 deletions(-)
drivers/net/gve/gve_ethdev.c +4 -1
@@ -150,14 +150,17 @@ gve_refill_dqo(struct gve_rx_queue *rxq) diag =rte_pktmbuf_alloc_bulk (rxq->mpool, &rxq->sw_ring[0 ], rxq->nb_rx_desc);if (diag <0 ) { + rxq->stats.no_mbufs_bulk++;for (i =0 ; i < rxq->nb_rx_desc -1 ; i++) { nmb =rte_pktmbuf_alloc (rxq->mpool);if (!nmb)break ; rxq->sw_ring[i] = nmb; } -if (i < rxq->nb_rx_desc -1 ) +if (i < rxq->nb_rx_desc -1 ) { + rxq->stats.no_mbufs += rxq->nb_rx_desc -1 - i;return -ENOMEM ; + } }for (i =0 ; i < rxq->nb_rx_desc; i++) {
drivers/net/gve/gve_rx_dqo.c +13 -1
@@ -39,6 +39,8 @@ gve_rx_refill_dqo(struct gve_rx_queue *rxq) next_avail =0 ; rxq->nb_rx_hold -= delta; }else { + rxq->stats.no_mbufs_bulk++; + rxq->stats.no_mbufs += nb_desc - next_avail; dev = &rte_eth_devices[rxq->port_id]; dev->data->rx_mbuf_alloc_failed += nb_desc - next_avail; PMD_DRV_LOG(DEBUG, "RX mbuf alloc failed port_id=%u queue_id=%u",
@@ -59,6 +61,8 @@ gve_rx_refill_dqo(struct gve_rx_queue *rxq) next_avail += nb_refill; rxq->nb_rx_hold -= nb_refill; }else { + rxq->stats.no_mbufs_bulk++; + rxq->stats.no_mbufs += nb_desc - next_avail; dev = &rte_eth_devices[rxq->port_id]; dev->data->rx_mbuf_alloc_failed += nb_desc - next_avail; PMD_DRV_LOG(DEBUG, "RX mbuf alloc failed port_id=%u queue_id=%u",
@@ -82,7 +86,9 @@ gve_rx_burst_dqo(void *rx_queue, struct rte_mbuf **rx_pkts, uint16_t nb_pkts)uint16_t pkt_len;uint16_t rx_id;uint16_t nb_rx; +uint64_t bytes; + bytes =0 ; nb_rx =0 ; rxq = rx_queue; rx_id = rxq->rx_tail;
@@ -96,8 +102,10 @@ gve_rx_burst_dqo(void *rx_queue, struct rte_mbuf **rx_pkts, uint16_t nb_pkts)if (rx_desc->generation != rxq->cur_gen_bit)break ; -if (unlikely (rx_desc->rx_error)) +if (unlikely (rx_desc->rx_error)) { + rxq->stats.errors++;continue ; + } pkt_len = rx_desc->packet_len;
@@ -122,6 +130,7 @@ gve_rx_burst_dqo(void *rx_queue, struct rte_mbuf **rx_pkts, uint16_t nb_pkts) rxm->hash.rss =rte_be_to_cpu_32 (rx_desc->hash); rx_pkts[nb_rx++] = rxm; + bytes += pkt_len; }if (nb_rx >0 ) {
@@ -130,6 +139,9 @@ gve_rx_burst_dqo(void *rx_queue, struct rte_mbuf **rx_pkts, uint16_t nb_pkts) rxq->next_avail = rx_id_bufq;gve_rx_refill_dqo (rxq); + + rxq->stats.packets += nb_rx; + rxq->stats.bytes += bytes; }return nb_rx;
drivers/net/gve/gve_tx_dqo.c +7 -0
@@ -81,10 +81,12 @@ gve_tx_burst_dqo(void *tx_queue, struct rte_mbuf **tx_pkts, uint16_t nb_pkts)uint16_t nb_used;uint16_t tx_id;uint16_t sw_id; +uint64_t bytes; sw_ring = txq->sw_ring; txr = txq->tx_ring; + bytes =0 ; mask = txq->nb_tx_desc -1 ; sw_mask = txq->sw_size -1 ; tx_id = txq->tx_tail;
@@ -119,6 +121,7 @@ gve_tx_burst_dqo(void *tx_queue, struct rte_mbuf **tx_pkts, uint16_t nb_pkts) tx_id = (tx_id +1 ) & mask; sw_id = (sw_id +1 ) & sw_mask; + bytes += tx_pkt->pkt_len; tx_pkt = tx_pkt->next; }while (tx_pkt);
@@ -142,6 +145,10 @@ gve_tx_burst_dqo(void *tx_queue, struct rte_mbuf **tx_pkts, uint16_t nb_pkts)rte_write32 (tx_id, txq->qtx_tail); txq->tx_tail = tx_id; txq->sw_tail = sw_id; + + txq->stats.packets += nb_tx; + txq->stats.bytes += bytes; + txq->stats.errors += nb_pkts - nb_tx; }return nb_tx;
Signature · 1 line
2.34.1
PATCH 8/10 net/gve: enable Tx checksum offload for DQO
In reply to Junfeng GuoEnable Tx checksum offload once any flag of L4 checksum is set.
--- drivers/net/gve/gve_ethdev.h | 4 ++++ drivers/net/gve/gve_tx_dqo.c | 5 +++++ 2 files changed, 9 insertions(+)
drivers/net/gve/gve_ethdev.h +4 -0
@@ -38,6 +38,10 @@#define GVE_MAX_MTU RTE_ETHER_MTU#define GVE_MIN_MTU RTE_ETHER_MIN_MTU +#define GVE_TX_CKSUM_OFFLOAD_MASK ( \ + RTE_MBUF_F_TX_L4_MASK | \ + RTE_MBUF_F_TX_TCP_SEG) +/* A list of pages registered with the device during setup and used by a queue * as buffers */
drivers/net/gve/gve_tx_dqo.c +5 -0
@@ -78,6 +78,7 @@ gve_tx_burst_dqo(void *tx_queue, struct rte_mbuf **tx_pkts, uint16_t nb_pkts)uint16_t mask, sw_mask;uint16_t nb_to_clean;uint16_t nb_tx =0 ; +uint64_t ol_flags;uint16_t nb_used;uint16_t tx_id;uint16_t sw_id;
@@ -104,6 +105,7 @@ gve_tx_burst_dqo(void *tx_queue, struct rte_mbuf **tx_pkts, uint16_t nb_pkts)if (txq->nb_free < tx_pkt->nb_segs)break ; + ol_flags = tx_pkt->ol_flags; nb_used = tx_pkt->nb_segs; do {
@@ -128,6 +130,9 @@ gve_tx_burst_dqo(void *tx_queue, struct rte_mbuf **tx_pkts, uint16_t nb_pkts)/* fill the last descriptor with End of Packet (EOP) bit */ txd->pkt.end_of_packet =1 ; +if (ol_flags &GVE_TX_CKSUM_OFFLOAD_MASK ) + txd->pkt.checksum_offload_enable =1 ; + txq->nb_free -= nb_used; txq->nb_used += nb_used; }
Signature · 1 line
2.34.1
PATCH 9/10 net/gve: add maintainers for GVE
In reply to Junfeng GuoAdd maintainers from Google for GVE.
--- MAINTAINERS | 3 +++ 1 file changed, 3 insertions(+)
MAINTAINERS +3 -0
@@ -713,6 +713,9 @@ F: doc/guides/nics/features/enic.ini Google Virtual Ethernet M: Junfeng Guo <[email protected]> +M: Jeroen de Borst <[email protected]> +M: Rushil Gupta <[email protected]> +M: Joshua Washington <[email protected]> F: drivers/net/gve/ F: doc/guides/nics/gve.rst F: doc/guides/nics/features/gve.ini
Signature · 1 line
2.34.1
Re: [PATCH 09/10] net/gve: add maintainers for GVE
Quoted 13 lines · Junfeng Guo
Add maintainers from Google for GVE.
Signed-off-by Junfeng Guo <[email protected]>Signed-off-by Rushil Gupta <[email protected]>--- MAINTAINERS | 3 +++ 1 file changed, 3 insertions(+)MAINTAINERS +0
-0
MAINTAINERS F: doc/guides/nics/features/enic.ini · line 721
Quoted 9 lines
MAINTAINERS +3
-0@@ -713,6 +713,9 @@ F: doc/guides/nics/features/enic.ini Google Virtual Ethernet M: Junfeng Guo <[email protected]> +M: Jeroen de Borst <[email protected]> +M: Rushil Gupta <[email protected]> +M: Joshua Washington <[email protected]> F: drivers/net/gve/ F: doc/guides/nics/gve.rst F: doc/guides/nics/features/gve.ini
Requested ack from new added maintainers not received (to other version of this patch [2]). This patch is not dependency for rest of the set, so dropping it from the set.
Also there is a standalone version of this patch [1], can you please send a new version to standalone one, instead of including same patch in various sets?
[1]
https://patches.dpdk.org/project/dpdk/patch/[email protected]/
[2]
https://patches.dpdk.org/project/dpdk/patch/[email protected]/
RE: [PATCH 09/10] net/gve: add maintainers for GVE
Quoted 41 lines
-----Original Message-----
From: Ferruh Yigit <[email protected]>
Sent: Thursday, May 4, 2023 19:01
To: Guo, Junfeng <[email protected]>; Zhang, Qi Z <[email protected]>; Wu, Jingjing <[email protected]>; Xing, Beilei <[email protected]>
Cc: [email protected]; Rushil Gupta <[email protected]>; Jeroen de Borst <[email protected]>; Joshua Washington <[email protected]>
Subject: Re: [PATCH 09/10] net/gve: add maintainers for GVEQuoted 13 lines · Junfeng Guo
Add maintainers from Google for GVE.
Signed-off-by Junfeng Guo <[email protected]>Signed-off-by Rushil Gupta <[email protected]>--- MAINTAINERS | 3 +++ 1 file changed, 3 insertions(+)MAINTAINERS +0
-0MAINTAINERS F: doc/guides/nics/features/enic.ini · line 721
Quoted 9 lines
MAINTAINERS +3
-0@@ -713,6 +713,9 @@ F: doc/guides/nics/features/enic.ini Google Virtual Ethernet M: Junfeng Guo <[email protected]> +M: Jeroen de Borst <[email protected]> +M: Rushil Gupta <[email protected]> +M: Joshua Washington <[email protected]> F: drivers/net/gve/ F: doc/guides/nics/gve.rst F: doc/guides/nics/features/gve.iniRequested ack from new added maintainers not received (to other version
of this patch [2]). This patch is not dependency for rest of the set, so dropping it from the set.
Quoted 4 lines
Also there is a standalone version of this patch [1], can you please send a new version to standalone one, instead of including same patch in various sets?
Sure! Will send out a standalone version with in-reply-to [1].
Thanks for the careful review!
PATCH 10/10 net/gve: support jumbo frame for GQI
In reply to Junfeng GuoAdd multi-segment support to enable GQI Rx Jumbo Frame.
--- drivers/net/gve/gve_ethdev.h | 8 ++ drivers/net/gve/gve_rx.c | 137 +++++++++++++++++++++++++---------- 2 files changed, 108 insertions(+), 37 deletions(-)
drivers/net/gve/gve_ethdev.h +8 -0
@@ -159,6 +159,13 @@ struct gve_tx_queue {uint8_t is_gqi_qpl; }; +struct gve_rx_ctx { +struct rte_mbuf *mbuf_head; +struct rte_mbuf *mbuf_tail; +uint16_t total_frags; +bool drop_pkt; +}; +struct gve_rx_queue {volatile struct gve_rx_desc *rx_desc_ring;volatile union gve_rx_data_slot *rx_data_ring;
@@ -167,6 +174,7 @@ struct gve_rx_queue {uint64_t rx_ring_phys_addr;struct rte_mbuf **sw_ring;struct rte_mempool *mpool; +struct gve_rx_ctx ctx;uint16_t rx_tail;uint16_t nb_rx_desc;
drivers/net/gve/gve_rx.c +100 -37
177 lines not on this page · raw message
Signature · 1 line
2.34.1
Quoted 7 lines · Junfeng Guo
This patch set includs two main enhancements for gve PMD:
- support basic data path with DQO queue format
- support jumbo frame with GQI queue formatThis patch set is based on this:
patchwork.dpdk.org/project/dpdk/list/?series=27653&state=*
Quoted 11 lines
Junfeng Guo (10):
net/gve: add Tx queue setup for DQO
net/gve: add Rx queue setup for DQO
net/gve: support device start and close for DQO
net/gve: support queue release and stop for DQO
net/gve: support basic Tx data path for DQO
net/gve: support basic Rx data path for DQO
net/gve: support basic stats for DQO
net/gve: enable Tx checksum offload for DQO
net/gve: add maintainers for GVE
net/gve: support jumbo frame for GQI
Except 9/10 (maintainers file update), please see note on relevant patch for it,
Series applied to dpdk-next-net/main, thanks.