SPMI patches for v6.4
Subsystems (3)
Stephen Boyd
maintainercover SPMI patches for v6.4
Hi Greg,
Here's the pile of SPMI patches for the next merge window. They're mostly cleanups, one batch migrates drivers to the new platform driver remove function and another drops of_match_ptr() from the Mediatek driver. There's also some kernel-doc warning fixes and we allow the 'remove' callback for spmi drivers to be optional so that drivers that don't have one don't oops when they're unbound.
Jishnu Prakash (1):
spmi: Add a check for remove callback when removing a SPMI driver
Krzysztof Kozlowski (1):
spmi: mtk-pmif: Drop of_match_ptr for ID table
Randy Dunlap (1):
spmi: fix W=1 kernel-doc warnings
Uwe Kleine-König (3):
spmi: hisi-spmi-controller: Convert to platform remove callback
returning void
spmi: mtk-pmif: Convert to platform remove callback returning void
spmi: pmic-arb: Convert to platform remove callback returning void
drivers/spmi/hisi-spmi-controller.c | 5 ++--- drivers/spmi/spmi-mtk-pmif.c | 7 +++---- drivers/spmi/spmi-pmic-arb.c | 9 ++++----- drivers/spmi/spmi.c | 8 +++++--- 4 files changed, 14 insertions(+), 15 deletions(-)
Signature · 2 lines
https://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git/ https://git.kernel.org/pub/scm/linux/kernel/git/sboyd/spmi.git
Stephen Boyd
maintainerPATCH 1/6 spmi: hisi-spmi-controller: Convert to platform remove callback returning void
From: Uwe Kleine-König <[email protected]>
The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void.
Trivially convert this driver from always returning zero in the remove callback to the void returning variant.
--- drivers/spmi/hisi-spmi-controller.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)
drivers/spmi/hisi-spmi-controller.c +2 -3
@@ -324,13 +324,12 @@ static int spmi_controller_probe(struct platform_device *pdev)return ret; } -static int spmi_del_controller (struct platform_device *pdev) +static void spmi_del_controller (struct platform_device *pdev) {struct spmi_controller *ctrl =platform_get_drvdata (pdev);spmi_controller_remove (ctrl);spmi_controller_put (ctrl); -return 0 ; }static const struct of_device_id spmi_controller_match_table[] = {
@@ -343,7 +342,7 @@ MODULE_DEVICE_TABLE(of, spmi_controller_match_table);static struct platform_driver spmi_controller_driver = { .probe = spmi_controller_probe, - .remove = spmi_del_controller, + .remove_new = spmi_del_controller, .driver = { .name ="hisi_spmi_controller" , .of_match_table = spmi_controller_match_table,
Signature · 2 lines
https://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git/ https://git.kernel.org/pub/scm/linux/kernel/git/sboyd/spmi.git
Stephen Boyd
maintainerPATCH 2/6 spmi: mtk-pmif: Convert to platform remove callback returning void
In reply to Stephen BoydFrom: Uwe Kleine-König <[email protected]>
The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void.
Trivially convert this driver from always returning zero in the remove callback to the void returning variant.
--- drivers/spmi/spmi-mtk-pmif.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)
drivers/spmi/spmi-mtk-pmif.c +2 -3
@@ -503,7 +503,7 @@ static int mtk_spmi_probe(struct platform_device *pdev)return err; } -static int mtk_spmi_remove (struct platform_device *pdev) +static void mtk_spmi_remove (struct platform_device *pdev) {struct spmi_controller *ctrl =platform_get_drvdata (pdev);struct pmif *arb =spmi_controller_get_drvdata (ctrl);
@@ -511,7 +511,6 @@ static int mtk_spmi_remove(struct platform_device *pdev)clk_bulk_disable_unprepare (arb->nclks, arb->clks);spmi_controller_remove (ctrl);spmi_controller_put (ctrl); -return 0 ; }static const struct of_device_id mtk_spmi_match_table[] = {
@@ -533,7 +532,7 @@ static struct platform_driver mtk_spmi_driver = { .of_match_table = of_match_ptr(mtk_spmi_match_table), }, .probe = mtk_spmi_probe, - .remove = mtk_spmi_remove, + .remove_new = mtk_spmi_remove, };module_platform_driver (mtk_spmi_driver);
Signature · 2 lines
https://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git/ https://git.kernel.org/pub/scm/linux/kernel/git/sboyd/spmi.git
Stephen Boyd
maintainerPATCH 3/6 spmi: pmic-arb: Convert to platform remove callback returning void
In reply to Stephen BoydFrom: Uwe Kleine-König <[email protected]>
The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void.
Trivially convert this driver from always returning zero in the remove callback to the void returning variant.
--- drivers/spmi/spmi-pmic-arb.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)
drivers/spmi/spmi-pmic-arb.c +2 -3
@@ -1674,7 +1674,7 @@ static int spmi_pmic_arb_probe(struct platform_device *pdev)return err; } -static int spmi_pmic_arb_remove (struct platform_device *pdev) +static void spmi_pmic_arb_remove (struct platform_device *pdev) {struct spmi_controller *ctrl =platform_get_drvdata (pdev);struct spmi_pmic_arb *pmic_arb =spmi_controller_get_drvdata (ctrl);
@@ -1682,7 +1682,6 @@ static int spmi_pmic_arb_remove(struct platform_device *pdev)irq_set_chained_handler_and_data (pmic_arb->irq,NULL ,NULL );irq_domain_remove (pmic_arb->domain);spmi_controller_put (ctrl); -return 0 ; }static const struct of_device_id spmi_pmic_arb_match_table[] = {
@@ -1693,7 +1692,7 @@ MODULE_DEVICE_TABLE(of, spmi_pmic_arb_match_table);static struct platform_driver spmi_pmic_arb_driver = { .probe = spmi_pmic_arb_probe, - .remove = spmi_pmic_arb_remove, + .remove_new = spmi_pmic_arb_remove, .driver = { .name ="spmi_pmic_arb" , .of_match_table = spmi_pmic_arb_match_table,
Signature · 2 lines
https://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git/ https://git.kernel.org/pub/scm/linux/kernel/git/sboyd/spmi.git
Stephen Boyd
maintainerPATCH 4/6 spmi: mtk-pmif: Drop of_match_ptr for ID table
In reply to Stephen BoydFrom: Krzysztof Kozlowski <[email protected]>
The driver can match only via the DT table so the table should be always used and the of_match_ptr does not have any sense (this also allows ACPI matching via PRP0001, even though it is not relevant here).
drivers/spmi/spmi-mtk-pmif.c:517:34: error: ‘mtk_spmi_match_table’ defined but not used [-Werror=unused-const-variable=]
--- drivers/spmi/spmi-mtk-pmif.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/spmi/spmi-mtk-pmif.c +1 -1
@@ -529,7 +529,7 @@ MODULE_DEVICE_TABLE(of, mtk_spmi_match_table);static struct platform_driver mtk_spmi_driver = { .driver = { .name ="spmi-mtk" , - .of_match_table =of_match_ptr (mtk_spmi_match_table), + .of_match_table = mtk_spmi_match_table, }, .probe = mtk_spmi_probe, .remove_new = mtk_spmi_remove,
Signature · 2 lines
https://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git/ https://git.kernel.org/pub/scm/linux/kernel/git/sboyd/spmi.git
Stephen Boyd
maintainerPATCH 5/6 spmi: fix W=1 kernel-doc warnings
In reply to Stephen BoydFrom: Randy Dunlap <[email protected]>
Fix all W=1 kernel-doc warnings in drivers/spmi/:
drivers/spmi/spmi.c:414: warning: expecting prototype for spmi_controller_alloc(). Prototype was for spmi_device_alloc() instead drivers/spmi/spmi.c:592: warning: expecting prototype for spmi_driver_register(). Prototype was for __spmi_driver_register() instead drivers/spmi/spmi.c:592: warning: Function parameter or member 'owner' not described in '__spmi_driver_register' drivers/spmi/spmi-pmic-arb.c:155: warning: cannot understand function prototype: 'struct spmi_pmic_arb ' drivers/spmi/spmi-pmic-arb.c:203: warning: cannot understand function prototype: 'struct pmic_arb_ver_ops ' drivers/spmi/spmi-pmic-arb.c:219: warning: expecting prototype for struct pmic_arb_ver. Prototype was for struct pmic_arb_ver_ops instead
--- drivers/spmi/spmi-pmic-arb.c | 4 ++-- drivers/spmi/spmi.c | 5 +++-- 2 files changed, 5 insertions(+), 4 deletions(-)
drivers/spmi/spmi-pmic-arb.c +2 -2
@@ -126,7 +126,7 @@ struct apid_data { };/** -* spmi_pmic_arb - SPMI PMIC Arbiter object +* struct spmi_pmic_arb - SPMI PMIC Arbiter object * * @rd_base: on v1 "core", on v2 "observer" register base off DT. * @wr_base: on v1 "core", on v2 "chnls" register base off DT.
@@ -180,7 +180,7 @@ struct spmi_pmic_arb { };/** -* pmic_arb_ver: version dependent functionality. +* struct pmic_arb_ver_ops - version dependent functionality. * * @ver_str: version string. * @ppid_to_apid: finds the apid for a given ppid.
drivers/spmi/spmi.c +3 -2
@@ -404,7 +404,7 @@ struct spmi_device *spmi_device_from_of(struct device_node *np)EXPORT_SYMBOL_GPL (spmi_device_from_of);/** -* spmi_controller_alloc() - Allocate a new SPMI device +* spmi_device_alloc() - Allocate a new SPMI device * @ctrl: associated controller * * Caller is responsible for either calling spmi_device_add() to add the
@@ -582,8 +582,9 @@ void spmi_controller_remove(struct spmi_controller *ctrl)EXPORT_SYMBOL_GPL (spmi_controller_remove);/** -* spmi_driver_register() - Register client driver with SPMI core +* __spmi_driver_register() - Register client driver with SPMI core * @sdrv: client driver to be associated with client-device. +* @owner: module owner * * This API will register the client driver with the SPMI framework. * It is typically called from the driver's module-init function.
Signature · 2 lines
https://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git/ https://git.kernel.org/pub/scm/linux/kernel/git/sboyd/spmi.git
Stephen Boyd
maintainerPATCH 6/6 spmi: Add a check for remove callback when removing a SPMI driver
In reply to Stephen BoydFrom: Jishnu Prakash <[email protected]>
When removing a SPMI driver, there can be a crash due to NULL pointer dereference if it does not have a remove callback defined. This is one such call trace observed when removing the QCOM SPMI PMIC driver:
dump_backtrace.cfi_jt+0x0/0x8 dump_stack_lvl+0xd8/0x16c panic+0x188/0x498 __cfi_slowpath+0x0/0x214 __cfi_slowpath+0x1dc/0x214 spmi_drv_remove+0x16c/0x1e0 device_release_driver_internal+0x468/0x79c driver_detach+0x11c/0x1a0 bus_remove_driver+0xc4/0x124 driver_unregister+0x58/0x84 cleanup_module+0x1c/0xc24 [qcom_spmi_pmic] __do_sys_delete_module+0x3ec/0x53c __arm64_sys_delete_module+0x18/0x28 el0_svc_common+0xdc/0x294 el0_svc+0x38/0x9c el0_sync_handler+0x8c/0xf0 el0_sync+0x1b4/0x1c0
If a driver has all its resources allocated through devm_() APIs and does not need any other explicit cleanup, it would not require a remove callback to be defined. Hence, add a check for remove callback presence before calling it when removing a SPMI driver.
--- drivers/spmi/spmi.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/spmi/spmi.c +2 -1
@@ -350,7 +350,8 @@ static void spmi_drv_remove(struct device *dev)const struct spmi_driver *sdrv =to_spmi_driver (dev->driver);pm_runtime_get_sync (dev); - sdrv->remove (to_spmi_device (dev)); +if (sdrv->remove) + sdrv->remove (to_spmi_device (dev));pm_runtime_put_noidle (dev);pm_runtime_disable (dev);
Signature · 2 lines
https://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git/ https://git.kernel.org/pub/scm/linux/kernel/git/sboyd/spmi.git