iio: tmag5273: Fix runtime PM leak on measurement error
Subsystems (2)
PATCH 1/1 iio: tmag5273: Fix runtime PM leak on measurement error
The tmag5273 gets a runtime PM reference before reading a measurement and releases it when done. But if the measurement fails the tmag5273_read_raw() function exits before releasing the reference.
Make sure that this error path also releases the runtime PM reference.
--- drivers/iio/magnetometer/tmag5273.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)
drivers/iio/magnetometer/tmag5273.c +3 -2
@@ -296,12 +296,13 @@ static int tmag5273_read_raw(struct iio_dev *indio_dev,return ret; ret =tmag5273_get_measure (data, &t, &x, &y, &z, &angle, &magnitude); -if (ret) -return ret;pm_runtime_mark_last_busy (data->dev);pm_runtime_put_autosuspend (data->dev); +if (ret) +return ret; +switch (chan->address) {case TEMPERATURE : *val = t;
Signature · 1 line
2.30.2
Quoted 6 lines · Lars-Peter Clausen
The tmag5273 gets a runtime PM reference before reading a measurement and
releases it when done. But if the measurement fails thetmag5273_read_raw()
function exits before releasing the reference.
Quoted 6 lines
Make sure that this error path also releases the runtime PM reference.
Fixes 866a1389174b ("iio: magnetometer: add ti tmag5273 driver")Signed-off-by Lars-Peter Clausen <[email protected]>---
Quoted 26 lines
drivers/iio/magnetometer/tmag5273.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)drivers/iio/magnetometer/tmag5273.c +0
-0@@ -296,12 +296,13 @@ static int tmag5273_read_raw(struct iio_dev *indio_dev, return ret;
ret =tmag5273_get_measure(data, &t, &x, &y, &z, &angle, &magnitude);
- if (ret)
- return ret;
pm_runtime_mark_last_busy(data->dev);pm_runtime_put_autosuspend(data->dev);
+ if (ret)
+ return ret;
+
switch (chan->address) {
case TEMPERATURE:
*val = t;
Am 14.04.2023 um 07:57 schrieb Nuno Sá:
Quoted 7 lines · Lars-Peter Clausen
Quoted 6 lines
The tmag5273 gets a runtime PM reference before reading a measurement and
releases it when done. But if the measurement fails thetmag5273_read_raw()
function exits before releasing the reference.
Quoted 9 lines
Quoted 6 lines
Make sure that this error path also releases the runtime PM reference.
Fixes 866a1389174b ("iio: magnetometer: add ti tmag5273 driver")Signed-off-by Lars-Peter Clausen <[email protected]>---
Reviewed-by Nuno Sa <[email protected]>
Quoted 27 lines
Quoted 26 lines
drivers/iio/magnetometer/tmag5273.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)drivers/iio/magnetometer/tmag5273.c +0
-0@@ -296,12 +296,13 @@ static int tmag5273_read_raw(struct iio_dev *indio_dev, return ret;
ret =tmag5273_get_measure(data, &t, &x, &y, &z, &angle, &magnitude);
- if (ret)
- return ret;
pm_runtime_mark_last_busy(data->dev);pm_runtime_put_autosuspend(data->dev);
+ if (ret)
+ return ret;
+
switch (chan->address) {
case TEMPERATURE:
*val = t;
Quoted 11 lines · On Fri, 14 Apr 2023 12:17:36 +0200 Gerald Loacker…
Am 14.04.2023 um 07:57 schrieb Nuno Sá:
Quoted 10 lines · Lars-Peter Clausen
Quoted 9 lines
The tmag5273 gets a runtime PM reference before reading a measurement and
releases it when done. But if the measurement fails thetmag5273_read_raw()
function exits before releasing the reference.Make sure that this error path also releases the runtime PM reference.
Quoted 8 lines
Quoted 6 lines
Quoted 3 lines
Fixes 866a1389174b ("iio: magnetometer: add ti tmag5273 driver")Signed-off-by Lars-Peter Clausen <[email protected]>---
Reviewed-by Nuno Sa <[email protected]>Acked-by Gerald Loacker <[email protected]>
Applied to the fixes-togreg branch of iio.git.
I'm not going to rush this in before the merge window. It might even wait until after rc1 as it would have had any time in linux-next before I send final pull request for the merge window.
Jonathan
Quoted 28 lines
Quoted 28 lines
Quoted 27 lines
drivers/iio/magnetometer/tmag5273.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)drivers/iio/magnetometer/tmag5273.c +0
-0@@ -296,12 +296,13 @@ static int tmag5273_read_raw(struct iio_dev *indio_dev, return ret;
ret =tmag5273_get_measure(data, &t, &x, &y, &z, &angle, &magnitude);
- if (ret)
- return ret;
pm_runtime_mark_last_busy(data->dev);pm_runtime_put_autosuspend(data->dev);
+ if (ret)
+ return ret;
+
switch (chan->address) {
case TEMPERATURE:
*val = t;