crypto/qat: fix stack buffer overflow in SGL loop
PATCH 1/1 crypto/qat: fix stack buffer overflow in SGL loop
The cvec pointer was incremented incorrectly in the case where the length of remaining_off equals cvec len, and there is no next cvec. This led to cvec->iova being invalid memory to access.
Instead, only increment the cvec pointer when we know there is a next cvec to point to, by checking the i value, which represents the number of cvecs available.
If i is 0, then no need to increment as the current cvec is the last one.
--- drivers/crypto/qat/dev/qat_crypto_pmd_gens.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/crypto/qat/dev/qat_crypto_pmd_gens.h +2 -1
@@ -682,7 +682,8 @@ enqueue_one_chain_job_gen1(struct qat_sym_session *ctx,while (remaining_off >= cvec->len && i >=1 ) { i--; remaining_off -= cvec->len; - cvec++; +if (i) + cvec++; } auth_iova_end = cvec->iova + remaining_off;
Signature · 1 line
2.25.1
Quoted 42 lines
-----Original Message-----
From: Power, Ciara <[email protected]>
Sent: Friday, April 14, 2023 1:32 PM
To: Ji, Kai <[email protected]>
Cc: [email protected]; Power, Ciara <[email protected]>; [email protected]
Subject: [PATCH]crypto/qat: fix stack buffer overflow in SGL loopThe cvec pointer was incremented incorrectly in the case where the length of
remaining_offequals cvec len, and there is no next cvec. This led tocvec->iovabeing invalid memory to access.Instead, only increment the cvec pointer when we know there is a next cvec to point to, by checking the i value, which represents the number of cvecs available.
If i is 0, then no need to increment as the current cvec is the last one.Fixes a815a04cea05 ("crypto/qat: support symmetric build op request")Signed-off-by Ciara Power <[email protected]>--- drivers/crypto/qat/dev/qat_crypto_pmd_gens.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)drivers/crypto/qat/dev/qat_crypto_pmd_gens.h +2
-2@@ -682,7 +682,8 @@ enqueue_one_chain_job_gen1(struct qat_sym_session *ctx,while (remaining_off >= cvec->len && i >=1 ) { i--; remaining_off -= cvec->len; - cvec++; +if (i) + cvec++; } auth_iova_end = cvec->iova + remaining_off; --2.25.1
Akhil Goyal
AppliedQuoted 1 line
Acked-by Kai Ji <[email protected]>
Applied to dpdk-next-crypto
Thanks.
Hi Ciara,
Quoted 40 lines
-----Original Message-----
From: Ciara Power <[email protected]>
Sent: Friday 14 April 2023 13:32
To: Ji, Kai <[email protected]>
Cc: [email protected]; Power, Ciara <[email protected]>; [email protected]
Subject: [PATCH]crypto/qat: fix stack buffer overflow in SGL loopThe cvec pointer was incremented incorrectly in the case where the length of
remaining_offequals cvec len, and there is no next cvec.
This led tocvec->iovabeing invalid memory to access.Instead, only increment the cvec pointer when we know there is a next cvec to point to, by checking the i value, which represents the number of cvecs available.
If i is 0, then no need to increment as the current cvec is the last one.Fixes a815a04cea05 ("crypto/qat: support symmetric build op request")Signed-off-by Ciara Power <[email protected]>--- drivers/crypto/qat/dev/qat_crypto_pmd_gens.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)drivers/crypto/qat/dev/qat_crypto_pmd_gens.h +2
-1@@ -682,7 +682,8 @@ enqueue_one_chain_job_gen1(struct qat_sym_session *ctx, while (remaining_off >= cvec->len && i >= 1) { i--; remaining_off -= cvec->len; - cvec++; +if (i) + cvec++; }
Quoted 3 lines
auth_iova_end=cvec->iova+remaining_off;
--
2.25.1