Skip to contentSkip to conversation

crypto/scheduler: fix last element for valid args

PATCH Applied Ciara Power 3 participants 3 messages Apr 14, 2023 – May 3, 2023 Crypto API

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 crypto/scheduler: fix last element for valid args

The list of valid arguments for Scheduler PMD should be terminated with a NULL entry, as expected by rte_kvargs_parse.

Without this, if an invalid key name was used, a global buffer overflow occurred resulting in a segmentation fault.

Fixes 503e9c5afb38 ("crypto/scheduler: register as vdev driver")
---
 drivers/crypto/scheduler/scheduler_pmd.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/crypto/scheduler/scheduler_pmd.c +2 -1
index 9d1ce46622..4e8bbf0e09 100644
@@ -50,7 +50,8 @@ static const char * const scheduler_valid_params[] = {
 	RTE_CRYPTODEV_VDEV_MAX_NB_QP_ARG,
 	RTE_CRYPTODEV_VDEV_SOCKET_ID,
 	RTE_CRYPTODEV_VDEV_COREMASK,
-	RTE_CRYPTODEV_VDEV_CORELIST
+	RTE_CRYPTODEV_VDEV_CORELIST,
+	NULL
 };
 
 struct scheduler_parse_map {
Signature · 1 line
2.25.1
Acked-by on v1 1/1
#1 lore raw
Quoted 40 lines

-----Original Message-----
From: Power, Ciara <[email protected]>
Sent: Friday, April 14, 2023 1:33 PM
To: Ji, Kai <[email protected]>
Cc: [email protected]; Power, Ciara <[email protected]>; [email protected]; [email protected]
Subject: [PATCH] crypto/scheduler: fix last element for valid args

The list of valid arguments for Scheduler PMD should be terminated with a NULL entry, as expected by rte_kvargs_parse.

Without this, if an invalid key name was used, a global buffer overflow occurred resulting in a segmentation fault.

Fixes 503e9c5afb38 ("crypto/scheduler: register as vdev driver")
---
 drivers/crypto/scheduler/scheduler_pmd.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/crypto/scheduler/scheduler_pmd.c +2 -2
index 9d1ce46622..4e8bbf0e09 100644
@@ -50,7 +50,8 @@ static const char * const scheduler_valid_params[] = {
 	RTE_CRYPTODEV_VDEV_MAX_NB_QP_ARG,
 	RTE_CRYPTODEV_VDEV_SOCKET_ID,
 	RTE_CRYPTODEV_VDEV_COREMASK,
-	RTE_CRYPTODEV_VDEV_CORELIST
+	RTE_CRYPTODEV_VDEV_CORELIST,
+	NULL
 };
 
 struct scheduler_parse_map {
--

2.25.1