Skip to contentSkip to conversation

ice: document RDMA devlink parameters

PATCH Applied Jacob Keller 5 participants 6 messages Apr 14, 2023 – Apr 18, 2023

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ice: document RDMA devlink parameters

Commit e523af4ee560 ("net/ice: Add support for enable_iwarp and enable_roce devlink param") added support for the enable_roce and enable_iwarp parameters in the ice driver. It didn't document these parameters in the ice devlink documentation file. Add this documentation, including a note about the mutual exclusion between the two modes.

---
 Documentation/networking/devlink/ice.rst | 15 +++++++++++++++
 1 file changed, 15 insertions(+)
Documentation/networking/devlink/ice.rst +15 -0
index 10f282c2117c..0e39a0caba55 100644
@@ -7,6 +7,21 @@ ice devlink support
 This document describes the devlink features implemented by the ``ice``
 device driver.
 
+Parameters
+==========
+
+.. list-table:: Generic parameters implemented
+
+   * - Name
+     - Mode
+     - Notes
+   * - ``enable_roce``
+     - runtime
+     - mutually exclusive with ``enable_iwarp``
+   * - ``enable_iwarp``
+     - runtime
+     - mutually exclusive with ``enable_roce``
+
 Info versions
 =============
 
Signature · 1 line
2.40.0.131.gc918699d9952
maintainer
#1 lore raw
Quoted 5 lines · On Fri, 14 Apr 2023 09:26:14 -0700 Jacob Keller wrote:

Commit e523af4ee560 ("net/ice: Add support for enable_iwarp and enable_roce devlink param") added support for the enable_roce and enable_iwarp parameters in the ice driver. It didn't document these parameters in the ice devlink documentation file. Add this documentation, including a note about the mutual exclusion between the two modes.

Thanks! We do need an ack from Tony if we're supposed to take this directly, tho. FWIW in case Tony takes it in - it should go towards net.

#2 lore raw
Quoted 10 lines · Jakub Kicinski
Quoted 5 lines · On Fri, 14 Apr 2023 09:26:14 -0700 Jacob Keller wrote:

Commit e523af4ee560 ("net/ice: Add support for enable_iwarp and enable_roce devlink param") added support for the enable_roce and enable_iwarp parameters in the ice driver. It didn't document these parameters in the ice devlink documentation file. Add this documentation, including a note about the mutual exclusion between the two modes.

Thanks! We do need an ack from Tony if we're supposed to take this directly, tho. FWIW in case Tony takes it in - it should go towards net.

Since this is documentation only, I feel like it doesn't need to go through IWL, unless you'd like it to. I'm ok either way. I'll add my ack on to the patch in case you want to take it directly.

Thanks,
Tony

Reviewed-by on v1 1/1
#3 lore raw
In reply to Jacob Keller
Quoted 11 lines · Jacob Keller

Commit e523af4ee560 ("net/ice: Add support for enable_iwarp and enable_roce devlink param") added support for the enable_roce and enable_iwarp parameters in the ice driver. It didn't document these parameters in the ice devlink documentation file. Add this documentation, including a note about the mutual exclusion between the two modes.

---
 Documentation/networking/devlink/ice.rst | 15 +++++++++++++++
 1 file changed, 15 insertions(+)

Thanks,

Acked-by on v1 1/1
#4 lore raw
In reply to Jacob Keller
Quoted 7 lines · Jacob Keller

Commit e523af4ee560 ("net/ice: Add support for enable_iwarp and enable_roce devlink param") added support for the enable_roce and enable_iwarp parameters in the ice driver. It didn't document these parameters in the ice devlink documentation file. Add this documentation, including a note about the mutual exclusion between the two modes.

Quoted 30 lines
---
  Documentation/networking/devlink/ice.rst | 15 +++++++++++++++
  1 file changed, 15 insertions(+)
Documentation/networking/devlink/ice.rst +15 -0
index 10f282c2117c..0e39a0caba55 100644
@@ -7,6 +7,21 @@ ice devlink support
  This document describes the devlink features implemented by the ``ice``
  device driver.
 
+Parameters
+==========
+
+.. list-table:: Generic parameters implemented
+
+   * - Name
+     - Mode
+     - Notes
+   * - ``enable_roce``
+     - runtime
+     - mutually exclusive with ``enable_iwarp``
+   * - ``enable_iwarp``
+     - runtime
+     - mutually exclusive with ``enable_roce``
+
  Info versions
  =============
 
#5 lore raw
In reply to Jacob Keller
This patch was applied to netdev/net.git (main) by Jakub Kicinski <[email protected]>:

Hello:

This patch was applied to netdev/net.git (main)
by Jakub Kicinski <[email protected]>:

Quoted 9 lines · On Fri, 14 Apr 2023 09:26:14 -0700 you wrote:

Commit e523af4ee560 ("net/ice: Add support for enable_iwarp and enable_roce devlink param") added support for the enable_roce and enable_iwarp parameters in the ice driver. It didn't document these parameters in the ice devlink documentation file. Add this documentation, including a note about the mutual exclusion between the two modes.

[...]

Here is the summary with links:
- ice: document RDMA devlink parameters

    https://git.kernel.org/netdev/net/c/1a2bd3bd72e9

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html