Skip to contentSkip to conversation

iio: st_sensors: Add lsm303d support

PATCH In review Marius Hoch 5 participants 19 messages Apr 15, 2023 – May 7, 2023

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

v3 cover iio: st_sensors: Add lsm303d support

Hi!

This patch series adds support for the LSM303D accelerometer and magnetometer. As the LSM303D is basically, as far as I can tell, the LSM9DS0 without gyroscope, we can easily re-use its definitions.

This was tested on a Lenovo Yoga Tablet 2 1051-F.

Cheers,
Marius

Changes in v3:
Simplified the ACPI tables in the LSM9DS0 IMU driver, per Jonathan Cameron.

Marius Hoch (6):
iio: accel: st_accel: Add LSM303D
iio: magnetometer: st_accel: Add LSM303D
iio: st_sensors: Add lsm303d support to the LSM9DS0 IMU driver
iio: st_sensors: Add ACPI support for lsm303d to the LSM9DS0 IMU
driver
iio: Comment that the LSM303D also has the Magnetometer DRDY
dt-bindings: iio: st-sensors: Add LSM303D accelerometer+magnetometer

 .../devicetree/bindings/iio/st,st-sensors.yaml       |  1 +
 drivers/iio/accel/st_accel_core.c                    |  1 +
 drivers/iio/imu/st_lsm9ds0/Kconfig                   |  3 ++-
 drivers/iio/imu/st_lsm9ds0/st_lsm9ds0_i2c.c          | 12 ++++++++++++
 drivers/iio/imu/st_lsm9ds0/st_lsm9ds0_spi.c          | 12 ++++++++++++
 drivers/iio/magnetometer/st_magn_core.c              |  1 +
 include/linux/iio/common/st_sensors.h                |  1 +
 include/linux/platform_data/st_sensors_pdata.h       |  2 +-
 8 files changed, 31 insertions(+), 2 deletions(-)

base-commit: e62252bc55b6d4eddc6c2bdbf95a448180d6a08d

Signature · 1 line
2.39.2
#1 lore raw

PATCH v3 1/6 iio: accel: st_accel: Add LSM303D

The lsm303d has the same register mapping as the lsm9ds0, thus we can just re-use that.

Tested on a Lenovo Yoga Tablet 2 1051-F.

---
 drivers/iio/accel/st_accel_core.c     | 1 +
 include/linux/iio/common/st_sensors.h | 1 +
 2 files changed, 2 insertions(+)
drivers/iio/accel/st_accel_core.c +1 -0
index 6b8562f684d5..1628b177d0ed 100644
@@ -1006,6 +1006,7 @@ static const struct st_sensor_settings st_accel_sensors_settings[] = {
 		.wai_addr = ST_SENSORS_DEFAULT_WAI_ADDRESS,
 		.sensors_supported = {
 			[0] = LSM9DS0_IMU_DEV_NAME,
+			[1] = LSM303D_IMU_DEV_NAME,
 		},
 		.ch = (struct iio_chan_spec *)st_accel_16bit_channels,
 		.odr = {
include/linux/iio/common/st_sensors.h +1 -0
index f5f3ee57bc70..607c3a89a647 100644
@@ -22,6 +22,7 @@
 #include <linux/platform_data/st_sensors_pdata.h>
 
 #define LSM9DS0_IMU_DEV_NAME		"lsm9ds0"
+#define LSM303D_IMU_DEV_NAME		"lsm303d"
 
 /*
  * Buffer size max case: 2bytes per channel, 3 channels in total +
Signature · 1 line
2.39.2
#3 lore raw

PATCH v3 2/6 iio: magnetometer: st_accel: Add LSM303D

In reply to Marius Hoch

The lsm303d has the same register mapping as the lsm9ds0, thus we can just re-use that.

Tested on a Lenovo Yoga Tablet 2 1051-F.

---
 drivers/iio/magnetometer/st_magn_core.c | 1 +
 1 file changed, 1 insertion(+)
drivers/iio/magnetometer/st_magn_core.c +1 -0
index 8faa7409d9e1..6cc0dfd31821 100644
@@ -427,6 +427,7 @@ static const struct st_sensor_settings st_magn_sensors_settings[] = {
 		.wai_addr = ST_SENSORS_DEFAULT_WAI_ADDRESS,
 		.sensors_supported = {
 			[0] = LSM9DS0_IMU_DEV_NAME,
+			[1] = LSM303D_IMU_DEV_NAME,
 		},
 		.ch = (struct iio_chan_spec *)st_magn_4_16bit_channels,
 		.odr = {
Signature · 1 line
2.39.2
#5 lore raw

PATCH v3 3/6 iio: st_sensors: Add lsm303d support to the LSM9DS0 IMU driver

In reply to Marius Hoch

The lsm303d is basically the lsm9ds0 without the gyroscope (which the LSM9DS0 IMU driver doesn't handle), as far as I can tell.

---
 drivers/iio/imu/st_lsm9ds0/Kconfig          | 3 ++-
 drivers/iio/imu/st_lsm9ds0/st_lsm9ds0_i2c.c | 5 +++++
 drivers/iio/imu/st_lsm9ds0/st_lsm9ds0_spi.c | 5 +++++
 3 files changed, 12 insertions(+), 1 deletion(-)
drivers/iio/imu/st_lsm9ds0/Kconfig +2 -1
index d29558edee60..7aef714b6ecb 100644
@@ -10,7 +10,8 @@ config IIO_ST_LSM9DS0
 
 	help
 	  Say yes here to build support for STMicroelectronics LSM9DS0 IMU
-	  sensor. Supported devices: accelerometer/magnetometer of lsm9ds0.
+	  sensor. Supported devices: accelerometer/magnetometer of lsm9ds0
+	  and lsm303d.
 
 	  To compile this driver as a module, choose M here: the module
 	  will be called st_lsm9ds0.
drivers/iio/imu/st_lsm9ds0/st_lsm9ds0_i2c.c +5 -0
index a90138d8b06a..64fa77d302e2 100644
@@ -22,12 +22,17 @@ static const struct of_device_id st_lsm9ds0_of_match[] = {
 		.compatible = "st,lsm9ds0-imu",
 		.data = LSM9DS0_IMU_DEV_NAME,
 	},
+	{
+		.compatible = "st,lsm303d-imu",
+		.data = LSM303D_IMU_DEV_NAME,
+	},
 	{}
 };
 MODULE_DEVICE_TABLE(of, st_lsm9ds0_of_match);
 
 static const struct i2c_device_id st_lsm9ds0_id_table[] = {
 	{ LSM9DS0_IMU_DEV_NAME },
+	{ LSM303D_IMU_DEV_NAME },
 	{}
 };
 MODULE_DEVICE_TABLE(i2c, st_lsm9ds0_id_table);
drivers/iio/imu/st_lsm9ds0/st_lsm9ds0_spi.c +5 -0
index b743bf3546a7..997b5ff792be 100644
@@ -22,12 +22,17 @@ static const struct of_device_id st_lsm9ds0_of_match[] = {
 		.compatible = "st,lsm9ds0-imu",
 		.data = LSM9DS0_IMU_DEV_NAME,
 	},
+	{
+		.compatible = "st,lsm303d-imu",
+		.data = LSM303D_IMU_DEV_NAME,
+	},
 	{}
 };
 MODULE_DEVICE_TABLE(of, st_lsm9ds0_of_match);
 
 static const struct spi_device_id st_lsm9ds0_id_table[] = {
 	{ LSM9DS0_IMU_DEV_NAME },
+	{ LSM303D_IMU_DEV_NAME },
 	{}
 };
 MODULE_DEVICE_TABLE(spi, st_lsm9ds0_id_table);
Signature · 1 line
2.39.2
#7 lore raw

PATCH v3 4/6 iio: st_sensors: Add ACPI support for lsm303d to the LSM9DS0 IMU driver

In reply to Marius Hoch

The lsm303d can be found as ACCL0001 on various Lenovo devices, including the Lenovo Yoga Tablet 2 1051-F, where I tested this patch.

---
 drivers/iio/imu/st_lsm9ds0/st_lsm9ds0_i2c.c | 7 +++++++
 drivers/iio/imu/st_lsm9ds0/st_lsm9ds0_spi.c | 7 +++++++
 2 files changed, 14 insertions(+)
drivers/iio/imu/st_lsm9ds0/st_lsm9ds0_i2c.c +7 -0
index 64fa77d302e2..52f1ea6c457f 100644
@@ -37,6 +37,12 @@ static const struct i2c_device_id st_lsm9ds0_id_table[] = {
 };
 MODULE_DEVICE_TABLE(i2c, st_lsm9ds0_id_table);
 
+static const struct acpi_device_id st_lsm9ds0_acpi_match[] = {
+	{"ACCL0001", (kernel_ulong_t)LSM303D_IMU_DEV_NAME},
+	{ },
+};
+MODULE_DEVICE_TABLE(acpi, st_lsm9ds0_acpi_match);
+
 static const struct regmap_config st_lsm9ds0_regmap_config = {
 	.reg_bits	= 8,
 	.val_bits	= 8,
@@ -73,6 +79,7 @@ static struct i2c_driver st_lsm9ds0_driver = {
 	.driver = {
 		.name = "st-lsm9ds0-i2c",
 		.of_match_table = st_lsm9ds0_of_match,
+		.acpi_match_table = st_lsm9ds0_acpi_match,
 	},
 	.probe_new = st_lsm9ds0_i2c_probe,
 	.id_table = st_lsm9ds0_id_table,
drivers/iio/imu/st_lsm9ds0/st_lsm9ds0_spi.c +7 -0
index 997b5ff792be..55f3738193af 100644
@@ -37,6 +37,12 @@ static const struct spi_device_id st_lsm9ds0_id_table[] = {
 };
 MODULE_DEVICE_TABLE(spi, st_lsm9ds0_id_table);
 
+static const struct acpi_device_id st_lsm9ds0_acpi_match[] = {
+	{"ACCL0001", (kernel_ulong_t)LSM303D_IMU_DEV_NAME},
+	{ },
+};
+MODULE_DEVICE_TABLE(acpi, st_lsm9ds0_acpi_match);
+
 static const struct regmap_config st_lsm9ds0_regmap_config = {
 	.reg_bits	= 8,
 	.val_bits	= 8,
@@ -72,6 +78,7 @@ static struct spi_driver st_lsm9ds0_driver = {
 	.driver = {
 		.name = "st-lsm9ds0-spi",
 		.of_match_table = st_lsm9ds0_of_match,
+		.acpi_match_table = st_lsm9ds0_acpi_match,
 	},
 	.probe = st_lsm9ds0_spi_probe,
 	.id_table = st_lsm9ds0_id_table,
Signature · 1 line
2.39.2
#9 lore raw

Re: [PATCH v3 4/6] iio: st_sensors: Add ACPI support for lsm303d to the LSM9DS0 IMU driver

In reply to Marius Hoch

Hi,

On 16/04/2023 01:11, Marius Hoch wrote:
<snip>

Quoted 18 lines
drivers/iio/imu/st_lsm9ds0/st_lsm9ds0_spi.c +6 -0
index 997b5ff792be..55f3738193af 100644
@@ -37,6 +37,12 @@ static const struct spi_device_id st_lsm9ds0_id_table[] = {
  };
  MODULE_DEVICE_TABLE(spi, st_lsm9ds0_id_table);
 
+static const struct acpi_device_id st_lsm9ds0_acpi_match[] = {
+	{"ACCL0001", (kernel_ulong_t)LSM303D_IMU_DEV_NAME},
+	{ },
+};
+MODULE_DEVICE_TABLE(acpi, st_lsm9ds0_acpi_match);
+
  static const struct regmap_config st_lsm9ds0_regmap_config = {
  	.reg_bits	= 8,
  	.val_bits	= 8,

drivers/iio/imu/st_lsm9ds0/st_lsm9ds0_spi.c static struct spi_driver st_lsm9ds0_driver = { · line 84

Quoted 7 lines
drivers/iio/imu/st_lsm9ds0/st_lsm9ds0_spi.c +1 -0
@@ -72,6 +78,7 @@ static struct spi_driver st_lsm9ds0_driver = {
  	.driver = {
  		.name = "st-lsm9ds0-spi",
  		.of_match_table = st_lsm9ds0_of_match,
+		.acpi_match_table = st_lsm9ds0_acpi_match,
  	},
  	.probe = st_lsm9ds0_spi_probe,
  	.id_table = st_lsm9ds0_id_table,

I just realized that these changes (the SPI ones, not the I2C ones) are entirely superfluous, and I'm not sure why I added this in the first place. In the Lenovo Yoga Tablet 2 series (which seem to be the only devices exposing this as "ACCL0001"), the device is accessible via I2C. Just to make sure, I re-tested the patch chain without this change.

@Jonathan: Shall I upload an entirely new patch set (v4), do this in a separate new clean up commit, or do you want to just drop these changes to drivers/iio/imu/st_lsm9ds0/st_lsm9ds0_spi.c? I'm fine with any of these options.

Cheers,
Marius

maintainer
#10 lore raw

Re: [PATCH v3 4/6] iio: st_sensors: Add ACPI support for lsm303d to the LSM9DS0 IMU driver

Quoted 35 lines · On Tue, 2 May 2023 16:51:42 +0200 Marius Hoch <[email protected]> wrote:

Hi,

On 16/04/2023 01:11, Marius Hoch wrote:
<snip>

Quoted 18 lines
drivers/iio/imu/st_lsm9ds0/st_lsm9ds0_spi.c +6 -0
index 997b5ff792be..55f3738193af 100644
@@ -37,6 +37,12 @@ static const struct spi_device_id st_lsm9ds0_id_table[] = {
  };
  MODULE_DEVICE_TABLE(spi, st_lsm9ds0_id_table);
 
+static const struct acpi_device_id st_lsm9ds0_acpi_match[] = {
+	{"ACCL0001", (kernel_ulong_t)LSM303D_IMU_DEV_NAME},
+	{ },
+};
+MODULE_DEVICE_TABLE(acpi, st_lsm9ds0_acpi_match);
+
  static const struct regmap_config st_lsm9ds0_regmap_config = {
  	.reg_bits	= 8,
  	.val_bits	= 8,

drivers/iio/imu/st_lsm9ds0/st_lsm9ds0_spi.c static struct spi_driver st_lsm9ds0_driver = { · line 84

Quoted 7 lines
drivers/iio/imu/st_lsm9ds0/st_lsm9ds0_spi.c +1 -0
@@ -72,6 +78,7 @@ static struct spi_driver st_lsm9ds0_driver = {
  	.driver = {
  		.name = "st-lsm9ds0-spi",
  		.of_match_table = st_lsm9ds0_of_match,
+		.acpi_match_table = st_lsm9ds0_acpi_match,
  	},
  	.probe = st_lsm9ds0_spi_probe,
  	.id_table = st_lsm9ds0_id_table,  

I just realized that these changes (the SPI ones, not the I2C ones) are entirely superfluous, and I'm not sure why I added this in the first place. In the Lenovo Yoga Tablet 2 series (which seem to be the only devices exposing this as "ACCL0001"), the device is accessible via I2C. Just to make sure, I re-tested the patch chain without this change.

Quoted 4 lines

@Jonathan: Shall I upload an entirely new patch set (v4), do this in a separate new clean up commit, or do you want to just drop these changes to drivers/iio/imu/st_lsm9ds0/st_lsm9ds0_spi.c? I'm fine with any of these options.

I'll drop it and push out a new version of the togreg tree.

Thanks for pointing this out.

Jonathan

Quoted 3 lines

Cheers,
Marius

#11 lore raw

PATCH v3 5/6 iio: Comment that the LSM303D also has the Magnetometer DRDY

In reply to Marius Hoch

Per its datasheet, the LSM303D also features that
pin.

---
 include/linux/platform_data/st_sensors_pdata.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
include/linux/platform_data/st_sensors_pdata.h +1 -1
index 897051e51b78..a657830232ae 100644
@@ -15,7 +15,7 @@
  * @drdy_int_pin: Redirect DRDY on pin 1 (1) or pin 2 (2).
  *	Available only for accelerometer, magnetometer and pressure sensors.
  *	Accelerometer DRDY on LSM330 available only on pin 1 (see datasheet).
- *	Magnetometer DRDY is supported only on LSM9DS0.
+ *	Magnetometer DRDY is supported only on LSM9DS0 and LSM303D.
  * @open_drain: set the interrupt line to be open drain if possible.
  * @spi_3wire: enable spi-3wire mode.
  * @pullups: enable/disable i2c controller pullup resistors.
Signature · 1 line
2.39.2
#13 lore raw

PATCH v3 6/6 dt-bindings: iio: st-sensors: Add LSM303D accelerometer+magnetometer

In reply to Marius Hoch

Same as the lsm9ds0, except that the lsm303d doesn't feature a gyroscope.

---
 Documentation/devicetree/bindings/iio/st,st-sensors.yaml | 1 +
 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/iio/st,st-sensors.yaml +1 -0
index c6201976378f..194aca5542c2 100644
@@ -85,6 +85,7 @@ properties:
       - description: IMUs
         enum:
           - st,lsm9ds0-imu
+          - st,lsm303d-imu
       - description: Deprecated bindings
         enum:
           - st,lis302dl-spi
Signature · 1 line
2.39.2
Acked-by on v3 6/6
#14 lore raw

Re: [PATCH v3 6/6] dt-bindings: iio: st-sensors: Add LSM303D accelerometer+magnetometer

Quoted 13 lines · Marius Hoch

Same as the lsm9ds0, except that the lsm303d doesn't feature a gyroscope.

---
 Documentation/devicetree/bindings/iio/st,st-sensors.yaml | 1 +
 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/iio/st,st-sensors.yaml +0 -0
index c6201976378f..194aca5542c2 100644

Documentation/devicetree/bindings/iio/st,st-sensors.yaml properties: · line 88

Quoted 4 lines
Documentation/devicetree/bindings/iio/st,st-sensors.yaml +1 -0
@@ -85,6 +85,7 @@ properties:
       - description: IMUs
         enum:
           - st,lsm9ds0-imu
+          - st,lsm303d-imu

The entries are ordered by name.

With fixed:

Best regards,
Krzysztof

maintainer
#15 lore raw

Re: [PATCH v3 6/6] dt-bindings: iio: st-sensors: Add LSM303D accelerometer+magnetometer

Quoted 21 lines · On Sun, 16 Apr 2023 09:29:23 +0200 Krzysztof Kozlowski…
Quoted 13 lines · Marius Hoch

Same as the lsm9ds0, except that the lsm303d doesn't feature a gyroscope.

---
 Documentation/devicetree/bindings/iio/st,st-sensors.yaml | 1 +
 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/iio/st,st-sensors.yaml +0 -0
index c6201976378f..194aca5542c2 100644

Documentation/devicetree/bindings/iio/st,st-sensors.yaml properties: · line 88

Quoted 4 lines
Documentation/devicetree/bindings/iio/st,st-sensors.yaml +1 -0
@@ -85,6 +85,7 @@ properties:
       - description: IMUs
         enum:
           - st,lsm9ds0-imu
+          - st,lsm303d-imu  

The entries are ordered by name.

Quoted 4 lines

With fixed:

I tidied up the ordering whilst applying and also swapped the ordering in patch 3 for similar reason.

Note that we are very late in this cycle so unless there is an unexpected delay these will sit in the branch I push out as iio.git/testing until after rc1 when I'll rebase it on rc1 and push out as togreg for linux-next to pick up for the 6.5 cycle.

Plenty of time for others to comment in the meantime, but I'm guessing we won't get much and this way I can 'probably' forget about handling this series individually.

Jonathan

Quoted 4 lines

Best regards,
Krzysztof

Tested-by on the v3 series
#16 lore raw
In reply to Marius Hoch

Hi Marius,

Quoted 7 lines · Marius Hoch

Hi!

This patch series adds support for the LSM303D accelerometer and magnetometer. As the LSM303D is basically, as far as I can tell, the LSM9DS0 without gyroscope, we can easily re-use its definitions.

This was tested on a Lenovo Yoga Tablet 2 1051-F.

Thank you for your work on this. I have had this on my own todo list since 2020 at least and I did not realize that Andy already added ST IMU support in 2021 so this just needed some extra device-ids :)

I have tested this successfully on the following models:

Lenovo Yoga Tablet 2 851F (Windows version 8")

This version needs an accel-mount-matrix quick in hwdb since it has a portrait screen rather then a landscape screen (so 90° rotated):
https://github.com/systemd/systemd/pull/27295
Note I've made sure that this quirk only applies to the 851 and not to the 1051.

Lenovo Yoga Tablet 2 830F (Android version 8")

Since the ACPI tables are broken in the Android BIOS these need a patch to x86-android-tablets to instantiate the i2c_client for the sensor, I'm still finalizing this patch and I'll submit it upstream when its finished.

Regards,

Hans

p.s.

1: I noticed that auto-screen rotation using iio-sensor-proxy is quite slow
so I wrote a patch to fix this :) :
https://gitlab.freedesktop.org/hadess/iio-sensor-proxy/-/merge_requests/366

2: There are some other unsupported sensors on these models too, perhaps you are interested in adding support for these too?

Here are my personal notes on this:
-Light sensor should work with drivers/iio/light/al3320a.c
https://github.com/JideTechnology/remixos-kernel/commit/c52d55b4bd907e87b7b115b3943219f3e089a77a

-MXM1120 HALL sensor, have datasheet, measures angle of kickstand thingie, use
for SW_TABLET_MODE. Do a pdx86 driver just for the Tab 2 which checks that the kick stand is out *and* the BT keyboard is paired, in that case report SW_TABLET_MODE=0, in all other cases report SW_TABLET_MODE=1 ??
For the commit msg:
Datasheet available here: http://haechitech.com/tech-support/
Requires creating an account, once you have an account you can immediately download the provided datasheets (or let me know if you want me to email you a copy)

Especially the light sensor should be an easy win and light sensors are already supported in e.g. iio-sensor-proxy

Quoted 24 lines

Changes in v3:
Simplified the ACPI tables in the LSM9DS0 IMU driver, per Jonathan Cameron.

Marius Hoch (6):
iio: accel: st_accel: Add LSM303D
iio: magnetometer: st_accel: Add LSM303D
iio: st_sensors: Add lsm303d support to the LSM9DS0 IMU driver
iio: st_sensors: Add ACPI support for lsm303d to the LSM9DS0 IMU
driver
iio: Comment that the LSM303D also has the Magnetometer DRDY
dt-bindings: iio: st-sensors: Add LSM303D accelerometer+magnetometer

 .../devicetree/bindings/iio/st,st-sensors.yaml       |  1 +
 drivers/iio/accel/st_accel_core.c                    |  1 +
 drivers/iio/imu/st_lsm9ds0/Kconfig                   |  3 ++-
 drivers/iio/imu/st_lsm9ds0/st_lsm9ds0_i2c.c          | 12 ++++++++++++
 drivers/iio/imu/st_lsm9ds0/st_lsm9ds0_spi.c          | 12 ++++++++++++
 drivers/iio/magnetometer/st_magn_core.c              |  1 +
 include/linux/iio/common/st_sensors.h                |  1 +
 include/linux/platform_data/st_sensors_pdata.h       |  2 +-
 8 files changed, 31 insertions(+), 2 deletions(-)

base-commit: e62252bc55b6d4eddc6c2bdbf95a448180d6a08d

#17 lore raw

Hi Hans,

Quoted 34 lines · Hans de Goede

Hi Marius,

Quoted 7 lines · Marius Hoch

Hi!

This patch series adds support for the LSM303D accelerometer and magnetometer. As the LSM303D is basically, as far as I can tell, the LSM9DS0 without gyroscope, we can easily re-use its definitions.

This was tested on a Lenovo Yoga Tablet 2 1051-F.

Thank you for your work on this. I have had this on my own todo list since 2020 at least and I did not realize that Andy already added ST IMU support in 2021 so this just needed some extra device-ids :)

I have tested this successfully on the following models:

Lenovo Yoga Tablet 2 851F (Windows version 8")

This version needs an accel-mount-matrix quick in hwdb since it has a portrait screen rather then a landscape screen (so 90° rotated):
https://github.com/systemd/systemd/pull/27295
Note I've made sure that this quirk only applies to the 851 and not to the 1051.

Lenovo Yoga Tablet 2 830F (Android version 8")

Since the ACPI tables are broken in the Android BIOS these need a patch to x86-android-tablets to instantiate the i2c_client for the sensor, I'm still finalizing this patch and I'll submit it upstream when its finished.

Regards,

Quoted 8 lines

Hans

p.s.

1: I noticed that auto-screen rotation using iio-sensor-proxy is quite slow
so I wrote a patch to fix this :) :
https://gitlab.freedesktop.org/hadess/iio-sensor-proxy/-/merge_requests/366

Nice, that should make rotating fast (well, as fast these devices can handle).

Quoted 7 lines

2: There are some other unsupported sensors on these models too, perhaps you are interested in adding support for these too?

Here are my personal notes on this:
-Light sensor should work with drivers/iio/light/al3320a.c
https://github.com/JideTechnology/remixos-kernel/commit/c52d55b4bd907e87b7b115b3943219f3e089a77a

That indeed worked like a charm, I'll post the patch later today.

Quoted 9 lines

-MXM1120 HALL sensor, have datasheet, measures angle of kickstand thingie, use
for SW_TABLET_MODE. Do a pdx86 driver just for the Tab 2 which checks that the kick stand is out *and* the BT keyboard is paired, in that case report SW_TABLET_MODE=0, in all other cases report SW_TABLET_MODE=1 ??
For the commit msg:
Datasheet available here: http://haechitech.com/tech-support/
Requires creating an account, once you have an account you can immediately download the provided datasheets (or let me know if you want me to email you a copy)

Thanks for the pointers, that sounds like a nice little project. I'll give it a shot :)

Quoted 3 lines

Especially the light sensor should be an easy win and light sensors are already supported in e.g. iio-sensor-proxy

Cheers,
Marius

Quoted 33 lines
Quoted 33 lines

Changes in v3:
Simplified the ACPI tables in the LSM9DS0 IMU driver, per Jonathan Cameron.

Marius Hoch (6):
iio: accel: st_accel: Add LSM303D
iio: magnetometer: st_accel: Add LSM303D
iio: st_sensors: Add lsm303d support to the LSM9DS0 IMU driver
iio: st_sensors: Add ACPI support for lsm303d to the LSM9DS0 IMU
driver
iio: Comment that the LSM303D also has the Magnetometer DRDY
dt-bindings: iio: st-sensors: Add LSM303D accelerometer+magnetometer

  .../devicetree/bindings/iio/st,st-sensors.yaml       |  1 +
  drivers/iio/accel/st_accel_core.c                    |  1 +
  drivers/iio/imu/st_lsm9ds0/Kconfig                   |  3 ++-
  drivers/iio/imu/st_lsm9ds0/st_lsm9ds0_i2c.c          | 12 ++++++++++++
  drivers/iio/imu/st_lsm9ds0/st_lsm9ds0_spi.c          | 12 ++++++++++++
  drivers/iio/magnetometer/st_magn_core.c              |  1 +
  include/linux/iio/common/st_sensors.h                |  1 +
  include/linux/platform_data/st_sensors_pdata.h       |  2 +-
  8 files changed, 31 insertions(+), 2 deletions(-)

base-commit: e62252bc55b6d4eddc6c2bdbf95a448180d6a08d

#18 lore raw
In reply to Hans de Goede

Hi Marius,

On 4/16/23 22:19, Hans de Goede wrote:

<snip>

Quoted 7 lines

2: There are some other unsupported sensors on these models too, perhaps you are interested in adding support for these too?

Here are my personal notes on this:
-Light sensor should work with drivers/iio/light/al3320a.c
https://github.com/JideTechnology/remixos-kernel/commit/c52d55b4bd907e87b7b115b3943219f3e089a77a

Quoted 8 lines

-MXM1120 HALL sensor, have datasheet, measures angle of kickstand thingie, use
for SW_TABLET_MODE. Do a pdx86 driver just for the Tab 2 which checks that the kick stand is out *and* the BT keyboard is paired, in that case report SW_TABLET_MODE=0, in all other cases report SW_TABLET_MODE=1 ??
For the commit msg:
Datasheet available here: http://haechitech.com/tech-support/
Requires creating an account, once you have an account you can immediately download the provided datasheets (or let me know if you want me to email you a copy)

A quick follow up on this, since you said you were going to take a look.

I think with the way bluetooth works under Linux, with a bunch of the work being done in userspace that figuring out if the BT keyboard is paired is not going to work in kernelspace. So I think the best we can do here is simply export the angle of the kickstand as an iio angle sensor.

Regards,

Hans